Re: [PATCH v2 01/34] sequencer: support a new action: 'interactive rebase'

2016-12-19 Thread Stephan Beyer
Hi Dscho, >> However, maintaining more than one directory (like "sequencer" for >> sequencer state and "rebase-merge" for rebase todo and log) can cause >> the necessity to be even more careful when hacking on sequencer... For >> example, the cleanup code must delete both of them, not only one of

Re: [PATCH v2 01/34] sequencer: support a new action: 'interactive rebase'

2016-12-19 Thread Johannes Schindelin
Hi Stephan, On Sat, 17 Dec 2016, Stephan Beyer wrote: > On 12/14/2016 08:29 PM, Junio C Hamano wrote: > > Johannes Schindelin writes: > >> -/* We will introduce the 'interactive rebase' mode later */ > >> static inline int is_rebase_i(const struct replay_opts *opts) > >> { > >> - return 0; >

Re: [PATCH v2 01/34] sequencer: support a new action: 'interactive rebase'

2016-12-19 Thread Johannes Schindelin
Hi Junio, On Tue, 13 Dec 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > @@ -395,7 +414,10 @@ static int do_recursive_merge(struct commit *base, > > struct commit *next, > > > > if (active_cache_changed && > > write_locked_index(&the_index, &index_lock, COMMIT_LOC

Re: [PATCH v2 01/34] sequencer: support a new action: 'interactive rebase'

2016-12-17 Thread Stephan Beyer
Hi, On 12/14/2016 08:29 PM, Junio C Hamano wrote: > Johannes Schindelin writes: >> -/* We will introduce the 'interactive rebase' mode later */ >> static inline int is_rebase_i(const struct replay_opts *opts) >> { >> -return 0; >> +return opts->action == REPLAY_INTERACTIVE_REBASE; >> }

Re: [PATCH v2 01/34] sequencer: support a new action: 'interactive rebase'

2016-12-14 Thread Junio C Hamano
Johannes Schindelin writes: > -/* We will introduce the 'interactive rebase' mode later */ > static inline int is_rebase_i(const struct replay_opts *opts) > { > - return 0; > + return opts->action == REPLAY_INTERACTIVE_REBASE; > } > > static const char *get_dir(const struct replay_o

Re: [PATCH v2 01/34] sequencer: support a new action: 'interactive rebase'

2016-12-13 Thread Junio C Hamano
Johannes Schindelin writes: > static inline int is_rebase_i(const struct replay_opts *opts) > { > - return 0; > + return opts->action == REPLAY_INTERACTIVE_REBASE; > } > > static const char *get_dir(const struct replay_opts *opts) > { > + if (is_rebase_i(opts)) > +

[PATCH v2 01/34] sequencer: support a new action: 'interactive rebase'

2016-12-13 Thread Johannes Schindelin
This patch introduces a new action for the sequencer. It really does not do a whole lot of its own right now, but lays the ground work for patches to come. The intention, of course, is to finally make the sequencer the work horse of the interactive rebase (the original idea behind the "sequencer" c