Re: [PATCH v2 1/3] fast-{import,export}: use get_sha1_hex() directly

2013-05-07 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: It's wrong to call get_sha1() if they should be SHA-1s, plus inefficient. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- It appears that they should be SHA-1s assumption does not hold; this patch breaks at least 3303, 9020,

Re: [PATCH v2 1/3] fast-{import,export}: use get_sha1_hex() directly

2013-05-07 Thread Felipe Contreras
On Tue, May 7, 2013 at 9:38 AM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com writes: It's wrong to call get_sha1() if they should be SHA-1s, plus inefficient. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- It appears that they should

Re: [PATCH v2 1/3] fast-{import,export}: use get_sha1_hex() directly

2013-05-07 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: Turns out most of the get_sha1() calls were correct; this does the trick: diff --git a/builtin/fast-export.c b/builtin/fast-export.c index 18fdfb3..d1d68e9 100644 --- a/builtin/fast-export.c +++ b/builtin/fast-export.c @@ -623,7 +623,7 @@

[PATCH v2 1/3] fast-{import,export}: use get_sha1_hex() directly

2013-05-05 Thread Felipe Contreras
It's wrong to call get_sha1() if they should be SHA-1s, plus inefficient. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- builtin/fast-export.c | 2 +- fast-import.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/builtin/fast-export.c