Re: [PATCH v2 1/3] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-12 Thread Junio C Hamano
Steven Penny writes: > On Wed, Dec 12, 2018 at 1:29 AM Johannes Sixt wrote: >> As long as C:\Windows\System32 on my Windows computer contains only >> 64-Bit binaries, I consider the characters "3" and "2" next to each >> other in this order just noise and without any form of information. The >> i

Re: [PATCH v2 1/3] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-12 Thread Johannes Schindelin
Hi Elijah, On Tue, 11 Dec 2018, Elijah Newren wrote: > I'm worried based on other emails in this thread that there is a > fundamental difference in frame of reference leading to a > misunderstanding about rationale for naming, and worse that folks might > not even realize where the misunderstandi

Re: [PATCH v2 1/3] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-12 Thread Johannes Schindelin
Hi Hannes, On Wed, 12 Dec 2018, Johannes Sixt wrote: > Am 12.12.18 um 01:42 schrieb Steven Penny: > > On Tue, Dec 11, 2018 at 7:39 AM Johannes Schindelin wrote: > > > > - pc-windows > > > > - pc-win > > > > - win > > > > > > I find all of those horrible. > > > > one windows triplet in use is "x8

Re: [PATCH v2 1/3] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-12 Thread Steven Penny
On Wed, Dec 12, 2018 at 1:29 AM Johannes Sixt wrote: > As long as C:\Windows\System32 on my Windows computer contains only > 64-Bit binaries, I consider the characters "3" and "2" next to each > other in this order just noise and without any form of information. The > important part of the name is

Re: [PATCH v2 1/3] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-11 Thread Johannes Sixt
Am 12.12.18 um 01:42 schrieb Steven Penny: On Tue, Dec 11, 2018 at 7:39 AM Johannes Schindelin wrote: - pc-windows - pc-win - win I find all of those horrible. one windows triplet in use is "x86_64-pc-windows", used by Rust: https://forge.rust-lang.org/other-installation-methods.html which

Re: [PATCH v2 1/3] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-11 Thread Elijah Newren
On Fri, Dec 7, 2018 at 4:51 PM Steven Penny wrote: > > On Fri, Dec 7, 2018 at 11:04 AM wrote: > > The solution is to implement has_dos_drive_prefix(), skip_dos_drive_prefix() > > is_dir_sep(), offset_1st_component() and convert_slashes() for cygwin > > in the same way as it is done in 'Git for Win

Re: [PATCH v2 1/3] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-11 Thread Steven Penny
On Tue, Dec 11, 2018 at 7:39 AM Johannes Schindelin wrote: > I have no intention of flaming anybody. That is simply a > misrepresentation. you may see yourself "through a glass darkly", but i dont. this language is not constructive: > > - pc-windows > > - pc-win > > - win > > I find all of those

Re: [PATCH v2 1/3] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-11 Thread Johannes Schindelin
Hi Steven, On Mon, 10 Dec 2018, Steven Penny wrote: > On Mon, Dec 10, 2018 at 2:46 AM Johannes Schindelin wrote: > > please stop dropping me from the Cc: list. Thanks. > > i dropped you specifically because i knew you were going to flame like > you just did below. oh well, i guess you cant avoid

Re: [PATCH v2 1/3] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-10 Thread Steven Penny
On Mon, Dec 10, 2018 at 2:46 AM Johannes Schindelin wrote: > please stop dropping me from the Cc: list. Thanks. i dropped you specifically because i knew you were going to flame like you just did below. oh well, i guess you cant avoid the inevitable. > > - pc-windows > > - pc-win > > - win > > I

Re: [PATCH v2 1/3] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-10 Thread Johannes Schindelin
Hi Steven, please stop dropping me from the Cc: list. Thanks. On Fri, 7 Dec 2018, Steven Penny wrote: > On Fri, Dec 7, 2018 at 11:04 AM wrote: > > > The solution is to implement has_dos_drive_prefix(), > > skip_dos_drive_prefix() is_dir_sep(), offset_1st_component() and > > convert_slashes() for

Re: [PATCH v2 1/3] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-07 Thread Steven Penny
On Fri, Dec 7, 2018 at 11:04 AM wrote: > The solution is to implement has_dos_drive_prefix(), skip_dos_drive_prefix() > is_dir_sep(), offset_1st_component() and convert_slashes() for cygwin > in the same way as it is done in 'Git for Windows' in compat/mingw.[ch] > > Instead of duplicating the code

Re: [PATCH v2 1/3] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-07 Thread Johannes Schindelin
Hi Torsten, On Fri, 7 Dec 2018, tbo...@web.de wrote: > compat/mingw-cygwin.c | 28 > compat/mingw-cygwin.h | 20 Please use compat/win32/path.c (or .../path-utils.c) instead. This is not so much about MINGW or Cygwin or MSys or MSYS2 or Visual C+

[PATCH v2 1/3] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-07 Thread tboegi
From: Torsten Bögershausen A regression for cygwin users was introduced with commit 05b458c, "real_path: resolve symlinks by hand". In the the commit message we read: The current implementation of real_path uses chdir() in order to resolve symlinks. Unfortunately this isn't thread-safe a