Re: [PATCH v2 3/6] stash: convert apply to builtin

2018-03-27 Thread Joel Teichroeb
On Mon, Mar 26, 2018 at 12:05 AM, Christian Couder wrote: > On Mon, Mar 26, 2018 at 3:14 AM, Joel Teichroeb wrote: >> Signed-off-by: Joel Teichroeb > > The commit message in this patch and the following ones could be a bit > more verbose. It could at least tell that the end goal is to convert >

Re: [PATCH v2 3/6] stash: convert apply to builtin

2018-03-26 Thread Christian Couder
On Mon, Mar 26, 2018 at 3:14 AM, Joel Teichroeb wrote: > Signed-off-by: Joel Teichroeb The commit message in this patch and the following ones could be a bit more verbose. It could at least tell that the end goal is to convert git-stash.sh to a C builtin. > +static void destroy_stash_info(struc

[PATCH v2 3/6] stash: convert apply to builtin

2018-03-25 Thread Joel Teichroeb
Signed-off-by: Joel Teichroeb --- .gitignore | 1 + Makefile| 1 + builtin.h | 1 + builtin/stash--helper.c | 431 git-stash.sh| 75 + git.c | 1 + 6 files ch