Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Sverre Rabbelier
On Tue, Oct 30, 2012 at 10:11 AM, Felipe Contreras felipe.contre...@gmail.com wrote: When an object has already been exported (and thus is in the marks) it is flagged as SHOWN, so it will not be exported again, even if this time it's exported through a different ref. We don't need the object

Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Felipe Contreras
On Tue, Oct 30, 2012 at 7:12 PM, Sverre Rabbelier srabbel...@gmail.com wrote: On Tue, Oct 30, 2012 at 10:11 AM, Felipe Contreras felipe.contre...@gmail.com wrote: When an object has already been exported (and thus is in the marks) it is flagged as SHOWN, so it will not be exported again, even

Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Sverre Rabbelier
On Tue, Oct 30, 2012 at 11:47 AM, Felipe Contreras felipe.contre...@gmail.com wrote: Why would it? We are not changing the way objects are exported, the only difference is what happens at the end (handle_tags_and_duplicates()). Because the marking is per-commit, not per-ref, right? Perhaps you

Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Jonathan Nieder
Felipe Contreras wrote: % git fast-export $marks_args one % git fast-export $marks_args one two Then yeah, 'one' will be updated once again in the second command, That's probably worth a mention in the commit message and tests (test_expect_failure), to save future readers from some

Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Sverre Rabbelier
On Tue, Oct 30, 2012 at 2:35 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Tue, Oct 30, 2012 at 10:17 PM, Sverre Rabbelier srabbel...@gmail.com wrote: On Tue, Oct 30, 2012 at 11:47 AM, Felipe Contreras felipe.contre...@gmail.com wrote: Why would it? We are not changing the way

Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Felipe Contreras
On Tue, Oct 30, 2012 at 10:59 PM, Sverre Rabbelier srabbel...@gmail.com wrote: On Tue, Oct 30, 2012 at 2:35 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Tue, Oct 30, 2012 at 10:17 PM, Sverre Rabbelier srabbel...@gmail.com wrote: On Tue, Oct 30, 2012 at 11:47 AM, Felipe Contreras

Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Sverre Rabbelier
On Tue, Oct 30, 2012 at 3:18 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Which is expected and correct; the branch already points to the right commit, no need for an extra reset. I think you're correct. Thanks for confirming. -- Cheers, Sverre Rabbelier -- To unsubscribe from this

Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Felipe Contreras
On Tue, Oct 30, 2012 at 11:35 PM, Sverre Rabbelier srabbel...@gmail.com wrote: On Tue, Oct 30, 2012 at 3:18 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Which is expected and correct; the branch already points to the right commit, no need for an extra reset. I think you're correct.

Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Felipe Contreras
On Wed, Oct 31, 2012 at 1:11 AM, Jonathan Nieder jrnie...@gmail.com wrote: (cc-ing the git list) Felipe Contreras wrote: When an object has already been exported (and thus is in the marks) it is flagged as SHOWN, so it will not be exported again, even if this time it's exported through a