Re: [PATCH v3] Refactor recv_sideband()

2016-06-23 Thread Nicolas Pitre
On Thu, 23 Jun 2016, Lukas Fleischer wrote: > On Thu, 23 Jun 2016 at 00:47:39, Nicolas Pitre wrote: > > On Wed, 22 Jun 2016, Nicolas Pitre wrote: > > [...] > > > if (*b) { > > > xwrite(STDERR_FILENO, outbuf.buf, outbuf.len); > > > /*

Re: [PATCH v3] Refactor recv_sideband()

2016-06-23 Thread Lukas Fleischer
On Thu, 23 Jun 2016 at 00:47:39, Nicolas Pitre wrote: > On Wed, 22 Jun 2016, Nicolas Pitre wrote: > [...] > > if (*b) { > > xwrite(STDERR_FILENO, outbuf.buf, outbuf.len); > > /* Incomplete line, skip the next prefix. */ > >

Re: [PATCH v3] Refactor recv_sideband()

2016-06-22 Thread Nicolas Pitre
On Wed, 22 Jun 2016, Nicolas Pitre wrote: > On Wed, 22 Jun 2016, Lukas Fleischer wrote: > > > Before this patch, we used character buffer manipulations to split > > messages from the sideband at line breaks and insert "remote: " at the > > beginning of each line, using the packet size to determin

Re: [PATCH v3] Refactor recv_sideband()

2016-06-22 Thread Nicolas Pitre
On Wed, 22 Jun 2016, Lukas Fleischer wrote: > Before this patch, we used character buffer manipulations to split > messages from the sideband at line breaks and insert "remote: " at the > beginning of each line, using the packet size to determine the end of a > message. However, since it is safe t

[PATCH v3] Refactor recv_sideband()

2016-06-21 Thread Lukas Fleischer
Before this patch, we used character buffer manipulations to split messages from the sideband at line breaks and insert "remote: " at the beginning of each line, using the packet size to determine the end of a message. However, since it is safe to assume that diagnostic messages from the sideband n