Corrects the issues found in review by Peff, including simplifying
the logic in report_helper(). bits_to_msg() would've been an alternate
solution to that change, however it'll get called by
real_report_garbage(), so there's no need to call it twice, especially
when the check we need within
On Fri, Dec 18, 2015 at 06:06:37PM -0600, Doug Kelly wrote:
> Corrects the issues found in review by Peff, including simplifying
> the logic in report_helper(). bits_to_msg() would've been an alternate
> solution to that change, however it'll get called by
> real_report_garbage(), so there's no
On Fri, Dec 18, 2015 at 09:02:47PM -0500, Jeff King wrote:
> I left a few comments on 3/3. I don't think it's _wrong_, but I think we
> can be a bit more thorough (and IMHO, a little more maintainable, but
> others might disagree).
Oh, and I forgot to say thank you for working on this. :)
-Peff
3 matches
Mail list logo
