Re: [PATCH v3 0/6] Fix initializing the_hash_algo

2018-02-26 Thread Stefan Beller
On Sun, Feb 25, 2018 at 12:34 PM, brian m. carlson wrote: > On Sun, Feb 25, 2018 at 06:18:34PM +0700, Nguyễn Thái Ngọc Duy wrote: >> v3 refines v2 a bit more: >> >> - fix configure typo (and stray words in commit message) >> - use repo_set_hash_algo() instead of reassigning the_hash_algo >> - comp

Re: [PATCH v3 0/6] Fix initializing the_hash_algo

2018-02-25 Thread brian m. carlson
On Sun, Feb 25, 2018 at 06:18:34PM +0700, Nguyễn Thái Ngọc Duy wrote: > v3 refines v2 a bit more: > > - fix configure typo (and stray words in commit message) > - use repo_set_hash_algo() instead of reassigning the_hash_algo > - compare hash algos by format_id > - catch NULL hash algo, report nice

[PATCH v3 0/6] Fix initializing the_hash_algo

2018-02-25 Thread Nguyễn Thái Ngọc Duy
v3 refines v2 a bit more: - fix configure typo (and stray words in commit message) - use repo_set_hash_algo() instead of reassigning the_hash_algo - compare hash algos by format_id - catch NULL hash algo, report nicely and suggest GIT_HASH_FIXUP The last point makes me much happier about keeping