Re: [PATCH v3 16/19] pathspec.c: move reusable code from builtin/add.c

2012-12-28 Thread Adam Spiers
On Fri, Dec 28, 2012 at 8:45 PM, Adam Spiers wrote: > On Fri, Dec 28, 2012 at 8:32 PM, Junio C Hamano wrote: >> Adam Spiers writes: >> >>> diff --git a/pathspec.h b/pathspec.h >>> new file mode 100644 >>> index 000..8bb670b >>> --- /dev/null >>> +++ b/pathspec.h >>> @@ -0,0 +1,5 @@ >>> +exte

Re: [PATCH v3 16/19] pathspec.c: move reusable code from builtin/add.c

2012-12-28 Thread Adam Spiers
On Fri, Dec 28, 2012 at 8:48 PM, Junio C Hamano wrote: > Adam Spiers writes: > >> diff --git a/pathspec.c b/pathspec.c >> new file mode 100644 >> index 000..8aea0d2 >> --- /dev/null >> +++ b/pathspec.c >> @@ -0,0 +1,99 @@ >> +#include "cache.h" >> +#include "dir.h" >> +#include "pathspec.h" >

Re: [PATCH v3 16/19] pathspec.c: move reusable code from builtin/add.c

2012-12-28 Thread Junio C Hamano
Adam Spiers writes: > diff --git a/pathspec.c b/pathspec.c > new file mode 100644 > index 000..8aea0d2 > --- /dev/null > +++ b/pathspec.c > @@ -0,0 +1,99 @@ > +#include "cache.h" > +#include "dir.h" > +#include "pathspec.h" > + > +void fill_pathspec_matches(const char **pathspec, char *seen,

Re: [PATCH v3 16/19] pathspec.c: move reusable code from builtin/add.c

2012-12-28 Thread Adam Spiers
On Fri, Dec 28, 2012 at 8:32 PM, Junio C Hamano wrote: > Adam Spiers writes: > >> diff --git a/pathspec.h b/pathspec.h >> new file mode 100644 >> index 000..8bb670b >> --- /dev/null >> +++ b/pathspec.h >> @@ -0,0 +1,5 @@ >> +extern char *find_used_pathspec(const char **pathspec); >> +extern v

Re: [PATCH v3 16/19] pathspec.c: move reusable code from builtin/add.c

2012-12-28 Thread Junio C Hamano
Adam Spiers writes: > diff --git a/pathspec.h b/pathspec.h > new file mode 100644 > index 000..8bb670b > --- /dev/null > +++ b/pathspec.h > @@ -0,0 +1,5 @@ > +extern char *find_used_pathspec(const char **pathspec); > +extern void fill_pathspec_matches(const char **pathspec, char *seen, int >

[PATCH v3 16/19] pathspec.c: move reusable code from builtin/add.c

2012-12-26 Thread Adam Spiers
Extract the following functions from builtin/add.c to pathspec.c, in preparation for reuse by a new git check-ignore command: - fill_pathspec_matches() - find_used_pathspec() - treat_gitlink() - treat_gitlinks() - validate_pathspec() The functions being extracted are not changed in any