Re: [PATCH v3 3/3] connect: improve check for plink to reduce false positives

2015-06-26 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Sun, Apr 26, 2015 at 08:30:12PM +, brian m. carlson wrote: Improve the check by looking for plink or tortoiseplink (or those names suffixed with .exe) only in the final component of the path. This has the downside that a program such as plink-0.63 would

Re: [PATCH v3 3/3] connect: improve check for plink to reduce false positives

2015-06-26 Thread Jeff King
On Fri, Jun 26, 2015 at 09:16:20AM -0700, Junio C Hamano wrote: FYI, this ended up biting me today. We have some integration tests that make sure we can clone over putty, and we wrap plink in a plink-wrapper.sh script that tweaks a few extra options. That used to match under the old

Re: [PATCH v3 3/3] connect: improve check for plink to reduce false positives

2015-06-26 Thread Johannes Schindelin
Hi Peff, On 2015-06-26 18:27, Jeff King wrote: On Fri, Jun 26, 2015 at 09:16:20AM -0700, Junio C Hamano wrote: FYI, this ended up biting me today. We have some integration tests that make sure we can clone over putty, and we wrap plink in a plink-wrapper.sh script that tweaks a few extra

Re: [PATCH v3 3/3] connect: improve check for plink to reduce false positives

2015-06-26 Thread Jeff King
On Fri, Jun 26, 2015 at 07:13:15PM +0200, Johannes Schindelin wrote: It's the test suite for the server side of our git infrastructure, so nothing gets installed. It's more like: export GIT_SSH=$PROJECT_ROOT/test/plink-wrapper.sh export REAL_PLINK=$PROJECT_ROOT/vendor/putty/plink

Re: [PATCH v3 3/3] connect: improve check for plink to reduce false positives

2015-06-26 Thread brian m. carlson
On Fri, Jun 26, 2015 at 09:15:24AM -0400, Jeff King wrote: On Sun, Apr 26, 2015 at 08:30:12PM +, brian m. carlson wrote: Improve the check by looking for plink or tortoiseplink (or those names suffixed with .exe) only in the final component of the path. This has the downside that a

Re: [PATCH v3 3/3] connect: improve check for plink to reduce false positives

2015-06-26 Thread Jeff King
On Sun, Apr 26, 2015 at 08:30:12PM +, brian m. carlson wrote: The git_connect function has code to handle plink and tortoiseplink specially, as they require different command line arguments from OpenSSH (-P instead of -p for ports; tortoiseplink additionally requires -batch). However,

Re: [PATCH v3 3/3] connect: improve check for plink to reduce false positives

2015-04-27 Thread Johannes Schindelin
Hi, On 2015-04-26 22:30, brian m. carlson wrote: The git_connect function has code to handle plink and tortoiseplink specially, as they require different command line arguments from OpenSSH (-P instead of -p for ports; tortoiseplink additionally requires -batch). However, the match was done

Re: [PATCH v3 3/3] connect: improve check for plink to reduce false positives

2015-04-27 Thread Jeff King
On Sun, Apr 26, 2015 at 08:30:12PM +, brian m. carlson wrote: The git_connect function has code to handle plink and tortoiseplink specially, as they require different command line arguments from OpenSSH (-P instead of -p for ports; tortoiseplink additionally requires -batch). However,

[PATCH v3 3/3] connect: improve check for plink to reduce false positives

2015-04-26 Thread brian m. carlson
The git_connect function has code to handle plink and tortoiseplink specially, as they require different command line arguments from OpenSSH (-P instead of -p for ports; tortoiseplink additionally requires -batch). However, the match was done by checking for plink anywhere in the string, which