Hi, On 2015-04-26 22:30, brian m. carlson wrote: > The git_connect function has code to handle plink and tortoiseplink > specially, as they require different command line arguments from > OpenSSH (-P instead of -p for ports; tortoiseplink additionally requires > -batch). However, the match was done by checking for "plink" anywhere > in the string, which led to a GIT_SSH value containing "uplink" being > treated as an invocation of putty's plink. > > Improve the check by looking for "plink" or "tortoiseplink" (or those > names suffixed with ".exe") only in the final component of the path. > This has the downside that a program such as "plink-0.63" would no > longer be recognized, but the increased robustness is likely worth it. > Add tests to cover these cases to avoid regressions. > > Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
I like it! Acked-by: Johannes Schindelin <johannes.schinde...@gmx.de> Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
