Re: [PATCH v3 5/8] push: add an advice on unqualified push

2018-11-01 Thread Jeff King
On Mon, Oct 29, 2018 at 02:14:02PM +0900, Junio C Hamano wrote: > Any failure in the &&-chain (or the last grep) would not terminate > the for loop, so for the purpose of determining the success of this > test_expect_success, the last "blob" iteration is the only thing > that matters. > > Which i

Re: [PATCH v3 5/8] push: add an advice on unqualified push

2018-10-28 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > + if (!advice_push_unqualified_ref_name) > + return; > + > + if (get_oid(matched_src_name, &oid)) > + BUG("'%s' is not a valid object, " > + "match_explicit_lhs() should catch this!", > + matched_sr

[PATCH v3 5/8] push: add an advice on unqualified push

2018-10-26 Thread Ævar Arnfjörð Bjarmason
Add an advice to the recently improved error message added in f8aae12034 ("push: allow unqualified dest refspecs to DWIM", 2008-04-23). Now with advice.pushUnqualifiedRefName=true (on by default) we show a hint about how to proceed: $ ./git-push avar v2.19.0^{commit}:newbranch -n error: T