Re: [PATCH v4 2/3] reset: add new reset.quiet config setting

2018-10-25 Thread Ramsay Jones
On 25/10/2018 10:26, Junio C Hamano wrote: > Junio C Hamano writes: > >> To be honest, I find the second sentence in your rewrite even more >> confusing. It reads as if `reset.quiet` configuration variable >> can be used to restore the "show what is yet to be added" >> behaviour, due to the

Re: [PATCH v4 2/3] reset: add new reset.quiet config setting

2018-10-25 Thread Ben Peart
On 10/25/2018 5:26 AM, Junio C Hamano wrote: Junio C Hamano writes: To be honest, I find the second sentence in your rewrite even more confusing. It reads as if `reset.quiet` configuration variable can be used to restore the "show what is yet to be added" behaviour, due to the

Re: [PATCH v4 2/3] reset: add new reset.quiet config setting

2018-10-25 Thread Junio C Hamano
Junio C Hamano writes: > To be honest, I find the second sentence in your rewrite even more > confusing. It reads as if `reset.quiet` configuration variable > can be used to restore the "show what is yet to be added" > behaviour, due to the parenthetical mention of the default behaviour >

Re: [PATCH v4 2/3] reset: add new reset.quiet config setting

2018-10-24 Thread Junio C Hamano
Ramsay Jones writes: >> diff --git a/Documentation/config.txt b/Documentation/config.txt >> index f6f4c21a54..a2d1b8b116 100644 >> --- a/Documentation/config.txt >> +++ b/Documentation/config.txt >> @@ -2728,6 +2728,9 @@ rerere.enabled:: >> `$GIT_DIR`, e.g. if "rerere" was previously used

Re: [PATCH v4 2/3] reset: add new reset.quiet config setting

2018-10-23 Thread Ramsay Jones
On 23/10/2018 20:04, Ben Peart wrote: > From: Ben Peart Sorry for the late reply, ... I've been away from email - I am still trying to catch up. > > Add a reset.quiet config setting that sets the default value of the --quiet > flag when running the reset command. This enables users to

[PATCH v4 2/3] reset: add new reset.quiet config setting

2018-10-23 Thread Ben Peart
From: Ben Peart Add a reset.quiet config setting that sets the default value of the --quiet flag when running the reset command. This enables users to change the default behavior to take advantage of the performance advantages of avoiding the scan for unstaged changes after reset. Defaults to