Christian Couder christian.cou...@gmail.com writes:
I think it is needed later when struct ref_sort is moved into
ref-filter.h, because then the used_atom[] array is not moved.
Now I am confused. used_atom[] is the mechanism we use to give a
small integer to each atom used in the
On Fri, Jun 12, 2015 at 8:29 PM, Karthik Nayak karthik@gmail.com wrote:
On 06/12/2015 11:34 PM, Junio C Hamano wrote:
Karthik Nayak karthik@gmail.com writes:
What change since 9f613dd do you have in mind, exactly, though?
Well initially the atoms were indexed into used_atom array,
On Sat, Jun 13, 2015 at 1:57 AM, Junio C Hamano gits...@pobox.com wrote:
Christian Couder christian.cou...@gmail.com writes:
I think it is needed later when struct ref_sort is moved into
ref-filter.h, because then the used_atom[] array is not moved.
Now I am confused. used_atom[] is the
Karthik Nayak karthik@gmail.com writes:
The comment in 'ref_sort' hasn't been changed 9f613dd.
Bad grammar? hasn't been changed since 9f613dd, perhaps?
But more importantly, don't just give an abbreviated object name. I
think the comment hasn't changed since the for-each-ref command was
On 06/12/2015 11:10 PM, Junio C Hamano wrote:
Karthik Nayak karthik@gmail.com writes:
The comment in 'ref_sort' hasn't been changed 9f613dd.
Bad grammar? hasn't been changed since 9f613dd, perhaps?
Yes! thanks :)
But more importantly, don't just give an abbreviated object name. I
On 06/12/2015 11:34 PM, Junio C Hamano wrote:
Karthik Nayak karthik@gmail.com writes:
What change since 9f613dd do you have in mind, exactly, though?
Well initially the atoms were indexed into used_atom array, which
later was removed. Hence the comment becomes obsolete.
Later in which
Karthik Nayak karthik@gmail.com writes:
What change since 9f613dd do you have in mind, exactly, though?
Well initially the atoms were indexed into used_atom array, which
later was removed. Hence the comment becomes obsolete.
Later in which commit? In builtin/for-each-ref.c in the
The comment in 'ref_sort' hasn't been changed 9f613dd.
Change the comment to reflect changes made in the code since
9f613dd.
Mentored-by: Christian Couder christian.cou...@gmail.com
Mentored-by: Matthieu Moy matthieu@grenoble-inp.fr
Signed-off-by: Karthik Nayak karthik@gmail.com
---
8 matches
Mail list logo