On Thu, Nov 15, 2012 at 09:17:30PM -0800, Junio C Hamano wrote:
Jeff King p...@peff.net writes:
That is a good question. That confirmation step does come after they
have typed their cover letter. However, if they are using --compose,
they are dumped in their editor with something like:
On Fri, Nov 16, 2012 at 8:08 PM, Jeff King p...@peff.net wrote:
On Thu, Nov 15, 2012 at 09:17:30PM -0800, Junio C Hamano wrote:
Jeff King p...@peff.net writes:
That is a good question. That confirmation step does come after they
have typed their cover letter. However, if they are using
Jeff King p...@peff.net writes:
On Thu, Nov 15, 2012 at 09:17:30PM -0800, Junio C Hamano wrote:
...
OK. Tentatively I replaced your old series with these 8 patches
including the last one, as I tend to agree with the value the
earlier clean-up in the series gives us in the longer term. As
On Fri, Nov 16, 2012 at 08:57:43PM +0100, Felipe Contreras wrote:
I'm not sure how orthogonal it is. The latter half of my series is about
exposing the user_ident_sufficiently_given() flag. If we go with
Felipe's patch, then that exposed information has no users, and it may
not be worth
Jeff King wrote:
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -191,15 +191,47 @@ test_expect_success $PREREQ 'Show all headers' '
test_expect_success $PREREQ 'Prompting works' '
clean_fake_sendmail
- (echo Example f...@example.com
- echo t...@example.com
On Thu, Nov 15, 2012 at 03:08:42AM +0100, Felipe Contreras wrote:
I don't think there's any need for all that, this does the trick:
diff --git a/git-send-email.perl b/git-send-email.perl
index aea66a0..503e551 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -748,16 +748,11
On Thu, Nov 15, 2012 at 9:33 AM, Jeff King p...@peff.net wrote:
On Thu, Nov 15, 2012 at 03:08:42AM +0100, Felipe Contreras wrote:
I don't think there's any need for all that, this does the trick:
diff --git a/git-send-email.perl b/git-send-email.perl
index aea66a0..503e551 100755
---
On Thu, Nov 15, 2012 at 11:28:46AM +0100, Felipe Contreras wrote:
I tried both:
ok 19 # skip implicit ident prompts for sender (missing AUTOIDENT of
PERL,AUTOIDENT)
ok 20 - broken implicit ident aborts send-email
ok 19 - implicit ident prompts for sender
ok 20 # skip broken implicit
On Thu, Nov 15, 2012 at 02:43:58AM -0800, Jeff King wrote:
And doesn't have any of the following:
* configured user.name/user.email
* specified $EMAIL
* configured sendemail.from
* specified --from argument
Very unlikely.
That is certainly the opinion you have stated
On Thu, Nov 15, 2012 at 03:13:47AM -0800, Jeff King wrote:
I think a much more compelling argument/commit message for your
suggested patch would be:
We currently prompt the user for the From address. This is an
inconvenience in the common case that the user has configured their
Jeff King p...@peff.net writes:
I think a much more compelling argument/commit message for your
suggested patch would be:
We currently prompt the user for the From address. This is an
inconvenience in the common case that the user has configured their
identity in the environment, but
On Thu, Nov 15, 2012 at 08:56:37AM -0800, Junio C Hamano wrote:
I think a much more compelling argument/commit message for your
suggested patch would be:
We currently prompt the user for the From address. This is an
inconvenience in the common case that the user has configured their
Jeff King p...@peff.net writes:
That is a good question. That confirmation step does come after they
have typed their cover letter. However, if they are using --compose,
they are dumped in their editor with something like:
From Jeff King p...@peff.net # This line is ignored.
GIT: Lines
If git-send-email is configured with sendemail.from, we will
not prompt the user for the From address of the emails.
If it is not configured, we prompt the user, but provide the
repo author or committer as a default. Even though we
probably have a sensible value for the default, the prompt
is a
On Thu, Nov 15, 2012 at 1:36 AM, Jeff King p...@peff.net wrote:
diff --git a/git-send-email.perl b/git-send-email.perl
index 5a7c29d..0c49b32 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -436,9 +436,8 @@ if (0) {
}
}
-my ($repoauthor, $repocommitter);
15 matches
Mail list logo
