Re: [RFC/PATCH] upload-pack: disable object filtering when disabled by config

2018-03-29 Thread Junio C Hamano
Junio C Hamano writes: > Jeff King writes: > >> I think I'd agree on it being a release blocker. Given that your fix is >> really a one-liner (3 of the lines are just changing the variable name, >> which I agree with), I'd be fine with applying it on top rather than >> reverting the original, ev

Re: [RFC/PATCH] upload-pack: disable object filtering when disabled by config

2018-03-29 Thread Junio C Hamano
Jeff King writes: > I think I'd agree on it being a release blocker. Given that your fix is > really a one-liner (3 of the lines are just changing the variable name, > which I agree with), I'd be fine with applying it on top rather than > reverting the original, even if it means delaying the rele

Re: [RFC/PATCH] upload-pack: disable object filtering when disabled by config

2018-03-29 Thread Jeff King
On Thu, Mar 29, 2018 at 03:03:54PM -0700, Jonathan Nieder wrote: > Jeff King wrote: > > On Wed, Mar 28, 2018 at 01:33:03PM -0700, Jonathan Nieder wrote: > > >> When upload-pack gained partial clone support (v2.17.0-rc0~132^2~12, > >> 2017-12-08), it was guarded by the uploadpack.allowFilter confi

Re: [RFC/PATCH] upload-pack: disable object filtering when disabled by config

2018-03-29 Thread Jonathan Nieder
Jeff King wrote: > On Wed, Mar 28, 2018 at 01:33:03PM -0700, Jonathan Nieder wrote: >> When upload-pack gained partial clone support (v2.17.0-rc0~132^2~12, >> 2017-12-08), it was guarded by the uploadpack.allowFilter config item >> to allow server operators to control when they start supporting it

Re: [RFC/PATCH] upload-pack: disable object filtering when disabled by config

2018-03-29 Thread Jeff King
On Wed, Mar 28, 2018 at 01:33:03PM -0700, Jonathan Nieder wrote: > When upload-pack gained partial clone support (v2.17.0-rc0~132^2~12, > 2017-12-08), it was guarded by the uploadpack.allowFilter config item > to allow server operators to control when they start supporting it. > > That config ite

Re: [RFC/PATCH] upload-pack: disable object filtering when disabled by config

2018-03-29 Thread Jeff Hostetler
On 3/28/2018 6:12 PM, Junio C Hamano wrote: Jonathan Nieder writes: When upload-pack gained partial clone support (v2.17.0-rc0~132^2~12, 2017-12-08), it was guarded by the uploadpack.allowFilter config item to allow server operators to control when they start supporting it. That config item

Re: [RFC/PATCH] upload-pack: disable object filtering when disabled by config

2018-03-28 Thread Junio C Hamano
Jonathan Nieder writes: > When upload-pack gained partial clone support (v2.17.0-rc0~132^2~12, > 2017-12-08), it was guarded by the uploadpack.allowFilter config item > to allow server operators to control when they start supporting it. > > That config item didn't go far enough, though: it contro

[RFC/PATCH] upload-pack: disable object filtering when disabled by config

2018-03-28 Thread Jonathan Nieder
When upload-pack gained partial clone support (v2.17.0-rc0~132^2~12, 2017-12-08), it was guarded by the uploadpack.allowFilter config item to allow server operators to control when they start supporting it. That config item didn't go far enough, though: it controls whether the 'filter' capability