Re: [RFC PATCH v3 5/9] Use new functions in git_rebase__interactive

2018-03-23 Thread Wink Saville
On Fri, Mar 23, 2018 at 11:24 AM, Junio C Hamano wrote: > Johannes Schindelin writes: > >> If you fold this into the previous patch, I am sure that after your 3/9 >> indenting the function properly, the splitting into functions will look >> more or

Re: [RFC PATCH v3 5/9] Use new functions in git_rebase__interactive

2018-03-23 Thread Junio C Hamano
Johannes Schindelin writes: > If you fold this into the previous patch, I am sure that after your 3/9 > indenting the function properly, the splitting into functions will look > more or less like this: > > -git_rebase__interactive () { > +initiate_action () { > +

Re: [RFC PATCH v3 5/9] Use new functions in git_rebase__interactive

2018-03-23 Thread Johannes Schindelin
Hi Wink, On Thu, 22 Mar 2018, Wink Saville wrote: > Use initiate_action, setup_reflog_action, init_basic_state, > init_revisions_and_shortrevisions and complete_action. > > Signed-off-by: Wink Saville > --- > git-rebase--interactive.sh | 187 >

[RFC PATCH v3 5/9] Use new functions in git_rebase__interactive

2018-03-22 Thread Wink Saville
Use initiate_action, setup_reflog_action, init_basic_state, init_revisions_and_shortrevisions and complete_action. Signed-off-by: Wink Saville --- git-rebase--interactive.sh | 187 ++--- 1 file changed, 8 insertions(+), 179 deletions(-)