Re: [WIP PATCH] diff: add option to ignore whitespaces for move detection only

2017-10-25 Thread Brandon Williams
On 10/25, Junio C Hamano wrote: > Junio C Hamano writes: > > > Brandon Williams writes: > > > >> One simple idea would be to convert the single 'flag' into various bit > >> fields themselves, that way if you need to add a new flag you would just > >> make a

Re: [WIP PATCH] diff: add option to ignore whitespaces for move detection only

2017-10-24 Thread Junio C Hamano
Junio C Hamano writes: > Brandon Williams writes: > >> One simple idea would be to convert the single 'flag' into various bit >> fields themselves, that way if you need to add a new flag you would just >> make a new bit field. I'm unaware of any downsides

Re: [WIP PATCH] diff: add option to ignore whitespaces for move detection only

2017-10-24 Thread Junio C Hamano
Brandon Williams writes: > One simple idea would be to convert the single 'flag' into various bit > fields themselves, that way if you need to add a new flag you would just > make a new bit field. I'm unaware of any downsides of doing so (though > i may be missing something)

Re: [WIP PATCH] diff: add option to ignore whitespaces for move detection only

2017-10-24 Thread Brandon Williams
On 10/23, Stefan Beller wrote: > Signed-off-by: Stefan Beller > --- > > diff.c | 10 ++-- > diff.h | 1 + > t/t4015-diff-whitespace.sh | 114 > - > > See, only 10 lines of code! (and a

[WIP PATCH] diff: add option to ignore whitespaces for move detection only

2017-10-23 Thread Stefan Beller
Signed-off-by: Stefan Beller --- diff.c | 10 ++-- diff.h | 1 + t/t4015-diff-whitespace.sh | 114 - See, only 10 lines of code! (and a few more for tests) We have run out of space in