Am 20.12.2016 um 19:52 schrieb Johannes Sixt:
Am 20.12.2016 um 19:35 schrieb Junio C Hamano:
test_expect_success 'shortlog --committer (internal)' '
+git checkout --orphan side &&
+git commit --allow-empty -m one &&
+git commit --allow-empty -m two &&
+GIT_COMMITTER_NAME="Sin No
Jeff King writes:
> I do wonder if in general it should be the responsibility of skippable
> tests to make sure we end up with the same state whether they are run or
> not. That might manage the complexity more. But I certainly don't mind
> tests being defensive like you have here.
If we speak "
On Tue, Dec 20, 2016 at 11:55:45PM -0800, Jacob Keller wrote:
> > I do wonder if in general it should be the responsibility of skippable
> > tests to make sure we end up with the same state whether they are run or
> > not. That might manage the complexity more. But I certainly don't mind
> > tests
On Tue, Dec 20, 2016 at 7:22 PM, Jeff King wrote:
> On Tue, Dec 20, 2016 at 10:35:36AM -0800, Junio C Hamano wrote:
>
>> -- >8 --
>> Subject: SQUASH???
>>
>> Make sure the test does not depend on the result of the previous
>> tests; with MINGW prerequisite satisfied, a "reset to original and
>> re
On Tue, Dec 20, 2016 at 10:35:36AM -0800, Junio C Hamano wrote:
> -- >8 --
> Subject: SQUASH???
>
> Make sure the test does not depend on the result of the previous
> tests; with MINGW prerequisite satisfied, a "reset to original and
> rebuild" in an earlier test was skipped, resulting in differe
Am 20.12.2016 um 19:35 schrieb Junio C Hamano:
test_expect_success 'shortlog --committer (internal)' '
+ git checkout --orphan side &&
+ git commit --allow-empty -m one &&
+ git commit --allow-empty -m two &&
+ GIT_COMMITTER_NAME="Sin Nombre" git commit --allow-empty -m t
Junio C Hamano writes:
> Junio C Hamano writes:
>
>>> May I kindly ask you to make this work on Windows, too? Just
>>>
>>> sed -i -e s/MINGW/MINGW,HAVENOT/ t4201-shortlog.sh
>>
>> HAVENOT???
>>>
>>> on your Linux box and make it pass the tests.
>>>
>>> Thank you so much in advance.
>
> Ah, I thi
Junio C Hamano writes:
>> May I kindly ask you to make this work on Windows, too? Just
>>
>> sed -i -e s/MINGW/MINGW,HAVENOT/ t4201-shortlog.sh
>
> HAVENOT???
>>
>> on your Linux box and make it pass the tests.
>>
>> Thank you so much in advance.
Ah, I think I am slower than my usual today.
Johannes Sixt writes:
> Am 16.12.2016 um 14:51 schrieb Jeff King:
>> diff --git a/t/t4201-shortlog.sh b/t/t4201-shortlog.sh
>> index ae08b57712..6c7c637481 100755
>> --- a/t/t4201-shortlog.sh
>> +++ b/t/t4201-shortlog.sh
>> @@ -190,4 +190,17 @@ test_expect_success 'shortlog with --output=' '
>>
Am 16.12.2016 um 14:51 schrieb Jeff King:
diff --git a/t/t4201-shortlog.sh b/t/t4201-shortlog.sh
index ae08b57712..6c7c637481 100755
--- a/t/t4201-shortlog.sh
+++ b/t/t4201-shortlog.sh
@@ -190,4 +190,17 @@ test_expect_success 'shortlog with --output=' '
test_line_count = 3 shortlog
'
+t
Jeff King writes:
> It obviously would need updating if we switch away from "-c", but I
> think I am OK with the short "-c" (even if we add a more exotic grouping
> option later, this can remain as a short synonym).
Yeah, I think it probably is OK.
As it is very clear that "group by author" i
On Fri, Dec 16, 2016 at 08:39:40AM -0500, Jeff King wrote:
> I'm OK with the approach your patch takes, but I think there were some
> unresolved issues:
>
> - are we OK taking the short "-c" for this, or do we want
> "--group-by=committer" or something like it?
>
> - no tests; you can st
On Thu, Dec 15, 2016 at 01:29:47PM -0800, Linus Torvalds wrote:
> On Tue, Oct 11, 2016 at 11:45 AM, Linus Torvalds
> wrote:
> > In some situations you may want to group the commits not by author,
> > but by committer instead.
> >
> > For example, when I just wanted to look up what I'm still missi
Linus Torvalds writes:
> On Thu, Dec 15, 2016 at 4:19 PM, Junio C Hamano wrote:
>>
>> This fell off the radar partly because of the distractions like
>> "there are other attempts and other ways", and also because the
>> message was not a text-plain that can be reviewed inline. Let me
>> try to
On Thursday, December 15, 2016 5:39:53 PM MST Linus Torvalds wrote:
> On Thu, Dec 15, 2016 at 4:19 PM, Junio C Hamano wrote:
>
> Sorry, I'll just re-send it without the attachment. I prefer inline
> myself, but I thought you didn't care (and gmail makes it
> unnecessarily hard).
>
>
On Thu, Dec 15, 2016 at 5:51 PM, Stephen & Linda Smith wrote:
>
> Why does gmail make it unnecessarily hard?
I read email with the gmail web interface, which is wonderful because
of the server-side searching etc. The only real downside is the weak
threading, but you get used to it.
I personally
From: Linus Torvalds
Subject: Allow "git shortlog" to group by committer information
Date: Tue, 11 Oct 2016 11:45:58 -0700
In some situations you may want to group the commits not by author, but by
committer instead.
For example, when I just wanted to look up what I'm sti
On Thu, Dec 15, 2016 at 4:19 PM, Junio C Hamano wrote:
>
> This fell off the radar partly because of the distractions like
> "there are other attempts and other ways", and also because the
> message was not a text-plain that can be reviewed inline. Let me
> try to dig it up from the mail archive
Linus Torvalds writes:
> Just a ping on this patch..
>
> Jeff had apparently done something similar as part of a bigger
> patch-series, but I don't see that either. I really don't care very
> much how this is done, but I do find this very useful, ...
>
> Yes, I can just maintain this myself, and
Just a ping on this patch..
On Tue, Oct 11, 2016 at 11:45 AM, Linus Torvalds
wrote:
> In some situations you may want to group the commits not by author,
> but by committer instead.
>
> For example, when I just wanted to look up what I'm still missing from
> linux-next in the current merge window
On Tue, Oct 11, 2016 at 12:07:40PM -0700, Linus Torvalds wrote:
> On Tue, Oct 11, 2016 at 12:01 PM, Jeff King wrote:
> >
> > My implementation is a little more complicated because it's also setting
> > things up for grouping by trailers (so you can group by "signed-off-by",
> > for example). I do
On Tue, Oct 11, 2016 at 12:01 PM, Jeff King wrote:
>
> My implementation is a little more complicated because it's also setting
> things up for grouping by trailers (so you can group by "signed-off-by",
> for example). I don't know if that's useful to your or not.
Hmm. Maybe in theory. But probab
On Tue, Oct 11, 2016 at 11:45:58AM -0700, Linus Torvalds wrote:
> In some situations you may want to group the commits not by author,
> but by committer instead.
>
> For example, when I just wanted to look up what I'm still missing from
> linux-next in the current merge window, I don't care so mu
In some situations you may want to group the commits not by author,
but by committer instead.
For example, when I just wanted to look up what I'm still missing from
linux-next in the current merge window, I don't care so much about who
wrote a patch, as what git tree it came from, which generally
24 matches
Mail list logo
