Re: [PATCH] fetch-pack: don't resend known-common refs in find_common

2014-10-21 Thread Junio C Hamano
Dennis Kaarsemaker writes: > By not clearing the request buffer in stateless-rpc mode, fetch-pack > would keep sending already known-common commits, leading to ever bigger > http requests, eventually getting too large for git-http-backend to > handle properly without filling up the pipe buffer in

Re: [PATCH] fetch-pack: don't resend known-common refs in find_common

2014-10-22 Thread Dennis Kaarsemaker
On di, 2014-10-21 at 10:56 -0700, Junio C Hamano wrote: > Dennis Kaarsemaker writes: > > > By not clearing the request buffer in stateless-rpc mode, fetch-pack > > would keep sending already known-common commits, leading to ever bigger > > http requests, eventually getting too large for git-http-

Re: [PATCH] fetch-pack: don't resend known-common refs in find_common

2014-10-22 Thread Duy Nguyen
On Wed, Oct 22, 2014 at 2:41 PM, Dennis Kaarsemaker wrote: > I see two options: > > * Turning that interaction into a more cooperative process, with a > select/poll loop > * Make upload-pack buffer its entire response when run in stateless_rpc > mode until it has consumed all of the request O

Re: [PATCH] fetch-pack: don't resend known-common refs in find_common

2014-10-22 Thread Junio C Hamano
Dennis Kaarsemaker writes: > On di, 2014-10-21 at 10:56 -0700, Junio C Hamano wrote: >> Dennis Kaarsemaker writes: >> >> > By not clearing the request buffer in stateless-rpc mode, fetch-pack >> > would keep sending already known-common commits, leading to ever bigger >> > http requests, eventu

Re: [PATCH] fetch-pack: don't resend known-common refs in find_common

2014-10-26 Thread Dennis Kaarsemaker
On Wed, Oct 22, 2014 at 10:11:40AM -0700, Junio C Hamano wrote: > Dennis Kaarsemaker writes: > > > On di, 2014-10-21 at 10:56 -0700, Junio C Hamano wrote: > >> Dennis Kaarsemaker writes: > >> > >> > By not clearing the request buffer in stateless-rpc mode, fetch-pack > >> > would keep sending a

Re: [PATCH] fetch-pack: don't resend known-common refs in find_common

2014-10-26 Thread Dennis Kaarsemaker
On Wed, Oct 22, 2014 at 05:07:31PM +0700, Duy Nguyen wrote: > On Wed, Oct 22, 2014 at 2:41 PM, Dennis Kaarsemaker > wrote: > > I see two options: > > > > * Turning that interaction into a more cooperative process, with a > > select/poll loop > > * Make upload-pack buffer its entire response when

Re: [PATCH] fetch-pack: don't resend known-common refs in find_common

2014-12-05 Thread Shawn Pearce
On Sun, Oct 26, 2014 at 8:39 AM, Dennis Kaarsemaker wrote: > On Wed, Oct 22, 2014 at 10:11:40AM -0700, Junio C Hamano wrote: >> Dennis Kaarsemaker writes: >> >> > On di, 2014-10-21 at 10:56 -0700, Junio C Hamano wrote: >> >> Dennis Kaarsemaker writes: >> >> >> >> > By not clearing the request bu