Re: [PATCH 4/3] t/Makefile: introduce TEST_SHELL_PATH

2017-10-27 Thread Johannes Schindelin
Hi Peff, On Wed, 25 Oct 2017, Jeff King wrote: > On Wed, Oct 25, 2017 at 11:35:44PM +0200, Johannes Schindelin wrote: > > > > > Or alternatively we could prefix the assignment by > > > > > > > > test -n "$TEST_SHELL_PATH" || > > > > > > > > or use the pattern > > > > > > > >

Re: [PATCH 4/3] t/Makefile: introduce TEST_SHELL_PATH

2017-10-25 Thread Jeff King
On Wed, Oct 25, 2017 at 11:35:44PM +0200, Johannes Schindelin wrote: > > > Or alternatively we could prefix the assignment by > > > > > > test -n "$TEST_SHELL_PATH" || > > > > > > or use the pattern > > > > > > TEST_SHELL_PATH="${TEST_SHELL_PATH:-[...]}" > > > > I'm not quite sure what

Re: [PATCH 4/3] t/Makefile: introduce TEST_SHELL_PATH

2017-10-25 Thread Johannes Schindelin
Hi Peff, On Mon, 23 Oct 2017, Jeff King wrote: > On Mon, Oct 23, 2017 at 01:01:42PM +0200, Johannes Schindelin wrote: > > > On Fri, 20 Oct 2017, Jeff King wrote: > > > > > @@ -2350,6 +2357,7 @@ GIT-LDFLAGS: FORCE > > > # and the first level quoting from the shell that runs "echo". > > >

Re: [PATCH 4/3] t/Makefile: introduce TEST_SHELL_PATH

2017-10-23 Thread Jeff King
On Mon, Oct 23, 2017 at 01:01:42PM +0200, Johannes Schindelin wrote: > On Fri, 20 Oct 2017, Jeff King wrote: > > > @@ -2350,6 +2357,7 @@ GIT-LDFLAGS: FORCE > > # and the first level quoting from the shell that runs "echo". > > GIT-BUILD-OPTIONS: FORCE > > @echo SHELL_PATH=\''$(subst

Re: [PATCH 4/3] t/Makefile: introduce TEST_SHELL_PATH

2017-10-23 Thread Johannes Schindelin
Hi Peff, On Fri, 20 Oct 2017, Jeff King wrote: > @@ -2350,6 +2357,7 @@ GIT-LDFLAGS: FORCE > # and the first level quoting from the shell that runs "echo". > GIT-BUILD-OPTIONS: FORCE > @echo SHELL_PATH=\''$(subst ','\'',$(SHELL_PATH_SQ))'\' >$@+ > + @echo TEST_SHELL_PATH=\''$(subst

Re: [PATCH 4/3] t/Makefile: introduce TEST_SHELL_PATH

2017-10-20 Thread Jeff King
On Sat, Oct 21, 2017 at 01:50:01AM +0200, SZEDER Gábor wrote: > > On Thu, Oct 19, 2017 at 05:01:40PM -0400, Jeff King wrote: > > > > > I sometimes run git's test suite as part of an automated testing > > > process. I was hoping to add "-x" support to get more details when a > > > test fails

Re: [PATCH 4/3] t/Makefile: introduce TEST_SHELL_PATH

2017-10-20 Thread SZEDER Gábor
> On Thu, Oct 19, 2017 at 05:01:40PM -0400, Jeff King wrote: > > > I sometimes run git's test suite as part of an automated testing > > process. I was hoping to add "-x" support to get more details when a > > test fails (since failures are sometimes hard to reproduce). Would it make sense (or