Christian Couder writes:
> Looking at the code of the patches again, I can't see any simple way
> to improve on the way it is done.
Thanks.
On Thu, Jul 26, 2018 at 6:57 PM, Junio C Hamano wrote:
> Оля Тележная writes:
>
>> 2018-07-26 1:13 GMT+03:00 Junio C Hamano :
>>>
>>> * ot/ref-filter-object-info (2018-07-17) 5 commits
>>> - ref-filter: use oid_object_info() to get object
>>> - ref-filter: merge get_obj and get_object
>>> -
Derrick Stolee writes:
> On 7/25/2018 6:13 PM, Junio C Hamano wrote:
>> * ds/multi-pack-index (2018-07-20) 23 commits
>> ...
>> Ready to move to 'next', with some known issues to be followed up?
>> cf.
> I'm not sure if there is anything actionable for me to do in response
> to this
Derrick Stolee writes:
>> Stuck in review?
>> cf. <20180723203500.231932-1-jonathanta...@google.com>
>
> This comments on the initial values of 'struct ref_filter' (that are
> not used). All we need is the diff below squashed into "test-reach:
> test commit_contains".
>
>> cf.
On 7/25/2018 6:13 PM, Junio C Hamano wrote:
* ds/multi-pack-index (2018-07-20) 23 commits
- midx: clear midx on repack
- packfile: skip loading index if in multi-pack-index
- midx: prevent duplicate packfile loads
- midx: use midx in approximate_object_count
- midx: use existing midx
On 7/25/2018 6:13 PM, Junio C Hamano wrote:
* ds/reachable (2018-07-20) 18 commits
- commit-reach: use can_all_from_reach
- commit-reach: make can_all_from_reach... linear
- commit-reach: replace ref_newer logic
- test-reach: test commit_contains
- test-reach: test
Johannes Schindelin writes:
>> If any other issue arises, I do not mind taking an update, either,
>> but I think at this point the topic is reaching the point of
>> diminishing returns and should switch to incremental.
>
> Thomas had a couple of good suggestions, still, and I am considering to
>
Hi Junio,
On Mon, 30 Jul 2018, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> > FWIW I picked up your Asciidoc-underline fix, and I also fixed a typo in a
> > commit message (you may want to pick that up, too, unless you want me to
> > send a full new iteration, I don't care either
Johannes Schindelin writes:
> FWIW I picked up your Asciidoc-underline fix, and I also fixed a typo in a
> commit message (you may want to pick that up, too, unless you want me to
> send a full new iteration, I don't care either way):
Meaning that if you send a full new iteration it would match
Hi Junio,
On Fri, 27 Jul 2018, Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason writes:
>
> > Count me in the "this is useful" camp, but also I did look at the latest
> > submission this time around, but had nothing to say, so I didn't say
> > anything :)
>
> Please make it a habit to do say
Ævar Arnfjörð Bjarmason writes:
> Count me in the "this is useful" camp, but also I did look at the latest
> submission this time around, but had nothing to say, so I didn't say
> anything :)
Please make it a habit to do say something to show that you did
carefully review the series especially
On Wed, Jul 25 2018, Junio C Hamano wrote:
> * js/range-diff (2018-07-25) 21 commits
> [...]
>
> "git tbdiff" that lets us compare individual patches in two
> iterations of a topic has been rewritten and made into a built-in
> command.
>
> Undecided.
>
> Many "The feature is useful"
On Thu, Jul 26, 2018 at 09:57:42AM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > On Wed, Jul 25, 2018 at 03:13:37PM -0700, Junio C Hamano wrote:
> >
> >> * jk/banned-function (2018-07-24) 5 commits
> >> - banned.h: mark strncpy() as banned
> >> - banned.h: mark sprintf() as banned
>
Jeff King writes:
> On Wed, Jul 25, 2018 at 03:13:37PM -0700, Junio C Hamano wrote:
>
>> * jk/banned-function (2018-07-24) 5 commits
>> - banned.h: mark strncpy() as banned
>> - banned.h: mark sprintf() as banned
>> - banned.h: mark strcat() as banned
>> - automatically ban strcpy()
>> -
Оля Тележная writes:
> 2018-07-26 1:13 GMT+03:00 Junio C Hamano :
>>
>> * ot/ref-filter-object-info (2018-07-17) 5 commits
>> - ref-filter: use oid_object_info() to get object
>> - ref-filter: merge get_obj and get_object
>> - ref-filter: initialize eaten variable
>> - ref-filter: fill
Junio C Hamano writes:
> Stefan Beller writes:
>
>>> * js/range-diff (2018-07-25) 21 commits
>
>> I think the current coloring is good enough to ship, but it still has
>> errors around corners, for example introduction of new files,
>> having lines in the inner diff as:
>>
>> diff --git
On Wed, Jul 25, 2018 at 03:13:37PM -0700, Junio C Hamano wrote:
> * jk/banned-function (2018-07-24) 5 commits
> - banned.h: mark strncpy() as banned
> - banned.h: mark sprintf() as banned
> - banned.h: mark strcat() as banned
> - automatically ban strcpy()
> - Merge branch 'sb/blame-color'
2018-07-26 1:13 GMT+03:00 Junio C Hamano :
>
> * ot/ref-filter-object-info (2018-07-17) 5 commits
> - ref-filter: use oid_object_info() to get object
> - ref-filter: merge get_obj and get_object
> - ref-filter: initialize eaten variable
> - ref-filter: fill empty fields with empty values
> -
Junio C Hamano writes:
> Stefan Beller writes:
>
>>> * ag/rebase-i-in-c (2018-07-10) 13 commits
>> [...]
>>>
>>> Piecemeal rewrite of the remaining "rebase -i" machinery in C.
>>>
>>> A reroll (which is rumored to be quite good) exists, but hasn't
>>> been picked up yet.
>>
>> Forgot to
Junio C Hamano writes:
> Stefan Beller writes:
>
>>> * js/range-diff (2018-07-25) 21 commits
>
> The non-coloring part, like patch matching and driving diff over a
> pair of "git show" output, looked reasonably solid when I read it
> (even though I admit I did not audit for leaks).
>
> The only
Stefan Beller writes:
>> * ag/rebase-i-in-c (2018-07-10) 13 commits
> [...]
>>
>> Piecemeal rewrite of the remaining "rebase -i" machinery in C.
>>
>> A reroll (which is rumored to be quite good) exists, but hasn't
>> been picked up yet.
>
> Forgot to state so on either the mailing list (or
Stefan Beller writes:
>> * jh/structured-logging (2018-07-25) 25 commits
> [...]
>> - structured-logging: design document
>> (this branch uses jh/json-writer.)
>>
>> X-Gah.
>
> I am not sure what to make of this comment?
That's just a line/editor noise.
> Does it need review or is the
Stefan Beller writes:
>> * js/range-diff (2018-07-25) 21 commits
> I think the current coloring is good enough to ship, but it still has
> errors around corners, for example introduction of new files,
> having lines in the inner diff as:
>
> diff --git a/Makefile b/Makefile
> ---
On Wed, Jul 25, 2018 at 3:13 PM Junio C Hamano wrote:
>
> Here are the topics that have been cooking. Commits prefixed with
> '-' are only in 'pu' (proposed updates) while commits prefixed with
> '+' are in 'next'. The ones marked with '.' do not appear in any of
> the integration branches, but
Here are the topics that have been cooking. Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'. The ones marked with '.' do not appear in any of
the integration branches, but I am still holding onto them.
Many topics have moved to
25 matches
Mail list logo
