Re: segfault in http.c when https URL is mistyped

2016-09-07 Thread Jeff King
On Wed, Sep 07, 2016 at 04:06:42PM -0400, Jeff King wrote: > +test_expect_success 'remote-http complains cleanly about malformed urls' ' > + # do not actually issue "list" or other commands, as we do not > + # want to rely on what curl would actually do with such a broken > + # URL.

Re: segfault in http.c when https URL is mistyped

2016-09-07 Thread Jeff King
On Wed, Sep 07, 2016 at 03:44:04PM +0200, Lars Wendler wrote: > we at Gentoo got a bug report [1] about git-remote-https segfaulting > when the URL has been mistyped. > This seems to only be triggered when git was compiled with curl > support: > > git clone

segfault in http.c when https URL is mistyped

2016-09-07 Thread Lars Wendler
Hi, we at Gentoo got a bug report [1] about git-remote-https segfaulting when the URL has been mistyped. This seems to only be triggered when git was compiled with curl support: git clone https::/some.example-site.net/test.git Observe the "https::/" instead of "https://;. As soon as you run