Re: Additional plumbing commands

2015-01-07 Thread Jeff King
On Tue, Jan 06, 2015 at 06:37:34PM +0100, Christian Couder wrote: On Tue, Jan 6, 2015 at 5:05 PM, Charles Rudolph charles.w.rudo...@gmail.com wrote: I am writing some higher level git commands for https://github.com/Originate/git-town and would like some additional plumbing commands that

Re: [PATCH] clean: style fix for 9f93e46 (git-clean: use a git-add-interactive ...)

2015-01-07 Thread Duy Nguyen
On Wed, Jan 7, 2015 at 2:17 AM, Junio C Hamano gits...@pobox.com wrote: When I do a SQUASH???, I expect the original authors use it as a hint in their rerolls, but because this series has seen no comments so far (no interests???), I do not foresee or expect you to feel a need for rerolling at

[PATCH] git-completion: add --autostash for 'git rebase'

2015-01-07 Thread Matthieu Moy
This option was added in 587947750bd73544 (not to be confused with --autosquash). Signed-off-by: Matthieu Moy matthieu@imag.fr --- contrib/completion/git-completion.bash | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/completion/git-completion.bash

[PATCHv12 00/10] atomic pushes

2015-01-07 Thread Stefan Beller
There wasn't discussion within the last 24 hours and we were discussing only about minor changes. Changes compared to v9 (the last time I completely sent the series) is only found in the first 2 patches, where we had a back and forth about naming the method warn_if_skipped_connectivity_check and

[PATCHv12 06/10] receive-pack.c: negotiate atomic push support

2015-01-07 Thread Stefan Beller
From: Ronnie Sahlberg sahlb...@google.com This adds the atomic protocol option to allow receive-pack to inform the client that it has atomic push capability. This commit makes the functionality introduced in the previous commits go live for the serving side. The changes in documentation reflect

[PATCHv12 09/10] push.c: add an --atomic argument

2015-01-07 Thread Stefan Beller
From: Ronnie Sahlberg sahlb...@google.com Add a command line argument to the git push command to request atomic pushes. Signed-off-by: Ronnie Sahlberg sahlb...@google.com Signed-off-by: Stefan Beller sbel...@google.com --- Notes: v10, v11, v12: * no changes v8, v9: no

[PATCHv12 02/10] receive-pack.c: die instead of error in case of possible future bug

2015-01-07 Thread Stefan Beller
Discussion on the previous patch revealed we rather want to err on the safe side. To do so we need to stop receive-pack in case of the possible future bug when connectivity is not checked on a shallow push. Also while touching that code we considered that removing the reported refs may be harmful

[PATCHv12 08/10] send-pack.c: add --atomic command line argument

2015-01-07 Thread Stefan Beller
From: Ronnie Sahlberg sahlb...@google.com This adds support to send-pack to negotiate and use atomic pushes iff the server supports it. Atomic pushes are activated by a new command line flag --atomic. In order to do this we also need to change the semantics for send_pack() slightly. The existing

[PATCHv12 01/10] receive-pack.c: shorten the execute_commands loop over all commands

2015-01-07 Thread Stefan Beller
Make the main execute_commands loop in receive-pack easier to read by splitting out some steps into helper functions. The new helper 'should_process_cmd' checks if a ref update is unnecessary, whether due to an error having occurred or for another reason. The helper

[PATCHv12 04/10] receive-pack.c: move transaction handling in a central place

2015-01-07 Thread Stefan Beller
This moves all code related to transactions into the execute_commands_non_atomic function. This includes beginning and committing the transaction as well as dealing with the errors which may occur during the begin and commit phase of a transaction. No functional changes intended. Helped-by: Eric

[PATCHv12 10/10] t5543-atomic-push.sh: add basic tests for atomic pushes

2015-01-07 Thread Stefan Beller
This adds tests for the atomic push option. The first four tests check if the atomic option works in good conditions and the last three patches check if the atomic option prevents any change to be pushed if just one ref cannot be updated. Signed-off-by: Stefan Beller sbel...@google.com ---

Re: [PATCH 1/3] configure.ac: check tv_nsec field in struct stat

2015-01-07 Thread Eric Sunshine
On Wed, Jan 7, 2015 at 5:19 PM, Reuben Hawkins reuben...@gmail.com wrote: On Wed, Jan 7, 2015 at 1:19 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Wed, Jan 7, 2015 at 3:23 PM, Reuben Hawkins reuben...@gmail.com wrote: This check will automatically set the correct NO_NSEC setting. This

Re: [PATCH 2/3] configure.ac: check for clock_gettime and CLOCK_MONOTONIC

2015-01-07 Thread Eric Sunshine
On Wed, Jan 7, 2015 at 5:31 PM, Reuben Hawkins reuben...@gmail.com wrote: On Wed, Jan 7, 2015 at 1:37 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Wed, Jan 7, 2015 at 3:23 PM, Reuben Hawkins reuben...@gmail.com wrote: +GIT_CHECK_FUNC(clock_gettime, +[HAVE_CLOCK_GETTIME=YesPlease],

[PATCH] standardize usage info string format

2015-01-07 Thread Alex Henrie
This patch puts the usage info strings that were not already in docopt- like format into docopt-like format, which will be a litle easier for end users and a lot easier for translators. Changes include: - Placing angle brackets around fill-in-the-blank parameters - Putting dashes in multiword

[PATCHv12 03/10] receive-pack.c: move iterating over all commands outside execute_commands

2015-01-07 Thread Stefan Beller
This commit allows us in a later patch to easily distinguish between the non atomic way to update the received refs and the atomic way which is introduced in a later patch. Signed-off-by: Stefan Beller sbel...@google.com --- Notes: v10, v11, v12: no changes v9: new and

[PATCHv12 07/10] send-pack: rename ref_update_to_be_sent to check_to_send_update

2015-01-07 Thread Stefan Beller
This renames ref_update_to_be_sent to check_to_send_update and inverts the meaning of the return value. Having the return value inverted we can have different values for the error codes. This is useful in a later patch when we want to know if we hit the CHECK_REF_STATUS_REJECTED case.

[PATCHv12 05/10] receive-pack.c: add execute_commands_atomic function

2015-01-07 Thread Stefan Beller
This introduces the new function execute_commands_atomic which will use one atomic transaction for all updates. The default behavior is still the old non atomic way, one ref at a time. This is to cause as little disruption as possible to existing clients. It is unknown if there are client scripts

Probably a bug with ~ symbol in filenames on Windows 7 x64 in git 1.9.5

2015-01-07 Thread Dmitry Bykov
Hello, Recently I installed 1.9.5 git version and faced the problem that one of the files in my cloned repository with a name ICON~714.PNG is marked as deleted even repository was freshly cloned. Trying to do anything with that file resulted in constant Invalid Path errors. Reverting back to

Re: [PATCH v2] remote-curl: fall back to Basic auth if Negotiate fails

2015-01-07 Thread brian m. carlson
On Tue, Jan 06, 2015 at 04:07:01PM +, Dan Langille (dalangil) wrote: HTTP/1.1 401 Authorization Required Date: Tue, 06 Jan 2015 16:02:48 GMT Server: Apache WWW-Authenticate: Negotiate Your server is set up incorrectly. You should see a Negotiate line and a Basic line as well. Right

Re: Probably a bug with ~ symbol in filenames on Windows 7 x64 in git 1.9.5

2015-01-07 Thread Stefan Beller
On Wed, Jan 7, 2015 at 3:26 PM, Dmitry Bykov pvr...@gmail.com wrote: Hello, Recently I installed 1.9.5 git version and faced the problem that one of the files in my cloned repository with a name ICON~714.PNG is marked as deleted even repository was freshly cloned. Trying to do anything with

Re: Probably a bug with ~ symbol in filenames on Windows 7 x64 in git 1.9.5

2015-01-07 Thread Junio C Hamano
Dscho, this sounds to me like the additional 8.3 ambiguity protection (which is only in Git for Windows) in action. Any thoughts? On Wed, Jan 7, 2015 at 3:26 PM, Dmitry Bykov pvr...@gmail.com wrote: Hello, Recently I installed 1.9.5 git version and faced the problem that one of the files in

[PATCH v3] remote-curl: fall back to Basic auth if Negotiate fails

2015-01-07 Thread brian m. carlson
Apache servers using mod_auth_kerb can be configured to allow the user to authenticate either using Negotiate (using the Kerberos ticket) or Basic authentication (using the Kerberos password). Often, one will want to use Negotiate authentication if it is available, but fall back to Basic

Re: [PATCH v3 1/2] t4255: test am submodule with diff.submodule

2015-01-07 Thread Eric Sunshine
On Wed, Jan 7, 2015 at 2:31 PM, Doug Kelly dougk@gmail.com wrote: git am will break when using diff.submodule=log; add some test cases to illustrate this breakage as simply as possible. There are currently two ways this can fail: * With errors (unrecognized input), if only change *

Re: [PATCH 1/2] t4255: test am submodule with diff.submodule

2015-01-07 Thread Junio C Hamano
Doug Kelly dougk@gmail.com writes: On Mon, Dec 29, 2014 at 9:42 AM, Junio C Hamano gits...@pobox.com wrote: Eric Sunshine sunsh...@sunshineco.com writes: + (git am --abort || true) Why (x || y)? Is 'x' so unreliable that we do not know how should exit? Should this be

Re: [PATCH 1/2] support for --no-relative and diff.relative

2015-01-07 Thread Junio C Hamano
kel...@shysecurity.com writes: Content-Type: text/plain; charset=utf-8; format=flowed Please. No format=flawed. Really. I'll figure out the line-wrapping. Also this step is not about --no-relative and diff.relative but is only about --no-relative option. Should I submit as two independent

[PATCH v5 1/2] t4255: test am submodule with diff.submodule

2015-01-07 Thread Doug Kelly
git am will break when using diff.submodule=log; add some test cases to illustrate this breakage as simply as possible. There are currently two ways this can fail: * With errors (unrecognized input), if only change * Silently (no submodule change), if other files change Test for both conditions

[PATCH v5 2/2] format-patch: ignore diff.submodule setting

2015-01-07 Thread Doug Kelly
diff.submodule when set to log produces output which git-am cannot handle. Ignore this setting when generating patch output. Signed-off-by: Doug Kelly dougk@gmail.com --- builtin/log.c | 2 +- t/t4255-am-submodule.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v4 1/2] t4255: test am submodule with diff.submodule

2015-01-07 Thread Doug Kelly
git am will break when using diff.submodule=log; add some test cases to illustrate this breakage as simply as possible. There are currently two ways this can fail: * With errors (unrecognized input), if only change * Silently (no submodule change), if other files change Test for both conditions

[PATCH v4 2/2] format-patch: ignore diff.submodule setting

2015-01-07 Thread Doug Kelly
diff.submodule when set to log produces output which git-am cannot handle. Ignore this setting when generating patch output. Signed-off-by: Doug Kelly dougk@gmail.com --- builtin/log.c | 2 +- t/t4255-am-submodule.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff

v2 patches for fixes on RHEL3

2015-01-07 Thread Reuben Hawkins
These patches add a few autoconfig checks for nanosecond resolution fields in struct stat, CLOCK_MONOTONIC, and HMAC_CTX_cleanup. I'm fairly sure I've fixed the concerns/doubts the first set of patched raised. (I rarely use git-send-email so forgive me if I botch this) -- To unsubscribe from

[PATCH 2/3] configure.ac: check for clock_gettime and CLOCK_MONOTONIC

2015-01-07 Thread Reuben Hawkins
CLOCK_MONOTONIC isn't available on RHEL3, but there are still RHEL3 systems being used in production. This change makes compiling git less tedious on older platforms without CLOCK_MONOTONIC. --- Makefile | 4 config.mak.uname | 1 + configure.ac | 22 ++

[PATCH 3/3] configure.ac: check for HMAC_CTX_cleanup

2015-01-07 Thread Reuben Hawkins
OpenSSL version 0.9.6b and before defined the function HMAC_cleanup. Newer versions define HMAC_CTX_cleanup. Check for HMAC_CTX_cleanup and fall back to HMAC_cleanup when the newer function is missing. --- Makefile | 3 +++ configure.ac | 7 +++ git-compat-util.h | 3 +++ 3

[PATCH 1/3] configure.ac: check tv_nsec field in struct stat

2015-01-07 Thread Reuben Hawkins
This check will automatically set the correct NO_NSEC setting. --- configure.ac | 12 1 file changed, 12 insertions(+) diff --git a/configure.ac b/configure.ac index 6af9647..dcc4bf0 100644 --- a/configure.ac +++ b/configure.ac @@ -754,6 +754,18 @@ AC_CHECK_TYPES([struct itimerval],

Re: [PATCH v2 2/2] t/t3308-notes-merge.sh: succeed with relaxed notes refs

2015-01-07 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Tue, Jan 06, 2015 at 02:20:33AM -0800, Junio C Hamano wrote: The fact that git notes merge refs/heads/master fails is a very good prevention of end-user mistakes, and this removal of test demonstrates that we are dropping a valuable safety. Is it really

A better git log --graph?

2015-01-07 Thread Yuri D'Elia
Hi everyone, git log --graph is hard for me to parse mentally when developing a project which has a lot of branches. All the tools I've been using seem to just parse log --graph's output, and thus are no better at showing history. I would love to have a graph mode where each branch is assigned

Re: [PATCH 1/3] configure.ac: check tv_nsec field in struct stat

2015-01-07 Thread Eric Sunshine
On Wed, Jan 7, 2015 at 3:23 PM, Reuben Hawkins reuben...@gmail.com wrote: This check will automatically set the correct NO_NSEC setting. This commit message neglects to mention the important point that you're also now setting USE_ST_TIMESPEC when detected. You might revise the message like this:

Re: [PATCH 3/3] configure.ac: check for HMAC_CTX_cleanup

2015-01-07 Thread Eric Sunshine
On Wed, Jan 7, 2015 at 3:23 PM, Reuben Hawkins reuben...@gmail.com wrote: OpenSSL version 0.9.6b and before defined the function HMAC_cleanup. Newer versions define HMAC_CTX_cleanup. Check for HMAC_CTX_cleanup and fall back to HMAC_cleanup when the newer function is missing. Missing sign-off.

Re: [PATCH 1/3] configure.ac: check tv_nsec field in struct stat

2015-01-07 Thread Reuben Hawkins
On Wed, Jan 7, 2015 at 1:19 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Wed, Jan 7, 2015 at 3:23 PM, Reuben Hawkins reuben...@gmail.com wrote: This check will automatically set the correct NO_NSEC setting. This commit message neglects to mention the important point that you're also

Re: [PATCH 2/3] configure.ac: check for clock_gettime and CLOCK_MONOTONIC

2015-01-07 Thread Reuben Hawkins
On Wed, Jan 7, 2015 at 1:37 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Wed, Jan 7, 2015 at 3:23 PM, Reuben Hawkins reuben...@gmail.com wrote: CLOCK_MONOTONIC isn't available on RHEL3, but there are still RHEL3 systems being used in production. This change makes compiling git less

Re: [PATCH 1/3] configure.ac: check tv_nsec field in struct stat

2015-01-07 Thread Reuben Hawkins
On Wed, Jan 7, 2015 at 1:19 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Wed, Jan 7, 2015 at 3:23 PM, Reuben Hawkins reuben...@gmail.com wrote: This check will automatically set the correct NO_NSEC setting. This commit message neglects to mention the important point that you're also

Re: [PATCH 2/3] configure.ac: check for clock_gettime and CLOCK_MONOTONIC

2015-01-07 Thread Eric Sunshine
On Wed, Jan 7, 2015 at 3:23 PM, Reuben Hawkins reuben...@gmail.com wrote: CLOCK_MONOTONIC isn't available on RHEL3, but there are still RHEL3 systems being used in production. This change makes compiling git less tedious on older platforms without CLOCK_MONOTONIC. The second sentence is

Re: [PATCH 1/3] configure.ac: check tv_nsec field in struct stat

2015-01-07 Thread Eric Sunshine
On Wed, Jan 7, 2015 at 4:33 PM, Reuben Hawkins reuben...@gmail.com wrote: On Wed, Jan 7, 2015 at 1:19 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Wed, Jan 7, 2015 at 3:23 PM, Reuben Hawkins reuben...@gmail.com wrote: +# Define USE_ST_TIMESPEC=YesPlease when stat.st_mtimespec.tv_nsec

Re: [PATCH v2 2/2] t/t3308-notes-merge.sh: succeed with relaxed notes refs

2015-01-07 Thread Junio C Hamano
Johan Herland jo...@herland.net writes: Alternatively (or additionally), for issue (2), we could add a --disable-ref-safety option to 'git notes', to explicitly disable the safety checks for experimental use. I actually would rather prefer to see a proper plumbing use supported, either by a

Re: Additional plumbing commands

2015-01-07 Thread Junio C Hamano
Jeff King p...@peff.net writes: ... Knowing what each state _means_ and what operations are meaningful to perform is much trickier (e.g., if we are in a rebase, you probably do not want to start a new rebase. But is it wrong to cherry-pick?). It would be nice if we could find a way to

Re: A better git log --graph?

2015-01-07 Thread Yuri D'Elia
On 01/07/2015 04:47 PM, Johan Herland wrote: Have you looked at git show-branch --all? I didn't. Helpful, but I need to get used to the output. The first impression after looking at some random repository histories is that it's still not what I had in mind, though. -- To unsubscribe from this

Re: A better git log --graph?

2015-01-07 Thread Junio C Hamano
Johan Herland jo...@herland.net writes: Have you looked at git show-branch --all? ...Johan Yeah, sounds vaguely like it. Its display certainly is easier to read while the set of branches you have is minimum and everything fits in a window; that is exactly why I wrote it back when the

Re: [PATCH 1/2] support for --no-relative and diff.relative

2015-01-07 Thread Junio C Hamano
kel...@shysecurity.com writes: Content-Type: text/plain; charset=utf-8; format=flowed Please. No format=flawed. Really. Subject: Re: [PATCH 1/2] support for --no-relative and diff.relative diff: teach --no-relative to override earlier --relative or something. Saying the affeced area

Re: [PATCH v3] doc: core.ignoreStat update, and clarify the --assume-unchanged effect

2015-01-07 Thread Junio C Hamano
Philip Oakley philipoak...@iee.org writes: The assume-unchanged bit, and consequently core.ignoreStat, can be misunderstood. Be assertive about the expectation that file changes should notified to Git. Overhaul the general wording thus: 1. direct description of what is ignored given

Re: Tab completion missing for --includes and branch description in git config

2015-01-07 Thread Stefan Beller
On Tue, Jan 6, 2015 at 4:58 PM, Michael Paquier michael.paqu...@gmail.com wrote: Hi all, While toying with the tab completion script for bash, I found a couple of things missing that cannot be completed: - git config --includes - git config branch.$BRANCH_NAME.description Attached are

[PATCH] gitk: Bind g to focus the sha1 entry box

2015-01-07 Thread Ismael Luceno
This allows switching to some commit quickly. Signed-off-by: Ismael Luceno ism...@iodev.co.uk --- gitk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gitk b/gitk index 78358a7..9552fd4 100755 --- a/gitk +++ b/gitk @@ -2561,6 +2561,7 @@ proc makewindow {} { bindkey b prevfile

Re: [PATCH 1/2] support for --no-relative and diff.relative

2015-01-07 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Patch 2/2 also seems to share similar line-wrapping breakages that make it unappliable, but more importantly, the configuration that is supposed to correspond to --relative option only parses a boolean. Is that the right design, or should it also be

Re: [PATCH 1/2] support for --no-relative and diff.relative

2015-01-07 Thread kelson
Content-Type: text/plain; charset=utf-8; format=flowed Please. No format=flawed. Really. I'll figure out the line-wrapping. Also this step is not about --no-relative and diff.relative but is only about --no-relative option. Should I submit as two independent patches then? I took the

[PATCH v3 2/2] format-patch: ignore diff.submodule setting

2015-01-07 Thread Doug Kelly
diff.submodule when set to log produces output which git-am cannot handle. Ignore this setting when generating patch output. Signed-off-by: Doug Kelly dougk@gmail.com --- builtin/log.c | 2 +- t/t4255-am-submodule.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v3 1/2] t4255: test am submodule with diff.submodule

2015-01-07 Thread Doug Kelly
git am will break when using diff.submodule=log; add some test cases to illustrate this breakage as simply as possible. There are currently two ways this can fail: * With errors (unrecognized input), if only change * Silently (no submodule change), if other files change Test for both conditions

Re: [PATCH 1/2] t4255: test am submodule with diff.submodule

2015-01-07 Thread Doug Kelly
On Mon, Dec 29, 2014 at 9:42 AM, Junio C Hamano gits...@pobox.com wrote: Eric Sunshine sunsh...@sunshineco.com writes: + (git am --abort || true) Why (x || y)? Is 'x' so unreliable that we do not know how should exit? Should this be test_must_fail git am --abort? Updated to

Re: A better git log --graph?

2015-01-07 Thread Johan Herland
Have you looked at git show-branch --all? ...Johan On Wed, Jan 7, 2015 at 3:23 PM, Yuri D'Elia wav...@thregr.org wrote: Hi everyone, git log --graph is hard for me to parse mentally when developing a project which has a lot of branches. All the tools I've been using seem to just parse log