[PATCH v3 01/11] fetch-object: make functions return an error code

2019-03-12 Thread Christian Couder
From: Christian Couder The callers of the fetch_object() and fetch_objects() might be interested in knowing if these functions succeeded or not. Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano --- fetch-object.c | 13 - fetch-object.h | 4 ++-- sha1-file.c| 4

[PATCH v3 02/11] Add initial support for many promisor remotes

2019-03-12 Thread Christian Couder
From: Christian Couder The promisor-remote.{c,h} files will contain functions to manage many promisor remotes. We expect that there will not be a lot of promisor remotes, so it is ok to use a simple linked list to manage them. Helped-by: Jeff King Signed-off-by: Christian Couder

[PATCH v3 00/11] Many promisor remotes

2019-03-12 Thread Christian Couder
-inbox.org/git/20180802061505.2983-1-chrisc...@tuxfamily.org/ V3: https://public-inbox.org/git/20180713174959.16748-1-chrisc...@tuxfamily.org/ V2: https://public-inbox.org/git/20180630083542.20347-1-chrisc...@tuxfamily.org/ V1: https://public-inbox.org/git/20180623121846.19750-1-chrisc...@tuxfamily.

[PATCH v3 04/11] promisor-remote: add promisor_remote_reinit()

2019-03-12 Thread Christian Couder
From: Christian Couder We will need to reinitialize the promisor remote configuration as we will make some changes to it in a later commit. Signed-off-by: Christian Couder --- promisor-remote.c | 14 -- promisor-remote.h | 1 + 2 files changed, 13 insertions(+), 2 deletions

[PATCH v3 05/11] promisor-remote: use repository_format_partial_clone

2019-03-12 Thread Christian Couder
A remote specified using the extensions.partialClone config option should be considered a promisor remote too. This remote should be at the end of the promisor remote list, so that it is used only if objects have not been found in other remotes. Signed-off-by: Christian Couder --- promisor

[PATCH v3 08/11] builtin/fetch: remove unique promisor remote limitation

2019-03-12 Thread Christian Couder
As the infrastructure for more than one promisor remote has been introduced in previous patches, we can remove code that forbids the registration of more than one promisor remote. Signed-off-by: Christian Couder --- builtin/fetch.c | 20 +--- 1 file changed, 5 insertions(+), 15

[PATCH v3 06/11] Use promisor_remote_get_direct() and has_promisor_remote()

2019-03-12 Thread Christian Couder
when cloning or fetching using a partial clone filter, remote.origin.promisor will be set to "true" instead of setting extensions.partialClone to "origin". This makes it possible to use many promisor remote just by fetching from them. Signed-off-by: Christian Couder

[PATCH v3 07/11] promisor-remote: parse remote.*.partialclonefilter

2019-03-12 Thread Christian Couder
This makes it possible to specify a different partial clone filter for each promisor remote. Signed-off-by: Christian Couder --- builtin/fetch.c | 2 +- list-objects-filter-options.c | 27 +++ list-objects-filter-options.h | 3 ++- promisor-remote.c

[PATCH v3 03/11] promisor-remote: implement promisor_remote_get_direct()

2019-03-12 Thread Christian Couder
From: Christian Couder This is implemented for now by calling fetch_objects(). It fetches from all the promisor remotes. Signed-off-by: Christian Couder --- promisor-remote.c | 17 + promisor-remote.h | 1 + 2 files changed, 18 insertions(+) diff --git a/promisor-remote.c b

[PATCH v3 09/11] t0410: test fetching from many promisor remotes

2019-03-12 Thread Christian Couder
From: Christian Couder This shows that it is now possible to fetch objects from more than one promisor remote, and that fetching from a new promisor remote can configure it as one. Signed-off-by: Christian Couder --- t/t0410-partial-clone.sh | 47 +++- 1

[PATCH v3 11/11] remote: add promisor and partial clone config to the doc

2019-03-12 Thread Christian Couder
Signed-off-by: Christian Couder --- Documentation/config/remote.txt | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/config/remote.txt b/Documentation/config/remote.txt index 6c4cad83a2..a8e6437a90 100644 --- a/Documentation/config/remote.txt +++ b/Documentation/config

[PATCH v3 10/11] partial-clone: add multiple remotes in the doc

2019-03-12 Thread Christian Couder
While at it, let's remove a reference to ODB effort as the ODB effort has been replaced by directly enhancing partial clone and promisor remote features. Signed-off-by: Christian Couder --- Documentation/technical/partial-clone.txt | 83 --- 1 file changed, 58 inser

Re: [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error

2019-03-15 Thread Christian Couder
Hi, On Fri, Mar 15, 2019 at 2:55 AM jonathan chang wrote: > > On Mon, Mar 11, 2019 at 1:59 AM Thomas Gummerer wrote: > > > > On 03/10, Jonathan Chang wrote: > > > Also I found that there is no such function as test_char_count, > > > is it worthwile to add such function? Here are some stat: > >

Re: Git Merge Conference Recordings [was: Re: [ANNOUNCE] Git Merge Contributor's Summit Jan 31, 2019, Brussels]

2019-03-16 Thread Christian Couder
On Thu, Feb 21, 2019 at 9:24 AM Jeff King wrote: > > On Wed, Feb 20, 2019 at 11:59:04PM -0500, Jeff King wrote: > > > On Wed, Feb 20, 2019 at 02:03:40PM +0100, Ævar Arnfjörð Bjarmason wrote: > > > > > > I wanted to point a colleague of mine to one of the talks. > > > > Unfortunately I could not fi

Draft of Git Rev News edition 49

2019-03-17 Thread Christian Couder
Hi everyone! A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-49.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this

Re: GSoC 2019: Git's application submitted

2019-03-18 Thread Christian Couder
On Mon, Mar 18, 2019 at 1:52 PM Duy Nguyen wrote: > > On Mon, Feb 4, 2019 at 4:17 PM Christian Couder > wrote: > > Anyway feel free to comment and suggest improvements on those pages, > > especially the micro-projects and ideas one. Pull requests on > > https://github

[ANNOUNCE] Git Rev News edition 49

2019-03-20 Thread Christian Couder
Hi everyone, The 49th edition of Git Rev News is now published: https://git.github.io/rev_news/2019/03/20/edition-49/ Thanks a lot to the contributor: Luca Milanesio! Enjoy, Christian, Jakub, Markus and Gabriel.

Re: [GSoC][RFC/PATCH] userdiff: added support for diffing shell scripts

2019-03-23 Thread Christian Couder
On Fri, Mar 22, 2019 at 5:08 PM Kapil Jain wrote: > > Signed-off-by: Kapil Jain > --- > > The test written does not pass, imo there's some problem with the regex part. > please let me know about the fault. To save some work by people who could help you, it might be a good idea to show the output

Re: [GSoC][RFC] Proposal: Improve consistency of sequencer commands

2019-03-23 Thread Christian Couder
Hi Rohit, On Fri, Mar 22, 2019 at 4:12 PM Rohit Ashiwal wrote: > > Hey People > > I am Rohit Ashiwal and here my first draft of the proposal for the project > titled: `Improve consistency of sequencer commands' this summer. I need your > feedback and more than that I need help to improve the time

Re: [GSoC][RFC/PATCH] userdiff: added support for diffing shell scripts

2019-03-24 Thread Christian Couder
On Sun, Mar 24, 2019 at 9:04 AM Kapil Jain wrote: > > On Sun, Mar 24, 2019 at 1:34 AM Christian Couder > wrote: > > > > To save some work by people who could help you, it might be a good > > idea to show the output of the failing test, for example the output of >

Re: git replace --graft does error checking too late

2019-03-27 Thread Christian Couder
On Wed, Mar 27, 2019 at 11:24 AM Andreas Schwab wrote: > > When running `git replace --graft A B' where B is a non-commit (eg. a > tag) it displays an error, Yeah, it seems that when A is a commit and B a tag I get: "error: object A is a tag, not a commit" which is wrong as A is a commit. > bu

Re: git replace --graft does error checking too late

2019-03-27 Thread Christian Couder
On Wed, Mar 27, 2019 at 2:11 PM Christian Couder wrote: > > On Wed, Mar 27, 2019 at 11:24 AM Andreas Schwab wrote: > > > > When running `git replace --graft A B' where B is a non-commit (eg. a > > tag) it displays an error, > > Yeah, it seems that when A is a c

Re: git replace --graft does error checking too late

2019-03-28 Thread Christian Couder
On Wed, Mar 27, 2019 at 2:21 PM Christian Couder wrote: > > On Wed, Mar 27, 2019 at 2:11 PM Christian Couder > wrote: > > > > On Wed, Mar 27, 2019 at 11:24 AM Andreas Schwab wrote: > > > > > > When running `git replace --graft A B' where B is a non-c

Re: [PATCH] Documentation/git-interpret-trailers: explain possible values

2018-07-20 Thread Christian Couder
On Sat, Jul 21, 2018 at 12:23 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> Signed-off-by: Stefan Beller >> --- >> >> Maybe we rather want to refer to the options that are described further >> down in the document? > > I have no strong preference either way. > > The patch looks reasonab

[RFC PATCH 2/5] Add delta-islands.{c,h}

2018-07-21 Thread Christian Couder
ta islands in "builtin/pack-objects.c". Signed-off-by: Jeff King Signed-off-by: Christian Couder --- Documentation/config.txt | 4 + Makefile | 1 + delta-islands.c | 490 +++ delta-islands.h | 11 + pack-object

[RFC PATCH 5/5] t: add t9930-delta-islands.sh

2018-07-21 Thread Christian Couder
From: Jeff King Signed-off-by: Jeff King Signed-off-by: Christian Couder --- t/t9930-delta-islands.sh | 143 +++ 1 file changed, 143 insertions(+) create mode 100755 t/t9930-delta-islands.sh diff --git a/t/t9930-delta-islands.sh b/t/t9930-delta-islands.sh

[RFC PATCH 1/5] packfile: make get_delta_base() non static

2018-07-21 Thread Christian Couder
From: Jeff King As get_delta_base() will be used outside 'packfile.c' in a following commit, let's make it non static and let's declare it in 'packfile.h'. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- packfile.c | 10 +- packfile.

[RFC PATCH 0/5] Add delta islands support

2018-07-21 Thread Christian Couder
This patch series is upstreaming work made by GitHub and available in: https://github.com/peff/git/commits/jk/delta-islands The patch in the above branch has been split into 5 patches with their own new commit message, but no other change has been made. I kept Peff as the author and took the lib

[RFC PATCH 3/5] pack-objects: add delta-islands support

2018-07-21 Thread Christian Couder
From: Jeff King Implement support for delta islands in git pack-objects and document how delta islands work in "Documentation/git-pack-objects.txt". Signed-off-by: Jeff King Signed-off-by: Christian Couder --- Documentation/git-pack-objects.txt | 88 +++ bu

[RFC PATCH 4/5] repack: add delta-islands support

2018-07-21 Thread Christian Couder
From: Jeff King Implement simple support for --delta-islands option and repack.useDeltaIslands config variable in git repack. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- Documentation/config.txt | 4 Documentation/git-repack.txt | 5 + builtin/repack.c

Re: [RFC PATCH 2/5] Add delta-islands.{c,h}

2018-07-22 Thread Christian Couder
On Sun, Jul 22, 2018 at 10:50 AM, Duy Nguyen wrote: > On Sun, Jul 22, 2018 at 7:51 AM Christian Couder > wrote: >> +pack.island:: >> + A regular expression configuring a set of delta islands. See >> + "DELTA ISLANDS" in linkgit:git-pack-objects[1]

Re: [PATCH 2/2] remote-odb: un-inline function remote_odb_reinit

2018-07-25 Thread Christian Couder
Hi, On Wed, Jul 25, 2018 at 12:03 AM, Beat Bolli wrote: > > On 24.07.18 23:59, Jonathan Nieder wrote: >> >> Beat Bolli wrote: >>> -inline void remote_odb_reinit(void) >>> +void remote_odb_reinit(void) >> >> This looks like an oversight in >> https://public-inbox.org/git/20180713174959.16748-6-ch

Re: [RFC PATCH 3/5] pack-objects: add delta-islands support

2018-07-28 Thread Christian Couder
On Sat, Jul 28, 2018 at 11:00 AM, Jeff King wrote: > > On Fri, Jul 27, 2018 at 10:22:09AM -0700, Stefan Beller wrote: > > > > That would solve the problem that fetching torvalds/linux from GitHub > > > yields a bigger pack than fetching it from kernel.org. But again, it's > > > making that root fo

[PATCH v4 8/9] t0410: test fetching from many promisor remotes

2018-08-01 Thread Christian Couder
From: Christian Couder Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano --- t/t0410-partial-clone.sh | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh index 71a9b9a3e8..9d513ebf57

[PATCH v4 5/9] remote-odb: add remote_odb_reinit()

2018-08-01 Thread Christian Couder
From: Christian Couder We will need to reinitialize the remote odb configuration as we will make some changes to it in a later commit when we will detect that a remote is also a remote odb. Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano --- remote-odb.c | 14

[PATCH v4 7/9] Use odb.origin.partialclonefilter instead of core.partialclonefilter

2018-08-01 Thread Christian Couder
From: Christian Couder Let's make the partial clone filter specific to one odb instead of general to all the odbs. This makes it possible to have different partial clone filters for different odbs. Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano --- builtin/fe

[PATCH v4 6/9] Use remote_odb_get_direct() and has_remote_odb()

2018-08-01 Thread Christian Couder
From: Christian Couder Instead of using the repository_format_partial_clone global and fetch_object() directly, let's use has_remote_odb() and remote_odb_get_direct(). Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano --- builtin/cat-file.c| 5 +++-- builtin/fe

[PATCH v4 1/9] fetch-object: make functions return an error code

2018-08-01 Thread Christian Couder
From: Christian Couder The callers of the fetch_object() and fetch_objects() might be interested in knowing if these functions succeeded or not. Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano --- fetch-object.c | 15 +-- fetch-object.h | 6 +++--- sha1-file.c

[PATCH v4 2/9] Add initial remote odb support

2018-08-01 Thread Christian Couder
From: Christian Couder The remote-odb.{c,h} files will contain the functions that are called by the rest of Git mostly from "sha1-file.c" to access the objects managed by the remote odbs. The odb-helper.{c,h} files will contain the functions to actually implement communication with

[PATCH v4 3/9] remote-odb: implement remote_odb_get_direct()

2018-08-01 Thread Christian Couder
From: Christian Couder This is implemented only in the promisor remote mode for now by calling fetch_object(). Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano --- odb-helper.c | 14 ++ odb-helper.h | 3 ++- remote-odb.c | 17 + remote-odb.h | 1

[PATCH v4 4/9] remote-odb: implement remote_odb_get_many_direct()

2018-08-01 Thread Christian Couder
From: Christian Couder This function will be used to get many objects from a promisor remote. Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano --- odb-helper.c | 15 +++ odb-helper.h | 3 +++ remote-odb.c | 17 + remote-odb.h | 1 + 4 files changed

[PATCH v4 0/9] Introducing remote ODBs

2018-08-01 Thread Christian Couder
romisor remotes and external ODB support" series on GitHub: https://github.com/chriscool/git/commits/gl-small-promisor-external-odb12 https://github.com/chriscool/git/commits/gl-small-promisor-external-odb71 Christian Couder (9): fetch-object: make functions return an error code Add initi

[PATCH v4 9/9] Documentation/config: add odb..promisorRemote

2018-08-01 Thread Christian Couder
From: Christian Couder Signed-off-by: Junio C Hamano --- Documentation/config.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index 43b2de7b5f..2d048d47f2 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt

Re: What's cooking in git.git (Jul 2018, #03; Wed, 25)

2018-08-02 Thread Christian Couder
On Thu, Jul 26, 2018 at 6:57 PM, Junio C Hamano wrote: > Оля Тележная writes: > >> 2018-07-26 1:13 GMT+03:00 Junio C Hamano : >>> >>> * ot/ref-filter-object-info (2018-07-17) 5 commits >>> - ref-filter: use oid_object_info() to get object >>> - ref-filter: merge get_obj and get_object >>> - r

[PATCH v2 2/6] Add delta-islands.{c,h}

2018-08-05 Thread Christian Couder
se of it. A few new fields are added in 'struct object_entry' in "pack-objects.h" though. The documentation will follow in a patch that actually uses delta islands in "builtin/pack-objects.c". Signed-off-by: Jeff King Signed-off-by:

[PATCH v2 1/6] packfile: make get_delta_base() non static

2018-08-05 Thread Christian Couder
From: Jeff King As get_delta_base() will be used outside 'packfile.c' in a following commit, let's make it non static and let's declare it in 'packfile.h'. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- packfile.c | 10 +- packfile.h |

[PATCH v2 4/6] repack: add delta-islands support

2018-08-05 Thread Christian Couder
intensive. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- Documentation/config.txt | 4 Documentation/git-repack.txt | 5 + builtin/repack.c | 9 + 3 files changed, 18 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index

[PATCH v2 5/6] t: add t5319-delta-islands.sh

2018-08-05 Thread Christian Couder
From: Jeff King Signed-off-by: Jeff King Signed-off-by: Christian Couder --- t/t5319-delta-islands.sh | 143 +++ 1 file changed, 143 insertions(+) create mode 100755 t/t5319-delta-islands.sh diff --git a/t/t5319-delta-islands.sh b/t/t5319-delta-islands.sh

[PATCH v2 0/6] Add delta islands support

2018-08-05 Thread Christian Couder
also available on GitHub in: https://github.com/chriscool/git/commits/delta-islands The previous version is available there: https://github.com/chriscool/git/commits/delta-islands6 https://public-inbox.org/git/20180722054836.28935-1-chrisc...@tuxfamily.org/ Christian Couder (1): pack-objects: m

[PATCH v2 3/6] pack-objects: add delta-islands support

2018-08-05 Thread Christian Couder
loning and fetching is still quite fast and not much more CPU intensive. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- Documentation/config.txt | 15 Documentation/git-pack-objects.txt | 97 + builtin/pack-objects.c

[PATCH v2 6/6] pack-objects: move tree_depth into 'struct packing_data'

2018-08-05 Thread Christian Couder
This reduces the size of 'struct object_entry' and therefore makes packing objects more efficient. This also renames cmp_tree_depth() into tree_depth_compare(), as it is more modern to have the name of the compare functions end with "compare". Signed-off-by: Christian Coude

Re: [RFC PATCH 3/5] pack-objects: add delta-islands support

2018-08-05 Thread Christian Couder
On Sun, Jul 22, 2018 at 10:55 AM, Duy Nguyen wrote: > On Sun, Jul 22, 2018 at 7:52 AM Christian Couder > wrote: >> >> - /* >> -* And then all remaining commits and tags. >> -*/ >> - for (i = last_untagged; i < to_pack.nr_objects

Re: [RFC PATCH 3/5] pack-objects: add delta-islands support

2018-08-05 Thread Christian Couder
On Tue, Jul 24, 2018 at 7:11 PM, Junio C Hamano wrote: > > Another thing I noticed from 2/5 is that you can have up to 7 such > capture groups. I do not have any opinion if 7 is too few or too > many, but we would want the number to be documented, and end-user > input diagnosed when it requires m

Re: [RFC PATCH 2/5] Add delta-islands.{c,h}

2018-08-05 Thread Christian Couder
On Sun, Jul 22, 2018 at 10:50 AM, Duy Nguyen wrote: > On Sun, Jul 22, 2018 at 7:51 AM Christian Couder > wrote: >> diff --git a/pack-objects.h b/pack-objects.h >> index edf74dabdd..8eecd67991 100644 >> --- a/pack-objects.h >> +++ b/pack-objects.h >> @@ -

Re: [RFC PATCH 3/5] pack-objects: add delta-islands support

2018-08-06 Thread Christian Couder
On Sun, Aug 5, 2018 at 7:40 PM, Christian Couder wrote: > On Tue, Jul 24, 2018 at 7:11 PM, Junio C Hamano wrote: > This is the new documentation: > > -> Refs are grouped into islands based on their "names", and two regexes > -> that produce the same name a

Re: [RFC PATCH 2/5] Add delta-islands.{c,h}

2018-08-06 Thread Christian Couder
On Mon, Aug 6, 2018 at 5:53 PM, Duy Nguyen wrote: > On Sun, Aug 5, 2018 at 8:53 PM Christian Couder > wrote: >> >> As you can see the patch 6/6 (in the v2 of this patch series that I >> just sent) moves `unsigned int tree_depth` from 'struct object_entry' >

Re: [GSoC][PATCH v5 02/20] rebase -i: rewrite append_todo_help() in C

2018-08-07 Thread Christian Couder
Hi Phillip, On Tue, Aug 7, 2018 at 3:57 PM, Phillip Wood wrote: > > On 31/07/18 18:59, Alban Gruin wrote: >> >> + >> + ret = fputs(buf.buf, todo); > > It is not worth changing the patch just for this but strbuf_write() > might be clearer (you use it in a later patch) > >> + if (ret < 0) >

Re: [GSoC][PATCH v5 02/20] rebase -i: rewrite append_todo_help() in C

2018-08-07 Thread Christian Couder
On Tue, Aug 7, 2018 at 6:15 PM, Phillip Wood wrote: > On 07/08/18 16:25, Christian Couder wrote: >> >> I agree about checking the return value from fputs(), but it seems to >> me that we don't usually check the value of fclose(). > > A quick grep shows you'

[PATCH v3 0/8] Add delta islands support

2018-08-09 Thread Christian Couder
ly.org/ V1: https://public-inbox.org/git/20180722054836.28935-1-chrisc...@tuxfamily.org/ Christian Couder (3): pack-objects: refactor code into compute_layer_order() pack-objects: move tree_depth into 'struct packing_data' pack-objects: move 'layer' into 'struct packing_data

[PATCH v3 1/8] packfile: make get_delta_base() non static

2018-08-09 Thread Christian Couder
From: Jeff King As get_delta_base() will be used outside 'packfile.c' in a following commit, let's make it non static and let's declare it in 'packfile.h'. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- packfile.c | 10 +- packfile.h |

[PATCH v3 4/8] pack-objects: add delta-islands support

2018-08-09 Thread Christian Couder
loning and fetching is still quite fast and not much more CPU intensive. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- Documentation/config.txt | 15 + Documentation/git-pack-objects.txt | 97 ++ builtin/pack-objects.c

[PATCH v3 3/8] pack-objects: refactor code into compute_layer_order()

2018-08-09 Thread Christian Couder
will make it easier to see and understand what the following changes are doing. Helped-by: Duy Nguyen Signed-off-by: Christian Couder --- builtin/pack-objects.c | 90 +++--- 1 file changed, 50 insertions(+), 40 deletions(-) diff --git a/builtin/pack-object

[PATCH v3 6/8] t: add t5319-delta-islands.sh

2018-08-09 Thread Christian Couder
From: Jeff King Signed-off-by: Jeff King Signed-off-by: Christian Couder --- t/t5319-delta-islands.sh | 143 +++ 1 file changed, 143 insertions(+) create mode 100755 t/t5319-delta-islands.sh diff --git a/t/t5319-delta-islands.sh b/t/t5319-delta-islands.sh

[PATCH v3 5/8] repack: add delta-islands support

2018-08-09 Thread Christian Couder
intensive. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- Documentation/config.txt | 4 Documentation/git-repack.txt | 5 + builtin/repack.c | 9 + 3 files changed, 18 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index

[PATCH v3 7/8] pack-objects: move tree_depth into 'struct packing_data'

2018-08-09 Thread Christian Couder
: Duy Nguyen Signed-off-by: Christian Couder --- builtin/pack-objects.c | 4 ++-- delta-islands.c| 27 ++- pack-objects.c | 6 ++ pack-objects.h | 21 - 4 files changed, 46 insertions(+), 12 deletions(-) diff --git a/buil

[PATCH v3 8/8] pack-objects: move 'layer' into 'struct packing_data'

2018-08-09 Thread Christian Couder
Duy Nguyen Signed-off-by: Christian Couder --- builtin/pack-objects.c | 4 ++-- delta-islands.c| 4 ++-- pack-objects.c | 6 ++ pack-objects.h | 20 ++-- 4 files changed, 28 insertions(+), 6 deletions(-) diff --git a/builtin/pack-objects.c b/bu

[PATCH v3 2/8] Add delta-islands.{c,h}

2018-08-09 Thread Christian Couder
se of it. A few new fields are added in 'struct object_entry' in "pack-objects.h" though. The documentation will follow in a patch that actually uses delta islands in "builtin/pack-objects.c". Signed-off-by: Jeff King Signed-off-by:

Re: [PATCH v3 0/8] Add delta islands support

2018-08-09 Thread Christian Couder
On Thu, Aug 9, 2018 at 5:55 PM, Christian Couder wrote: > The following changes have been made since the previous iteration: > > * suggested by Duy: move the code computing the write order for a > layer to a new separate function called compute_layer_order() in > builtin/pa

Re: [PATCH v3 2/8] Add delta-islands.{c,h}

2018-08-11 Thread Christian Couder
On Sat, Aug 11, 2018 at 11:04 AM, SZEDER Gábor wrote: >> diff --git a/delta-islands.c b/delta-islands.c >> new file mode 100644 >> index 00..448ddcbbe4 >> --- /dev/null >> +++ b/delta-islands.c > >> +static void deduplicate_islands(void) >> +{ >> + struct remote_island *island, *core =

Re: function get_delta_base() is a file-local symbol

2018-08-11 Thread Christian Couder
Hi Ramsay and Peff, On Sun, Aug 12, 2018 at 3:16 AM, Jeff King wrote: > On Sun, Aug 12, 2018 at 01:30:02AM +0100, Ramsay Jones wrote: > >> My static-check.pl script has pinged me about the get_delta_base() >> symbol from packfile.[co]. The first patch from your 'cc/delta-islands' >> branch export

Re: [PATCH v3 2/8] Add delta-islands.{c,h}

2018-08-11 Thread Christian Couder
On Sat, Aug 11, 2018 at 4:12 PM, Jeff King wrote: > On Sat, Aug 11, 2018 at 12:32:32PM +0200, Christian Couder wrote: > >> Ok, I have made the following changes in the branch I will send next. >> >> diff --git a/delta-islands.c b/delta-islands.c >> index 92137f2e

[PATCH v4 2/7] pack-objects: refactor code into compute_layer_order()

2018-08-11 Thread Christian Couder
will make it easier to see and understand what the following changes are doing. Helped-by: Duy Nguyen Signed-off-by: Christian Couder --- builtin/pack-objects.c | 90 +++--- 1 file changed, 50 insertions(+), 40 deletions(-) diff --git a/builtin/pack-object

[PATCH v4 4/7] repack: add delta-islands support

2018-08-11 Thread Christian Couder
intensive. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- Documentation/config.txt | 4 Documentation/git-repack.txt | 5 + builtin/repack.c | 9 + 3 files changed, 18 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index

[PATCH v4 0/7] Add delta islands support

2018-08-11 Thread Christian Couder
55532.26151-1-chrisc...@tuxfamily.org/ V2: https://public-inbox.org/git/20180805172525.15278-1-chrisc...@tuxfamily.org/ V1: https://public-inbox.org/git/20180722054836.28935-1-chrisc...@tuxfamily.org/ Christian Couder (3): pack-objects: refactor code into compute_layer_order() pack-objects: move tre

[PATCH v4 3/7] pack-objects: add delta-islands support

2018-08-11 Thread Christian Couder
loning and fetching is still quite fast and not much more CPU intensive. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- Documentation/config.txt | 15 + Documentation/git-pack-objects.txt | 97 ++ builtin/pack-objects.c

[PATCH v4 1/7] Add delta-islands.{c,h}

2018-08-11 Thread Christian Couder
se of it. A few new fields are added in 'struct object_entry' in "pack-objects.h" though. The documentation will follow in a patch that actually uses delta islands in "builtin/pack-objects.c". Signed-off-by: Jeff King Signed-off-by:

[PATCH v4 6/7] pack-objects: move tree_depth into 'struct packing_data'

2018-08-11 Thread Christian Couder
: Duy Nguyen Signed-off-by: Christian Couder --- builtin/pack-objects.c | 4 ++-- delta-islands.c| 27 ++- pack-objects.c | 6 ++ pack-objects.h | 21 - 4 files changed, 46 insertions(+), 12 deletions(-) diff --git a/buil

[PATCH v4 7/7] pack-objects: move 'layer' into 'struct packing_data'

2018-08-11 Thread Christian Couder
Duy Nguyen Signed-off-by: Christian Couder --- builtin/pack-objects.c | 4 ++-- delta-islands.c| 4 ++-- pack-objects.c | 6 ++ pack-objects.h | 20 ++-- 4 files changed, 28 insertions(+), 6 deletions(-) diff --git a/builtin/pack-objects.c b/bu

[PATCH v4 5/7] t: add t5319-delta-islands.sh

2018-08-11 Thread Christian Couder
From: Jeff King Signed-off-by: Jeff King Signed-off-by: Christian Couder --- t/t5319-delta-islands.sh | 143 +++ 1 file changed, 143 insertions(+) create mode 100755 t/t5319-delta-islands.sh diff --git a/t/t5319-delta-islands.sh b/t/t5319-delta-islands.sh

Re: [PATCH v4 1/7] Add delta-islands.{c,h}

2018-08-12 Thread Christian Couder
On Mon, Aug 13, 2018 at 3:14 AM, Ramsay Jones wrote: > On 12/08/18 06:11, Christian Couder wrote: >> Because the inefficiency primarily arises when an >> object is delitified against another object that does > > s/delitified/deltified/ ? Ok, this will be in the next reroll

Re: Contributor Summit planning

2018-08-13 Thread Christian Couder
On Mon, Aug 13, 2018 at 7:46 PM, Stefan Beller wrote: > On Mon, Aug 13, 2018 at 9:31 AM Jeff King wrote: >> >> For the past several years, we've held a Git Contributor Summit as part >> of the Git Merge conference. I'd like to get opinions from the community >> to help plan future installments. A

Syncing HEAD

2018-08-14 Thread Christian Couder
Hi, When cloning with --mirror, the clone gets its HEAD initialized with the value HEAD has in its origin remote. After that if HEAD changes in origin there is no simple way to sync HEAD at the same time as the refs are synced. It looks like the simplest way to sync HEAD is: 1) git remote show o

Re: Syncing HEAD

2018-08-14 Thread Christian Couder
On Tue, Aug 14, 2018 at 11:47 PM, Jeff King wrote: > On Tue, Aug 14, 2018 at 05:06:16PM -0400, Jeff King wrote: > >> On Tue, Aug 14, 2018 at 10:09:37PM +0200, Christian Couder wrote: >> >> > When cloning with --mirror, the clone gets its HEAD initialized with >> &

Re: [PATCH v4 1/7] Add delta-islands.{c,h}

2018-08-15 Thread Christian Couder
On Mon, Aug 13, 2018 at 8:11 PM, Jeff King wrote: > On Mon, Aug 13, 2018 at 01:17:18PM +0100, Ramsay Jones wrote: > >> >>> +struct island_bitmap { >> >>> + uint32_t refcount; >> >>> + uint32_t bits[]; >> >> >> >> Use FLEX_ARRAY here? We are slowly moving toward requiring >> >> certain C99

Re: [PATCH v4 1/7] Add delta-islands.{c,h}

2018-08-15 Thread Christian Couder
On Mon, Aug 13, 2018 at 9:00 PM, Jeff King wrote: > On Mon, Aug 13, 2018 at 05:33:59AM +0200, Christian Couder wrote: > >> >> + memcpy(&sha_core, oid->hash, sizeof(uint64_t)); >> >> + rl->hash += sha_core; >> > >> > Hmm, s

[PATCH v5 0/7] [PATCH v4 0/7] Add delta islands support

2018-08-15 Thread Christian Couder
51151.6425-1-chrisc...@tuxfamily.org/ V3: https://public-inbox.org/git/20180809155532.26151-1-chrisc...@tuxfamily.org/ V2: https://public-inbox.org/git/20180805172525.15278-1-chrisc...@tuxfamily.org/ V1: https://public-inbox.org/git/20180722054836.28935-1-chrisc...@tuxfamily.org/ Christian Couder

[PATCH v5 4/7] repack: add delta-islands support

2018-08-15 Thread Christian Couder
intensive. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- Documentation/config.txt | 4 Documentation/git-repack.txt | 5 + builtin/repack.c | 9 + 3 files changed, 18 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index

[PATCH v5 2/7] pack-objects: refactor code into compute_layer_order()

2018-08-15 Thread Christian Couder
will make it easier to see and understand what the following changes are doing. Helped-by: Duy Nguyen Signed-off-by: Christian Couder --- builtin/pack-objects.c | 90 +++--- 1 file changed, 50 insertions(+), 40 deletions(-) diff --git a/builtin/pack-object

[PATCH v5 3/7] pack-objects: add delta-islands support

2018-08-15 Thread Christian Couder
loning and fetching is still quite fast and not much more CPU intensive. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- Documentation/config.txt | 15 + Documentation/git-pack-objects.txt | 97 ++ builtin/pack-objects.c

[PATCH v5 7/7] pack-objects: move 'layer' into 'struct packing_data'

2018-08-15 Thread Christian Couder
Duy Nguyen Signed-off-by: Christian Couder --- builtin/pack-objects.c | 4 ++-- delta-islands.c| 4 ++-- pack-objects.c | 6 ++ pack-objects.h | 20 ++-- 4 files changed, 28 insertions(+), 6 deletions(-) diff --git a/builtin/pack-objects.c b/bu

[PATCH v5 1/7] Add delta-islands.{c,h}

2018-08-15 Thread Christian Couder
se of it. A few new fields are added in 'struct object_entry' in "pack-objects.h" though. The documentation will follow in a patch that actually uses delta islands in "builtin/pack-objects.c". Signed-off-by: Jeff King Signed-off-by:

[PATCH v5 6/7] pack-objects: move tree_depth into 'struct packing_data'

2018-08-15 Thread Christian Couder
: Duy Nguyen Signed-off-by: Christian Couder --- builtin/pack-objects.c | 4 ++-- delta-islands.c| 27 ++- pack-objects.c | 6 ++ pack-objects.h | 21 - 4 files changed, 46 insertions(+), 12 deletions(-) diff --git a/buil

[PATCH v5 5/7] t: add t5319-delta-islands.sh

2018-08-15 Thread Christian Couder
From: Jeff King Signed-off-by: Jeff King Signed-off-by: Christian Couder --- t/t5319-delta-islands.sh | 143 +++ 1 file changed, 143 insertions(+) create mode 100755 t/t5319-delta-islands.sh diff --git a/t/t5319-delta-islands.sh b/t/t5319-delta-islands.sh

Re: [PATCH v5 0/7] [PATCH v4 0/7] Add delta islands support

2018-08-15 Thread Christian Couder
Sorry, I made a copy paste error in the subject there should not be "[PATCH v4 0/7]" in it. On Thu, Aug 16, 2018 at 8:13 AM, Christian Couder wrote: > This patch series is upstreaming work made by GitHub and available in: [...]

Re: What's cooking in git.git (Aug 2018, #04; Fri, 17)

2018-08-18 Thread Christian Couder
On Sat, Aug 18, 2018 at 12:44 AM Junio C Hamano wrote: > * cc/delta-islands (2018-08-16) 7 commits > - pack-objects: move 'layer' into 'struct packing_data' > - pack-objects: move tree_depth into 'struct packing_data' > - t5320: tests for delta islands > - repack: add delta-islands support >

Re: What's cooking in git.git (Aug 2018, #04; Fri, 17)

2018-08-18 Thread Christian Couder
On Sat, Aug 18, 2018 at 1:34 PM Ævar Arnfjörð Bjarmason wrote: > On Sat, Aug 18 2018, Christian Couder wrote: > > FYI this has been requested from GitLab by Drupal (as well as others) > > see > > https://www.drupal.org/drupalorg/blog/developer-tools-initiative-part

Draft of Git Rev News edition 42

2018-08-20 Thread Christian Couder
Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-42.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub is

Re: Draft of Git Rev News edition 42

2018-08-20 Thread Christian Couder
On Mon, Aug 20, 2018 at 10:51 AM, Ævar Arnfjörð Bjarmason wrote: > On Mon, Aug 20 2018, Christian Couder wrote: >> Jakub, Markus, Gabriel and me plan to publish this edition on >> Wednesday August 22nd. > > Let's mention that we've picked SHA-256 as NewHash, a

Re: Git Project Leadership Committee

2018-08-20 Thread Christian Couder
On Fri, Aug 17, 2018 at 12:41 AM, Jeff King wrote: > So here are the nominations I came up with. If you'd like to nominate > somebody else (or yourself!), please do. If you have opinions, let me > know (public or private, as you prefer). > > - Christian Couder > -

[ANNOUNCE] Git Rev News edition 42

2018-08-22 Thread Christian Couder
Hi everyone, The 42nd edition of Git Rev News is now published: https://git.github.io/rev_news/2018/08/22/edition-42/ Thanks a lot to the contributors: Derrick Stolee and Ævar Arnfjörð Bjarmason! Enjoy, Christian, Jakub, Markus and Gabriel.

<    12   13   14   15   16   17   18   19   20   21   >