assigned by the outer while-loop is read-only, so the
attempt to modify it via "$_ .= readline" in the inner while-loop fails
with a "Modification of a read-only value" error.
Avoid both problems by collecting the stitched-together line in a
variable other than $_ and droppin
On Thu, May 9, 2019 at 7:48 AM Ævar Arnfjörð Bjarmason wrote:
> Change the git-send-email command-line argument parsing and config
> reading code to parse those two in the right order. I.e. first we set
> our hardcoded defaults, then we read our config, and finally we read
> the command-line, with
On Fri, May 10, 2019 at 2:59 AM Carlo Marcelo Arenas Belón
wrote:
> In function 'finish_request',
> inlined from 'process_response' at http-push.c:248:2:
> http-push.c:587:4: warning: '%s' directive argument is null
> [-Wformat-overflow=]
> 587 |fprintf(stderr, "Unable to get pack file
On Thu, May 9, 2019 at 8:33 AM Ævar Arnfjörð Bjarmason wrote:
> On Thu, May 09 2019, Eric Sunshine wrote:
> > Although this implementation is well supported in reasonably modern Perl
> > versions (5.10 and later), it fails in a couple ways with older versions
> > (such as
ropping readline() and instead incorporating the stitching of
incomplete lines directly into the existing while (<>) {...} loop.
Helped-by: Ævar Arnfjörð Bjarmason
Signed-off-by: Eric Sunshine
---
This is a re-roll of [1]. The only change since v1 is to drop
localization of $_ as suggested
On Fri, May 10, 2019 at 9:35 PM Eric Wong wrote:
> Do not change the existing info/refs and objects/info/packs
> files if they match the existing content on the filesystem.
> This is intended to preserve mtime and make it easier for dumb
> HTTP pollers to rely on the If-Modified-Since header.
> [.
On Mon, May 13, 2019 at 10:06 AM Johannes Schindelin
wrote:
> I should have posted the link, as it may not be totally obvious where you
> can download artifacts:
>
> https://dev.azure.com/mseng/AzureDevOps/_build/results?buildId=9464474&view=artifacts
This link leads to a Login page requiring som
On Mon, May 13, 2019 at 7:17 PM Elijah Newren wrote:
> Automatic re-encoding of commit messages (and dropping of the encoding
> header) hurts attempts to do reversible history rewrites (e.g. sha1sum
> <-> sha256sum transitions, some subtree rewrites), and seems
> inconsistent with the general prin
On Tue, May 14, 2019 at 5:19 AM Johannes Schindelin via GitGitGadget
wrote:
> The stash.useBuiltin variable introduced in 90a462725e ("stash:
> optionally use the scripted version again", 2019-02-25) was turned on by
> default, but had no documentation.
>
> Let's document it so that users who run
On Wed, May 15, 2019 at 4:11 AM Philip Oakley wrote:
> It is not immediately obvious how to use the `git help` system to show
> the git(1) page, with its overview and its background and coordinating
> material, such as environment variables.
>
> Let's simply list it as the last few words of the la
On Thu, May 16, 2019 at 7:25 AM Duy Nguyen wrote:
> pre-commit hook sets GIT_INDEX_FILE to this "index.lock" so you have
> the latest index content (which is not the same as from
> $GIT_DIR/index). This variable will interfere with any commands that
> work on a different worktree.
>
> So you proba
On Thu, May 16, 2019 at 7:33 AM Eric Sunshine wrote:
> I researched this also and concluded that it's a bug in git-commit.
> You run afoul of it in other situations, as well. For instance, say
> you have your index file in a non-standard location:
>
> $ export GIT_INDEX_F
On Thu, May 16, 2019 at 7:25 AM Duy Nguyen wrote:
> pre-commit hook sets GIT_INDEX_FILE to this "index.lock" so you have
> the latest index content (which is not the same as from
> $GIT_DIR/index). This variable will interfere with any commands that
> work on a different worktree.
I think that th
On Thu, May 16, 2019 at 7:45 AM Duy Nguyen wrote:
> On Thu, May 16, 2019 at 6:39 PM Eric Sunshine wrote:
> > Thinking more clearly on it, a better fix might be for git-worktree to
> > deal with this itself, converting such a path to absolute before
> > cd'ing to the
On Thu, May 16, 2019 at 7:42 AM Duy Nguyen wrote:
> On Thu, May 16, 2019 at 6:33 PM Eric Sunshine wrote:
> > You run afoul of it in other situations, as well. For instance, say
> > you have your index file in a non-standard location:
> >
> > $ export GIT_
On Thu, May 16, 2019 at 6:17 PM Jeff King wrote:
> On Thu, May 16, 2019 at 06:25:24PM +0700, Duy Nguyen wrote:
> > So you probably can still make it work by backing up $GIT_INDEX_FILE
> > (in case you need it), then unset it before you use "git worktree" (or
> > cd to it if you keep a permanent se
On Thu, May 16, 2019 at 8:19 PM Jeff King wrote:
> On Thu, May 16, 2019 at 07:16:54PM -0400, Eric Sunshine wrote:
> > Is there
> > any existing code in Git for doing the relative fixups you mention for
> > other Git environment variables?
>
> You can assign local_repo_e
On Mon, May 13, 2019 at 6:50 AM Nguyễn Thái Ngọc Duy wrote:
> find_worktree() can die() unexpectedly because it uses real_path()
> instead of the gentler version. When it's used in 'git worktree add' [1]
> and there's a bad worktree, this die() could prevent people from adding
> new worktrees.
Th
On Fri, May 17, 2019 at 3:30 AM clime wrote:
> for my app, i need to be able get remote urls (fetch/pull/push) so
> that i can derive some information from those, e.g. pull url netloc
> from which i derive where other custom endpoints (binary file storage)
> related to the remote git repo is locat
On Sun, May 19, 2019 at 2:37 PM Jeff King wrote:
> [...]
> - credential_form_url() parses a URL and decodes the specific
s/form/from/
> elements, but it's hard to convert it back into a regular URL. It
> treats "host:port" as a single unit, meaning it needs to be
> re-encoded speci
On Sun, May 19, 2019 at 2:42 PM Jeff King wrote:
> If the user clones with a URL containing a password and has no
> credential helper configured, we're stuck. We don't want to write the
> password into .git/config because that risks accidentally disclosing it.
> But if we don't record it somewhere
On Wed, May 22, 2019 at 8:56 PM Emily Shaffer wrote:
> We check for a handy environment variable GIT_DEBUGGER when running via
> bin-wrappers/, but this feature is undocumented. Add a hint to how to
> use it into the CodingGuidelines (which is where other useful
> environment settings like DEVELOP
On Wed, May 29, 2019 at 5:11 AM Nguyễn Thái Ngọc Duy wrote:
> Most number-related OPT_ macros store the value in an 'int'
> variable. Many of the variables in 'struct diff_options' have a
> different type, but during the conversion to using parse_options() I
> failed to notice and correct.
>
> The
On Mon, May 27, 2019 at 11:32 AM Ingo Wolf wrote:
> $ ls -a barework
> ./ ../ test.txt
> $ git -C bare worktree add --no-checkout ../barework
> Preparing worktree (new branch 'barework')
> fatal: '../barework' already exists
> $ git -C bare branch
>barework
> * master
> Why this doesn't just
On Sat, Jun 1, 2019 at 4:12 PM Victory Osikwemhe
wrote:
> The current content of date-formats.txt under the RFC 2822 section
> specifies 'The standard email format' whereas the format specified
> is a date format
>
> Signed-off-by: Victory Osikwemhe
> ---
> diff --git a/Documentation/date-formats
On Mon, Jun 3, 2019 at 5:47 AM Duy Nguyen wrote:
> On Sun, Jun 2, 2019 at 2:11 PM Eric Sunshine wrote:
> > On Mon, May 27, 2019 at 11:32 AM Ingo Wolf wrote:
> > > I would like to attach an existing dir to git (make it a workdir) and
> > > then update the index wit
[forwarding to the Git list]
On Sun, Jun 2, 2019 at 6:23 AM Jeffrey Walton wrote:
> On Sun, Jun 2, 2019 at 5:09 AM Jeffrey Walton wrote:
> > I'm catching a self test failure on Solaris 11.3. Git 2.21 from sources.
> >
> > ok 8 - check normal git operations: two packs
> > ok 9 - add more packs
>
On Thu, Jun 6, 2019 at 1:35 PM Jeff King wrote:
> On Thu, Jun 06, 2019 at 01:18:01PM -0400, Eric Sunshine wrote:
> > > > not ok 12 - check normal git operations: twelve packs
> >
> > Jeff Walton reported this to me privately. I'm not familiar with this
> >
On Thu, Jun 6, 2019 at 9:08 PM Emily Shaffer wrote:
> [...]
> The tutorial covers a basic overview of the structs involved during
> revision walk, setting up a basic commit walk, setting up a basic
> all-object walk, and adding some configuration changes to both walk
> types. It intentionally does
On Fri, Jun 7, 2019 at 6:59 PM Emily Shaffer wrote:
> Teach show_object_with_name() to avoid writing a space before a name
> which is empty. Also teach tests for rev-list --objects --filter to not
> require a space between the object ID and name.
> [...]
> Signed-off-by: Emily Shaffer
> ---
> Not
On Sun, Jun 9, 2019 at 6:44 PM brian m. carlson
wrote:
> Replace several hard-coded full and partial object IDs with variables or
> computed values. Create junk data to stuff inside an invalid tree that
> can be either 20 or 32 bytes long. Compute a binary all-zeros object ID
> instead of hard-c
On Mon, Jun 10, 2019 at 5:27 PM Junio C Hamano wrote:
> Eric Sunshine writes:
> >> +#include
> >> +#include "builtin.h"
> >
> > Git source files must always include cache.h or git-compat-util.h (or,
> > for builtins, builtin.h) as the very
On Tue, Jun 11, 2019 at 7:03 PM Jonathan Tan wrote:
> > test_expect_success 'alternate objects are correctly blamed' '
> > test_when_finished "rm -rf alt.git .git/objects/info/alternates" &&
> > + path=$(test_oid numeric) &&
> > + path=$(test_oid_to_path "$path") &&
>
> Double assig
On Wed, Jun 12, 2019 at 2:10 PM Morian Sonnet via GitGitGadget
wrote:
> [...]
> . Add -- before the command to execute, such that now correctly
>
> git --super-prefix submodule--helper \
> foreach --recursive -- git reset --hard
>
> is called.
>
> Signed-off-by: Morian Sonnet
> ---
>
On Tue, Jun 18, 2019 at 12:39 PM Anthony Sottile wrote:
> + git fetch origin --tags
> Unpacking objects: 100% (10/10), done.
> From https://github.com/asottile-archive/git-windows-branch-test
> * [new branch] master -> origin/master
> error: cannot lock ref 'refs/remotes/origin/pr/aux':
On Tue, Jun 18, 2019 at 8:24 AM Johannes Schindelin via GitGitGadget
wrote:
> When redirecting stdout/stderr to the same file, we cannot guarantee
> that stdout will come first.
>
> In fact, in this test case, it seems that an MSVC build always prints
> stderr first.
>
> In any case, this test cas
On Tue, Jun 18, 2019 at 8:24 AM Jeff Hostetler via GitGitGadget
wrote:
> In MSVC, the DEBUG constant is set automatically whenever compiling with
> debug information.
>
> This is clearly not what was intended in cache-tree.c, so let's use a less
> ambiguous constant there.
s/constant/macro name/
On Tue, Jun 18, 2019 at 8:24 AM Jeff Hostetler via GitGitGadget
wrote:
> This special-cases various signals that are not supported on Windows,
> such as SIGPIPE. These cause the UCRT to throw asserts (at least in
> debug mode).
>
> Signed-off-by: Jeff Hostetler
> Signed-off-by: Johannes Schindeli
On Wed, Jun 19, 2019 at 2:19 AM Johannes Sixt wrote:
> Am 19.06.19 um 01:12 schrieb Eric Sunshine:
> > On Tue, Jun 18, 2019 at 8:24 AM Johannes Schindelin via GitGitGadget
> > wrote:
> >> printf ".git\nfatal: Needed a single revision\n" >expect &
On Mon, Jun 17, 2019 at 7:20 PM Emily Shaffer wrote:
> On Fri, Jun 07, 2019 at 02:21:07AM -0400, Eric Sunshine wrote:
> > On Thu, Jun 6, 2019 at 9:08 PM Emily Shaffer
> > wrote:
> > > +int cmd_walken(int argc, const char **argv, const char *prefix)
> > > +{
&g
On Tue, Jun 18, 2019 at 8:24 AM Jeff Hostetler via GitGitGadget
wrote:
> With this patch, Git can be built using the Microsoft toolchain, via:
>
> make MSVC=1 [DEBUG=1]
>
> Third party libraries are built from source using the open source
> "vcpkg" tool set. See https://github.com/Microsof
On Fri, Jun 21, 2019 at 6:43 AM Christian Couder
wrote:
> On Thu, Jun 20, 2019 at 11:29 PM Emily Shaffer
> wrote:
> > It doesn't require 1 or more args - you can run it with no args. So it
> > might be better suited to state the args as optional:
> >
> > 'git psuh [arg]...'
>
> Yeah sure, I wi
On Fri, Jun 21, 2019 at 1:19 PM Junio C Hamano wrote:
> Eric Sunshine writes:
> > On Fri, Jun 21, 2019 at 6:43 AM Christian Couder
> > wrote:
> >> On Thu, Jun 20, 2019 at 11:29 PM Emily Shaffer
> >> wrote:
> >> > It doesn't require 1
On Wed, Jun 19, 2019 at 7:36 PM Emily Shaffer wrote:
> On Wed, Jun 19, 2019 at 04:13:35AM -0400, Eric Sunshine wrote:
> > Maybe I got confused because the tiny cmd_walken() snippets followed
> > one another so closely (or because I got interrupted several times
> > during the
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> It's expected that Git commands support '-h' in order to provide a
> consistent user experience (and this expectation is enforced by the
> test suite). '-h' is captured by parse_options() by default; in order to
> support this flag, we add a s
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> It's expected that Git commands support '-h' in order to provide a
> consistent user experience (and this expectation is enforced by the
> test suite). '-h' is captured by parse_options() by default; in order to
> support this flag, we add a s
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> For now, we have no configuration options we want to set up for
> ourselves, but in the future we may need to. At the very least, we
> should invoke git_default_config() for each config option; we will do so
> inside of a skeleton config callb
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> `struct rev_info` is what's used by the struct itself.
What "struct itself"? Do you mean 'struct rev_info' is used by the
_walk_ itself? Or something?
> `repo_init_revisions()` initializes the struct; then we need to set it
> up for the walk
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> Add the final steps needed and implement the walk loop itself. We add a
> method walken_commit_walk() which performs the final setup to revision.c
> and then iterates over commits from get_revision().
> [...]
> Signed-off-by: Emily Shaffer
>
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> In order to demonstrate how to create grep filters for revision walks,
> filter the walk performed by cmd_walken() to print only commits which
> are authored by someone with a gmail address.
> [...]
> Signed-off-by: Emily Shaffer
> ---
> diff
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> Order the revision walk by author or commit dates, to demonstrate how to
s/,//
> apply topo_sort to a revision walk.
>
> While following the tutorial, new contributors are guided to run a walk
> with each sort and compare the results.
>
> Si
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> The final installment in the tutorial about sorting revision walk
> outputs. This commit reverses the commit list, so that we see newer
> commits last (handy since we aren't using a pager).
>
> It's important to note that rev->reverse needs to
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> Provide a demonstration of a revision walk which traverses all types of
> object, not just commits. This type of revision walk is used for
> operations such as creating packfiles and performing fetches or clones,
> so it's useful to teach new
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> Demonstrate how filter specs can be used when performing a revision walk
> of all object types. In this case, tree depth is used. Contributors who
> are following the revision walking tutorial will be encouraged to run
> the revision walk with
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> It may be illuminating to see which objects were not included within a
> given filter. This also demonstrates, since filter-spec "tree:1" is
> used, that the 'omitted' list contains all objects which are omitted,
> not just the first objects w
On Thu, Jun 27, 2019 at 5:37 AM Johannes Schindelin via GitGitGadget
wrote:
> Many Win32 API functions actually exist in two variants: one with
> the `A` suffix that takes ANSI parameters (`char *` or `const char *`)
> and one with the `W` suffix that takes Unicode parameters (`wchar_t *`
> or `co
On Thu, Jun 27, 2019 at 6:31 PM Emily Shaffer wrote:
> On Thu, Jun 27, 2019 at 01:37:58AM -0400, Eric Sunshine wrote:
> > Don't localize the die() message via _() here or in the preceding
> > OBJ_COMMIT case.
>
> I'm a little surprised by that. Is it because die() i
On Fri, Jun 28, 2019 at 11:03 AM garrett dean wrote:
> I have been trying to install for on my PC for Windows ten and at
> first I was having a hang when it reached the end. Now pop ups are
> appearing saying there are configuration problems.
You'll likely get more helpful responses by contacting
On Fri, Jun 28, 2019 at 5:39 AM Jeff King wrote:
> [...]
> For bulk creation, we can do much better by using fast-import, but it's
> often a pain to generate the input. Let's provide a helper to do so.
> [...]
> Signed-off-by: Jeff King
> ---
> diff --git a/t/test-lib-functions.sh b/t/test-lib-fu
On Fri, Jun 28, 2019 at 7:04 PM SZEDER Gábor wrote:
> On Fri, Jun 28, 2019 at 05:32:35PM -0400, Eric Sunshine wrote:
> > On Fri, Jun 28, 2019 at 5:39 AM Jeff King wrote:
> > > + in_dir=${indir:+-C "$indir"}
> >
> > Doesn't this suffer the probl
On Sun, Jun 30, 2019 at 2:57 PM Johannes Sixt wrote:
> On my Windows system where the POSIX commands are provided by MSYS2,
> I observe this output:
>
> $ ls -l Makefile
> -rw-r--r-- 1 Johannes Sixt 197121 101780 Jun 30 09:33 Makefile
>
> Notice the blank in the user name. Obviously, extracting th
On Thu, Jul 18, 2019 at 11:22 AM SZEDER Gábor wrote:
> C99 'for' loop initial declaration, i.e. 'for (int i = 0; i < n; i++)',
> is not allowed in Git's codebase yet, to maintain compatibility with
> some older compilers.
> [...]
> [1] The Azure Pipelines builds have been using Ubuntu 16.04 images
On Sun, Jul 21, 2019 at 2:31 PM Carlo Marcelo Arenas Belón
wrote:
> grep: skip UTF8 checks explicitally
s/explicitally/explicitly/
> Usually PCRE is compiled with JIT support, and therefore the code
> path used includes calling pcre2_jit_match (for PCRE2), that ignores
> invalid UTF-8 in the cor
On Mon, Oct 22, 2018 at 4:46 PM Andreas Heiduk wrote:
> diff --git a/Documentation/git-worktree.txt b/Documentation/git-worktree.txt
> @@ -270,8 +270,8 @@ Porcelain Format
> The porcelain format has a line per attribute. Attributes are listed with a
> label and value separated by a single space
On Mon, Oct 22, 2018 at 6:15 PM Johannes Schindelin via GitGitGadget
wrote:
> When `git stash apply ` sees an argument that consists only of
> digits, it tries to be smart and interpret it as `stash@{}`.
>
> Unfortunately, an all-digit hash (which is unlikely but still possible)
> is therefore mis
On Mon, Oct 22, 2018 at 11:53 PM Stephen P. Smith wrote:>
> Rename test and update the test description to explicitly state that
> included tests all relate to commit authorship. The t7509-commit.sh
> file was not rnemamed when other scripts were updated in compliance
s/rnemamed/renamed/
> with
On Mon, Oct 22, 2018 at 11:53 PM Stephen P. Smith wrote:
> When the test naming convention was documented[1] the commit script
> was not renamed.
>
> Update the test description to note that the tests fall into for
> general categories: template, sign-off, -F and squash tests.
s/for/four/
> Chos
On Mon, Oct 22, 2018 at 11:54 PM Stephen P. Smith wrote:
> The naming convention was documented [1] but this script was not
> renamed.
>
> The original commit message indicates the script tests basic commit
> functionality. Clean up the test name by changing the file name to
> specify the intent a
On Tue, Oct 23, 2018 at 12:31 PM Slavica wrote:
> This is part of enhancement request that ask for `git stash` to work even if
> `user.name` is not configured.
> The issue is discussed here:
> https://public-inbox.org/git/87o9debty4@evledraar.gmail.com/T/#u.
As Christian mentioned already,
On Wed, Oct 24, 2018 at 2:39 AM wrote:
> lock_reason is now populated during the execution of get_worktrees
>
> is_worktree_locked has been simplified, renamed, and changed to internal
> linkage. It is simplified to only return the lock reason (or NULL in case
> there is no lock reason) and to not
On Wed, Oct 24, 2018 at 4:06 PM Slavica Djukic
wrote:
> This is part of enhancement request that ask for 'git stash' to work
> even if 'user.name' and 'user.email' are not configured.
> Due to an implementation detail, git-stash undesirably requires
> 'user.name' and 'user.email' to be set, but sh
On Thu, Oct 25, 2018 at 1:47 AM Nickolai Belakovski
wrote:
> The motivation for the change is some work that I'm doing to add a
> worktree atom in ref-filter.c. I wanted that atom to be able to access
> all fields of the worktree struct and noticed that lock_reason wasn't
> getting populated so I
On Thu, Oct 25, 2018 at 3:04 PM Daniels Umanovskis
wrote:
> When called with --show-current, git branch will print the current
> branch name and terminate. Only the actual name gets printed,
> without refs/heads. In detached HEAD state, nothing is output.
>
> Signed-off-by: Daniels Umanovskis
> -
On Sun, Oct 28, 2018 at 11:32 AM Martin Ågren wrote:
> [...]
> Let's be explicit about breaking out of the loop. This helps the
> compiler grok our intention. As a bonus, it might make it (even) more
> obvious to human readers that the loop stops at the first space.
This did come up in review[1,2
On Sun, Oct 28, 2018 at 5:55 PM Nickolai Belakovski
> wrote: This was meant to be a reply to
> https://public-inbox.org/git/cac05386f1x7tspr6kgkulwewsmdiq4vktf5rxahvzpkwbmx...@mail.gmail.com/T/#m8898c8f7c68e1ea234aca21cb2d7776b375c6f51,
> please look there for some more context. I think it both di
On Sun, Oct 28, 2018 at 9:11 PM Nickolai Belakovski
wrote:
> On Sun, Oct 28, 2018 at 4:03 PM Eric Sunshine wrote:
> > Aside from that, it doesn't seem like worktree needs any changes for
> > the ref-filter atom you have in mind. (Don't interpret this
> > observatio
On Mon, Oct 29, 2018 at 1:45 AM Nickolai Belakovski
wrote:
> On Sun, Oct 28, 2018 at 9:01 PM Eric Sunshine wrote:
> > That said, I wouldn't necessarily oppose renaming the function, but I
> > also don't think it's particularly important to do so.
>
> To me,
On Mon, Oct 29, 2018 at 10:10 PM Junio C Hamano wrote:
> How's this?
>
> On platforms with recent cURL library, http.sslBackend configuration
> variable can be used to choose different SSL backend at runtime.
s/choose/& a/
> The Windows port uses this mechanism to switch between Open
On Wed, Oct 31, 2018 at 10:54 AM Johannes Schindelin
wrote:
> On Tue, 30 Oct 2018, Martin Ågren wrote:
> > Rewrite the loop to a more idiomatic variant which doesn't muck with
> > `len` in the loop body. That should help compilers and human readers
> > figure out what is going on here. But do note
On Tue, Oct 30, 2018 at 07:23:38PM -0400, Jeff King wrote:
> There are three ways to convince cat-file to stream a blob:
>
> - cat-file -p $blob
>
> - cat-file blob $blob
>
> - echo $batch | cat-file --batch
>
> In the first two, we simply exit with the error code of
> streaw_blob_to_fd()
On Sat, Nov 3, 2018 at 11:31 AM Nguyễn Thái Ngọc Duy wrote:
> Rules 8 and 18 are now updated to be less eager. We conclude that the
> current entry is positively matched and included. But we say nothing
> about remaining entries. tree_entry_interesting() will be called again
> for those entries wh
On Fri, Nov 2, 2018 at 6:38 PM Ævar Arnfjörð Bjarmason wrote:
> Add a switch for use in conjunction with the INSTALL_SYMLINKS flag
> added in ad874608d8 ("Makefile: optionally symlink libexec/git-core
> binaries to bin/git", 2018-03-13).
> [...]
> Signed-off-by: Ævar Arnfjörð Bjarmason
> ---
> di
On Fri, Nov 2, 2018 at 6:38 PM Ævar Arnfjörð Bjarmason wrote:
> Let's add an option to break this backwards compatibility. Now with
> NO_INSTALL_BUILTIN_EXECDIR_ALIASES=YesPlease there's only 3 programs
> in the bindir that are hardlinked to "git" (receive-pack,
> upload-archive & upload-pack), an
'sb/filenames-with-dashes'On Fri, Nov 2, 2018 at 6:38 PM Ævar Arnfjörð
Bjarmason wrote:
> Move a 37 line for-loop mess out of "install" and into a helper
> script. This started out fairly innocent but over the years has grown
> into a hard-to-maintain monster, and my recent ad874608d8 ("Makefile:
On Wed, Oct 31, 2018 at 6:16 AM Phillip Wood wrote:
> diff --git a/builtin/am.c b/builtin/am.c
> @@ -308,6 +312,7 @@ static int read_author_script(struct am_state *state)
> + int i, name_i = -2, email_i = -2, date_i = -2, err = 0;
> @@ -326,14 +331,38 @@ static int read_author_script(struct
On Sat, Nov 3, 2018 at 8:25 PM Eric Sunshine wrote:
> On Sat, Nov 3, 2018 at 11:31 AM Nguyễn Thái Ngọc Duy
> wrote:
> > +test_expect_success 't_e_i() exclude case #8' '
> > + git init case8 &&
> > + (
> > +
On Sun, Nov 4, 2018 at 10:23 AM Anders Waldenborg wrote:
> This adds support for three new options to %(trailers):
> * key -- show only trailers with specified key
> * nokey -- don't show key part of trailers
> * separator -- allow specifying custom separator between trailers
If "key" is for i
On Sun, Nov 4, 2018 at 10:24 AM Anders Waldenborg wrote:
> Adds a new "key=X" option to "%(trailers)" which will cause it to only
> print trailers lines which matches the specified key.
>
> Signed-off-by: Anders Waldenborg
> ---
> diff --git a/Documentation/pretty-formats.txt
> b/Documentation/p
On Sun, Nov 4, 2018 at 6:26 PM Junio C Hamano wrote:
> OK, thanks. It seems that the relative silence after this message
> is a sign that the resulting patch after squashing is what everybody
> is happey with?
>
> -- >8 --
> From: Steve Hoelzer
>
> Signed-off-by: Johannes Sixt
> Acked-by: Steve
On Sun, Nov 4, 2018 at 10:48 PM Junio C Hamano wrote:
> Eric Sunshine writes:
> > Does the user have to include the colon when specifying of
> > 'key='?
> > Does 'key=', do a full or partial match on trailers?
> > What happens if 'key=...&#
On Mon, Nov 5, 2018 at 3:26 AM Anders Waldenborg wrote:
> Eric Sunshine writes:
> > Should the code tolerate a trailing colon? (Genuine question; it's
> > easy to do and would be more user-friendly.)
>
> I would make sense to allow the trailing colon, it is easy enough
On Mon, Nov 5, 2018 at 3:07 PM Ævar Arnfjörð Bjarmason wrote:
> Add a --no-patch option which shows which changes got removed, added
> or moved etc., without showing the diff associated with them.
This option existed in the very first version[1] of range-diff (then
called branch-diff) implemented
On Mon, Nov 5, 2018 at 11:17 PM Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason writes:
> > This change doesn't update git-format-patch with a --no-patch
> > option. That can be added later similar to how format-patch first
> > learned --range-diff, and then --creation-factor in
> > 8631bf1cdd (
On Wed, Nov 7, 2018 at 7:22 AM Ævar Arnfjörð Bjarmason wrote:
> In 73a834e9e2 ("range-diff: relieve callers of low-level configuration
> burden", 2018-07-22) we broke passing down options like --no-patch,
> --stat etc. Fix that regression, and add a test for some of these
> options being passed do
On Thu, Nov 8, 2018 at 10:45 AM Johannes Schindelin
wrote:
> On Thu, 8 Nov 2018, Duy Nguyen wrote:
> > One thing I had in mind when proposing $VARIABLE is that it opens up a
> > namespace for us to expand more things (*) for example $GIT_DIR (from
> > ~/.gitconfig).
> >
> > (*) but in a controlled
On Thu, Nov 8, 2018 at 2:00 AM Force Charlie via GitGitGadget
wrote:
> In order to give users the freedom to control the HTTP version,
> we need to add a setting to choose which HTTP version to use.
>
> Signed-off-by: Force Charlie
> ---
> diff --git a/http.c b/http.c
> @@ -284,6 +285,9 @@ static
On Wed, Nov 7, 2018 at 10:24 PM Junio C Hamano wrote:
> Makefile: ease dynamic-gettext-poison transition
>
> Earlier we made the entire build to fail when GETTEXT_POISON=Yes is
> given to make, to notify those who did not notice that text poisoning
> is now a runtime behaviour.
>
> It turns out th
On Thu, Nov 8, 2018 at 5:34 PM Ævar Arnfjörð Bjarmason wrote:
> On Thu, Nov 08 2018, Eric Sunshine wrote:
> > Looking at diff.c:parse_diff_opt() and enable_patch_output(), rather
> > than introducing this new conditional, I'm thinking that a more
>
On Fri, Nov 9, 2018 at 9:46 AM wrote:
> When printing variables which contains a size, today "unsigned long"
> is used at many places.
> In order to be able to change the type from "unsigned long" into size_t
> some day the future, we need to have a way to print 64 bit variables
s/day/& in/
> on
On Sat, Nov 10, 2018 at 7:21 PM Fredi Fowler wrote:
> Is there any way to create pull request to git man (https://git-scm.com/docs)?
That website is maintained as a project separate from Git, so you can
report issues specific to the website, or create pull requests, at its
project page (https://g
1401 - 1500 of 3976 matches
Mail list logo
