On Fri, Jul 11, 2014 at 7:22 PM, David Turner dtur...@twopensource.com wrote:
During the commit process, update the cache-tree. Write this updated
cache-tree so that it's ready for subsequent commands.
Add test code which demonstrates that git commit now writes the cache
tree. Make all tests
On Fri, Jul 11, 2014 at 6:55 PM, Jacob Keller jacob.e.kel...@intel.com wrote:
Add support for configuring default sort ordering for git tags. Command
line option will override this configured value, using the exact same
syntax.
Cc: Jeff King p...@peff.net
Signed-off-by: Jacob Keller
On Fri, Jul 11, 2014 at 12:52 PM, Yi EungJun semtlen...@gmail.com wrote:
Add an Accept-Language header which indicates the user's preferred
languages defined by $LANGUAGE, $LC_ALL, $LC_MESSAGES and $LANG.
Examples:
LANGUAGE= -
LANGUAGE=ko:en - Accept-Language: ko, en; q=0.9, *; q=0.1
On Sun, Jul 13, 2014 at 1:22 PM, Junio C Hamano gits...@pobox.com wrote:
Eric Sunshine sunsh...@sunshineco.com writes:
+ (echo p; echo 1; echo; echo s; echo n; echo y; echo q) | git commit
--interactive -m foo
Broken -chain.
Would a printf make this more readable?
printf p\n1
On Tue, Jul 15, 2014 at 7:29 AM, Ephrim Khong dr.kh...@gmail.com wrote:
When adding alternate object directories, we try not to add the
directory of the current repository to avoid cycles. Unfortunately,
that test was broken, since it compared an absolute with a relative
path.
On Sun, Jul 13, 2014 at 12:50 AM, Nguyễn Thái Ngọc Duy
pclo...@gmail.com wrote:
git checkout --to sets up a new working directory with a .git file
pointing to $GIT_DIR/repos/id. It then executes git checkout again
on the new worktree with the same arguments except --to is taken
out. The second
On Sun, Jul 13, 2014 at 12:51 AM, Nguyễn Thái Ngọc Duy
pclo...@gmail.com wrote:
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com
---
builtin/checkout.c | 49 +++--
1 file changed, 47 insertions(+), 2 deletions(-)
diff --git
On Sun, Jul 20, 2014 at 7:55 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Sun, Jul 13, 2014 at 12:51 AM, Nguyễn Thái Ngọc Duy
pclo...@gmail.com wrote:
+
+ junk_pid = getpid();
+ atexit(remove_junk);
+ sigchain_push_common(remove_junk_on_signal);
+
if (mkdir
On Sun, Jul 13, 2014 at 12:50 AM, Nguyễn Thái Ngọc Duy
pclo...@gmail.com wrote:
This variable is intended to support multiple working directories
attached to a repository. Such a repository may have a main working
directory, created by either git init or git clone and one or more
linked
On Wed, Jul 23, 2014 at 2:42 PM, Tanay Abhra tanay...@gmail.com wrote:
t4018-diff-funcname.sh fails for the new `git_config()` which uses the
configuration files caching layer internally.
The test introduced in commit d64d6cdc checks that whether `xfuncname` takes
s/that//
precedence over
On Wed, Jul 23, 2014 at 1:03 PM, Ronnie Sahlberg sahlb...@google.com wrote:
Add (back?) support to make it possible to delete refs that are broken.
Add a new flag REF_ALLOWBROKEN that can be passed to the functions to
lock a ref. If this flag is set we allow locking the ref even if the
ref
On Fri, Jul 25, 2014 at 9:44 AM, Matthieu Moy matthieu@imag.fr wrote:
When the user has no ~/.gitconfig file, git config --global --edit used
to launch an editor on an nonexistant file name.
Instead, create a file with a default content before launching the
editor. The template contains
On Fri, Jul 25, 2014 at 6:43 AM, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote:
This function is used to replaced some code in the next patch that
s/replaced/replace/
does this (i.e. keep the errno when read() fails)
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com
---
strbuf.c | 7
On Fri, Jul 25, 2014 at 9:44 AM, Matthieu Moy matthieu@imag.fr wrote:
commit: advertize config --global --edit on guessed identity
s/advertize/advertise/
When the user has no user-wide configuration file, it's faster to use the
newly introduced config file template than to run two
On Fri, Jul 25, 2014 at 6:43 AM, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote:
In the beginning, we had resolve_ref() that returns a buffer owned by
this function. Then we started to move away from that direction because
the buffer could be overwritten by the next resolve_ref() call and
On Fri, Jul 25, 2014 at 12:01 PM, Matthieu Moy
matthieu@grenoble-inp.fr wrote:
Eric Sunshine sunsh...@sunshineco.com writes:
+static char *default_user_config()
+{
+ struct strbuf buf = STRBUF_INIT;
+ strbuf_addf(buf,
+ _(# This is Git's user-wide
On Mon, Jul 28, 2014 at 2:26 PM, René Scharfe l@web.de wrote:
Convert setup_git_directory_gently_1() and its helper functions
setup_explicit_git_dir(), setup_discovered_git_dir() and
setup_bare_git_dir() to use a struct strbuf to hold the current working
directory. Replacing the
On Mon, Jul 28, 2014 at 2:01 PM, Ronnie Sahlberg sahlb...@google.com wrote:
On Fri, Jul 25, 2014 at 12:37 PM, Jonathan Nieder jrnie...@gmail.com wrote:
Ronnie Sahlberg wrote:
/*
* Append a reflog entry for refname. If the REFLOG_TRUNCATE flag is set
* this update will first truncate the
On Monday, July 28, 2014, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote:
Instead of reading the index from disk and worrying about disk
corruption, the index is cached in memory (memory bit-flips happen
too, but hopefully less often). The result is faster read.
The biggest gain is not having
On Mon, Aug 4, 2014 at 11:45 AM, Matthieu Moy
matthieu@grenoble-inp.fr wrote:
Tanay Abhra tanay...@gmail.com writes:
`git_pretty_formats_config()` continues without checking git_config_string's
return value which can lead to a SEGFAULT.
Indeed, without the patch:
$ git -c pretty.my=
On Mon, Aug 4, 2014 at 2:33 PM, Tanay Abhra tanay...@gmail.com wrote:
Use `git_config_get_bool()` family instead of `git_config()` to take
advantage of
the config-set API which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
http-backend.c | 31
On Wed, Aug 6, 2014 at 11:44 AM, Matthieu Moy
matthieu@grenoble-inp.fr wrote:
Tanay Abhra tanay...@gmail.com writes:
On 8/5/2014 12:29 AM, Eric Sunshine wrote:
On Mon, Aug 4, 2014 at 2:33 PM, Tanay Abhra tanay...@gmail.com wrote:
- if (skip_prefix(var, http., p
On Fri, Nov 14, 2014 at 1:29 PM, 0xAX kuleshovm...@gmail.com wrote:
When we execute git config --list and $GIT_CONFIG value starts with home
prefix - ~/ it produces folowing error - fatal: unable to read config
file '~/.gitconfig': No such file or directory. This patch fixed it with
On Sun, Nov 16, 2014 at 2:21 AM, Michael Haggerty mhag...@alum.mit.edu wrote:
Since time immemorial, the test of whether to set core.filemode has
been done by trying to toggle the u+x bit on $GIT_DIR/config and then
testing whether the change took. It is somewhat odd to use the
config file for
On Sun, Nov 23, 2014 at 2:19 PM, Alex Kuleshov kuleshovm...@gmail.com wrote:
Signed-off-by: Alex Kuleshov kuleshovm...@gmail.com
---
exec_cmd.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/exec_cmd.c b/exec_cmd.c
index 698e752..7ed9bcc 100644
--- a/exec_cmd.c
On Mon, Nov 24, 2014 at 6:21 AM, Øystein Walle oys...@gmail.com wrote:
When a commit is amended a pre-commit hook that verifies the commit's
contents might not find what it's looking for if for example it looks at
the differences against HEAD when HEAD~1 might be more appropriate.
Inform the
On Mon, Nov 24, 2014 at 4:07 PM, Richard Littauer
richard.litta...@gmail.com wrote:
I've been confused several times by the docs when running across
the word 'usually'. It is difficult to know before hand if it
means 'under normal conditions' or 'by default'. I've gone through
the
On Mon, Nov 24, 2014 at 4:52 PM, Stefan Beller sbel...@google.com wrote:
No functional changes intended. This commit makes user of higher level
s/user/use/
and better documented functions of the string list API, so the code is
more understandable.
Note that also the required computational
On Tue, Nov 25, 2014 at 9:00 AM, Paolo Bonzini bonz...@gnu.org wrote:
From: Paolo Bonzini pbonz...@redhat.com
The thread at http://thread.gmane.org/gmane.comp.version-control.git/257392
details problems when applying patches with git am in a repository with
CRLF line endings. In the example
On Tue, Nov 25, 2014 at 6:48 AM, Peter Wu pe...@lekensteyn.nl wrote:
git remote set-url knew about the '--push' option to update just the
pushurl, but it does not have a similar option for update fetch URL and
leave whatever was in place for the push URL.
This patch adds support for a
On Tue, Nov 25, 2014 at 5:51 PM, Øystein Walle oys...@gmail.com wrote:
Signed-off-by: Øystein Walle oys...@gmail.com
---
t/t7503-pre-commit-hook.sh | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/t/t7503-pre-commit-hook.sh b/t/t7503-pre-commit-hook.sh
index
On Tue, Nov 25, 2014 at 5:51 PM, Øystein Walle oys...@gmail.com wrote:
The first patch changes t/t7503-pre-commit-hook.sh to use write_script
everywhere, as was suggested by Jeff King in the discussion of the
previous patch.
The second patch is v2 of the patch I sent earlier. I've
On Tue, Nov 25, 2014 at 5:51 PM, Øystein Walle oys...@gmail.com wrote:
When a commit is amended a pre-commit hook that verifies the commit's
contents might not find what it's looking for if it looks at the
differences against HEAD when HEAD~1 might be more appropriate. Inform
the commit hook
On Wed, Nov 26, 2014 at 7:24 PM, Jonathan Nieder jrnie...@gmail.com wrote:
Alexander Kuleshov wrote:
[...]
+++ b/builtin/cat-file.c
@@ -68,9 +69,14 @@ static int cat_one_file(int opt, const char
+buf_must_free = 1;
+
-if (!buf)
+if (!buf) {
+free(buf);
On Thu, Nov 27, 2014 at 1:44 PM, Michael Blume blume.m...@gmail.com wrote:
The variable index seems to be unused/uninitialized now -- it's still
printed in debug messages, but if I'm reading correctly, its contents are
going to be nonsense.
Nice catch.
(Aside: Please don't top-post on this
On Fri, Nov 28, 2014 at 11:57 AM, Ramsay Jones
ram...@ramsay1.demon.co.uk wrote:
Since commit baa37bff (mv: allow renaming to fix case on case
insensitive filesystems, 08-05-2014), the 'git mv' command has
been able to rename a file, to one which differs only in case,
on a case insensitive
On Sunday, November 30, 2014, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote:
This is more user friendly version of ls-files:
* it's automatically colored and columnized
* it refreshes the index like all porcelain commands
* it defaults to non-recursive behavior like ls
* :(glob) is on by
On Tue, Dec 2, 2014 at 12:26 PM, Junio C Hamano gits...@pobox.com wrote:
Aarni Koskela aarni.kosk...@andersinnovations.com writes:
From 9096652a71666920ae8d59dd4317d536ba974d5b Mon Sep 17 00:00:00 2001
From: Aarni Koskela a...@iki.fi
Date: Tue, 2 Dec 2014 13:56:15 +0200
Subject: [PATCH]
On Tue, Dec 2, 2014 at 7:11 AM, Duy Nguyen pclo...@gmail.com wrote:
On Tue, Dec 2, 2014 at 2:32 AM, Junio C Hamano gits...@pobox.com wrote:
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes:
This allows the callback to use 'base' as a temporary buffer to
quickly assemble full path without extra
On Mon, Dec 1, 2014 at 1:04 PM, Junio C Hamano gits...@pobox.com wrote:
Torsten Bögershausen tbo...@web.de writes:
On 12/01/2014 04:02 AM, Michael Blume wrote:
I have no idea whether this should concern anyone, but my mac build of git
shows
CC imap-send.o
imap-send.c:183:36: warning:
On Tue, Dec 2, 2014 at 8:12 PM, Michael Blume blume.m...@gmail.com wrote:
On Tue, Dec 2, 2014 at 4:37 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Mon, Dec 1, 2014 at 1:04 PM, Junio C Hamano gits...@pobox.com wrote:
I am not a Mac person, but is this about APPLE_COMMON_CRYPTO support
On Wed, Dec 3, 2014 at 5:04 AM, David Aguilar dav...@gmail.com wrote:
On Tue, Dec 02, 2014 at 10:09:35PM -0500, Eric Sunshine wrote:
The potentially lesser evil would be this small patch (minus Gmail
whitespace damage) which disables the deprecation warnings only for
Apple's headers:
- 8
On Tue, Dec 2, 2014 at 7:12 AM, Yi EungJun semtlen...@gmail.com wrote:
From: Yi EungJun eungjun...@navercorp.com
Add an Accept-Language header which indicates the user's preferred
languages defined by $LANGUAGE, $LC_ALL, $LC_MESSAGES and $LANG.
Examples:
LANGUAGE= -
LANGUAGE=ko:en -
On Wed, Dec 3, 2014 at 12:10 AM, Jonathan Nieder jrnie...@gmail.com wrote:
When preparing an error message in a strbuf, it can be convenient
to add a formatted string to the beginning:
if (transaction_commit(t, err)) {
strbuf_prefixf(err, cannot fetch '%s': ,
On Sun, Dec 7, 2014 at 3:00 AM, Torsten Bögershausen tbo...@web.de wrote:
On 2014-12-07 06.45, Torsten Bögershausen wrote:
[]
+
+test_expect_success 'add multiple props' '
+git svn propset svn:keywords FreeBSD=%H foo
+git svn propset fbsd:nokeywords yes foo
+echo hello foo
On Sat, Dec 6, 2014 at 5:29 PM, Alfred Perlstein alf...@freebsd.org wrote:
I have incorporated Eric Wong's feedback into the git-svn propset support
patch.
There is a nit that I want to point out. The code does not support adding
props
unless there are also content changes to the files as
On Tue, Dec 9, 2014 at 3:14 PM, Johannes Sixt j...@kdbg.org wrote:
Am 20.11.2014 um 16:17 schrieb Jeff King:
+#define COLOR_FOREGROUND '3'
+#define COLOR_BACKGROUND '4'
This (COLOR_BACKGROUND) causes an ugly redefinition warning on Windows,
because we inherit a definition from a Windows
On Tue, Dec 9, 2014 at 8:53 AM, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote:
Keep track of all recognized macros in the new maybe_macro field.
This this field is true, it _may_ be a macro (depending on what's in
s/This this/If this/
the current attr stack). But if the field is false, it's
On Mon, Dec 8, 2014 at 9:04 AM, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote:
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com
---
diff --git a/Documentation/technical/index-format.txt
b/Documentation/technical/index-format.txt
index fe6f316..b97ac8d 100644
---
On Wed, Dec 10, 2014 at 2:34 AM, Jeff King p...@peff.net wrote:
Below is a another iteration on the patch. The actual code changes are
the same as the strbuf one, but the tests take care to avoid assuming
the filesystem can handle such a long path. Testing on Windows and OS X
is appreciated.
On Wed, Dec 10, 2014 at 3:36 AM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Wed, Dec 10, 2014 at 2:34 AM, Jeff King p...@peff.net wrote:
Below is a another iteration on the patch. The actual code changes are
the same as the strbuf one, but the tests take care to avoid assuming
On Wed, Dec 10, 2014 at 4:42 AM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Wed, Dec 10, 2014 at 3:36 AM, Eric Sunshine sunsh...@sunshineco.com
wrote:
On Wed, Dec 10, 2014 at 2:34 AM, Jeff King p...@peff.net wrote:
Below is a another iteration on the patch. The actual code changes
On Wed, Dec 10, 2014 at 4:47 AM, Jeff King p...@peff.net wrote:
On Wed, Dec 10, 2014 at 03:36:31AM -0500, Eric Sunshine wrote:
On Wed, Dec 10, 2014 at 2:34 AM, Jeff King p...@peff.net wrote:
Below is a another iteration on the patch. The actual code changes are
the same as the strbuf one
On Wed, Dec 10, 2014 at 4:47 AM, Jeff King p...@peff.net wrote:
Subject: pkt-line: allow writing of LARGE_PACKET_MAX buffers
When we send out pkt-lines with refnames, we use a static
1000-byte buffer. This means that the maximum size of a ref
over the git protocol is around 950 bytes (the
On Wed, Dec 10, 2014 at 10:42 AM, Jeff King p...@peff.net wrote:
Signed-off-by: Jeff King p...@peff.net
---
diff --git a/builtin/commit.c b/builtin/commit.c
index d1c90db..2be5506 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -822,8 +821,14 @@ static int prepare_to_commit(const
On Fri, Dec 12, 2014 at 3:50 AM, Christian Hesse m...@eworm.de wrote:
GnuPG 2.1 homedir looks different, so just creat it on the fly by
s/creat/create/
importing needed private and public keys and ownertrust.
This solves an issue with gnupg 2.1 running interactive pinentry when
old secret
On Tue, Dec 16, 2014 at 3:40 AM, Christian Hesse m...@eworm.de wrote:
GnuPG homedir is generated on the fly and keys are imported from
armored key file. Make commet match available key info and new key
s/commet/comment/
generation procedure.
Signed-off-by: Christian Hesse m...@eworm.de
--
On Tue, Dec 16, 2014 at 1:49 PM, Stefan Beller sbel...@google.com wrote:
From: Ronnie Sahlberg sahlb...@google.com
Update receive-pack to use an atomic transaction iff the client negotiated
that it wanted atomic-push. This leaves the default behavior to be the old
non-atomic one ref at a time
On Tue, Dec 16, 2014 at 1:49 PM, Stefan Beller sbel...@google.com wrote:
From: Ronnie Sahlberg sahlb...@google.com
Add a command line argument to the git push command to request atomic
pushes.
Signed-off-by: Ronnie Sahlberg sahlb...@google.com
Signed-off-by: Stefan Beller sbel...@google.com
On Tue, Dec 16, 2014 at 1:49 PM, Stefan Beller sbel...@google.com wrote:
This adds tests for the atomic push option.
The first four tests check if the atomic option works in
good conditions and the last three patches check if the atomic
option prevents any change to be pushed if just one ref
On Tue, Dec 16, 2014 at 2:29 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Tue, Dec 16, 2014 at 1:49 PM, Stefan Beller sbel...@google.com wrote:
---
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index e76e5d5..0803fd2 100644
--- a/builtin/receive-pack.c
+++ b/builtin
noise: they don't tell us
anything useful and we have no control over them, nor is Apple likely to
provide replacements any time soon. Such noise may obscure other
legitimate warnings, therefore silence them.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
Related discussion:
http
On Wed, Dec 17, 2014 at 4:20 AM, Alex Henrie alexhenri...@gmail.com wrote:
Signed-off-by: Alex Henrie alexhenri...@gmail.com
---
builtin/remote.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/remote.c b/builtin/remote.c
index 7f28f92..c55c7ce 100644
---
On Tue, Dec 16, 2014 at 6:19 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
With the release of Mac OS X 10.7 in July 2011, Apple deprecated all
openssl.h functionality due to OpenSSL ABI (application binary
interface) instability, resulting in an explosion of compilation
warnings about
On Thu, Dec 18, 2014 at 12:45 PM, Stefan Beller sbel...@google.com wrote:
From: Ronnie Sahlberg sahlb...@google.com
Update receive-pack to use an atomic transaction iff the client negotiated
that it wanted atomic-push. This leaves the default behavior to be the old
non-atomic one ref at a
On Wed, Dec 17, 2014 at 1:32 PM, Stefan Beller sbel...@google.com wrote:
From: Ronnie Sahlberg sahlb...@google.com
This adds support to send-pack to negotiate and use atomic pushes
iff the server supports it. Atomic pushes are activated by a new command
line flag --atomic.
Signed-off-by:
On Wed, Dec 17, 2014 at 1:32 PM, Stefan Beller sbel...@google.com wrote:
From: Ronnie Sahlberg sahlb...@google.com
Add a command line argument to the git push command to request atomic
pushes.
Signed-off-by: Ronnie Sahlberg sahlb...@google.com
Signed-off-by: Stefan Beller sbel...@google.com
On Thu, Dec 18, 2014 at 7:22 PM, Stefan Beller sbel...@google.com wrote:
From: Ronnie Sahlberg sahlb...@google.com
Update receive-pack to use an atomic transaction iff the client negotiated
that it wanted atomic-push. This leaves the default behavior to be the old
non-atomic one ref at a time
On Sun, Dec 21, 2014 at 1:53 PM, Reuben Hawkins reuben...@gmail.com wrote:
This check will automatically set the correct NO_NSEC setting.
Missing sign-off. See git/Documentation/SubmittingPatches.
---
diff --git a/configure.ac b/configure.ac
index 6af9647..3cfdd51 100644
--- a/configure.ac
On Sun, Dec 21, 2014 at 1:53 PM, Reuben Hawkins reuben...@gmail.com wrote:
CLOCK_MONOTONIC isn't available on RHEL3, but there are still RHEL3
systems being used in production. This change makes compiling git
less tedious on older platforms.
Missing sign-off.
---
diff --git a/configure.ac
On Sun, Dec 21, 2014 at 1:53 PM, Reuben Hawkins reuben...@gmail.com wrote:
Older versions of OpenSSL have HMAC_cleanup, but not HMAC_CTX_cleanup.
This change checks for both, uses HMAC_CTX_cleanup on platforms which
have it, otherwise falls back to HMAC_cleanup.
On this project, imperative
On Sun, Dec 21, 2014 at 3:20 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Sun, Dec 21, 2014 at 1:53 PM, Reuben Hawkins reuben...@gmail.com wrote:
+AC_CHECK_MEMBER([struct stat.st_mtim.tv_nsec],
+[HAVE_ST_MTIM=Yes],
+[HAVE_ST_MTIM=No],
In Autoconf, it's customary to use lowercase
On Fri, Dec 19, 2014 at 2:38 PM, Stefan Beller sbel...@google.com wrote:
From: Ronnie Sahlberg sahlb...@google.com
This adds support to the protocol between send-pack and receive-pack to
* allow receive-pack to inform the client that it has atomic push capability
* allow send-pack to request
On Fri, Dec 19, 2014 at 2:38 PM, Stefan Beller sbel...@google.com wrote:
From: Ronnie Sahlberg sahlb...@google.com
This adds support to send-pack to negotiate and use atomic pushes
iff the server supports it. Atomic pushes are activated by a new command
line flag --atomic.
Signed-off-by:
.
Inspired-by: Ronnie Sahlberg sahlb...@google.com
Helped-by: Eric Sunshine sunsh...@sunshineco.com
Signed-off-by: Stefan Beller sbel...@google.com
---
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index e76e5d5..710cd7f 100644
--- a/builtin/receive-pack.c
+++ b/builtin
On Tue, Dec 23, 2014 at 11:36 AM, Russ Cox r...@golang.org wrote:
I am using git checkout-index --temp to obtain copies of files from
the index, but it does not always print valid file names unless run
from the repository root.
git checkout-index --temp prints names of files in the index
In particular:
* indent test body
* place test description on same line as test_expect_*
* place closing quote on its own line
* name output file actual rather than out
* name setup test setup rather than preparation
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
t/t2004-checkout
This patch series fixes a path mangling bug in checkout-index --temp
reported by Russ Cox[1]. As a bonus, it also squashes a bug in which
checkout-index was accessing and printing memory beyond end-of-string.
[1]: http://thread.gmane.org/gmane.comp.version-control.git/261739
Eric Sunshine (5
longer than the directory name in
which checkout-index is invoked.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
t/t2004-checkout-cache-temp.sh | 12
1 file changed, 12 insertions(+)
diff --git a/t/t2004-checkout-cache-temp.sh b/t/t2004-checkout-cache-temp.sh
index 602fbc7
in file\0rectory/../file. When checkout-index skipped
strlen(subdirectory/) bytes, it ended up back at ../file and thus
appeared to give the correct answer, despite being past end-of-string.
Reported-by: Russ Cox r...@golang.org
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
builtin
Update symlink test to use the common file naming scheme so that its
temporary files can be cleaned up by the rm -f path* idiom employed by
other tests in this script.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
t/t2004-checkout-cache-temp.sh | 6 +++---
1 file changed, 3 insertions
Unlike earlier tests which reference several trees prepared by setup,
no other tests utilize the tree from the symlink test, so there is no
need to write it (or read it back immediately).
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
t/t2004-checkout-cache-temp.sh | 3 ---
1 file
On Mon, Dec 22, 2014 at 11:44 AM, Yi EungJun semtlen...@gmail.com wrote:
From: Yi EungJun eungjun...@navercorp.com
Add an Accept-Language header which indicates the user's preferred
languages defined by $LANGUAGE, $LC_ALL, $LC_MESSAGES and $LANG.
Examples:
LANGUAGE= -
LANGUAGE=ko:en -
, no need to go through the whole attr stack in macroexpand_one()
to search for one.
Without this, git grep abcdefghi on git.git hits the inner loop in
macroexpand_one() 2481 times. With this, it's 66 times.
Helped-by: Eric Sunshine sunsh...@sunshineco.com
My only contribution was pointing out
On Fri, Dec 26, 2014 at 6:11 PM, Doug Kelly dougk@gmail.com wrote:
git am will break when using diff.submodule=log; add some test cases
to illustrate this breakage as simply as possible. There are
currently two ways this can fail:
* With errors (unrecognized input), if only change
*
On Sat, Dec 27, 2014 at 07:04:23PM -0600, Doug Kelly wrote:
git am will break when using diff.submodule=log; add some test cases
to illustrate this breakage as simply as possible. There are
currently two ways this can fail:
* With errors (unrecognized input), if only change
* Silently (no
On Wed, Dec 24, 2014 at 4:43 AM, Eric Sunshine sunsh...@sunshineco.com wrote:
checkout-index --temp only properly prints relative paths which are
descendants of the current directory. Paths in ancestor or sibling
directories (or their children) are often printed in mangled form. For
example
On Sat, Dec 27, 2014 at 6:09 AM, Alexander Kuleshov
kuleshovm...@gmail.com wrote:
Signed-off-by: Alexander Kuleshov kuleshovm...@gmail.com
This patch has two distinct goals. First, it's adding \n to 'die'
messages to suppress the file+line# information which Perl appends
automatically to 'die'
On Mon, Dec 29, 2014 at 12:42 PM, Stefan Beller sbel...@google.com wrote:
This adds more explanation of why you want to have the --notes option
given to git format-patch.
Signed-off-by: Stefan Beller sbel...@google.com
---
diff --git a/Documentation/SubmittingPatches
be conveying to the reader.
The claimed simplification is questionable and not of particular
importance; and it's misleading to paint it as a goal of the patch.
Consequently, you could drop mention of it altogether.
More below.
Suggested-by: Eric Sunshine sunsh...@sunshineco.com
Signed-off-by: Stefan
On Mon, Dec 29, 2014 at 9:36 PM, Stefan Beller sbel...@google.com wrote:
Subject: receive-pack.c: add documentation for atomic push support
This patch is doing a lot more than merely adding documentation. It's
also updating send-pack and receive-pack to be able to negotiate the
new protocol
On Mon, Dec 29, 2014 at 9:36 PM, Stefan Beller sbel...@google.com wrote:
No functional changes intended.
This commit shortens execute_commands by moving some parts of the code
to extra functions.
Suggested-by: Eric Sunshine sunsh...@sunshineco.com
Signed-off-by: Stefan Beller sbel
-level role, execute_commands() does not need to know or care
about the low-level details of each mode of operation. Therefore, as
preparation for introducing a new mode, you're factoring out the
existing mode into its own stand-alone function.
Helped-by: Eric Sunshine sunsh...@sunshineco.com
Signed
...@google.com
Helped-by: Eric Sunshine sunsh...@sunshineco.com
Signed-off-by: Stefan Beller sbel...@google.com
---
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index 5f44466..35a2264 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -1076,8 +1076,8 @@ static void
On Tue, Dec 30, 2014 at 3:42 AM, Stefan Beller sbel...@google.com wrote:
On Mon, Dec 29, 2014 at 11:46 PM, Eric Sunshine sunsh...@sunshineco.com
wrote:
On Mon, Dec 29, 2014 at 9:36 PM, Stefan Beller sbel...@google.com wrote:
No functional changes intended.
+static void check_shallow_bugs
On Tue, Dec 30, 2014 at 3:33 AM, Stefan Beller sbel...@google.com wrote:
On Mon, Dec 29, 2014 at 11:08 PM, Eric Sunshine sunsh...@sunshineco.com
wrote:
On Mon, Dec 29, 2014 at 9:36 PM, Stefan Beller sbel...@google.com wrote:
Subject: receive-pack.c: add documentation for atomic push support
On Tue, Dec 30, 2014 at 1:45 PM, Stefan Beller sbel...@google.com wrote:
On Tue, Dec 30, 2014 at 12:36 AM, Eric Sunshine sunsh...@sunshineco.com
wrote:
On Mon, Dec 29, 2014 at 9:36 PM, Stefan Beller sbel...@google.com wrote:
No functional changes intended.
Secondary information can
On Tue, Dec 30, 2014 at 5:21 PM, Josh Bleecher Snyder
joshar...@gmail.com wrote:
In the section on using --temp, 'git help checkout-index' says:
The path field is always relative to the current directory and the
temporary file names are always relative to the top level directory.
However,
On Mon, Dec 29, 2014 at 06:48:48PM -0800, Stefan Beller wrote:
On Mon, Dec 29, 2014 at 6:47 PM, Stefan Beller sbel...@google.com wrote:
From: Eric Sunshine sunsh...@sunshineco.com
As I just copied the whole text of Eric, I think
it would be better if Eric is credited for this commit
On Fri, Jan 2, 2015 at 10:44 AM, Raphael Kubo da Costa
raphael.kubo.da.co...@intel.com wrote:
The code handling %(upstream:track) and %(upstream:trackshort) assumed
it always had a valid branch that had been sanitized earlier in
populate_value(), and thus did not check the return value of the
801 - 900 of 3596 matches
Mail list logo
