On Thu, Dec 6, 2018 at 6:30 PM Lukáš Krejčí wrote:
>
> I am talking about `git bisect replay`. The shell script, as far as I
> can see, only updates the references (ref/bisect/*) and never checks if
> the revisions marked as 'good' are ancestors of the 'bad' one.
> Therefore,
Hi,
On Thu, Dec 6, 2018 at 3:43 PM Lukáš Krejčí wrote:
>
> Hello again,
>
> after looking into this today, I'm not sure if this can be considered a
> bug - it's just that I expected Git to check out the exact commit to
> test that was there before resetting the bisect. That made me uncertain
>
On Tue, Dec 4, 2018 at 12:20 PM Lukáš Krejčí wrote:
>
> On Tue, 2018-12-04 at 12:04 +0100, Christian Couder wrote:
> >
> > Could you try to check that? And first could you give us the output of:
> >
> > git merge-base 5b394b2ddf
On Tue, Dec 4, 2018 at 10:53 AM Lukáš Krejčí wrote:
>
> Executing git bisect replay reaches a different commit than
> the one that is obtained by running the commands from the bisect log manually.
> $ git bisect replay /var/tmp/git-bisect.log
> We are not bisecting.
> Bisecting: a merge base
Hi everyone,
The 45th edition of Git Rev News is now published:
https://git.github.io/rev_news/2018/11/21/edition-45/
Thanks a lot to the contributors: Elijah Newren, Luca Milanesio,
Derrick Stolee and Johannes Schindelin!
Enjoy,
Christian, Jakub, Markus and Gabriel.
Hi,
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-45.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this GitHub
On Sat, Nov 17, 2018 at 10:29 AM Junio C Hamano wrote:
>
> Christian Couder writes:
>
> > However, as noted in those commits we'd still create the file as 0600,
> > and would just re-chmod it depending on the setting of
> > core.sharedRepository. So without core.split
On Fri, Nov 16, 2018 at 8:20 PM Duy Nguyen wrote:
>
> On Fri, Nov 16, 2018 at 8:07 PM SZEDER Gábor wrote:
>
> > With the default 20% threshold a new shared index is written rather
> > frequently with our usual small test-repos:
>
> Side note. Split index is definitely not meant for small repos.
On Fri, Nov 16, 2018 at 7:29 PM SZEDER Gábor wrote:
>
> On Fri, Nov 16, 2018 at 06:31:05PM +0100, Christian Couder wrote:
> > diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh
> > index 2ac47aa0e4..fa1d3d468b 100755
> > --- a/t/t1700-split-index.sh
> >
On Fri, Nov 16, 2018 at 7:03 PM Duy Nguyen wrote:
>
> On Fri, Nov 16, 2018 at 6:31 PM Christian Couder
> wrote:
> > diff --git a/read-cache.c b/read-cache.c
> > index 8c924506dd..ea80600bff 100644
> > --- a/read-cache.c
> > +++ b/read-cache.c
> > @@ -3
On Tue, Nov 13, 2018 at 6:34 PM Ævar Arnfjörð Bjarmason
wrote:
>
> On Tue, Nov 13 2018, Duy Nguyen wrote:
>
> > On Tue, Nov 13, 2018 at 4:32 PM Ævar Arnfjörð Bjarmason
> > wrote:
> > I don't have any bright idea how to catch the literal _X file.
> > It's a temporary file and will not last
elated cleanup. We
already have that minor issue with the "index" file #leftoverbits.
Signed-off-by: Ævar Arnfjörð Bjarmason
Signed-off-by: Christian Couder
---
This is a simpler fix iterating from Ævar's RFC patch and the
following discussions:
https://public-inbox.org/git/201811131
On Thu, Nov 1, 2018 at 3:42 PM Nicolas Mailhot
wrote:
>
> Le jeudi 01 novembre 2018 à 15:13 +0100, Christian Couder a écrit :
> >
> > How can Git know when you commit where you will want to push the
> > commit afterwards?
>
> You have an url in the repo config. of co
On Thu, Nov 1, 2018 at 2:31 PM Slavica Djukic
wrote:
>
> Add test to assert that stash fails if user.name and user.email
Nit: I am not sure that "assert" is the right word here.
test_expect_failure() is more for documenting an existing bug than for
really asserting a behavior (that users could
On Thu, Nov 1, 2018 at 2:31 PM Nicolas Mailhot
wrote:
>
> Le jeudi 01 novembre 2018 à 12:22 +0100, Ævar Arnfjörð Bjarmason a
> écrit :
> >
> > Where would we get an E-Mail to lookup to pass to the helper? Are you
> > just asking that the helper git the result of $(git config user.name
> > &&
> >
Hi Jonathan,
On Tue, Oct 16, 2018 at 7:43 PM Jonathan Nieder wrote:
>
> Hi Christian,
>
> On Tue, Sep 25, 2018, Christian Couder wrote:
>
> > In the cover letter there is a "Discussion" section which is about
> > this, but I agree that it might not
On Thu, Oct 25, 2018 at 4:42 AM brian m. carlson
wrote:
> +static void blk_SHA256_Transform(blk_SHA256_CTX *ctx, const unsigned char
> *buf)
> +{
> +
> + uint32_t S[8], W[64], t0, t1;
> + int i;
> +
> + /* copy state into S */
> + for (i = 0; i < 8; i++) {
> +
Hi everyone,
The 44th edition of Git Rev News is now published:
https://git.github.io/rev_news/2018/10/24/edition-44/
Enjoy,
Christian, Jakub, Markus and Gabriel.
On Tue, Oct 23, 2018 at 6:35 PM Slavica wrote:
>
> This is part of enhancement request that ask for `git stash` to work even if
> `user.name` is not configured.
> The issue is discussed here:
> https://public-inbox.org/git/87o9debty4@evledraar.gmail.com/T/#u.
We prefer commit messages that
Hi,
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-44.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this GitHub
Hi,
On Thu, Oct 18, 2018 at 2:51 PM Πλάτων Κιορπελίδης
wrote:
>
> Hello,
>
> I’m a computer science student and I’m interested in contributing to git.
> I’ve read the GSoC git page with the ideas and micro-projects as I’m
> interested in participating next summer.
> I’ve also read the
On Mon, Oct 15, 2018 at 8:33 PM Johannes Schindelin
wrote:
>
> Hi team,
>
> On Mon, 15 Oct 2018, Christian Couder wrote:
>
> > On Mon, Oct 15, 2018 at 5:46 PM Duy Nguyen wrote:
> > >
> > > On Mon, Oct 15, 2018 at 5:08 PM Ævar Arnfjörð Bjarmason
> > &g
On Mon, Oct 15, 2018 at 5:46 PM Duy Nguyen wrote:
>
> On Mon, Oct 15, 2018 at 5:08 PM Ævar Arnfjörð Bjarmason
> wrote:
> > As an aside I poked Junio via private mail in late August to see if he'd
> > be interested in pushing to gitlab.com/git/git.git too as part of his
> > normal push-outs.
On Wed, Oct 10, 2018 at 10:46 AM Junio C Hamano wrote:
>
> Johannes Schindelin writes:
>
> > Personally, I find the "whoever is picking it up should do the thinking"
> > much too harsh for a first-time contributor who specifically came through
> > the Outreachy program, i.e. expected to have a
(removing git-security from CC)
On Wed, Oct 3, 2018 at 4:09 PM Dimitri Kopriwa wrote:
> Git credentials in ~/.git-credentials and ~/.config/git/credentials are
> being removed by git upon reading.
https://git-scm.com/docs/git-credential says:
"If the action is reject, git-credential will send
Hi Giovana,
On Mon, Oct 1, 2018 at 4:04 PM Giovana Morais wrote:
>
> Hey there, Christian and Git!
>
> My initial Outreachy application got accepted and, looking through available
> projects, I was really interested in `git bisect` one, since I want to take
> my C skills to a next level and,
Hi Ananya,
On Sun, Sep 30, 2018 at 5:53 PM Ananya Krishna Maram
wrote:
>
> Hi Git Community, Christian and Johannes,
>
> My initial Outreachy got accepted.
Great! Welcome to the Git community!
[...]
> Having done a lot of assignment in C and
> bash scripting and keen interest to learn about
On Fri, Sep 28, 2018 at 12:35 PM SZEDER Gábor wrote:
>
> On Tue, Sep 25, 2018 at 01:53:40PM +0200, Christian Couder wrote:
> > + IDX=$(cat promisorlist | sed "s/promisor$/idx/") &&
>
> You could drop the unnecessary 'cat', 'sed' is capable to open a file
From: Christian Couder
Signed-off-by: Junio C Hamano
---
Documentation/config.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index ad0f4510c3..9df988adb9 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
Instead of using the repository_format_partial_clone global
and fetch_objects() directly, let's use has_remote_odb() and
remote_odb_get_direct().
Signed-off-by: Christian Couder
Signed-off-by: Junio C Hamano
---
builtin/cat-file.c| 5 +++--
builtin/fetch.c | 11
From: Christian Couder
Signed-off-by: Christian Couder
Signed-off-by: Junio C Hamano
---
t/t0410-partial-clone.sh | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh
index 8b32be6417..3fbd8d919e
From: Christian Couder
Let's make the partial clone filter specific to one odb
instead of general to all the odbs.
This makes it possible to have different partial clone
filters for different odbs.
Signed-off-by: Christian Couder
Signed-off-by: Junio C Hamano
---
builtin/fetch.c
From: Christian Couder
The remote-odb.{c,h} files will contain the functions
that are called by the rest of Git mostly from
"sha1-file.c" to access the objects managed by the
remote odbs.
The odb-helper.{c,h} files will contain the functions to
actually implement communication w
From: Christian Couder
This is implemented only in the promisor remote mode
for now by calling fetch_objects().
Signed-off-by: Christian Couder
Signed-off-by: Junio C Hamano
---
odb-helper.c | 15 +++
odb-helper.h | 3 +++
remote-odb.c | 17 +
remote-odb.h | 1
B support" series:
https://public-inbox.org/git/20180103163403.11303-1-chrisc...@tuxfamily.org/
https://public-inbox.org/git/20180319133147.15413-1-chrisc...@tuxfamily.org/
Version 1 and 2 of the "Promisor remotes and external ODB support" series on
GitHub:
https://github.com/chriscool/
From: Christian Couder
The callers of the fetch_object() and fetch_objects() might
be interested in knowing if these functions succeeded or not.
Signed-off-by: Christian Couder
Signed-off-by: Junio C Hamano
---
fetch-object.c | 13 -
fetch-object.h | 4 ++--
sha1-file.c| 4
From: Christian Couder
We will need to reinitialize the remote odb configuration
as we will make some changes to it in a later commit when
we will detect that a remote is also a remote odb.
Signed-off-by: Christian Couder
Signed-off-by: Junio C Hamano
---
remote-odb.c | 14
On Fri, Aug 3, 2018 at 12:55 AM, Stefan Beller wrote:
> On Wed, Aug 1, 2018 at 11:16 PM Christian Couder
> wrote:
>>
>> From: Christian Couder
>>
>> Signed-off-by: Junio C Hamano
>> ---
>> Documentation/config.txt | 5 +
>> 1 file changed,
Hi everyone,
The 43rd edition of Git Rev News is now published:
https://git.github.io/rev_news/2018/09/19/edition-43/
Thanks a lot to the contributors: Johannes Schindelin and Luca Milanesio.!
Enjoy,
Christian, Jakub, Markus and Gabriel.
On Mon, Sep 17, 2018 at 5:21 AM, Jeff King wrote:
> On Sun, Sep 16, 2018 at 03:15:20AM -0700, David Aguilar wrote:
>> The "Git Cola" project[1][2] provides two fully-featured Git porcelains,
>> "git-cola" and "git-dag". The DAG tool is never referred to as a
>> separate project, so shouldn't be
Hi,
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-43.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this GitHub
On Tue, Sep 11, 2018 at 1:19 PM, Derrick Stolee wrote:
> On 9/11/2018 1:22 AM, Christian Couder wrote:
>> It would be nice if the "Future Work" section of
>> Documentation/technical/commit-graph.txt had something about
>> integration with 'git gc'.
>
> I'
On Wed, Jun 27, 2018 at 3:24 PM, Derrick Stolee wrote:
> When writing commit-graph files, it can be convenient to ask for all
> reachable commits (starting at the ref set) in the resulting file. This
> is particularly helpful when writing to stdin is complicated, such as a
> future integration
On Thu, Sep 6, 2018 at 9:34 PM, Jeff King wrote:
>
> By the way, I've got funding from GitHub lined up, so we are good on
> that front.
Great, thanks!
On Thu, Sep 6, 2018 at 9:31 PM, Jeff King wrote:
> On Thu, Sep 06, 2018 at 11:51:49AM +0200, Christian Couder wrote:
>
>> Yeah, I think the https://git.github.io/Outreachy-17/ is not actually
>> necessary.
>
> I think it still may be helpful for explaining in furt
On Thu, Sep 6, 2018 at 3:14 AM, Jeff King wrote:
> On Wed, Sep 05, 2018 at 09:20:23AM +0200, Christian Couder wrote:
>
>> >> Thanks. I think sooner is better for this (for you or anybody else who's
>> >> interested in mentoring). The application period opens on Sep
On Thu, Sep 6, 2018 at 3:21 AM, Jeff King wrote:
> On Mon, Sep 03, 2018 at 06:36:19AM +0200, Christian Couder wrote:
>
>> So here is a landing page for the next Outreachy round:
>>
>> https://git.github.io/Outreachy-17/
>>
>> about the microprojects I am
On Mon, Sep 3, 2018 at 6:36 AM, Christian Couder
wrote:
> On Sat, Sep 1, 2018 at 10:43 AM, Jeff King wrote:
>> On Fri, Aug 31, 2018 at 10:16:49AM +0200, Christian Couder wrote:
>>
>>> > 2. To get our landing page and list of projects in order (and also
>>>
On Mon, Sep 3, 2018 at 7:31 PM, Duy Nguyen wrote:
> On Sun, Sep 2, 2018 at 9:57 AM Christian Couder
> wrote:
>>
>> Thanks for going the extra mile and doing this!
>>
>> I wonder if we should also try to make the show_list() function part
>> of the trace_*() fu
On Sat, Sep 1, 2018 at 10:43 AM, Jeff King wrote:
> On Fri, Aug 31, 2018 at 10:16:49AM +0200, Christian Couder wrote:
>
>> > 2. To get our landing page and list of projects in order (and also
>> > micro-projects for applicants). This can probably build on the
Hi Wesley,
On Sun, Sep 2, 2018 at 11:38 PM, Wesley Schwengle wrote:
> Hi all,
>
> I've made some progress with the hook.d implementation. It isn't
> finished, as it is my first C project I'm still somewhat rocky with
> how pointers and such work, but I'm getting somewhere. I haven't
> broken any
On Sun, Sep 2, 2018 at 9:42 AM, Nguyễn Thái Ngọc Duy wrote:
> In order to stop this from happening again, the function is now
> compiled unconditionally but exits early unless DEBUG_BISECT is
> non-zero.
Thanks for going the extra mile and doing this!
I wonder if we should also try to make the
On Sat, Sep 1, 2018 at 10:43 AM, Jeff King wrote:
> On Fri, Aug 31, 2018 at 10:16:49AM +0200, Christian Couder wrote:
>> I can also look at getting outside funds.
>>
>> My opinion though is that it is probably better if the Git project can
>> use its own fund for
Hi Olga,
On Fri, Aug 31, 2018 at 12:30 PM, Оля Тележная wrote:
> Hi everyone,
>
> I was Outreachy intern last winter. I guess I need to speak up: I will
> be happy if my feedback helps you.
> At first, I want to repeat all thanks to Outreachy organizers and Git
> mentors. That was unique
On Thu, Aug 30, 2018 at 7:22 PM, Stefan Beller wrote:
>
> AFAICT this is more than just a coloring scheme as it both produces
> a different low level diff, which would need code in the xdiff parts
> as well as colors, that is in diff.c.
About the low level diff, Michael Haggerty's tools for
On Thu, Aug 30, 2018 at 9:24 PM, Jeff King wrote:
> On Thu, Aug 30, 2018 at 01:46:00PM +0200, Johannes Schindelin wrote:
>
>> I am willing to mentor, and the only reason that kept me from already
>> stepping forward and trying to brush up the landing page is this concern:
>> traditionally, we (as
Hi,
On Tue, Aug 28, 2018 at 5:14 PM, Jeff King wrote:
> The Outreachy application period is set to begin on September 10th for
> interns participating in the December-March program. Do we want to
> participate?
>
> Details on the program are here:
>
> https://www.outreachy.org/communities/cfp/
Hi everyone,
The 42nd edition of Git Rev News is now published:
https://git.github.io/rev_news/2018/08/22/edition-42/
Thanks a lot to the contributors: Derrick Stolee and Ævar Arnfjörð Bjarmason!
Enjoy,
Christian, Jakub, Markus and Gabriel.
On Fri, Aug 17, 2018 at 12:41 AM, Jeff King wrote:
> So here are the nominations I came up with. If you'd like to nominate
> somebody else (or yourself!), please do. If you have opinions, let me
> know (public or private, as you prefer).
>
> - Christian Couder
> - Ævar
On Mon, Aug 20, 2018 at 10:51 AM, Ævar Arnfjörð Bjarmason
wrote:
> On Mon, Aug 20 2018, Christian Couder wrote:
>> Jakub, Markus, Gabriel and me plan to publish this edition on
>> Wednesday August 22nd.
>
> Let's mention that we've picked SHA-256 as NewHash, as a follow
Hi,
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-42.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this GitHub
On Sat, Aug 18, 2018 at 1:34 PM Ævar Arnfjörð Bjarmason
wrote:
> On Sat, Aug 18 2018, Christian Couder wrote:
> > FYI this has been requested from GitLab by Drupal (as well as others)
> > see
> > https://www.drupal.org/drupalorg/blog/developer-tools-initiative-part
On Sat, Aug 18, 2018 at 12:44 AM Junio C Hamano wrote:
> * cc/delta-islands (2018-08-16) 7 commits
> - pack-objects: move 'layer' into 'struct packing_data'
> - pack-objects: move tree_depth into 'struct packing_data'
> - t5320: tests for delta islands
> - repack: add delta-islands support
>
Sorry, I made a copy paste error in the subject there should not be
"[PATCH v4 0/7]" in it.
On Thu, Aug 16, 2018 at 8:13 AM, Christian Couder
wrote:
> This patch series is upstreaming work made by GitHub and available in:
[...]
en
Signed-off-by: Christian Couder
---
builtin/pack-objects.c | 4 ++--
delta-islands.c| 27 ++-
pack-objects.c | 6 ++
pack-objects.h | 21 -
4 files changed, 46 insertions(+), 12 deletions(-)
diff --git a/builtin/pack-o
From: Jeff King
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
t/t5319-delta-islands.sh | 143 +++
1 file changed, 143 insertions(+)
create mode 100755 t/t5319-delta-islands.sh
diff --git a/t/t5319-delta-islands.sh b/t/t5319-delta-islands.sh
intensive.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
Documentation/config.txt | 4
Documentation/git-repack.txt | 5 +
builtin/repack.c | 9 +
3 files changed, 18 insertions(+)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index
.
This will make it easier to see and understand what the
following changes are doing.
Helped-by: Duy Nguyen
Signed-off-by: Christian Couder
---
builtin/pack-objects.c | 90 +++---
1 file changed, 50 insertions(+), 40 deletions(-)
diff --git a/builtin/pack-objects.c b
le cloning and fetching
is still quite fast and not much more CPU intensive.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
Documentation/config.txt | 15 +
Documentation/git-pack-objects.txt | 97 ++
builtin/pack-objects.c
Signed-off-by: Christian Couder
---
builtin/pack-objects.c | 4 ++--
delta-islands.c| 4 ++--
pack-objects.c | 6 ++
pack-objects.h | 20 ++--
4 files changed, 28 insertions(+), 6 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack
e use of it.
A few new fields are added in 'struct object_entry'
in "pack-objects.h" though.
The documentation will follow in a patch that actually
uses delta islands in "builtin/pack-objects.c".
Signed-off-by: Jeff King
Signed-off-by: Christian
-1-chrisc...@tuxfamily.org/
V3: https://public-inbox.org/git/20180809155532.26151-1-chrisc...@tuxfamily.org/
V2: https://public-inbox.org/git/20180805172525.15278-1-chrisc...@tuxfamily.org/
V1: https://public-inbox.org/git/20180722054836.28935-1-chrisc...@tuxfamily.org/
Christian Couder (3):
On Mon, Aug 13, 2018 at 9:00 PM, Jeff King wrote:
> On Mon, Aug 13, 2018 at 05:33:59AM +0200, Christian Couder wrote:
>
>> >> + memcpy(_core, oid->hash, sizeof(uint64_t));
>> >> + rl->hash += sha_core;
>> >
>> > Hmm, so
On Mon, Aug 13, 2018 at 8:11 PM, Jeff King wrote:
> On Mon, Aug 13, 2018 at 01:17:18PM +0100, Ramsay Jones wrote:
>
>> >>> +struct island_bitmap {
>> >>> + uint32_t refcount;
>> >>> + uint32_t bits[];
>> >>
>> >> Use FLEX_ARRAY here? We are slowly moving toward requiring
>> >> certain C99
On Tue, Aug 14, 2018 at 11:47 PM, Jeff King wrote:
> On Tue, Aug 14, 2018 at 05:06:16PM -0400, Jeff King wrote:
>
>> On Tue, Aug 14, 2018 at 10:09:37PM +0200, Christian Couder wrote:
>>
>> > When cloning with --mirror, the clone gets its HEAD initialized with
>> &
Hi,
When cloning with --mirror, the clone gets its HEAD initialized with
the value HEAD has in its origin remote. After that if HEAD changes in
origin there is no simple way to sync HEAD at the same time as the
refs are synced.
It looks like the simplest way to sync HEAD is:
1) git remote show
On Mon, Aug 13, 2018 at 7:46 PM, Stefan Beller wrote:
> On Mon, Aug 13, 2018 at 9:31 AM Jeff King wrote:
>>
>> For the past several years, we've held a Git Contributor Summit as part
>> of the Git Merge conference. I'd like to get opinions from the community
>> to help plan future installments.
On Mon, Aug 13, 2018 at 3:14 AM, Ramsay Jones
wrote:
> On 12/08/18 06:11, Christian Couder wrote:
>> Because the inefficiency primarily arises when an
>> object is delitified against another object that does
>
> s/delitified/deltified/ ?
Ok, this will be in the next reroll
le cloning and fetching
is still quite fast and not much more CPU intensive.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
Documentation/config.txt | 15 +
Documentation/git-pack-objects.txt | 97 ++
builtin/pack-objects.c
e use of it.
A few new fields are added in 'struct object_entry'
in "pack-objects.h" though.
The documentation will follow in a patch that actually
uses delta islands in "builtin/pack-objects.c".
Signed-off-by: Jeff King
Signed-off-by: Christian
en
Signed-off-by: Christian Couder
---
builtin/pack-objects.c | 4 ++--
delta-islands.c| 27 ++-
pack-objects.c | 6 ++
pack-objects.h | 21 -
4 files changed, 46 insertions(+), 12 deletions(-)
diff --git a/builtin/pack-o
Signed-off-by: Christian Couder
---
builtin/pack-objects.c | 4 ++--
delta-islands.c| 4 ++--
pack-objects.c | 6 ++
pack-objects.h | 20 ++--
4 files changed, 28 insertions(+), 6 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack
From: Jeff King
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
t/t5319-delta-islands.sh | 143 +++
1 file changed, 143 insertions(+)
create mode 100755 t/t5319-delta-islands.sh
diff --git a/t/t5319-delta-islands.sh b/t/t5319-delta-islands.sh
intensive.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
Documentation/config.txt | 4
Documentation/git-repack.txt | 5 +
builtin/repack.c | 9 +
3 files changed, 18 insertions(+)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index
55532.26151-1-chrisc...@tuxfamily.org/
V2: https://public-inbox.org/git/20180805172525.15278-1-chrisc...@tuxfamily.org/
V1: https://public-inbox.org/git/20180722054836.28935-1-chrisc...@tuxfamily.org/
Christian Couder (3):
pack-objects: refactor code into compute_layer_order()
pack-objects: move tre
.
This will make it easier to see and understand what the
following changes are doing.
Helped-by: Duy Nguyen
Signed-off-by: Christian Couder
---
builtin/pack-objects.c | 90 +++---
1 file changed, 50 insertions(+), 40 deletions(-)
diff --git a/builtin/pack-objects.c b
On Sat, Aug 11, 2018 at 4:12 PM, Jeff King wrote:
> On Sat, Aug 11, 2018 at 12:32:32PM +0200, Christian Couder wrote:
>
>> Ok, I have made the following changes in the branch I will send next.
>>
>> diff --git a/delta-islands.c b/delta-islands.c
>> index
Hi Ramsay and Peff,
On Sun, Aug 12, 2018 at 3:16 AM, Jeff King wrote:
> On Sun, Aug 12, 2018 at 01:30:02AM +0100, Ramsay Jones wrote:
>
>> My static-check.pl script has pinged me about the get_delta_base()
>> symbol from packfile.[co]. The first patch from your 'cc/delta-islands'
>> branch
On Sat, Aug 11, 2018 at 11:04 AM, SZEDER Gábor wrote:
>> diff --git a/delta-islands.c b/delta-islands.c
>> new file mode 100644
>> index 00..448ddcbbe4
>> --- /dev/null
>> +++ b/delta-islands.c
>
>> +static void deduplicate_islands(void)
>> +{
>> + struct remote_island *island, *core
On Thu, Aug 9, 2018 at 5:55 PM, Christian Couder
wrote:
> The following changes have been made since the previous iteration:
>
> * suggested by Duy: move the code computing the write order for a
> layer to a new separate function called compute_layer_order() in
> builtin
e use of it.
A few new fields are added in 'struct object_entry'
in "pack-objects.h" though.
The documentation will follow in a patch that actually
uses delta islands in "builtin/pack-objects.c".
Signed-off-by: Jeff King
Signed-off-by: Christian
From: Jeff King
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
t/t5319-delta-islands.sh | 143 +++
1 file changed, 143 insertions(+)
create mode 100755 t/t5319-delta-islands.sh
diff --git a/t/t5319-delta-islands.sh b/t/t5319-delta-islands.sh
intensive.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
Documentation/config.txt | 4
Documentation/git-repack.txt | 5 +
builtin/repack.c | 9 +
3 files changed, 18 insertions(+)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index
en
Signed-off-by: Christian Couder
---
builtin/pack-objects.c | 4 ++--
delta-islands.c| 27 ++-
pack-objects.c | 6 ++
pack-objects.h | 21 -
4 files changed, 46 insertions(+), 12 deletions(-)
diff --git a/builtin/pack-o
Signed-off-by: Christian Couder
---
builtin/pack-objects.c | 4 ++--
delta-islands.c| 4 ++--
pack-objects.c | 6 ++
pack-objects.h | 20 ++--
4 files changed, 28 insertions(+), 6 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack
le cloning and fetching
is still quite fast and not much more CPU intensive.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
Documentation/config.txt | 15 +
Documentation/git-pack-objects.txt | 97 ++
builtin/pack-objects.c
.
This will make it easier to see and understand what the
following changes are doing.
Helped-by: Duy Nguyen
Signed-off-by: Christian Couder
---
builtin/pack-objects.c | 90 +++---
1 file changed, 50 insertions(+), 40 deletions(-)
diff --git a/builtin/pack-objects.c b
From: Jeff King
As get_delta_base() will be used outside 'packfile.c' in
a following commit, let's make it non static and let's
declare it in 'packfile.h'.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
packfile.c | 10 +-
packfile.h | 7 +++
2 files changed, 12
5-1-chrisc...@tuxfamily.org/
Christian Couder (3):
pack-objects: refactor code into compute_layer_order()
pack-objects: move tree_depth into 'struct packing_data'
pack-objects: move 'layer' into 'struct packing_data'
Jeff King (5):
packfile: make get_delta_base() non static
Add delta-islands.{c
On Tue, Aug 7, 2018 at 6:15 PM, Phillip Wood wrote:
> On 07/08/18 16:25, Christian Couder wrote:
>>
>> I agree about checking the return value from fputs(), but it seems to
>> me that we don't usually check the value of fclose().
>
> A quick grep shows you're righ
1 - 100 of 2901 matches
Mail list logo
