Re: [PATCH v2] git-svn: workaround for a bug in svn serf backend

2014-01-17 Thread Roman Kagan
2013/12/31 Roman Kagan rka...@mail.ru: 2013/12/30 Junio C Hamano gits...@pobox.com: Roman Kagan rka...@mail.ru writes: I'd like to note that it's IMO worth including in the 'maint' branch as it's a crasher. Especially so since the real fix has been merged in the subversion upstream

Re: [PATCH] git-svn: workaround for a bug in svn serf backend

2013-12-30 Thread Roman Kagan
2013/12/30 Thomas Rast t...@thomasrast.ch: Roman Kagan rka...@mail.ru writes: + # workaround for a bug in svn serf backend (v1.8.5 and below): + # store 3d argument to -add_file() in a local variable, to make it + # have the same lifetime as $fbat + my $upa = $self-url_path

Re: [PATCH v2] git-svn: workaround for a bug in svn serf backend

2013-12-30 Thread Roman Kagan
2013/12/30 Junio C Hamano gits...@pobox.com: Roman Kagan rka...@mail.ru writes: I'd like to note that it's IMO worth including in the 'maint' branch as it's a crasher. Especially so since the real fix has been merged in the subversion upstream and nominated for 1.8 branch, so the workaround

Re: [PATCH v2] git-svn: workaround for a bug in svn serf backend

2013-12-28 Thread Roman Kagan
) Roman Kagan (1): git-svn: workaround for a bug in svn serf backend perl/Git/SVN/Editor.pm | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) Thanks. I almost missed this pull-request, though. Will pull. Thanks

[PATCH v2] git-svn: workaround for a bug in svn serf backend

2013-12-27 Thread Roman Kagan
-off-by: Roman Kagan rka...@mail.ru --- changes since v1: - fix grammar in the patch and the log message - refer to the triggered error message perl/Git/SVN/Editor.pm | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/perl/Git/SVN/Editor.pm b/perl/Git/SVN/Editor.pm

[PATCH] git-svn: workaround for a bug in svn serf backend

2013-12-26 Thread Roman Kagan
Cc: Eric Wong normalper...@yhbt.net Signed-off-by: Roman Kagan rka...@mail.ru --- perl/Git/SVN/Editor.pm | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/perl/Git/SVN/Editor.pm b/perl/Git/SVN/Editor.pm index b3bcd47..ae399c3 100644 --- a/perl/Git/SVN/Editor.pm +++ b

Re: [PATCH] git-svn: workaround for a bug in svn serf backend

2013-12-26 Thread Roman Kagan
2013/12/27 Jonathan Nieder jrnie...@gmail.com: Roman Kagan wrote: Subversion serf backend in versions 1.8.5 and below has a bug that the function creating the descriptor of a file change -- add_file() -- doesn't make a copy of its 3d argument when storing it on the returned 3d makes me

Re: [PATCH] git-svn: workaround for a bug in svn serf backend

2013-12-26 Thread Roman Kagan
2013/12/27 Roman Kagan rka...@mail.ru: 2013/12/27 Jonathan Nieder jrnie...@gmail.com: Could this be reproduced with a test script to make sure we don't reintroduce the bug again later? (It's okay if the test only fails on machines with the problematic svn version.) That would need a fairly

Re: Fwd: Error with git-svn pushing a rename

2013-12-25 Thread Roman Kagan
2013/12/25 Roman Kagan rka...@mail.ru: I've hit this problem too, and tracked it down to what I think is a bug in svn. [...] I'm going to submit a patch adding apr_pstrdup() to subversion folks. http://thread.gmane.org/gmane.comp.version-control.subversion.devel/145186 Roman

Re: Fwd: Error with git-svn pushing a rename

2013-12-25 Thread Roman Kagan
2013/12/25 Roman Kagan rka...@mail.ru: 2013/12/25 Roman Kagan rka...@mail.ru: I've hit this problem too, and tracked it down to what I think is a bug in svn. [...] I'm going to submit a patch adding apr_pstrdup() to subversion folks. http://thread.gmane.org/gmane.comp.version

Re: Fwd: Error with git-svn pushing a rename

2013-12-24 Thread Roman Kagan
Benjamin Pabst benjamin.pabst85 at gmail.com writes: is it possible to debug git-svn or get a more verbose / debug output from it? I already tried with the GIT_TRACE variable, but it does not include any further output on the svn methods. I've hit this problem too, and tracked it down to what