Support for grafts predates Git's strbuf, and hence it is understandable
that there was a hard-coded line length limit of 1023 characters (which
was chosen a bit awkwardly, given that it is *exactly* one byte short of
aligning with the 41 bytes occupied by a commit name and the following
space or
Hi,
Johannes Schindelin wrote:
While regular commit histories hardly win comprehensibility in general
if they merge more than twenty-two branches in one go, it is not Git's
business to limit grafts in such a way.
Fun. :) Makes sense.
[...]
---
builtin/blame.c | 8
commit.c
Johannes Schindelin johannes.schinde...@gmx.de writes:
Support for grafts predates Git's strbuf, and hence it is understandable
that there was a hard-coded line length limit of 1023 characters (which
was chosen a bit awkwardly, given that it is *exactly* one byte short of
aligning with the 41
Johannes Schindelin wrote:
it returns EOF only if ch == EOF *and* sb-len == 0, i.e. if no characters
have been read before hitting EOF.
Yep. api-strbuf.txt even says so. Sorry for the nonsense.
For what it's worth,
Reviewed-by: Jonathan Nieder jrnie...@gmail.com
--
To unsubscribe from this
Johannes Schindelin wrote:
On Fri, 27 Dec 2013, Jonathan Nieder wrote:
Is this easy to reproduce so some interested but lazy person could
write a test?
Yep. Make 25 orphan commits, add a graft line to make the first a merge of
the rest.
Thanks. Here's a pair of tests doing that.
Hi Jonathan,
On Fri, 27 Dec 2013, Jonathan Nieder wrote:
Johannes Schindelin wrote:
it returns EOF only if ch == EOF *and* sb-len == 0, i.e. if no characters
have been read before hitting EOF.
Yep. api-strbuf.txt even says so.
I never bothered to look ;-)
Sorry for the nonsense.
Hi Jonathan,
On Fri, 27 Dec 2013, Jonathan Nieder wrote:
Johannes Schindelin wrote:
On Fri, 27 Dec 2013, Jonathan Nieder wrote:
Is this easy to reproduce so some interested but lazy person could
write a test?
Yep. Make 25 orphan commits, add a graft line to make the first a merge of
Jonathan Nieder jrnie...@gmail.com writes:
Johannes Schindelin wrote:
On Fri, 27 Dec 2013, Jonathan Nieder wrote:
Is this easy to reproduce so some interested but lazy person could
write a test?
Yep. Make 25 orphan commits, add a graft line to make the first a merge of
the rest.
Thanks.
8 matches
Mail list logo