Re: [PATCH 0/8] object_id part 2

2015-06-13 Thread brian m. carlson
On Sat, Jun 13, 2015 at 10:45:29AM +0200, Michael Haggerty wrote: In the same email where I made those design suggestions, I also I pointed out a bug in the implementation of parse_oid_hex(). Maybe that is the reason for the test failures. It probably is, although I either botched a conversion

Re: [PATCH 0/8] object_id part 2

2015-06-13 Thread Michael Haggerty
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/13/2015 12:27 AM, brian m. carlson wrote: On Fri, Jun 12, 2015 at 03:14:25PM -0700, Junio C Hamano wrote: brian m. carlson sand...@crustytoothpaste.net writes: While I did run the tests between each commit, I hadn't noticed they were

Re: [PATCH 0/8] object_id part 2

2015-06-12 Thread brian m. carlson
On Fri, Jun 12, 2015 at 03:14:25PM -0700, Junio C Hamano wrote: brian m. carlson sand...@crustytoothpaste.net writes: While I did run the tests between each commit, I hadn't noticed they were failing because I don't have Apache installed on my laptop, so they were silently skipped. I'll

Re: [PATCH 0/8] object_id part 2

2015-06-12 Thread Junio C Hamano
brian m. carlson sand...@crustytoothpaste.net writes: While I did run the tests between each commit, I hadn't noticed they were failing because I don't have Apache installed on my laptop, so they were silently skipped. I'll resubmit with that fixed. It is somewhat strange that _only_ http

Re: [PATCH 0/8] object_id part 2

2015-06-12 Thread brian m. carlson
On Thu, Jun 11, 2015 at 01:00:04PM -0700, Junio C Hamano wrote: Fetched that branch, built and found out that it does not pass the tests, at least these (there may be others I do not usually run that are broken by this series; I dunno), so I'll discard what I fetched for now X-. Test

Re: [PATCH 0/8] object_id part 2

2015-06-11 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: brian m. carlson sand...@crustytoothpaste.net writes: On Wed, Jun 10, 2015 at 11:51:14PM +, brian m. carlson wrote: On Wed, Jun 10, 2015 at 03:50:32PM -0700, Junio C Hamano wrote: brian m. carlson sand...@crustytoothpaste.net writes: Convert

Re: [PATCH 0/8] object_id part 2

2015-06-10 Thread Junio C Hamano
brian m. carlson sand...@crustytoothpaste.net writes: The final piece in this series is the conversion of struct object to use struct object_id. This is a necessarily large patch because of the large number of places this code is used. brian m. carlson (8): refs: convert some internal

Re: [PATCH 0/8] object_id part 2

2015-06-10 Thread Junio C Hamano
brian m. carlson sand...@crustytoothpaste.net writes: On Wed, Jun 10, 2015 at 11:51:14PM +, brian m. carlson wrote: On Wed, Jun 10, 2015 at 03:50:32PM -0700, Junio C Hamano wrote: brian m. carlson sand...@crustytoothpaste.net writes: Convert struct object to object_id It seems

Re: [PATCH 0/8] object_id part 2

2015-06-10 Thread brian m. carlson
On Wed, Jun 10, 2015 at 11:51:14PM +, brian m. carlson wrote: On Wed, Jun 10, 2015 at 03:50:32PM -0700, Junio C Hamano wrote: brian m. carlson sand...@crustytoothpaste.net writes: Convert struct object to object_id It seems that the last one didn't make it... It appears the

Re: [PATCH 0/8] object_id part 2

2015-06-10 Thread brian m. carlson
On Wed, Jun 10, 2015 at 03:50:32PM -0700, Junio C Hamano wrote: brian m. carlson sand...@crustytoothpaste.net writes: Convert struct object to object_id It seems that the last one didn't make it... It appears the mail was too large for vger. Unfortunately for bisectability reasons, it is

Re: [PATCH 0/8] object_id part 2

2015-06-10 Thread brian m. carlson
On Wed, Jun 10, 2015 at 05:21:33PM -0700, Junio C Hamano wrote: brian m. carlson sand...@crustytoothpaste.net writes: [0] https://github.com/bk2204/git.git object-id-part2 No approach other than just letting reviewers fetch from there and taking a look is reasonable, I would think. Did

[PATCH 0/8] object_id part 2

2015-06-09 Thread brian m. carlson
This is another series of conversions to struct object_id. This series converts more of the refs code and struct object to use struct object_id. It introduces two additional helper functions. One is has_object_file, which is the equivalent of has_sha1_file. The name was chosen to be slightly