Re: [PATCH 1/2] git-p4: support multiple depot paths in p4 submit

On 07 Dec 2015, at 19:51, Sam Hocevar wrote: > On Sun, Dec 06, 2015, Lars Schneider wrote: >> Thanks for the patch! Do you see a way to demonstrate the bug in a test case >> similar to t9821 [1]? > > Not yet, I'm afraid. It's proving trickier than expected because for >

Re: [PATCH 1/2] git-p4: support multiple depot paths in p4 submit

On 8 December 2015 at 11:41, Sam Hocevar wrote: > On Tue, Dec 08, 2015, Lars Schneider wrote: > >> > Would a refactor of lib-git-p4.sh (and probably all git-p4 tests) to >> > support multiple depots be acceptable and/or welcome? I prefer to ask >> > before I dig into the task.

Re: [PATCH 1/2] git-p4: support multiple depot paths in p4 submit

On Tue, Dec 08, 2015, Lars Schneider wrote: > > Would a refactor of lib-git-p4.sh (and probably all git-p4 tests) to > > support multiple depots be acceptable and/or welcome? I prefer to ask > > before I dig into the task. > > Can you outline your idea a bit? Are you aware of the following way

Re: [PATCH 1/2] git-p4: support multiple depot paths in p4 submit

On Sun, Dec 06, 2015, Lars Schneider wrote: > Thanks for the patch! Do you see a way to demonstrate the bug in a test case > similar to t9821 [1]? Not yet, I'm afraid. It's proving trickier than expected because for now I can only reproduce the bug when the view uses multiples depots

Re: [PATCH 1/2] git-p4: support multiple depot paths in p4 submit

Thanks for the patch! Do you see a way to demonstrate the bug in a test case similar to t9821 [1]? Cheers, Lars [1] https://github.com/git/git/blob/master/t/t9821-git-p4-path-variations.sh > On 05 Dec 2015, at 12:22, Sam Hocevar wrote: > > When submitting from a repository

[PATCH 1/2] git-p4: support multiple depot paths in p4 submit

When submitting from a repository that was cloned using a client spec, use the full list of paths when ruling out files that are outside the view. This fixes a bug where only files pertaining to the first path would be included in the p4 submit. Signed-off-by: Sam Hocevar ---