Re: [PATCH 1/2] parse-options: expand $HOME on filename options

On Thu, Feb 22, 2018 at 8:38 PM, Ævar Arnfjörð Bjarmason wrote: > Ah I see, so you're doing "git init --template=~/". > > ... > > I wonder if the consistency with the tab completion wouldn't be better > done by teaching the tab completion to just expand --template=~/ to > e.g.

Re: [PATCH 1/2] parse-options: expand $HOME on filename options

On Thu, Feb 22 2018, Duy Nguyen jotted: > On Thu, Feb 15, 2018 at 5:46 AM, Ævar Arnfjörð Bjarmason > wrote: >> In general I'm mildly negative on adding this, for every user like Doron >> who'll be less confused by a hack like this, you'll have other users >> who'll be confused

Re: [PATCH 1/2] parse-options: expand $HOME on filename options

On Thu, Feb 15, 2018 at 5:46 AM, Ævar Arnfjörð Bjarmason wrote: > In general I'm mildly negative on adding this, for every user like Doron > who'll be less confused by a hack like this, you'll have other users > who'll be confused about git inexplicably working with ~ in the

Re: [PATCH 1/2] parse-options: expand $HOME on filename options

Ævar Arnfjörð Bjarmason writes: > In general I'm mildly negative on adding this, for every user like Doron > who'll be less confused by a hack like this, you'll have other users > who'll be confused about git inexplicably working with ~ in the middle > of strings, even though;

Re: [PATCH 1/2] parse-options: expand $HOME on filename options

On Wed, Feb 14 2018, Nguyễn Thái Ngọc Duy jotted: > When you specify "--path ~/foo", the shell will automatically expand > ~/foo to $HOME/foo before it's passed to git. The expansion is not done > on "--path=~/foo". An experienced user sees the difference but it could > still be confusing for

Re: [PATCH 1/2] parse-options: expand $HOME on filename options

Jeff King writes: >> Support $HOME expansion for all filename options. There are about seven >> of them. > > I think this probably makes sense. > >> parse-options.c | 9 ++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) > > Should this be mentioned in the comment

Re: [PATCH 1/2] parse-options: expand $HOME on filename options

On Wed, Feb 14, 2018 at 05:51:48PM +0700, Nguyễn Thái Ngọc Duy wrote: > When you specify "--path ~/foo", the shell will automatically expand > ~/foo to $HOME/foo before it's passed to git. The expansion is not done > on "--path=~/foo". An experienced user sees the difference but it could > still

[PATCH 1/2] parse-options: expand $HOME on filename options

When you specify "--path ~/foo", the shell will automatically expand ~/foo to $HOME/foo before it's passed to git. The expansion is not done on "--path=~/foo". An experienced user sees the difference but it could still be confusing for others (especially when tab-completion still works on