On Sep 12, 2013, at 02:57, Thomas Rast wrote:
The calls to strbuf_add* within append_normalized_escapes() can
reallocate the buffer passed to it. Therefore, the seg_start pointer
into the string cannot be kept across such calls.
Thanks for finding this.
It went undetected for a while
Kyle J. McKay mack...@gmail.com writes:
Also some nits. The patch description should be imperative mood
(cf. Documentation/SubmittingPatches).
Heh. Serves me right to go away for a while and get SubmittingPatches
cited at me on return ;-)
Thanks for the updated patch. I agree with the
Thanks, both.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Kyle J. McKay mack...@gmail.com writes:
So how about this patch instead...
-- 8 --
From: Thomas Rast tr...@inf.ethz.ch
Subject: urlmatch.c: recompute pointer after append_normalized_escapes
When append_normalized_escapes is called, its internal strbuf_add* calls can
cause the strbuf's buf
On Sep 12, 2013, at 11:30, Junio C Hamano wrote:
+ /* append_normalized_escapes can cause norm.buf to change */
+ seg_start = norm.buf + seg_start_off;
The change looks good, but I find that this comment is not placed in
the right place. It is good if the reader
Kyle J. McKay wrote:
The longer comment looks good to me. If you think the code will be safe from
simplification patches without a comment, that works for me too.
I think if we can't trust reviewers to catch this kind of thing, we're
in trouble (i.e., moving too fast). :)
So FWIW my instinct
Jonathan Nieder jrnie...@gmail.com writes:
Kyle J. McKay wrote:
The longer comment looks good to me. If you think the code will be safe from
simplification patches without a comment, that works for me too.
I think if we can't trust reviewers to catch this kind of thing, we're
in trouble
7 matches
Mail list logo
