Patch 17/17 of v4 failed to arrive in my inbox for some reason, so
I'll just reply to v3 since there's another error I noticed which is
still present in v4, plus a comment specific to v4 (see below).
On Mon, Jan 27, 2014 at 3:33 PM, Christian Couder
chrisc...@tuxfamily.org wrote:
From: Eric
From: Junio C Hamano gits...@pobox.com
Subject: Re: [PATCH v3 17/17] Documentation: add documentation for 'git
interpret-trailers'
Date: Mon, 27 Jan 2014 13:20:18 -0800
Christian Couder chrisc...@tuxfamily.org writes:
+'git interpret-trailers' [--trim-empty] [--infile=file]
[token[=value
Christian Couder chrisc...@tuxfamily.org writes:
I find it a bad taste to allow unbound set of token on the LHS of
'=' on the command line, but that is a separate issue in the design,
not in the documentation of the design.
I don't understand this sentence, sorry.
It is a bad design taste
From: Eric Sunshine sunsh...@sunshineco.com
On Sun, Jan 26, 2014 at 12:00 PM, Christian Couder
chrisc...@tuxfamily.org wrote:
Signed-off-by: Christian Couder chrisc...@tuxfamily.org
---
diff --git a/Documentation/git-interpret-trailers.txt
b/Documentation/git-interpret-trailers.txt
new
Christian Couder chrisc...@tuxfamily.org writes:
+'git interpret-trailers' [--trim-empty] [--infile=file]
[token[=value]...]
Would it be more consistent with existing documentation to format this as so?
[--infile=file] [token[=value]]...
No, it would be very inconsistent:
$ grep
Signed-off-by: Christian Couder chrisc...@tuxfamily.org
---
Documentation/git-interpret-trailers.txt | 137 +++
1 file changed, 137 insertions(+)
create mode 100644 Documentation/git-interpret-trailers.txt
diff --git a/Documentation/git-interpret-trailers.txt
On Sun, Jan 26, 2014 at 12:00 PM, Christian Couder
chrisc...@tuxfamily.org wrote:
Signed-off-by: Christian Couder chrisc...@tuxfamily.org
---
diff --git a/Documentation/git-interpret-trailers.txt
b/Documentation/git-interpret-trailers.txt
new file mode 100644
index 000..f74843e
---
7 matches
Mail list logo
