Re: [PATCH Outreachy] mru: use double-linked list from list.h

I added "v2" after "PATCH", but it does not appeared. Actually it was written automatically and it was "PATCH Outreachy v2". I rearranged it in the middle of the phrase. >> I forgot about leak. I also need to add checking in mru_clear. That's >> not beautiful solution but it works reliably. > >

Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

>> Simplify mru.[ch] and related code by reusing the double-linked list >> implementation from list.h instead of a custom one. >> This commit is an intermediate step. Our final goal is to get rid of >> mru.[ch] at all and inline all logic. > > Thanks, this version looks correct to me. Great! What

Re: [PATCH Outreachy] mru: use double-linked list from list.h

Hi everyone, Many thanks to all of you, I am interested in every opinion. Sorry that I wasn't in the discussion, unfortunately I got sick, that's why I skipped all the process. I want to reply to the main moments and also ask some questions. >> Simplify mru.c, mru.h and related code by reusing

Re: [PATCH Outreachy] mru: use double-linked list from list.h

> About minor issues ( "tmp" vs "p2", variable scope, space indentation) > - fully agree, I will fix it. > ... > So finally I think that I need to fix that minor issues and that's > all. I forgot about leak. I also need to add checking in mru_clear. That's not beautiful solution but it works

[PATCH] [Outreachy] cleanup: use list.h in mru.h and mru.c

Remove implementation of double-linked list in mru.c and mru.h and use implementation from list.h. Signed-off-by: Olga Telezhnaia Mentored-by: Christian Couder , Jeff King --- builtin/pack-objects.c | 5 +++-- mru.c

Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

> We hung back on it to leave it as low-hanging fruit for other Outreachy > applicants. Perhaps Olga would like to pick it up now that the > application period is over. It's absolutely not a problem for me, I can do that as one more warm-up exercise in the beginning of the internship. Thanks!

Re: [PATCH Outreachy 1/2] format: create pretty.h file

> I see you've "standardized" to drop "extern" from the declarations > in the header; I have an impression that our preference however is > to go in the other direction. OK, absolutely not a problem, I will return them. Do I need to write "extern" further in function declarations? And why did

Re: [PATCH Outreachy 1/2] format: create pretty.h file

Is it true that I need to fix only one commit message? (a typo s/futher/further/) Do you have any other advises what do I need to change? Thanks!

Re: [PATCH] mru: Replace mru.[ch] with list.h implementation

Gargi, If you have some difficulties - please feel free to ask questions (here or you can write me directly). I will be happy to help you. As I understand, you are super close to finish your first patch. Olga

[PATCH RFC 0/1] ref-filter: start using oid_object_info

Hello everyone, Some context at first: I am trying to migrate cat-file formatting part (I mean batch option) from its own implementation to ref-filter one. That's why I want to use oid_object_info_extended() in ref-filter, it will simplify my further work. Additionally, it will give us 2 new

[PATCH RFC v2 0/4] ref-filter: start using oid_object_info

Hello, Discussion starts here: [1], [2]. Updates: I fixed memory leaks, now we use data from oid_object_info() OR from grab_commom_values() - not both as it was before. I added support for "%(objectsize:disk)" atom (with tests) and for "%(deltabase)" atom (without tests yet). I didn't support

Re: Rewrite cat-file.c : need help to find a bug

2017-12-29 16:22 GMT+03:00 Jeff King <p...@peff.net>: > On Fri, Dec 29, 2017 at 01:05:50PM +0300, Оля Тележная wrote: > >> Hi everyone, >> I am trying to reuse formatting logic from ref-filter in cat-file >> command. Now cat-file uses its own formatting code. >&

Re: Rewrite cat-file.c : need help to find a bug

2017-12-29 17:04 GMT+03:00 Оля Тележная <olyatelezhn...@gmail.com>: > 2017-12-29 16:22 GMT+03:00 Jeff King <p...@peff.net>: >> On Fri, Dec 29, 2017 at 01:05:50PM +0300, Оля Тележная wrote: >> >>> Hi everyone, >>> I am trying to reuse formatting logic

Re: [PATCH v2 03/18] ref-filter: make valid_atom as function parameter

2018-01-16 0:42 GMT+03:00 Jeff King : > On Wed, Jan 10, 2018 at 09:36:41AM +, Olga Telezhnaya wrote: > >> Make valid_atom as a function parameter, >> there could be another variable further. >> Need that for further reusing of formatting logic in cat-file.c. >> >> We do not need

Re: [PATCH v2 04/18] cat-file: move struct expand_data into ref-filter

2018-01-16 0:44 GMT+03:00 Jeff King : > On Wed, Jan 10, 2018 at 09:36:41AM +, Olga Telezhnaya wrote: > >> Need that for further reusing of formatting logic in cat-file. >> Have plans to get rid of using expand_data in cat-file at all, >> and use it only in ref-filter for

Re: [PATCH v2 01/18] cat-file: split expand_atom into 2 functions

2018-01-16 1:09 GMT+03:00 Jeff King : > On Mon, Jan 15, 2018 at 04:33:35PM -0500, Jeff King wrote: > >> That works, but I don't think it's where we want to end up in the long >> run. I absolutely agree, I want to merge current edits and then continue migrating process. And

Re: [PATCH v2 02/18] cat-file: reuse struct ref_format

2018-01-16 0:37 GMT+03:00 Jeff King : > On Wed, Jan 10, 2018 at 09:36:41AM +, Olga Telezhnaya wrote: > >> Start using ref_format struct instead of simple char*. >> Need that for further reusing of formatting logic from ref-filter. > > OK, this makes sense (though again, at some

Re: [PATCH v2 03/18] ref-filter: make valid_atom as function parameter

2018-01-18 17:23 GMT+03:00 Christian Couder <christian.cou...@gmail.com>: > On Thu, Jan 18, 2018 at 12:49 PM, Оля Тележная <olyatelezhn...@gmail.com> > wrote: >> 2018-01-18 9:20 GMT+03:00 Оля Тележная <olyatelezhn...@gmail.com>: >>> >>> I think it'

Re: [PATCH v2 03/18] ref-filter: make valid_atom as function parameter

2018-01-19 20:14 GMT+03:00 Christian Couder <christian.cou...@gmail.com>: > On Thu, Jan 18, 2018 at 7:20 AM, Оля Тележная <olyatelezhn...@gmail.com> > wrote: >> 2018-01-18 1:39 GMT+03:00 Christian Couder <christian.cou...@gmail.com>: >>> On Wed, Jan 17, 201

Re: Please review my code

2018-01-25 23:22 GMT+03:00 Christian Couder <christian.cou...@gmail.com>: > Hi Olga, > > On Thu, Jan 25, 2018 at 6:20 PM, Оля Тележная <olyatelezhn...@gmail.com> > wrote: >> Hi everyone, >> I haven't sent the code by mailing lists because 25 commits (every >

Re: Please review my code

2018-01-26 19:42 GMT+03:00 Christian Couder <christian.cou...@gmail.com>: > On Fri, Jan 26, 2018 at 11:32 AM, Оля Тележная <olyatelezhn...@gmail.com> > wrote: >> 2018-01-25 23:22 GMT+03:00 Christian Couder <christian.cou...@gmail.com>: >>> On Thu

Re: [PATCH v2 01/18] cat-file: split expand_atom into 2 functions

2018-01-18 2:04 GMT+03:00 Christian Couder <christian.cou...@gmail.com>: > On Wed, Jan 17, 2018 at 10:49 PM, Jeff King <p...@peff.net> wrote: >> On Tue, Jan 16, 2018 at 10:22:23AM +0300, Оля Тележная wrote: >> >>> >> In other words, I thi

Re: [PATCH v2 04/18] cat-file: move struct expand_data into ref-filter

2018-01-18 0:45 GMT+03:00 Jeff King <p...@peff.net>: > On Tue, Jan 16, 2018 at 10:00:42AM +0300, Оля Тележная wrote: > >> > I think some of these will want to remain in cat-file.c. For instance, >> > split_on_whitespace is not something that ref-filter.c itself wou

Re: [PATCH v2 03/18] ref-filter: make valid_atom as function parameter

2018-01-18 1:39 GMT+03:00 Christian Couder <christian.cou...@gmail.com>: > On Wed, Jan 17, 2018 at 10:43 PM, Jeff King <p...@peff.net> wrote: >> On Tue, Jan 16, 2018 at 09:55:22AM +0300, Оля Тележная wrote: >> >>> > IOW, the progression I'd expect in a seri

Please review my code

Hi everyone, I haven't sent the code by mailing lists because 25 commits (every commit in separate message) look like a spam. Please look at my code: https://github.com/telezhnaya/git/commits/catfile You could send me any ideas here or in Github. The main idea of the patch is to get rid of using

Re: [PATCH 03/20] cat-file: rename variables in ref-filter

2018-01-10 1:04 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> Rename some variables for easier reading. >> They point not to values, but to arrays. > > Once the code is written and people start to build on top, a change > like this is not

Re: [PATCH RFC 01/24] ref-filter: get rid of goto

2018-01-30 23:49 GMT+03:00 Junio C Hamano <gits...@pobox.com>: > Оля Тележная <olyatelezhn...@gmail.com> writes: > >>> one place improves readability. If better readability is the >>> purpose, I would even say >>>

Re: [PATCH RFC 03/24] cat-file: split expand_atom into 2 functions

2018-01-27 0:46 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> Split expand_atom function into 2 different functions, >> expand_atom_into_fields prepares variable for further filling, >> (new) expand_atom creates resulting string. >> Need

Re: [PATCH RFC 01/24] ref-filter: get rid of goto

2018-01-26 23:19 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> Get rid of goto command in ref-filter for better readability. >> >> Signed-off-by: Olga Telezhnaia >> Mentored-by: Christian Couder

Re: [PATCH RFC 02/24] ref-filter: add return value to some functions

2018-01-27 0:05 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> Add return flag to format_ref_array_item, show_ref_array_item, >> get_ref_array_info and populate_value for further using. >> Need it to handle situations when item is broken but

[PATCH v3 0/23] cat-file: reuse formatting logic from ref-filter

The main idea of the patch is to get rid of using custom formatting in cat-file and start using general one from ref-filter. Additional bonus is that cat-file becomes to support many new formatting commands like %(if), %(color), %(committername) etc. Updates since last review: In [PATCH v3 16/23]

Re: [PATCH v3 14/23] ref_filter: add is_atom_used function

2018-02-15 8:49 GMT+03:00 Jeff King : > On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > >> Delete all items related to split_on_whitespace from ref-filter >> and add new function for handling the logic. >> Now cat-file could invoke that function to implementing

Re: [PATCH v3 09/23] cat-file: start use ref_array_item struct

2018-02-15 8:40 GMT+03:00 Jeff King : > On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > >> Moving from using expand_data to ref_array_item structure. >> That helps us to reuse functions from ref-filter easier. > > This one feels weird. The point of a

Re: [PATCH v3 20/23] ref-filter: unifying formatting of cat-file opts

2018-02-15 8:56 GMT+03:00 Jeff King : > On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > >> cat-file options are now filled by general logic. > > Yay. > > One puzzling thing: > >> diff --git a/ref-filter.c b/ref-filter.c >> index 8d104b567eb7c..5781416cf9126 100644

Re: [PATCH v3 08/23] ref-filter: reuse parse_ref_filter_atom()

2018-02-15 8:37 GMT+03:00 Jeff King : > On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > >> Continue migrating formatting logic from cat-file to ref-filter. >> Reuse parse_ref_filter_atom() for unifying all processes in ref-filter >> and further removing of

Re: [PATCH v3 15/23] cat-file: move skip_object_info into ref-filter

2018-02-15 8:51 GMT+03:00 Jeff King : > On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > >> Move logic related to skip_object_info into ref-filter, >> so that cat-file does not use that field at all. > > I think this is going the wrong way. ref-filter should always

Re: [PATCH v3 02/23] ref-filter: add return value to some functions

2018-02-15 8:16 GMT+03:00 Jeff King : > On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > >> Add return flag to format_ref_array_item(), show_ref_array_item(), >> get_ref_array_info() and populate_value() for further using. >> Need it to handle situations when item

Re: [PATCH v3 13/23] ref-filter: get rid of mark_atom_in_object_info()

2018-02-15 8:45 GMT+03:00 Jeff King : > On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > >> Remove mark_atom_in_object_info() and create same logic >> in terms of ref-filter style. > > This one is definitely a step in the right direction. In fact, this is > what I

Re: [PATCH v3 16/23] ref-filter: make cat_file_info independent

2018-02-15 8:53 GMT+03:00 Jeff King : > On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > >> Remove connection between expand_data variable >> in cat-file and in ref-filter. >> It will help further to get rid of using expand_data in cat-file. > > I have to admit I'm

Re: [PATCH v3 21/23] for-each-ref: tests for new atoms added

2018-02-15 8:57 GMT+03:00 Jeff King : > On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > >> Add tests for new formatting atoms: rest, deltabase, objectsize:disk. >> rest means nothing and we expand it into empty string. >> We need this atom for cat-file command. >>

Re: [PATCH v3 04/23] ref-filter: make valid_atom as function parameter

2018-02-15 8:23 GMT+03:00 Jeff King : > On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > >> Make valid_atom as a function parameter, >> there could be another variable further. >> Need that for further reusing of formatting logic in cat-file.c. >> >> We do not need

Re: [PATCH 2/2] ref-filter: get rid of goto

2018-02-21 20:41 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> Get rid of goto command in ref-filter for better readability. >> >> Signed-off-by: Olga Telezhnaia >> Mentored-by: Christian Couder

ref-filter: how to improve the code

Hi everyone, I am trying to remove cat-file formatting part and reuse same functionality from ref-filter. I have a problem that cat-file sometimes needs to continue running even if the request is broken, while in ref-filter we invoke die() in many places everywhere during formatting process. I

Rewrite cat-file.c : need help to find a bug

Hi everyone, I am trying to reuse formatting logic from ref-filter in cat-file command. Now cat-file uses its own formatting code. I am trying to achieve that step-by-step, now I want to invoke populate_value function, and I have a bug somewhere. My code is here.

Re: What's cooking in git.git (Jul 2018, #03; Wed, 25)

2018-07-26 1:13 GMT+03:00 Junio C Hamano : > > * ot/ref-filter-object-info (2018-07-17) 5 commits > - ref-filter: use oid_object_info() to get object > - ref-filter: merge get_obj and get_object > - ref-filter: initialize eaten variable > - ref-filter: fill empty fields with empty values > -

Re: [PATCH v2 4/4] ref-filter: use oid_object_info() to get object

2018-07-16 23:53 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> -static int get_object(struct ref_array_item *ref, const struct object_id >> *oid, >> - int deref, struct object **obj, struct strbuf *err) >> +static int get_object(struct ref_array_item *ref, int

Re: What's cooking in git.git (Jul 2018, #02; Wed, 18)

> * ot/ref-filter-object-info (2018-07-17) 5 commits > - ref-filter: use oid_object_info() to get object > - ref-filter: merge get_obj and get_object > - ref-filter: initialize eaten variable > - ref-filter: fill empty fields with empty values > - ref-filter: add info_source to valid_atom > >

Re: Git in Outreachy Dec-Mar?

Hi everyone, I was Outreachy intern last winter. I guess I need to speak up: I will be happy if my feedback helps you. At first, I want to repeat all thanks to Outreachy organizers and Git mentors. That was unique experience and I am so proud of being a part of this project. But, I need to say

Re: [PATCH 3/4] ref-filter: merge get_obj and get_object

Fully agree, thank you so much. I have fixed it. Waiting for other issues that need to be fixed, then I will re-send the patch. Thank you!

Re: [PATCH 2/4] ref-filter: add empty values to technical fields

2018-07-10 1:39 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> Atoms like "align" or "end" do not have string representation. >> Earlier we had to go and parse whole object with a hope that we >> could fill their string representations. It's easier to fill them >> with an empty string

Re: [PATCH 0/4] Use oid_object_info() instead of read_object_file()

2018-07-09 11:27 GMT+03:00 Оля Тележная : > Hello everyone, > This is my new attempt to start using oid_object_info_extended() in > ref-filter. You could look at previous one [1] [2] but it is not > necessary. > > The goal (still) is to improve performance by avoiding calling exp

Re: [PATCH] ref-filter: mark some file-local symbols as static

2018-07-12 18:57 GMT+03:00 Ramsay Jones : > > Signed-off-by: Ramsay Jones > --- > > Hi Olga, > > If you need to re-roll your 'ot/ref-filter-object-info' branch, > could you please squash this into the relevant patch (commit c5d9a471d6, > "ref-filter: use oid_object_info() to get object",

[PATCH 0/4] Use oid_object_info() instead of read_object_file()

Hello everyone, This is my new attempt to start using oid_object_info_extended() in ref-filter. You could look at previous one [1] [2] but it is not necessary. The goal (still) is to improve performance by avoiding calling expensive functions when we don't need the information they provide or

Re: [PATCH v2 03/18] ref-filter: make valid_atom as function parameter

2018-01-18 9:20 GMT+03:00 Оля Тележная <olyatelezhn...@gmail.com>: > 2018-01-18 1:39 GMT+03:00 Christian Couder <christian.cou...@gmail.com>: >> On Wed, Jan 17, 2018 at 10:43 PM, Jeff King <p...@peff.net> wrote: >>> On Tue, Jan 16, 2018 at 09:55:22AM +0300

Re: ref-filter: how to improve the code

2018-02-28 16:25 GMT+03:00 Jeff King <p...@peff.net>: > On Sun, Feb 25, 2018 at 09:28:25PM +0300, Оля Тележная wrote: > >> I am trying to remove cat-file formatting part and reuse same >> functionality from ref-filter. >> I have a problem that cat-file sometimes nee

[RFC 0/4] ref-filter: remove printing from formatting logic

The main idea of the patch is, if you want to format the output by ref-filter, you should have an ability to work with errors by yourself if you want to. So I decided not to touch signature of show_ref_array_item(), but to move all printing (I mean errors) to it. So that we could invoke

Re: [PATCH v2 5/5] ref-filter: get_ref_atom_value() error handling

2018-03-15 23:47 GMT+03:00 Martin Ågren : > I skimmed the first four patches of this v2. It seems that patches 1 and > 4 are identical to v2. Patches 2 and 3 have very straightforward changes > based on my earlier comments. Let's see what this patch is about. :-) Yes, you

Re: [PATCH v2 5/5] ref-filter: get_ref_atom_value() error handling

2018-03-16 0:01 GMT+03:00 Eric Sunshine : > On Thu, Mar 15, 2018 at 4:47 PM, Martin Ågren wrote: >> These are "real" errors and yield several more changes in the remainder. >> Ignoring those BUG-type messages at the beginning of this patch would >>

Re: [PATCH v2 3/5] ref-filter: change parsing function error handling

2018-03-16 1:48 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> Continue removing any printing from ref-filter formatting logic, >> so that it could be more general. > > Hmm. > >> Change the signature of parse_ref_filter_atom() by changing

Re: [RFC 0/4] ref-filter: remove printing from formatting logic

2018-03-13 22:26 GMT+03:00 Martin Ågren <martin.ag...@gmail.com>: > Hi Olga > > On 13 March 2018 at 11:25, Оля Тележная <olyatelezhn...@gmail.com> wrote: >> The main idea of the patch is, if you want to format the output by >> ref-filter, you should have an abilit

Re: [RFC 1/4] ref-filter: start adding strbufs with errors

2018-03-13 22:12 GMT+03:00 Martin Ågren : > On 13 March 2018 at 11:16, Olga Telezhnaya wrote: >> This is a first step in removing any printing from >> ref-filter formatting logic, so that it could be more general. >> Everything would be the same

Re: [RFC 3/4] ref-filter: change parsing function error handling

2018-03-13 22:18 GMT+03:00 Martin Ågren : > On 13 March 2018 at 11:16, Olga Telezhnaya wrote: >> Continue removing any printing from ref-filter formatting logic, >> so that it could be more general. >> >> Change the signature of

Re: [PATCH v6 0/6] ref-filter: remove die() calls from formatting logic

2018-03-29 17:41 GMT+03:00 Christian Couder <christian.cou...@gmail.com>: > On Thu, Mar 29, 2018 at 2:52 PM, Оля Тележная <olyatelezhn...@gmail.com> > wrote: >> Move helper function from strbuf to ref-filter. >> Get rid of some memory leaks. > > The above seems

[PATCH v6 0/6] ref-filter: remove die() calls from formatting logic

Move helper function from strbuf to ref-filter. Get rid of some memory leaks. Thanks to everyone! Olga

[PATCH v4 0/5] ref-filter: remove die() calls from formatting logic

Only commit messages were updated since last review (there was no comments about the code). Thank you! Olga

[PATCH v5 0/6] ref-filter: remove die() calls from formatting logic

Add strbuf_error() as a first commit and use it in all other commits. Good line reduction, -67 lines compare to previous version. Eric, thanks a lot, new code looks much better! Thank all of you, Olga

Re: [PATCH v5 1/6] strbuf: add shortcut to work with error messages

2018-03-21 23:20 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> Add function strbuf_error() that helps to save few lines of code. >> Function expands fmt with placeholders, append resulting error message >> to strbuf *err, and return error

Re: [PATCH v5 4/6] ref-filter: change parsing function error handling

2018-03-21 23:36 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> @@ -2144,13 +2151,15 @@ int format_ref_array_item(struct ref_array_item >> *info, >> >> for (cp = format->format; *cp && (sp = find_next(cp)); cp = ep + 1) { >>

Re: [PATCH 1/3] ref-filter: free memory from used_atom

чт, 18 окт. 2018 г. в 9:51, Junio C Hamano : > > Jeff King writes: > > > Presumably it came from the manual comment-style fixup. > > Wow, that was embarrassing. Thanks for catching it. Jeff, thanks a lot! I just sent new version where I fixed all known issues including that comment. > > > > >

[RFC PATCH 0/5] ref-filter: add new formatting options

Add formatting options %(objectsize:disk) and %(deltabase), as in cat-file command. I can not test %(deltabase) properly (I mean, I want to have test with meaningful deltabase in the result - now we have only with zeros). I tested it manually on my git repo, and I have not-null deltabases there.

[PATCH 0/3] ref-filter: reduce memory leaks

Reduce memory leaks in ref-filter.c. We still have leaks, but at least not so much. I use command valgrind --leak-check=full -v ./git for-each-ref to check results. Before: ==24727== LEAK SUMMARY: ==24727==definitely lost: 69,424 bytes in 724 blocks ==24727==indirectly lost: 29,643 bytes

Re: [RFC PATCH 1/5] ref-filter: add objectsize:disk option

вт, 13 нояб. 2018 г. в 04:52, Junio C Hamano : > > Jeff King writes: > > >> You mean something like > >> > >> v->s = xstrfmt("%"PRIdMAX, (intmax_t)oi->disk_size); > > > > I think elsewhere we simply use PRIuMAX for printing large sizes via > > off_t; we know this value isn't