[GitHub] [hive] dengzhhu653 commented on pull request #1201: HIVE-23797: Throw exception when no metastore found in zookeeper

dengzhhu653 commented on pull request #1201: URL: https://github.com/apache/hive/pull/1201#issuecomment-655848906 @belugabehr can you take another look at the changes? thank you! This is an automated message from the Apache

[GitHub] [hive] github-actions[bot] closed pull request #1003: HIVE-23347: MSCK REPAIR cannot discover partitions with upper case directory names

github-actions[bot] closed pull request #1003: URL: https://github.com/apache/hive/pull/1003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hive] pvary commented on pull request #1230: HIVE-23819: Use ranges in ValidReadTxnList serialization

pvary commented on pull request #1230: URL: https://github.com/apache/hive/pull/1230#issuecomment-655666860 Can we have microbenchmarks for serializing/deserializing for edge cases at least? * Everything is one big range * Everything is single event * Everything is 2 long range

[GitHub] [hive] pvary merged pull request #1192: HIVE-23780: Fail dropTable if acid cleanup fails

pvary merged pull request #1192: URL: https://github.com/apache/hive/pull/1192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] pvargacl opened a new pull request #1230: HIVE-23819: Use ranges in ValidReadTxnList serialization

pvargacl opened a new pull request #1230: URL: https://github.com/apache/hive/pull/1230 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hive] klcopp commented on pull request #1216: HIVE-23760: Upgrading to Kafka 2.5 Clients

klcopp commented on pull request #1216: URL: https://github.com/apache/hive/pull/1216#issuecomment-655578545 @pvary, would you mind taking a look? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hive] belugabehr commented on a change in pull request #1169: HIVE-20447: Add JSON Output Format to beeline

belugabehr commented on a change in pull request #1169: URL: https://github.com/apache/hive/pull/1169#discussion_r451617508 ## File path: beeline/src/java/org/apache/hive/beeline/JSONOutputFormat.java ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hive] belugabehr closed pull request #421: HIVE-20447 Add JSON Outputformat support

belugabehr closed pull request #421: URL: https://github.com/apache/hive/pull/421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] zeroflag opened a new pull request #1228: HIVE-23817. Pushing TopN Key operator PKFK inner joins (amagyar)

zeroflag opened a new pull request #1228: URL: https://github.com/apache/hive/pull/1228 ## NOTICE (work in progress) ### Pushing the TopNKey operator through PK-FK inner joins. Example: Customer table: ID (PK) | LAST_NAME -- | -- 1 | Robinson 2 | Jones

[GitHub] [hive] kgyrtkirk merged pull request #1211: HIVE-23790: The error message length of 2000 is exceeded for scheduled query

kgyrtkirk merged pull request #1211: URL: https://github.com/apache/hive/pull/1211 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] aasha commented on a change in pull request #1223: HIVE-23813 : Fix flaky tests due to JDO Exception

aasha commented on a change in pull request #1223: URL: https://github.com/apache/hive/pull/1223#discussion_r451545094 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ReplicationMetricsMaintTask.java ## @@ -63,13 +63,12 @@

[GitHub] [hive] dengzhhu653 commented on a change in pull request #1205: HIVE-23800: Make HiveServer2 oom hook interface

dengzhhu653 commented on a change in pull request #1205: URL: https://github.com/apache/hive/pull/1205#discussion_r451539918 ## File path: service/src/java/org/apache/hive/service/server/HiveServer2OomHookRunner.java ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache

[GitHub] [hive] dengzhhu653 commented on a change in pull request #1205: HIVE-23800: Make HiveServer2 oom hook interface

dengzhhu653 commented on a change in pull request #1205: URL: https://github.com/apache/hive/pull/1205#discussion_r451539648 ## File path: service/src/java/org/apache/hive/service/server/HiveServer2OomHookRunner.java ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache

[GitHub] [hive] kgyrtkirk commented on a change in pull request #1105: HIVE-22957: Support Partition Filtering In MSCK REPAIR TABLE Command

kgyrtkirk commented on a change in pull request #1105: URL: https://github.com/apache/hive/pull/1105#discussion_r451502201 ## File path: parser/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g ## @@ -734,6 +734,21 @@ dropPartitionOperator EQUAL | NOTEQUAL |

[GitHub] [hive] xinghuayu007 opened a new pull request #1227: HIVE-23815: statistics of metastore's underlying datastore

xinghuayu007 opened a new pull request #1227: URL: https://github.com/apache/hive/pull/1227 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g.

[GitHub] [hive] xinghuayu007 closed pull request #1226: HIVE-23815: statistics of metastore's underlying datastore

xinghuayu007 closed pull request #1226: URL: https://github.com/apache/hive/pull/1226 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hive] xinghuayu007 opened a new pull request #1226: statistics of metastore's underlying datastore

xinghuayu007 opened a new pull request #1226: URL: https://github.com/apache/hive/pull/1226 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g.

[GitHub] [hive] kgyrtkirk commented on a change in pull request #1223: HIVE-23813 : Fix flaky tests due to JDO Exception

kgyrtkirk commented on a change in pull request #1223: URL: https://github.com/apache/hive/pull/1223#discussion_r451486233 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ReplicationMetricsMaintTask.java ## @@ -63,13 +63,12

[GitHub] [hive] pgaref commented on a change in pull request #1161: HIVE-23638: Spotbugs issues in hive-common

pgaref commented on a change in pull request #1161: URL: https://github.com/apache/hive/pull/1161#discussion_r451489380 ## File path: common/src/java/org/apache/hive/common/util/SuppressFBWarnings.java ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hive] pgaref commented on a change in pull request #1161: HIVE-23638: Spotbugs issues in hive-common

pgaref commented on a change in pull request #1161: URL: https://github.com/apache/hive/pull/1161#discussion_r451489258 ## File path: common/src/java/org/apache/hadoop/hive/conf/Validator.java ## @@ -357,14 +357,15 @@ public String validate(String value) { final Path

[GitHub] [hive] pgaref commented on a change in pull request #1161: HIVE-23638: Spotbugs issues in hive-common

pgaref commented on a change in pull request #1161: URL: https://github.com/apache/hive/pull/1161#discussion_r451488767 ## File path: common/src/java/org/apache/hadoop/hive/common/StringInternUtils.java ## @@ -135,10 +135,10 @@ public static Path internUriStringsInPath(Path

[GitHub] [hive] pgaref commented on a change in pull request #1161: HIVE-23638: Spotbugs issues in hive-common

pgaref commented on a change in pull request #1161: URL: https://github.com/apache/hive/pull/1161#discussion_r451487709 ## File path: common/src/java/org/apache/hadoop/hive/common/FileUtils.java ## @@ -926,8 +925,7 @@ public static File createLocalDirsTempFile(Configuration

[GitHub] [hive] pkumarsinha opened a new pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha opened a new pull request #1225: URL: https://github.com/apache/hive/pull/1225 …n. Config option to execute data copy during load. ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which

[GitHub] [hive] pvary commented on a change in pull request #1224: HIVE-23805: Provide ValidTxnList to AcidUtils::getAcidState

pvary commented on a change in pull request #1224: URL: https://github.com/apache/hive/pull/1224#discussion_r451472066 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ## @@ -730,7 +729,10 @@ public boolean validateInput(FileSystem fs, HiveConf

[GitHub] [hive] pvary commented on a change in pull request #1224: HIVE-23805: Provide ValidTxnList to AcidUtils::getAcidState

pvary commented on a change in pull request #1224: URL: https://github.com/apache/hive/pull/1224#discussion_r451470405 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java ## @@ -1262,8 +1262,8 @@ public static boolean isAcid(FileSystem fileSystem, Path

[GitHub] [hive] pvargacl commented on a change in pull request #1224: HIVE-23805: Provide ValidTxnList to AcidUtils::getAcidState

pvargacl commented on a change in pull request #1224: URL: https://github.com/apache/hive/pull/1224#discussion_r451446059 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java ## @@ -1262,8 +1262,8 @@ public static boolean isAcid(FileSystem fileSystem, Path

[GitHub] [hive] pvargacl opened a new pull request #1224: HIVE-23805: Provide ValidTxnList to AcidUtils::getAcidState

pvargacl opened a new pull request #1224: URL: https://github.com/apache/hive/pull/1224 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hive] aasha commented on pull request #1223: HIVE-23813 : Fix flaky tests due to JDO Exception

aasha commented on pull request #1223: URL: https://github.com/apache/hive/pull/1223#issuecomment-655435804 > @aasha: Could you please verify that the flaky tests are fixed with running the flaky check tester jenkins job?http://ci.hive.apache.org/job/hive-flaky-check/ > > Thanks,

[GitHub] [hive] pvary commented on pull request #1223: HIVE-23813 : Fix flaky tests due to JDO Exception

pvary commented on pull request #1223: URL: https://github.com/apache/hive/pull/1223#issuecomment-655415683 @aasha: Could you please verify that the flaky tests are fixed with running the flaky check tester jenkins job?http://ci.hive.apache.org/job/hive-flaky-check/ Thanks,

[GitHub] [hive] aasha opened a new pull request #1223: HIVE-23813 : Fix flaky tests due to JDO Exception

aasha opened a new pull request #1223: URL: https://github.com/apache/hive/pull/1223 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g.

[GitHub] [hive] miklosgergely opened a new pull request #1222: HIVE-23814: Clean up Driver (Miklos Gergely)

miklosgergely opened a new pull request #1222: URL: https://github.com/apache/hive/pull/1222 Driver is now cut down to it's minimal size by extracting all of it's sub tasks to separate classes. The rest should be cleaned up by - moving out some smaller parts of the code to sub task

[GitHub] [hive] pvary commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

pvary commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r451351199 ## File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java ## @@ -1959,6 +1959,28 @@ public

[GitHub] [hive] kishendas commented on pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

kishendas commented on pull request #1217: URL: https://github.com/apache/hive/pull/1217#issuecomment-655338122 @pvary Addressed all your comments and rebased with master. This is an automated message from the Apache Git

[GitHub] [hive] kishendas commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

kishendas commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r451334032 ## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ## @@ -3284,6 +3299,8 @@ public Partition getPartition(Table tbl, Map partSpec,