Re: [PR] HIVE-27509: query-executors fail to start: java.lang.NoSuchFieldError… [hive]

2023-10-10 Thread via GitHub
mayankkunwar commented on code in PR #4758: URL: https://github.com/apache/hive/pull/4758#discussion_r1354015620 ## common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java: ## @@ -95,6 +95,9 @@ public void testConfProperties() throws Exception { // Test HiveConf pro

[PR] HIVE-27785: Backport of HIVE-20467, HIVE-20508, HIVE-20550 [hive]

2023-10-10 Thread via GitHub
amanraj2520 opened a new pull request, #4790: URL: https://github.com/apache/hive/pull/4790 JIRA link - HIVE-27785 Backports HIVE-20467, HIVE-20508, HIVE-20550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] HIVE-27784: Backport of HIVE-20364, HIVE-20549 to branch-3 [hive]

2023-10-10 Thread via GitHub
amanraj2520 opened a new pull request, #4789: URL: https://github.com/apache/hive/pull/4789 JIRA link - HIVE-27784 This ticket backports HIVE-20364, HIVE-20549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] HIVE-27559: Query hangs while trying to determine if the LIKE clause can be chained [hive]

2023-10-10 Thread via GitHub
github-actions[bot] closed pull request #4541: HIVE-27559: Query hangs while trying to determine if the LIKE clause can be chained URL: https://github.com/apache/hive/pull/4541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HIVE-27370: support 4 bytes characters [hive]

2023-10-10 Thread via GitHub
github-actions[bot] closed pull request #4374: HIVE-27370: support 4 bytes characters URL: https://github.com/apache/hive/pull/4374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] HIVE-27446: Exception when rebuild materialized view incrementally in presence of delete operations [hive]

2023-10-10 Thread via GitHub
github-actions[bot] closed pull request #4427: HIVE-27446: Exception when rebuild materialized view incrementally in presence of delete operations URL: https://github.com/apache/hive/pull/4427 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] HIVE-23127 Replace listPartitionsByExpr with GetPartitionsWithSpecs i… [hive]

2023-10-10 Thread via GitHub
github-actions[bot] closed pull request #4519: HIVE-23127 Replace listPartitionsByExpr with GetPartitionsWithSpecs i… URL: https://github.com/apache/hive/pull/4519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] HIVE-27772: Hive UNIX_TIMESTAMP() should return null for invalid dates [hive]

2023-10-10 Thread via GitHub
sonarcloud[bot] commented on PR #4777: URL: https://github.com/apache/hive/pull/4777#issuecomment-1756458910 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27499: Include optional db/table names in the NotificationEvent … [hive]

2023-10-10 Thread via GitHub
VenuReddy2103 commented on code in PR #4569: URL: https://github.com/apache/hive/pull/4569#discussion_r1353584451 ## standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0-beta-2.mssql.sql: ## @@ -661,6 +661,8 @@ ALTER TABLE NOTIFICATION_LOG ADD CONSTRAINT N

Re: [PR] Bump org.eclipse.jetty:jetty-http from 9.4.45.v20220203 to 9.4.53.v20231009 [hive]

2023-10-10 Thread via GitHub
sonarcloud[bot] commented on PR #4788: URL: https://github.com/apache/hive/pull/4788#issuecomment-1756358540 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] Bump org.eclipse.jetty:jetty-http from 9.4.40.v20210413 to 9.4.52.v20230823 [hive]

2023-10-10 Thread via GitHub
dependabot[bot] commented on PR #4699: URL: https://github.com/apache/hive/pull/4699#issuecomment-1756278512 Superseded by #4788. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Bump org.eclipse.jetty:jetty-http from 9.4.40.v20210413 to 9.4.52.v20230823 [hive]

2023-10-10 Thread via GitHub
dependabot[bot] closed pull request #4699: Bump org.eclipse.jetty:jetty-http from 9.4.40.v20210413 to 9.4.52.v20230823 URL: https://github.com/apache/hive/pull/4699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Bump org.eclipse.jetty:jetty-http from 9.4.45.v20220203 to 9.4.53.v20231009 [hive]

2023-10-10 Thread via GitHub
dependabot[bot] opened a new pull request, #4788: URL: https://github.com/apache/hive/pull/4788 Bumps [org.eclipse.jetty:jetty-http](https://github.com/eclipse/jetty.project) from 9.4.45.v20220203 to 9.4.53.v20231009. Release notes Sourced from https://github.com/eclipse/jetty.pro

Re: [PR] HIVE-27772: Hive UNIX_TIMESTAMP() should return null for invalid dates [hive]

2023-10-10 Thread via GitHub
simhadri-g commented on code in PR #4777: URL: https://github.com/apache/hive/pull/4777#discussion_r1353244254 ## ql/src/java/org/apache/hadoop/hive/ql/udf/generic/InstantDateTimeFormatter.java: ## @@ -25,15 +25,20 @@ import java.time.LocalDate; import java.time.ZoneId; impor

Re: [PR] HIVE-27751 Log Query Compilation summary in an accumulated way [hive]

2023-10-10 Thread via GitHub
sonarcloud[bot] commented on PR #4755: URL: https://github.com/apache/hive/pull/4755#issuecomment-1755997109 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27531: Unparse identifiers in show create table output [hive]

2023-10-10 Thread via GitHub
sonarcloud[bot] commented on PR #4779: URL: https://github.com/apache/hive/pull/4779#issuecomment-1755925092 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27761: Addendum: Compilation of nested CTEs throws SemanticExcep… [hive]

2023-10-10 Thread via GitHub
kasakrisz merged PR #4778: URL: https://github.com/apache/hive/pull/4778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.

Re: [PR] HIVE-27772: Hive UNIX_TIMESTAMP() should return null for invalid dates [hive]

2023-10-10 Thread via GitHub
simhadri-g commented on code in PR #4777: URL: https://github.com/apache/hive/pull/4777#discussion_r1353019825 ## ql/src/java/org/apache/hadoop/hive/ql/udf/generic/InstantDateTimeFormatter.java: ## @@ -49,7 +54,7 @@ public Instant parse(String text, String pattern) { Object

Re: [PR] HIVE-27772: Hive UNIX_TIMESTAMP() should return null for invalid dates [hive]

2023-10-10 Thread via GitHub
simhadri-g commented on PR #4777: URL: https://github.com/apache/hive/pull/4777#issuecomment-1755881733 Thanks @zabetak for the review :) . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] HIVE-27772: Hive UNIX_TIMESTAMP() should return null for invalid dates [hive]

2023-10-10 Thread via GitHub
simhadri-g commented on code in PR #4777: URL: https://github.com/apache/hive/pull/4777#discussion_r1352977575 ## ql/src/test/queries/clientpositive/test_unixtimestamp_for_invaild_dates.q: ## @@ -0,0 +1,20 @@ +DESCRIBE FUNCTION UNIX_TIMESTAMP; Review Comment: Sure , i have a

Re: [PR] HIVE-27772: Hive UNIX_TIMESTAMP() should return null for invalid dates [hive]

2023-10-10 Thread via GitHub
simhadri-g commented on code in PR #4777: URL: https://github.com/apache/hive/pull/4777#discussion_r1352971210 ## ql/src/test/queries/clientpositive/test_unixtimestamp_for_invaild_dates.q: ## @@ -0,0 +1,20 @@ +DESCRIBE FUNCTION UNIX_TIMESTAMP; Review Comment: Sure, i hav

Re: [PR] HIVE-27779: Iceberg: Drop partition support [hive]

2023-10-10 Thread via GitHub
aturoczy commented on PR #4785: URL: https://github.com/apache/hive/pull/4785#issuecomment-1755741689 The test is failed and it seems like it related to the change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] HIVE-27169: New Locked List to prevent configuration change at runtime without throwing error [hive]

2023-10-10 Thread via GitHub
pkumarsinha commented on code in PR #4731: URL: https://github.com/apache/hive/pull/4731#discussion_r1352815310 ## ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java: ## @@ -1321,6 +1321,45 @@ public void printInfo(String info, String detail, boolean isSilent) {

Re: [PR] HIVE-27686 ORC upgraded to 1.8.5. [hive]

2023-10-10 Thread via GitHub
abstractdog commented on code in PR #4690: URL: https://github.com/apache/hive/pull/4690#discussion_r1352705834 ## ql/src/test/org/apache/hadoop/hive/ql/TestTxnNoBuckets.java: ## @@ -848,7 +848,7 @@ public void testCompactStatsGather() throws Exception { .getParamet

Re: [PR] HIVE-27686 ORC upgraded to 1.8.5. [hive]

2023-10-10 Thread via GitHub
abstractdog commented on code in PR #4690: URL: https://github.com/apache/hive/pull/4690#discussion_r1352666151 ## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java: ## @@ -108,8 +108,8 @@ private void testRebalanceCompactionWith

Re: [PR] HIVE-27686 ORC upgraded to 1.8.5. [hive]

2023-10-10 Thread via GitHub
abstractdog commented on code in PR #4690: URL: https://github.com/apache/hive/pull/4690#discussion_r1352666151 ## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java: ## @@ -108,8 +108,8 @@ private void testRebalanceCompactionWith

Re: [PR] HIVE-27686 ORC upgraded to 1.8.5. [hive]

2023-10-10 Thread via GitHub
abstractdog commented on code in PR #4690: URL: https://github.com/apache/hive/pull/4690#discussion_r1352666151 ## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java: ## @@ -108,8 +108,8 @@ private void testRebalanceCompactionWith

Re: [PR] HIVE-27637: Compare highest write ID of compaction records when tryin… [hive]

2023-10-10 Thread via GitHub
sonarcloud[bot] commented on PR #4740: URL: https://github.com/apache/hive/pull/4740#issuecomment-1755522485 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27686 ORC upgraded to 1.8.5. [hive]

2023-10-10 Thread via GitHub
zratkai commented on code in PR #4690: URL: https://github.com/apache/hive/pull/4690#discussion_r1352596270 ## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java: ## @@ -108,8 +108,8 @@ private void testRebalanceCompactionWithPara

Re: [PR] HIVE-27686 ORC upgraded to 1.8.5. [hive]

2023-10-10 Thread via GitHub
abstractdog commented on code in PR #4690: URL: https://github.com/apache/hive/pull/4690#discussion_r1352580100 ## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java: ## @@ -108,8 +108,8 @@ private void testRebalanceCompactionWith

Re: [PR] HIVE-27637: Compare highest write ID of compaction records when tryin… [hive]

2023-10-10 Thread via GitHub
InvisibleProgrammer closed pull request #4740: HIVE-27637: Compare highest write ID of compaction records when tryin… URL: https://github.com/apache/hive/pull/4740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] HIVE-27686 ORC upgraded to 1.8.5. [hive]

2023-10-10 Thread via GitHub
zratkai commented on code in PR #4690: URL: https://github.com/apache/hive/pull/4690#discussion_r1352276107 ## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java: ## @@ -826,7 +835,7 @@ public void testStatsAfterQueryCompactionOnTe

Re: [PR] HIVE-27773 get_valid_write_ids is being called multiple times for a single query [hive]

2023-10-10 Thread via GitHub
sonarcloud[bot] commented on PR #4787: URL: https://github.com/apache/hive/pull/4787#issuecomment-1755078696 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27733: ensure PerfLogger is thread-safe; [hive]

2023-10-10 Thread via GitHub
ayushtkn merged PR #4749: URL: https://github.com/apache/hive/pull/4749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.o

[PR] HIVE-27773 get_valid_write_ids is being called multiple times for a single query [hive]

2023-10-10 Thread via GitHub
ramesh0201 opened a new pull request, #4787: URL: https://github.com/apache/hive/pull/4787 ### What changes were proposed in this pull request? get_valid_write_ids gets called multiple times for the same transaction list and set of tables for a query. Subsequent calls can make use of

Re: [PR] HIVE-27783: Iceberg: Implement Copy-On-Write for Update queries [hive]

2023-10-10 Thread via GitHub
zhangbutao commented on code in PR #4781: URL: https://github.com/apache/hive/pull/4781#discussion_r1351933080 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -1590,10 +1593,18 @@ public Map getNativeProperties(org.apach

Re: [PR] HIVE-27783: Iceberg: Implement Copy-On-Write for Update queries [hive]

2023-10-10 Thread via GitHub
kasakrisz commented on code in PR #4781: URL: https://github.com/apache/hive/pull/4781#discussion_r1351867614 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -1590,10 +1593,18 @@ public Map getNativeProperties(org.apache

Re: [PR] HIVE-27783: Iceberg: Implement Copy-On-Write for Update queries [hive]

2023-10-10 Thread via GitHub
sonarcloud[bot] commented on PR #4781: URL: https://github.com/apache/hive/pull/4781#issuecomment-1754713143 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27747: Generalize TestSchemaToolForMetastore to run on every suported DBMS [hive]

2023-10-10 Thread via GitHub
dengzhhu653 commented on PR #4754: URL: https://github.com/apache/hive/pull/4754#issuecomment-1754619038 Thanks @zabetak! I don't realize we have `DbInstallBase` to test default installation and validation, this `TestSchemaToolForMetastore` can act as a validator for some corner cases, s

Re: [PR] HIVE-27686 ORC upgraded to 1.8.5. [hive]

2023-10-10 Thread via GitHub
zhangbutao commented on code in PR #4690: URL: https://github.com/apache/hive/pull/4690#discussion_r1351766515 ## ql/src/test/org/apache/hadoop/hive/ql/TestTxnNoBuckets.java: ## @@ -848,7 +848,7 @@ public void testCompactStatsGather() throws Exception { .getParamete

Re: [PR] HIVE-27779: Iceberg: Drop partition support [hive]

2023-10-10 Thread via GitHub
sonarcloud[bot] commented on PR #4785: URL: https://github.com/apache/hive/pull/4785#issuecomment-1754603819 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27762: ObjectStore GetHelper do not need run jdo query if direct sql exception is unrecoverable [hive]

2023-10-10 Thread via GitHub
wecharyu commented on PR #4767: URL: https://github.com/apache/hive/pull/4767#issuecomment-1754581063 @deniskuzZ @zabetak @saihemanth-cloudera: could you help review this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HIVE-27686 ORC upgraded to 1.8.5. [hive]

2023-10-10 Thread via GitHub
zratkai commented on code in PR #4690: URL: https://github.com/apache/hive/pull/4690#discussion_r1351722798 ## ql/src/test/org/apache/hadoop/hive/ql/TestTxnNoBuckets.java: ## @@ -848,7 +848,7 @@ public void testCompactStatsGather() throws Exception { .getParameters(

Re: [PR] HIVE-27731: Iceberg: Perform metadata delete for queries with static filters [hive]

2023-10-10 Thread via GitHub
kasakrisz commented on code in PR #4748: URL: https://github.com/apache/hive/pull/4748#discussion_r1351718594 ## ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java: ## @@ -287,6 +299,29 @@ private void reparseAndSuperAnalyze(ASTNode tree, Table mTable