sonarcloud[bot] commented on PR #4791:
URL: https://github.com/apache/hive/pull/4791#issuecomment-1758911647
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
rkirtir commented on code in PR #4791:
URL: https://github.com/apache/hive/pull/4791#discussion_r1356040552
##
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/schematool/TestSchemaToolForMetastore.java:
##
@@ -467,6 +471,18 @@ public vo
rkirtir commented on code in PR #4791:
URL: https://github.com/apache/hive/pull/4791#discussion_r1356026283
##
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/schematool/TestSchemaToolForMetastore.java:
##
@@ -467,6 +471,18 @@ public vo
rkirtir commented on code in PR #4791:
URL: https://github.com/apache/hive/pull/4791#discussion_r1356026164
##
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/schematool/TestSchemaToolForMetastore.java:
##
@@ -467,6 +471,18 @@ public vo
sonarcloud[bot] commented on PR #4796:
URL: https://github.com/apache/hive/pull/4796#issuecomment-1758862102
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #4793:
URL: https://github.com/apache/hive/pull/4793#issuecomment-1758822236
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
xiaolin84250 opened a new pull request, #4796:
URL: https://github.com/apache/hive/pull/4796
hive.metastore.warehouse.dir, this configuration item is configured
incorrectly, causing the configuration item to not take effect.
bug image:
![image](https://github.com/apache/hive/asset
xiaolin84250 closed pull request #4795: HIVE-27787 Corrected wrong hive-site.xml
URL: https://github.com/apache/hive/pull/4795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
xiaolin84250 opened a new pull request, #4795:
URL: https://github.com/apache/hive/pull/4795
hive.metastore.warehouse.dir, this configuration item is configured
incorrectly, causing the configuration item to not take effect.
bug image:
![image](https://github.com/apache/hive/asset
sonarcloud[bot] commented on PR #4761:
URL: https://github.com/apache/hive/pull/4761#issuecomment-1758658364
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
saihemanth-cloudera commented on PR #4678:
URL: https://github.com/apache/hive/pull/4678#issuecomment-1758639171
@wecharyu - I'm happy to approve this PR if you can get a green run on the
Jenkins tests (unrelated test failure).
--
This is an automated message from the Apache Git Service.
sonarcloud[bot] commented on PR #4794:
URL: https://github.com/apache/hive/pull/4794#issuecomment-1758636298
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #4793:
URL: https://github.com/apache/hive/pull/4793#issuecomment-1758577654
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
dependabot[bot] opened a new pull request, #4794:
URL: https://github.com/apache/hive/pull/4794
Bumps org.apache.zookeeper:zookeeper from 3.7.1 to 3.7.2.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apach
ayushtkn commented on PR #4792:
URL: https://github.com/apache/hive/pull/4792#issuecomment-1758532009
can we run the flaky job for ``TestMiniTezCliDriver`` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
sonarcloud[bot] commented on PR #4777:
URL: https://github.com/apache/hive/pull/4777#issuecomment-1758526124
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
simhadri-g commented on code in PR #4777:
URL: https://github.com/apache/hive/pull/4777#discussion_r1355700050
##
ql/src/test/resources/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFToUnixTimestampEvaluateStringString.csv:
##
@@ -1,54 +1,128 @@
-1970-01-01 00:00:00;-MM
simhadri-g commented on code in PR #4777:
URL: https://github.com/apache/hive/pull/4777#discussion_r1355699567
##
ql/src/test/resources/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFToUnixTimestampEvaluateStringString.csv:
##
@@ -1,54 +1,128 @@
-1970-01-01 00:00:00;-MM
simhadri-g commented on code in PR #4777:
URL: https://github.com/apache/hive/pull/4777#discussion_r1355699322
##
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##
@@ -3860,6 +3860,17 @@ public static enum ConfVars {
"is discouraged. It suffers from known bu
simhadri-g commented on code in PR #4777:
URL: https://github.com/apache/hive/pull/4777#discussion_r1355698666
##
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/InstantFormatter.java:
##
@@ -56,16 +57,16 @@ InstantFormatter newFormatter(ZoneId zone) {
*/
DATETIME {
sonarcloud[bot] commented on PR #4783:
URL: https://github.com/apache/hive/pull/4783#issuecomment-1758345447
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
scarlin-cloudera commented on code in PR #4783:
URL: https://github.com/apache/hive/pull/4783#discussion_r1355515696
##
ql/src/test/queries/clientpositive/multi_insert_gby5.q:
##
@@ -0,0 +1,16 @@
+set hive.cbo.fallback.strategy=NEVER;
+
+CREATE TABLE tbl1 (key int, f1 int);
+CRE
scarlin-cloudera commented on code in PR #4783:
URL: https://github.com/apache/hive/pull/4783#discussion_r1355477882
##
ql/src/test/results/clientpositive/llap/multi_insert_gby5.q.out:
##
@@ -0,0 +1,250 @@
+PREHOOK: query: CREATE TABLE tbl1 (key int, f1 int)
+PREHOOK: type: CREA
scarlin-cloudera commented on code in PR #4783:
URL: https://github.com/apache/hive/pull/4783#discussion_r1355476622
##
ql/src/test/results/clientpositive/llap/multi_insert_gby5.q.out:
##
@@ -0,0 +1,250 @@
+PREHOOK: query: CREATE TABLE tbl1 (key int, f1 int)
+PREHOOK: type: CREA
scarlin-cloudera commented on code in PR #4783:
URL: https://github.com/apache/hive/pull/4783#discussion_r1355474928
##
ql/src/test/results/clientpositive/llap/multi_insert_gby5.q.out:
##
@@ -0,0 +1,250 @@
+PREHOOK: query: CREATE TABLE tbl1 (key int, f1 int)
+PREHOOK: type: CREA
zabetak closed pull request #4754: HIVE-27747: Generalize
TestSchemaToolForMetastore to run on every suported DBMS
URL: https://github.com/apache/hive/pull/4754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
sonarcloud[bot] commented on PR #4757:
URL: https://github.com/apache/hive/pull/4757#issuecomment-1758092042
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #4793:
URL: https://github.com/apache/hive/pull/4793#issuecomment-1758033719
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
simhadri-g commented on code in PR #4777:
URL: https://github.com/apache/hive/pull/4777#discussion_r1355216984
##
ql/src/test/resources/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFToUnixTimestampEvaluateStringString.csv:
##
@@ -1,54 +1,128 @@
-1970-01-01 00:00:00;-MM
simhadri-g commented on code in PR #4777:
URL: https://github.com/apache/hive/pull/4777#discussion_r1355208165
##
ql/src/test/queries/clientpositive/test_unixtimestamp_for_invaild_dates.q:
##
@@ -0,0 +1,20 @@
+DESCRIBE FUNCTION UNIX_TIMESTAMP;
Review Comment:
With this PR:
zabetak commented on code in PR #4783:
URL: https://github.com/apache/hive/pull/4783#discussion_r1355049106
##
ql/src/test/results/clientpositive/llap/multi_insert_gby5.q.out:
##
@@ -0,0 +1,250 @@
+PREHOOK: query: CREATE TABLE tbl1 (key int, f1 int)
+PREHOOK: type: CREATETABLE
+
sonarcloud[bot] commented on PR #4785:
URL: https://github.com/apache/hive/pull/4785#issuecomment-1757790952
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #4748:
URL: https://github.com/apache/hive/pull/4748#issuecomment-1757763179
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
simhadri-g commented on code in PR #4777:
URL: https://github.com/apache/hive/pull/4777#discussion_r1355027302
##
ql/src/test/queries/clientpositive/test_unixtimestamp_for_invaild_dates.q:
##
@@ -0,0 +1,20 @@
+DESCRIBE FUNCTION UNIX_TIMESTAMP;
Review Comment:
Tested Without
zabetak commented on code in PR #4791:
URL: https://github.com/apache/hive/pull/4791#discussion_r1354900459
##
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/schematool/TestSchemaToolForMetastore.java:
##
@@ -467,6 +471,18 @@ public vo
ayushtkn opened a new pull request, #4793:
URL: https://github.com/apache/hive/pull/4793
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-
dengzhhu653 merged PR #4774:
URL: https://github.com/apache/hive/pull/4774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach
InvisibleProgrammer commented on PR #4740:
URL: https://github.com/apache/hive/pull/4740#issuecomment-1757650756
@SourabhBadhya , can I ask you to review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
SourabhBadhya commented on code in PR #4748:
URL: https://github.com/apache/hive/pull/4748#discussion_r1354920338
##
ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java:
##
@@ -287,6 +299,29 @@ private void reparseAndSuperAnalyze(ASTNode tree, Table
mT
zratkai commented on code in PR #4690:
URL: https://github.com/apache/hive/pull/4690#discussion_r1354881360
##
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java:
##
@@ -108,8 +108,8 @@ private void
testRebalanceCompactionWithPara
zabetak commented on code in PR #4777:
URL: https://github.com/apache/hive/pull/4777#discussion_r1354460818
##
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFToUnixTimestampEvaluateStringString.java:
##
@@ -91,7 +95,22 @@ public void testEvaluate() throws HiveEx
zratkai commented on code in PR #4690:
URL: https://github.com/apache/hive/pull/4690#discussion_r1354878020
##
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java:
##
@@ -108,8 +108,8 @@ private void
testRebalanceCompactionWithPara
zratkai commented on code in PR #4690:
URL: https://github.com/apache/hive/pull/4690#discussion_r1354876487
##
ql/src/test/org/apache/hadoop/hive/ql/TestTxnNoBuckets.java:
##
@@ -848,7 +848,7 @@ public void testCompactStatsGather() throws Exception {
.getParameters(
sonarcloud[bot] commented on PR #4792:
URL: https://github.com/apache/hive/pull/4792#issuecomment-1757476619
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #4740:
URL: https://github.com/apache/hive/pull/4740#issuecomment-1757474287
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #4791:
URL: https://github.com/apache/hive/pull/4791#issuecomment-1757344013
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
zabetak opened a new pull request, #4792:
URL: https://github.com/apache/hive/pull/4792
### What changes were proposed in this pull request?
Increase max heap space for Tez Application master to 512MB.
### Why are the changes needed?
java.lang.OutOfMemoryError: GC overhead limit
sonarcloud[bot] commented on PR #4731:
URL: https://github.com/apache/hive/pull/4731#issuecomment-1757288225
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
abstractdog commented on code in PR #4690:
URL: https://github.com/apache/hive/pull/4690#discussion_r1354559556
##
ql/src/test/org/apache/hadoop/hive/ql/TestTxnNoBuckets.java:
##
@@ -848,7 +848,7 @@ public void testCompactStatsGather() throws Exception {
.getParamet
abstractdog commented on code in PR #4690:
URL: https://github.com/apache/hive/pull/4690#discussion_r1354559556
##
ql/src/test/org/apache/hadoop/hive/ql/TestTxnNoBuckets.java:
##
@@ -848,7 +848,7 @@ public void testCompactStatsGather() throws Exception {
.getParamet
sonarcloud[bot] commented on PR #4777:
URL: https://github.com/apache/hive/pull/4777#issuecomment-1757141031
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
rkirtir commented on PR #4791:
URL: https://github.com/apache/hive/pull/4791#issuecomment-1757119534
@zabetak Would like to have your review on this. This is created as per
suggestion given at https://github.com/apache/hive/pull/4750
--
This is an automated message from the Apache Git Ser
rkirtir opened a new pull request, #4791:
URL: https://github.com/apache/hive/pull/4791
### What changes were proposed in this pull request?
After every release, stream gets updated with newer hive-version and related
short-version. This test makes sure hive short version is part
Aggarwal-Raghav commented on code in PR #4731:
URL: https://github.com/apache/hive/pull/4731#discussion_r1354327832
##
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java:
##
@@ -1321,6 +1321,45 @@ public void printInfo(String info, String detail,
boolean isSilent)
InvisibleProgrammer commented on PR #4740:
URL: https://github.com/apache/hive/pull/4740#issuecomment-1757034146
> +1 I think it is fine. Also the test is also kinda ok. Do you know need
anything that remain?
It seems I have one test to fix.
--
This is an automated message from the
55 matches
Mail list logo