Re: [PR] HIVE-25054: (2.3) Upgrade `jodd-core` dependency to get rid of CVE-2018-21234 [hive]

2023-12-06 Thread via GitHub
pan3793 commented on PR #4923: URL: https://github.com/apache/hive/pull/4923#issuecomment-1844770828 cc @sunchao @luciferyang @wangyum -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] HIVE-25054: (2.3) Upgrade `jodd-core` dependency to get rid of CVE-2018-21234 [hive]

2023-12-06 Thread via GitHub
pan3793 opened a new pull request, #4923: URL: https://github.com/apache/hive/pull/4923 ### What changes were proposed in this pull request? Backport HIVE-25054 to branch-2.3, to address CVE-2018-21234. ### Why are the changes needed? jodd CVE is listed in https:

Re: [PR] HIVE-27804 Implement batching in various getPartition calls which return auth info along with Partition List [hive]

2023-12-06 Thread via GitHub
vikramahuja1001 commented on code in PR #4807: URL: https://github.com/apache/hive/pull/4807#discussion_r1418456119 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/PartitionIterable.java: ## @@ -99,7 +99,11 @@ private void getNextBatch() { batchCounter++; }

Re: [PR] HIVE-27804 Implement batching in various getPartition calls which return auth info along with Partition List [hive]

2023-12-06 Thread via GitHub
vikramahuja1001 commented on code in PR #4807: URL: https://github.com/apache/hive/pull/4807#discussion_r1418456351 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: ## @@ -4385,6 +4419,33 @@ public List getPartitionsByNames(Table tbl, List partNames, b return p

Re: [PR] HIVE-27804 Implement batching in various getPartition calls which return auth info along with Partition List [hive]

2023-12-06 Thread via GitHub
vikramahuja1001 commented on code in PR #4807: URL: https://github.com/apache/hive/pull/4807#discussion_r1418455883 ## ql/src/test/org/apache/hadoop/hive/ql/exec/TestGetPartitionAuthWithBatches.java: ## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] HIVE-27804 Implement batching in various getPartition calls which return auth info along with Partition List [hive]

2023-12-06 Thread via GitHub
vikramahuja1001 commented on code in PR #4807: URL: https://github.com/apache/hive/pull/4807#discussion_r1418455651 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/PartitionIterable.java: ## @@ -150,18 +157,36 @@ public PartitionIterable(Hive db, Table table, Map partialParti

Re: [PR] HIVE-27746: Hive Metastore should send single AlterPartitionEvent wit… [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4820: URL: https://github.com/apache/hive/pull/4820#issuecomment-1844679688 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27911 : Drop database query failing with Invalid ACL Exception [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4901: URL: https://github.com/apache/hive/pull/4901#issuecomment-1844594101 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27714: Addendum: Iceberg: metadata location overrides can cause data breach - handling default locations. [hive]

2023-12-06 Thread via GitHub
ayushtkn merged PR #4921: URL: https://github.com/apache/hive/pull/4921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.o

Re: [PR] HIVE-27555: Upgrade issues with Kudu table on backend db [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4872: URL: https://github.com/apache/hive/pull/4872#issuecomment-1844281506 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27930: Insert/Load overwrite table partition does not clean up directory before overwriting [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4915: URL: https://github.com/apache/hive/pull/4915#issuecomment-1844211564 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27555: Upgrade issues with Kudu table on backend db [hive]

2023-12-06 Thread via GitHub
dengzhhu653 commented on code in PR #4872: URL: https://github.com/apache/hive/pull/4872#discussion_r1418252598 ## standalone-metastore/metastore-server/src/main/sql/derby/upgrade-4.0.0-alpha-2-to-4.0.0-beta-1.derby.sql: ## @@ -31,18 +31,19 @@ ALTER TABLE "APP"."METASTORE_DB_PRO

Re: [PR] HIVE-27801: Exists subquery rewrite results in a wrong plan [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4922: URL: https://github.com/apache/hive/pull/4922#issuecomment-1844140404 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27555: Upgrade issues with Kudu table on backend db [hive]

2023-12-06 Thread via GitHub
dengzhhu653 commented on code in PR #4872: URL: https://github.com/apache/hive/pull/4872#discussion_r1418247666 ## standalone-metastore/metastore-server/src/main/sql/derby/upgrade-4.0.0-alpha-2-to-4.0.0-beta-1.derby.sql: ## @@ -31,18 +31,19 @@ ALTER TABLE "APP"."METASTORE_DB_PRO

Re: [PR] HIVE-27928: Preparing for 4.1.0 development [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4914: URL: https://github.com/apache/hive/pull/4914#issuecomment-1844098311 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[PR] HIVE-27801: Exists subquery rewrite results in a wrong plan [hive]

2023-12-06 Thread via GitHub
deniskuzZ opened a new pull request, #4922: URL: https://github.com/apache/hive/pull/4922 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### Is the chang

Re: [PR] HIVE-27934: Fix incorrect description about the execution framework in README.md [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4917: URL: https://github.com/apache/hive/pull/4917#issuecomment-1843957412 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27930: Insert/Load overwrite table partition does not clean up directory before overwriting [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4915: URL: https://github.com/apache/hive/pull/4915#issuecomment-1843591203 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27714: Addendum: Iceberg: metadata location overrides can cause data breach - handling default locations. [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4921: URL: https://github.com/apache/hive/pull/4921#issuecomment-1843589887 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27653: Iceberg: Add conflictDetectionFilter to validate concurre… [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4761: URL: https://github.com/apache/hive/pull/4761#issuecomment-1843498648 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27937: Clarifying comments around tez container size [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4920: URL: https://github.com/apache/hive/pull/4920#issuecomment-1843454256 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27930: Insert overwrite table partition does not clean up directory before overwriting [hive]

2023-12-06 Thread via GitHub
KiranVelumuri commented on code in PR #4915: URL: https://github.com/apache/hive/pull/4915#discussion_r1417800663 ## ql/src/test/queries/clientpositive/insert_overwrite_drop_partition.q: ## @@ -0,0 +1,46 @@ +set hive.exec.dynamic.partition.mode=nonstrict; +set hive.stats.column.

Re: [PR] HIVE-27714: Iceberg: metadata location overrides can cause data breach - handling default locations. [hive]

2023-12-06 Thread via GitHub
ayushtkn commented on PR #4880: URL: https://github.com/apache/hive/pull/4880#issuecomment-1843429326 Thanx @nrg4878 for pointing it out, I have quickly fixed it in addendum PR at https://github.com/apache/hive/pull/4921 If you can help check if it is working fine for you. Not sure wh

[PR] HIVE-27926: Addendum: Iceberg: Allow restricting Iceberg data file reads to table location. [hive]

2023-12-06 Thread via GitHub
ayushtkn opened a new pull request, #4921: URL: https://github.com/apache/hive/pull/4921 ### What changes were proposed in this pull request? Move constant out of thrift gen file ### Why are the changes needed? Issues with build ### Does this PR introduce _any_ use

Re: [PR] HIVE-27714: Iceberg: metadata location overrides can cause data breach - handling default locations. [hive]

2023-12-06 Thread via GitHub
nrg4878 commented on PR #4880: URL: https://github.com/apache/hive/pull/4880#issuecomment-1843366265 @ayushtkn the hive_metastoreConstants is a generated class. We cannot make change to it directly. Any changes will have to be made to hive_metastore.thrift file. So this breaks the b

Re: [PR] HIVE-27911 : Drop database query failing with Invalid ACL Exception [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4901: URL: https://github.com/apache/hive/pull/4901#issuecomment-1843292677 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27934: Fix incorrect description about the execution framework in README.md [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4917: URL: https://github.com/apache/hive/pull/4917#issuecomment-1843269994 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27935: Add qtest for Avro invalid schema and field names [hive]

2023-12-06 Thread via GitHub
zhangbutao merged PR #4918: URL: https://github.com/apache/hive/pull/4918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache

Re: [PR] HIVE-27712: GenericUDAFNumericStatsEvaluator throws NPE [hive]

2023-12-06 Thread via GitHub
ayushtkn commented on PR #4909: URL: https://github.com/apache/hive/pull/4909#issuecomment-1843131192 if it is deprecated in the prev release, it can be removed in the master branch now -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] HIVE-27712: GenericUDAFNumericStatsEvaluator throws NPE [hive]

2023-12-06 Thread via GitHub
zhangbutao commented on PR #4909: URL: https://github.com/apache/hive/pull/4909#issuecomment-1843126998 > It should be in either of two states: either we remove it or fix it, if we are keeping it, it shouldn't be broken, if we plan to remove not now but in future then it should be in fixed

Re: [PR] Some GenericUDFs wrongly cast ObjectInspectors [hive]

2023-12-06 Thread via GitHub
okumin commented on PR #4896: URL: https://github.com/apache/hive/pull/4896#issuecomment-1843076592 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Some GenericUDFs wrongly cast ObjectInspectors [hive]

2023-12-06 Thread via GitHub
ayushtkn merged PR #4896: URL: https://github.com/apache/hive/pull/4896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.o

Re: [PR] HIVE-27517 SessionState is not correctly initialized when hive.security.authorization.createtable.group.grants is set to automatically grant privileges [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4694: URL: https://github.com/apache/hive/pull/4694#issuecomment-1843020986 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27712: GenericUDAFNumericStatsEvaluator throws NPE [hive]

2023-12-06 Thread via GitHub
ayushtkn commented on PR #4909: URL: https://github.com/apache/hive/pull/4909#issuecomment-1843011239 It should be in either of two states: either we remove it or fix it, if we are keeping it, it shouldn't be broken, if we plan to remove not now but in future then it should be in fixed stat

Re: [PR] HIVE-27690: Handle casting NULL literal to complex type [hive]

2023-12-06 Thread via GitHub
veghlaci05 commented on code in PR #4696: URL: https://github.com/apache/hive/pull/4696#discussion_r1417192870 ## ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToArray.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] HIVE-27934: Fix incorrect description about the execution framework in README.md [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4917: URL: https://github.com/apache/hive/pull/4917#issuecomment-1842848536 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27797 - Transactions that got timed out are not getting logged a… [hive]

2023-12-06 Thread via GitHub
deniskuzZ merged PR #4805: URL: https://github.com/apache/hive/pull/4805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.

Re: [PR] HIVE-27712: GenericUDAFNumericStatsEvaluator throws NPE [hive]

2023-12-06 Thread via GitHub
zhangbutao commented on PR #4909: URL: https://github.com/apache/hive/pull/4909#issuecomment-1842832316 > It seems that this patch can solve the problem, but I think my solution is more helpful because this is a bug for function compute_stats, that patch just deprecated the function compute

Re: [PR] HIVE-27555: Upgrade issues with Kudu table on backend db [hive]

2023-12-06 Thread via GitHub
deniskuzZ commented on PR #4872: URL: https://github.com/apache/hive/pull/4872#issuecomment-1842816361 @dengzhhu653 thanks for the patch! please fill the summary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HIVE-27555: Upgrade issues with Kudu table on backend db [hive]

2023-12-06 Thread via GitHub
deniskuzZ commented on code in PR #4872: URL: https://github.com/apache/hive/pull/4872#discussion_r1417244671 ## standalone-metastore/metastore-server/src/main/sql/derby/upgrade-4.0.0-alpha-2-to-4.0.0-beta-1.derby.sql: ## @@ -31,18 +31,19 @@ ALTER TABLE "APP"."METASTORE_DB_PROPE

Re: [PR] HIVE-27555: Upgrade issues with Kudu table on backend db [hive]

2023-12-06 Thread via GitHub
deniskuzZ commented on code in PR #4872: URL: https://github.com/apache/hive/pull/4872#discussion_r1417233592 ## standalone-metastore/metastore-server/src/main/sql/derby/upgrade-4.0.0-alpha-2-to-4.0.0-beta-1.derby.sql: ## @@ -31,18 +31,19 @@ ALTER TABLE "APP"."METASTORE_DB_PROPE

Re: [PR] HIVE-27555: Upgrade issues with Kudu table on backend db [hive]

2023-12-06 Thread via GitHub
deniskuzZ commented on code in PR #4872: URL: https://github.com/apache/hive/pull/4872#discussion_r1417233592 ## standalone-metastore/metastore-server/src/main/sql/derby/upgrade-4.0.0-alpha-2-to-4.0.0-beta-1.derby.sql: ## @@ -31,18 +31,19 @@ ALTER TABLE "APP"."METASTORE_DB_PROPE

[PR] HIVE-27937: Clarifying comments around tez container size [hive]

2023-12-06 Thread via GitHub
abstractdog opened a new pull request, #4920: URL: https://github.com/apache/hive/pull/4920 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### Is the change

Re: [PR] HIVE-27934: Fix doc README.md [hive]

2023-12-06 Thread via GitHub
zhangbutao commented on code in PR #4917: URL: https://github.com/apache/hive/pull/4917#discussion_r1417208789 ## README.md: ## @@ -24,7 +24,7 @@ subqueries, common table expressions, and more. Hive's SQL can also be extended with user code via user defined functions (UDFs),

Re: [PR] HIVE-27093: Fix NPE in initialize() of Partition class [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4073: URL: https://github.com/apache/hive/pull/4073#issuecomment-1842747323 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[PR] HIVE-27093: Fix NPE in initialize() of Partition class [hive]

2023-12-06 Thread via GitHub
wecharyu opened a new pull request, #4073: URL: https://github.com/apache/hive/pull/4073 ### What changes were proposed in this pull request? Check if the SD of a Partition exists to avoid NPE. ### Why are the changes needed? The Partition SD may lost in backend metadata dat

Re: [PR] HIVE-27911 : Drop database query failing with Invalid ACL Exception [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4901: URL: https://github.com/apache/hive/pull/4901#issuecomment-1842614426 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27934: Fix doc README.md [hive]

2023-12-06 Thread via GitHub
zabetak commented on code in PR #4917: URL: https://github.com/apache/hive/pull/4917#discussion_r1417068958 ## README.md: ## @@ -24,7 +24,7 @@ subqueries, common table expressions, and more. Hive's SQL can also be extended with user code via user defined functions (UDFs), use

Re: [PR] HIVE-27893 Add a range validator in hive.metastore.batch.retrieve.max to only have values greater than 0 [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4912: URL: https://github.com/apache/hive/pull/4912#issuecomment-1842581337 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27930: Insert overwrite table partition does not clean up directory before overwriting [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4915: URL: https://github.com/apache/hive/pull/4915#issuecomment-1842503772 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27712: GenericUDAFNumericStatsEvaluator throws NPE [hive]

2023-12-06 Thread via GitHub
sonarcloud[bot] commented on PR #4909: URL: https://github.com/apache/hive/pull/4909#issuecomment-1842479498 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality