[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-03 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464698359 ## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/ExecuteStatementAnalyzer.java ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache So

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-03 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464701187 ## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/ExecuteStatementAnalyzer.java ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache So

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-03 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464709177 ## File path: ql/src/java/org/apache/hadoop/hive/ql/plan/ExprDynamicParamDesc.java ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-03 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464710291 ## File path: ql/src/test/results/clientpositive/llap/prepare_plan.q.out ## @@ -0,0 +1,1575 @@ +PREHOOK: query: explain extended prepare pcount from sel

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-03 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464713600 ## File path: ql/src/test/results/clientpositive/llap/prepare_plan.q.out ## @@ -0,0 +1,1575 @@ +PREHOOK: query: explain extended prepare pcount from sel

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-03 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464714632 ## File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ## @@ -1619,6 +1620,9 @@ public static ColStatistics getColStatisticsFromExpr

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-03 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464721831 ## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/PrepareStatementAnalyzer.java ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Sof

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-03 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464722011 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java ## @@ -49,6 +50,8 @@ import com.google.common.collect.Lists; import com.go

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-03 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464722096 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/type/TypeCheckProcFactory.java ## @@ -283,6 +283,33 @@ public Object process(Node nd, Stack s

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-03 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464722308 ## File path: ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java ## @@ -205,7 +205,9 @@ DROP_MAPPING("DROP MAPPING", HiveParser.TOK_DROP_M

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-04 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r465349679 ## File path: ql/src/java/org/apache/hadoop/hive/ql/plan/ExprDynamicParamDesc.java ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-04 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r465356752 ## File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ## @@ -1619,6 +1620,9 @@ public static ColStatistics getColStatisticsFromExpr

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-04 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r465362372 ## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/ExecuteStatementAnalyzer.java ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache So

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-06 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r466531974 ## File path: ql/src/test/results/clientpositive/llap/prepare_plan.q.out ## @@ -0,0 +1,2512 @@ +PREHOOK: query: explain extended prepare pcount from sel

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-06 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r466533366 ## File path: ql/src/test/results/clientpositive/llap/udf_greatest.q.out ## @@ -63,7 +63,7 @@ STAGE PLANS: alias: src Row Limit Pe

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-06 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r466533583 ## File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ## @@ -1619,6 +1620,12 @@ public static ColStatistics getColStatisticsFromExp

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-06 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r466534477 ## File path: ql/src/test/queries/clientpositive/prepare_plan.q ## @@ -0,0 +1,113 @@ +--! qt:dataset:src +--! qt:dataset:alltypesorc + +set hive.explain

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-06 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r466561873 ## File path: parser/src/java/org/apache/hadoop/hive/ql/parse/PrepareStatementParser.g ## @@ -0,0 +1,66 @@ +/** + Licensed to the Apache Software Fou

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-06 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r466563430 ## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/ExecuteStatementAnalyzer.java ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache So

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-06 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r466567882 ## File path: ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java ## @@ -205,7 +205,9 @@ DROP_MAPPING("DROP MAPPING", HiveParser.TOK_DROP_M

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-06 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r466568964 ## File path: ql/src/test/results/clientpositive/llap/prepare_plan.q.out ## @@ -0,0 +1,1575 @@ +PREHOOK: query: explain extended prepare pcount from sel

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

2020-08-06 Thread GitBox
vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r466570882 ## File path: ql/src/test/results/clientpositive/llap/prepare_plan.q.out ## @@ -0,0 +1,1575 @@ +PREHOOK: query: explain extended prepare pcount from sel