[GitHub] [arrow] nevi-me commented on pull request #4140: ARROW-5123: [Rust] Parquet derive for simple structs

nevi-me commented on pull request #4140: URL: https://github.com/apache/arrow/pull/4140#issuecomment-691620839 @sunchao given the age of this PR, I'd like to propose merging it if CI is green, we can make further changes in separate PRs. I suspect that if people start using the functionali

[GitHub] [arrow] nevi-me commented on pull request #8174: ARROW-9848: [Rust] Implement 0.15 IPC alignment

nevi-me commented on pull request #8174: URL: https://github.com/apache/arrow/pull/8174#issuecomment-691617589 I'll look into the integration failures during the week, but it's C++ null arrays. I noticed similar failures when I was trying to read a null array from pyarrow. Seems I'm likely

[GitHub] [arrow] emkornfield commented on a change in pull request #8177: ARROW-8494: [C++] Full support for mixed lista and structs

emkornfield commented on a change in pull request #8177: URL: https://github.com/apache/arrow/pull/8177#discussion_r487483180 ## File path: cpp/src/parquet/level_conversion.cc ## @@ -18,176 +18,169 @@ #include #include -#if defined(ARROW_HAVE_BMI2) -#include -#endif +#

[GitHub] [arrow] github-actions[bot] commented on pull request #8177: ARROW-8494: [C++] Full support for mixed lista and structs

github-actions[bot] commented on pull request #8177: URL: https://github.com/apache/arrow/pull/8177#issuecomment-691614256 https://issues.apache.org/jira/browse/ARROW-8494 This is an automated message from the Apache Git Serv

[GitHub] [arrow] emkornfield commented on pull request #8156: ARROW-9810: [C++] Generalized nested reconstruction helpers

emkornfield commented on pull request #8156: URL: https://github.com/apache/arrow/pull/8156#issuecomment-691613607 Closing in favor of: https://github.com/apache/arrow/pull/8177 This is an automated message from the Apache Gi

[GitHub] [arrow] emkornfield closed pull request #8156: ARROW-9810: [C++] Generalized nested reconstruction helpers

emkornfield closed pull request #8156: URL: https://github.com/apache/arrow/pull/8156 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [arrow] emkornfield opened a new pull request #8177: ARROW-8494: [C++] Full support for mixed lista and structs

emkornfield opened a new pull request #8177: URL: https://github.com/apache/arrow/pull/8177 Also: ARROW-9810 (generalize rep/def level conversion to list lengths/bitmaps) This adds helper methods for reconstructing all necessary metadata for arrow types. For now this doesn't hand

[GitHub] [arrow] github-actions[bot] commented on pull request #8176: ARROW-9984: [Rust] [DataFusion] Minor cleanup DRY

github-actions[bot] commented on pull request #8176: URL: https://github.com/apache/arrow/pull/8176#issuecomment-691607059 https://issues.apache.org/jira/browse/ARROW-9984 This is an automated message from the Apache Git Serv

[GitHub] [arrow] jorgecarleitao opened a new pull request #8176: ARROW-9984: [Rust] [DataFusion] Minor cleanup DRY

jorgecarleitao opened a new pull request #8176: URL: https://github.com/apache/arrow/pull/8176 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [arrow] zeroshade commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client

zeroshade commented on pull request #8175: URL: https://github.com/apache/arrow/pull/8175#issuecomment-691602646 Tagging the people that were on the previous PR for visibility: @sbinet @mindhash @stuartcarnie could any / all of you have a look / review? Thanks much! ---

[GitHub] [arrow] arw2019 commented on a change in pull request #8145: ARROW-9967: [Python] Add compute module documentation

arw2019 commented on a change in pull request #8145: URL: https://github.com/apache/arrow/pull/8145#discussion_r487475288 ## File path: docs/source/cpp/compute.rst ## @@ -201,6 +201,11 @@ an ``Invalid`` :class:`Status` when overflow is detected. +--+--

[GitHub] [arrow] alamb commented on pull request #8161: ARROW-9961: [Rust][DataFusion] Make to_timestamp function parses timestamp without timezone offset as local

alamb commented on pull request #8161: URL: https://github.com/apache/arrow/pull/8161#issuecomment-691126612 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] nevi-me commented on pull request #8171: ARROW-9977: [Rust] Added min/max of [Large]StringArray

nevi-me commented on pull request #8171: URL: https://github.com/apache/arrow/pull/8171#issuecomment-691231822 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow] emkornfield commented on pull request #7979: ARROW-9766: [C++][Parquet] Add EngineVersion for toggling between new and old logic

emkornfield commented on pull request #7979: URL: https://github.com/apache/arrow/pull/7979#issuecomment-690915801 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] jhorstmann commented on pull request #8161: ARROW-9961: [Rust][DataFusion] Make to_timestamp function parses timestamp without timezone offset as local

jhorstmann commented on pull request #8161: URL: https://github.com/apache/arrow/pull/8161#issuecomment-691464193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] andygrove commented on pull request #7873: ARROW-9608: [Rust] Leaner feature gating for arrow in parquet

andygrove commented on pull request #7873: URL: https://github.com/apache/arrow/pull/7873#issuecomment-691512022 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] github-actions[bot] commented on pull request #8174: ARROW-9848: [Rust] Implement 0.15 IPC alignment

github-actions[bot] commented on pull request #8174: URL: https://github.com/apache/arrow/pull/8174#issuecomment-691508247 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow] alamb commented on a change in pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

alamb commented on a change in pull request #8172: URL: https://github.com/apache/arrow/pull/8172#discussion_r487395554 ## File path: rust/datafusion/src/physical_plan/expressions.rs ## @@ -125,192 +128,188 @@ pub fn sum_return_type(arg_type: &DataType) -> Result { } }

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8171: ARROW-9977: [Rust] Added min/max of [Large]StringArray

jorgecarleitao commented on a change in pull request #8171: URL: https://github.com/apache/arrow/pull/8171#discussion_r487430955 ## File path: rust/arrow/src/compute/kernels/aggregate.rs ## @@ -19,9 +19,42 @@ use std::ops::Add; -use crate::array::{Array, PrimitiveArray}; +

[GitHub] [arrow] nevi-me commented on a change in pull request #8173: ARROW-9980: [Rust] [Parquet] Fix clippy lints

nevi-me commented on a change in pull request #8173: URL: https://github.com/apache/arrow/pull/8173#discussion_r487447527 ## File path: rust/arrow/src/compute/kernels/aggregate.rs ## @@ -121,7 +121,7 @@ mod tests { #[test] fn test_primitive_array_float_sum() {

[GitHub] [arrow] andygrove closed pull request #7873: ARROW-9608: [Rust] Leaner feature gating for arrow in parquet

andygrove closed pull request #7873: URL: https://github.com/apache/arrow/pull/7873 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow] nevi-me commented on pull request #8168: ARROW-9979: [Rust] Fix arrow crate clippy lints

nevi-me commented on pull request #8168: URL: https://github.com/apache/arrow/pull/8168#issuecomment-691505185 Thanks @alamb @jorgecarleitao, I've opened https://issues.apache.org/jira/browse/ARROW-9978 to keep track of all clippy work. I'll wait for @andygrove and @paddyhoran's opinions b

[GitHub] [arrow] andygrove closed pull request #8168: ARROW-9979: [Rust] Fix arrow crate clippy lints

andygrove closed pull request #8168: URL: https://github.com/apache/arrow/pull/8168 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] github-actions[bot] commented on pull request #8173: ARROW-9980: [Rust] [Parquet] Fix clippy lints

github-actions[bot] commented on pull request #8173: URL: https://github.com/apache/arrow/pull/8173#issuecomment-691506541 https://issues.apache.org/jira/browse/ARROW-9980 This is an automated message from the Apache Git Serv

[GitHub] [arrow] jorgecarleitao closed pull request #8169: Improved performance of take by 50

jorgecarleitao closed pull request #8169: URL: https://github.com/apache/arrow/pull/8169 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] nevi-me closed pull request #8173: ARROW-9980: [Rust] [Parquet] Fix clippy lints

nevi-me closed pull request #8173: URL: https://github.com/apache/arrow/pull/8173 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] andygrove commented on pull request #8171: ARROW-9977: [Rust] Added min/max of [Large]StringArray

andygrove commented on pull request #8171: URL: https://github.com/apache/arrow/pull/8171#issuecomment-691512675 I think that @nevi-me 's suggestion addresses something that I've been trying to solve as well. Our kernels operate on arrays, so calling `a + b` is fine when both are arrays, b

[GitHub] [arrow] eerhardt closed pull request #8146: ARROW-5034: [C#] ArrowStreamWriter and ArrowFileWriter implement sync WriteRecordBatch

eerhardt closed pull request #8146: URL: https://github.com/apache/arrow/pull/8146 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [arrow] github-actions[bot] commented on pull request #8171: ARROW-9977: [Rust] Added min/max of [Large]StringArray

github-actions[bot] commented on pull request #8171: URL: https://github.com/apache/arrow/pull/8171#issuecomment-691218089 https://issues.apache.org/jira/browse/ARROW-9977 This is an automated message from the Apache Git Serv

[GitHub] [arrow] stuartcarnie commented on pull request #6731: [WIP] ARROW-8601: [Go][Flight] Added implementation of FlightDataWriter

stuartcarnie commented on pull request #6731: URL: https://github.com/apache/arrow/pull/6731#issuecomment-691351237 @zeroshade I have no problem if you want to create a new PR to take over this work. I would love to see something functional land in the Go implementation.

[GitHub] [arrow] nevi-me commented on pull request #8174: ARROW-9848: [Rust] Implement 0.15 IPC alignment

nevi-me commented on pull request #8174: URL: https://github.com/apache/arrow/pull/8174#issuecomment-691506881 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow] nevi-me commented on a change in pull request #8174: ARROW-9848: [Rust] Implement 0.15 IPC alignment

nevi-me commented on a change in pull request #8174: URL: https://github.com/apache/arrow/pull/8174#discussion_r487448427 ## File path: rust/arrow/src/ipc/mod.rs ## @@ -36,3 +36,4 @@ pub use self::gen::SparseTensor::*; pub use self::gen::Tensor::*; static ARROW_MAGIC: [u8;

[GitHub] [arrow] tianchen92 commented on a change in pull request #7887: ARROW-9304: [C++] Add "AppendEmpty" builder APIs for use inside StructBuilder::AppendNull

tianchen92 commented on a change in pull request #7887: URL: https://github.com/apache/arrow/pull/7887#discussion_r486768419 ## File path: cpp/src/arrow/array/builder_base.h ## @@ -98,6 +98,9 @@ class ARROW_EXPORT ArrayBuilder { virtual Status AppendNull() = 0; virtual St

[GitHub] [arrow] github-actions[bot] commented on pull request #8175: [WIP] ARROW-8601: [Go][Flight] Implementations Flight RPC server and client

github-actions[bot] commented on pull request #8175: URL: https://github.com/apache/arrow/pull/8175#issuecomment-691527891 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow] pwoody commented on a change in pull request #8167: ARROW-9973: [Java] JDBC DateConsumer does not allow dates before epoch

pwoody commented on a change in pull request #8167: URL: https://github.com/apache/arrow/pull/8167#discussion_r487010013 ## File path: java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/consumer/DateConsumer.java ## @@ -85,13 +85,13 @@ public void consume(ResultSet

[GitHub] [arrow] vertexclique commented on pull request #7873: ARROW-9608: [Rust] Leaner feature gating for arrow in parquet

vertexclique commented on pull request #7873: URL: https://github.com/apache/arrow/pull/7873#issuecomment-691518018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] andygrove commented on a change in pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

andygrove commented on a change in pull request #8172: URL: https://github.com/apache/arrow/pull/8172#discussion_r487426214 ## File path: rust/datafusion/src/physical_plan/planner.rs ## @@ -218,32 +217,18 @@ impl DefaultPhysicalPlanner { .collect::>>()?;

[GitHub] [arrow] ggershinsky commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

ggershinsky commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r486786803 ## File path: cpp/src/parquet/key_metadata.h ## @@ -0,0 +1,91 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] andygrove closed pull request #8144: ARROW-9950: [Rust] [DataFusion] Made UDFs usable without a registry

andygrove closed pull request #8144: URL: https://github.com/apache/arrow/pull/8144 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow] github-actions[bot] commented on pull request #8127: WIP: ARROW-8359: [C++/Python] Enable linux-aarch64 builds

github-actions[bot] commented on pull request #8127: URL: https://github.com/apache/arrow/pull/8127#issuecomment-690974243 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow] github-actions[bot] commented on pull request #8170: ARROW-9971: [Rust] Improve speed of `take` by 2x-3x (change scaling with batch size)

github-actions[bot] commented on pull request #8170: URL: https://github.com/apache/arrow/pull/8170#issuecomment-691124876 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow] kszucs commented on pull request #8127: WIP: ARROW-8359: [C++/Python] Enable linux-aarch64 builds

kszucs commented on pull request #8127: URL: https://github.com/apache/arrow/pull/8127#issuecomment-690973467 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] andygrove commented on pull request #8161: ARROW-9961: [Rust][DataFusion] Make to_timestamp function parses timestamp without timezone offset as local

andygrove commented on pull request #8161: URL: https://github.com/apache/arrow/pull/8161#issuecomment-691350548 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8170: ARROW-9971: [Rust] Improve speed of `take` by 2x-3x (change scaling with batch size)

jorgecarleitao commented on a change in pull request #8170: URL: https://github.com/apache/arrow/pull/8170#discussion_r487071953 ## File path: rust/arrow/src/compute/kernels/take.rs ## @@ -425,22 +514,32 @@ mod tests { #[test] fn test_take_string() { let inde

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8165: ARROW-9966: [Rust] Speedup kernels for sum,min,max by 10%-60%

jorgecarleitao commented on a change in pull request #8165: URL: https://github.com/apache/arrow/pull/8165#discussion_r486972953 ## File path: rust/arrow/src/compute/kernels/aggregate.rs ## @@ -27,40 +27,51 @@ pub fn min(array: &PrimitiveArray) -> Option where T: ArrowNu

[GitHub] [arrow] github-actions[bot] commented on pull request #8168: [DRAFT] Arrow clippy fixes

github-actions[bot] commented on pull request #8168: URL: https://github.com/apache/arrow/pull/8168#issuecomment-691029743 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow] nealrichardson closed pull request #8101: ARROW-9868: [C++][R] Provide CopyFiles for copying files between FileSystems

nealrichardson closed pull request #8101: URL: https://github.com/apache/arrow/pull/8101 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] alippai edited a comment on pull request #8162: ARROW-9962: [Python] Fix conversion to_pandas with tz-aware index column and fixed offset timezones

alippai edited a comment on pull request #8162: URL: https://github.com/apache/arrow/pull/8162#issuecomment-691047149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] andygrove commented on a change in pull request #8173: ARROW-9980: [Rust] [Parquet] Fix clippy lints

andygrove commented on a change in pull request #8173: URL: https://github.com/apache/arrow/pull/8173#discussion_r487438276 ## File path: rust/arrow/src/compute/kernels/aggregate.rs ## @@ -121,7 +121,7 @@ mod tests { #[test] fn test_primitive_array_float_sum() {

[GitHub] [arrow] nevi-me closed pull request #8157: ARROW-9957: [Rust] Replace tempdir with tempfile

nevi-me closed pull request #8157: URL: https://github.com/apache/arrow/pull/8157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] emkornfield commented on pull request #8156: ARROW-9810: [C++] Generalized nested reconstruction helpers

emkornfield commented on pull request #8156: URL: https://github.com/apache/arrow/pull/8156#issuecomment-690859782 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] xhochy commented on pull request #8127: WIP: ARROW-8359: [C++/Python] Enable linux-aarch64 builds

xhochy commented on pull request #8127: URL: https://github.com/apache/arrow/pull/8127#issuecomment-691066568 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] romainfrancois commented on pull request #7807: ARROW-6537 [R]: Pass column_types to CSV reader

romainfrancois commented on pull request #7807: URL: https://github.com/apache/arrow/pull/7807#issuecomment-691148776 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] sunchao commented on a change in pull request #8173: ARROW-9980: [Rust] [Parquet] Fix clippy lints

sunchao commented on a change in pull request #8173: URL: https://github.com/apache/arrow/pull/8173#discussion_r487436938 ## File path: rust/arrow/src/compute/kernels/aggregate.rs ## @@ -121,7 +121,7 @@ mod tests { #[test] fn test_primitive_array_float_sum() {

[GitHub] [arrow] alamb commented on pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

alamb commented on pull request #8172: URL: https://github.com/apache/arrow/pull/8172#issuecomment-691324132 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] nealrichardson commented on a change in pull request #8150: ARROW-9271: [R] Preserve data frame metadata in round trip

nealrichardson commented on a change in pull request #8150: URL: https://github.com/apache/arrow/pull/8150#discussion_r487119708 ## File path: r/tests/testthat/test-dataset.R ## @@ -890,6 +890,7 @@ test_that("Dataset writing: from data.frame", { select(string = chr, inte

[GitHub] [arrow] jhorstmann commented on a change in pull request #8173: ARROW-9980: [Rust] [Parquet] Fix clippy lints

jhorstmann commented on a change in pull request #8173: URL: https://github.com/apache/arrow/pull/8173#discussion_r487429355 ## File path: rust/arrow/src/compute/kernels/aggregate.rs ## @@ -121,7 +121,7 @@ mod tests { #[test] fn test_primitive_array_float_sum() {

[GitHub] [arrow] nevi-me commented on a change in pull request #8165: ARROW-9966: [Rust] Speedup kernels for sum,min,max by 10%-60%

nevi-me commented on a change in pull request #8165: URL: https://github.com/apache/arrow/pull/8165#discussion_r486971637 ## File path: rust/arrow/src/compute/kernels/aggregate.rs ## @@ -27,40 +27,51 @@ pub fn min(array: &PrimitiveArray) -> Option where T: ArrowNumericTy

[GitHub] [arrow] emkornfield commented on a change in pull request #7887: ARROW-9304: [C++] Add "AppendEmpty" builder APIs for use inside StructBuilder::AppendNull

emkornfield commented on a change in pull request #7887: URL: https://github.com/apache/arrow/pull/7887#discussion_r486759286 ## File path: cpp/src/arrow/array/builder_base.h ## @@ -98,6 +98,9 @@ class ARROW_EXPORT ArrayBuilder { virtual Status AppendNull() = 0; virtual S

[GitHub] [arrow] emkornfield closed pull request #7979: ARROW-9766: [C++][Parquet] Add EngineVersion for toggling between new and old logic

emkornfield closed pull request #7979: URL: https://github.com/apache/arrow/pull/7979 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] liyafan82 commented on a change in pull request #8167: ARROW-9973: [Java] JDBC DateConsumer does not allow dates before epoch

liyafan82 commented on a change in pull request #8167: URL: https://github.com/apache/arrow/pull/8167#discussion_r486998232 ## File path: java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/consumer/DateConsumer.java ## @@ -85,13 +85,13 @@ public void consume(ResultS

[GitHub] [arrow] andygrove closed pull request #8155: ARROW-9954: [Rust] [DataFusion] Made aggregates support the same signatures as functions.

andygrove closed pull request #8155: URL: https://github.com/apache/arrow/pull/8155 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow] andygrove closed pull request #8009: ARROW-9790: [Rust][Parquet]: Increase test coverage in arrow_reader.rs

andygrove closed pull request #8009: URL: https://github.com/apache/arrow/pull/8009 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow] zeroshade commented on pull request #6731: [WIP] ARROW-8601: [Go][Flight] Added implementation of FlightDataWriter

zeroshade commented on pull request #6731: URL: https://github.com/apache/arrow/pull/6731#issuecomment-691346806 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] jhorstmann commented on a change in pull request #8170: ARROW-9971: [Rust] Improve speed of `take` by 2x-3x (change scaling with batch size)

jhorstmann commented on a change in pull request #8170: URL: https://github.com/apache/arrow/pull/8170#discussion_r487396427 ## File path: rust/arrow/src/compute/kernels/take.rs ## @@ -166,42 +166,124 @@ fn take_primitive(values: &ArrayRef, indices: &UInt32Array) -> Result::ne

[GitHub] [arrow] nevi-me closed pull request #8165: ARROW-9966: [Rust] Speedup kernels for sum,min,max by 10%-60%

nevi-me closed pull request #8165: URL: https://github.com/apache/arrow/pull/8165 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] andygrove closed pull request #8161: ARROW-9961: [Rust][DataFusion] Make to_timestamp function parses timestamp without timezone offset as local

andygrove closed pull request #8161: URL: https://github.com/apache/arrow/pull/8161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow] nealrichardson closed pull request #8125: ARROW-9387: [R] Use new C++ table select method

nealrichardson closed pull request #8125: URL: https://github.com/apache/arrow/pull/8125 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] romainfrancois commented on pull request #8150: ARROW-9271: [R] Preserve data frame metadata in round trip

romainfrancois commented on pull request #8150: URL: https://github.com/apache/arrow/pull/8150#issuecomment-691051291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] mundaym commented on a change in pull request #8011: ARROW-9803: [Go] Add initial support for s390x

mundaym commented on a change in pull request #8011: URL: https://github.com/apache/arrow/pull/8011#discussion_r487033507 ## File path: go/arrow/type_traits_decimal128.go ## @@ -39,8 +40,13 @@ func (decimal128Traits) BytesRequired(n int) int { return Decimal128SizeBytes * /

[GitHub] [arrow] github-actions[bot] commented on pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

github-actions[bot] commented on pull request #8172: URL: https://github.com/apache/arrow/pull/8172#issuecomment-691326047 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow] andygrove commented on a change in pull request #8171: ARROW-9977: [Rust] Added min/max of [Large]StringArray

andygrove commented on a change in pull request #8171: URL: https://github.com/apache/arrow/pull/8171#discussion_r487425717 ## File path: rust/arrow/src/compute/kernels/aggregate.rs ## @@ -19,9 +19,42 @@ use std::ops::Add; -use crate::array::{Array, PrimitiveArray}; +use c

[GitHub] [arrow] nealrichardson commented on a change in pull request #8125: ARROW-9387: [R] Use new C++ table select method

nealrichardson commented on a change in pull request #8125: URL: https://github.com/apache/arrow/pull/8125#discussion_r487105657 ## File path: r/tests/testthat/test-Table.R ## @@ -130,16 +130,16 @@ test_that("[, [[, $ for Table", { expect_null(tab[["asdf"]]) # List-like c

[GitHub] [arrow] jorgecarleitao commented on pull request #8171: ARROW-9977: [Rust] Added min/max of [Large]StringArray

jorgecarleitao commented on pull request #8171: URL: https://github.com/apache/arrow/pull/8171#issuecomment-691402590 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] github-actions[bot] commented on pull request #8167: ARROW-9973: [Java] JDBC DateConsumer does not allow dates before epoch

github-actions[bot] commented on pull request #8167: URL: https://github.com/apache/arrow/pull/8167#issuecomment-690845681 https://issues.apache.org/jira/browse/ARROW-9973 This is an automated message from the Apache Git Serv

[GitHub] [arrow] andygrove commented on pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

andygrove commented on pull request #8172: URL: https://github.com/apache/arrow/pull/8172#issuecomment-691513935 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] nealrichardson closed pull request #8150: ARROW-9271: [R] Preserve data frame metadata in round trip

nealrichardson closed pull request #8150: URL: https://github.com/apache/arrow/pull/8150 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] alippai commented on pull request #8162: ARROW-9962: [Python] Fix conversion to_pandas with tz-aware index column and fixed offset timezones

alippai commented on pull request #8162: URL: https://github.com/apache/arrow/pull/8162#issuecomment-691047149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow] nevi-me commented on pull request #8168: ARROW-9979: [Rust] Fix arrow crate clippy lints

nevi-me commented on pull request #8168: URL: https://github.com/apache/arrow/pull/8168#issuecomment-691505185 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow] github-actions[bot] commented on pull request #8173: ARROW-9980: [Rust] [Parquet] Fix clippy lints

github-actions[bot] commented on pull request #8173: URL: https://github.com/apache/arrow/pull/8173#issuecomment-691506541 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow] jorgecarleitao closed pull request #8169: Improved performance of take by 50

jorgecarleitao closed pull request #8169: URL: https://github.com/apache/arrow/pull/8169 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] andygrove closed pull request #8168: ARROW-9979: [Rust] Fix arrow crate clippy lints

andygrove closed pull request #8168: URL: https://github.com/apache/arrow/pull/8168 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow] github-actions[bot] commented on pull request #8171: ARROW-9977: [Rust] Added min/max of [Large]StringArray

github-actions[bot] commented on pull request #8171: URL: https://github.com/apache/arrow/pull/8171#issuecomment-691218089 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow] andygrove commented on pull request #8171: ARROW-9977: [Rust] Added min/max of [Large]StringArray

andygrove commented on pull request #8171: URL: https://github.com/apache/arrow/pull/8171#issuecomment-691512675 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] eerhardt closed pull request #8146: ARROW-5034: [C#] ArrowStreamWriter and ArrowFileWriter implement sync WriteRecordBatch

eerhardt closed pull request #8146: URL: https://github.com/apache/arrow/pull/8146 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] stuartcarnie commented on pull request #6731: [WIP] ARROW-8601: [Go][Flight] Added implementation of FlightDataWriter

stuartcarnie commented on pull request #6731: URL: https://github.com/apache/arrow/pull/6731#issuecomment-691351237 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] nevi-me commented on pull request #8174: ARROW-9848: [Rust] Implement 0.15 IPC alignment

nevi-me commented on pull request #8174: URL: https://github.com/apache/arrow/pull/8174#issuecomment-691506881 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow] tianchen92 commented on a change in pull request #7887: ARROW-9304: [C++] Add "AppendEmpty" builder APIs for use inside StructBuilder::AppendNull

tianchen92 commented on a change in pull request #7887: URL: https://github.com/apache/arrow/pull/7887#discussion_r486737805 ## File path: cpp/src/arrow/array/builder_base.h ## @@ -98,6 +98,9 @@ class ARROW_EXPORT ArrayBuilder { virtual Status AppendNull() = 0; virtual St

[GitHub] [arrow] vertexclique commented on pull request #7873: ARROW-9608: [Rust] Leaner feature gating for arrow in parquet

vertexclique commented on pull request #7873: URL: https://github.com/apache/arrow/pull/7873#issuecomment-691518018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] pwoody commented on a change in pull request #8167: ARROW-9973: [Java] JDBC DateConsumer does not allow dates before epoch

pwoody commented on a change in pull request #8167: URL: https://github.com/apache/arrow/pull/8167#discussion_r487010013 ## File path: java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/consumer/DateConsumer.java ## @@ -85,13 +85,13 @@ public void consume(ResultSet

[GitHub] [arrow] github-actions[bot] commented on pull request #8175: [WIP] ARROW-8601: [Go][Flight] Implementations Flight RPC server and client

github-actions[bot] commented on pull request #8175: URL: https://github.com/apache/arrow/pull/8175#issuecomment-691527891 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow] ggershinsky commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

ggershinsky commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r486786803 ## File path: cpp/src/parquet/key_metadata.h ## @@ -0,0 +1,91 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] andygrove commented on a change in pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

andygrove commented on a change in pull request #8172: URL: https://github.com/apache/arrow/pull/8172#discussion_r487426214 ## File path: rust/datafusion/src/physical_plan/planner.rs ## @@ -218,32 +217,18 @@ impl DefaultPhysicalPlanner { .collect::>>()?;

[GitHub] [arrow] andygrove closed pull request #8144: ARROW-9950: [Rust] [DataFusion] Made UDFs usable without a registry

andygrove closed pull request #8144: URL: https://github.com/apache/arrow/pull/8144 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8165: ARROW-9966: [Rust] Speedup kernels for sum,min,max by 10%-60%

jorgecarleitao commented on a change in pull request #8165: URL: https://github.com/apache/arrow/pull/8165#discussion_r486972953 ## File path: rust/arrow/src/compute/kernels/aggregate.rs ## @@ -27,40 +27,51 @@ pub fn min(array: &PrimitiveArray) -> Option where T: ArrowNu

[GitHub] [arrow] github-actions[bot] commented on pull request #8170: ARROW-9971: [Rust] Improve speed of `take` by 2x-3x (change scaling with batch size)

github-actions[bot] commented on pull request #8170: URL: https://github.com/apache/arrow/pull/8170#issuecomment-691124876 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow] github-actions[bot] commented on pull request #8127: WIP: ARROW-8359: [C++/Python] Enable linux-aarch64 builds

github-actions[bot] commented on pull request #8127: URL: https://github.com/apache/arrow/pull/8127#issuecomment-690974243 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow] andygrove commented on pull request #8161: ARROW-9961: [Rust][DataFusion] Make to_timestamp function parses timestamp without timezone offset as local

andygrove commented on pull request #8161: URL: https://github.com/apache/arrow/pull/8161#issuecomment-691350548 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] kszucs commented on pull request #8127: WIP: ARROW-8359: [C++/Python] Enable linux-aarch64 builds

kszucs commented on pull request #8127: URL: https://github.com/apache/arrow/pull/8127#issuecomment-690973467 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] github-actions[bot] commented on pull request #8168: [DRAFT] Arrow clippy fixes

github-actions[bot] commented on pull request #8168: URL: https://github.com/apache/arrow/pull/8168#issuecomment-691029743 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

  1   2   3   >