arw2019 commented on issue #8610:
URL: https://github.com/apache/arrow/issues/8610#issuecomment-723526024
xref #8386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
shyamalschandra opened a new issue #8610:
URL: https://github.com/apache/arrow/issues/8610
Does Arrow work with Python 3.9+?
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
nealrichardson closed pull request #8547:
URL: https://github.com/apache/arrow/pull/8547
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
nealrichardson commented on pull request #8547:
URL: https://github.com/apache/arrow/pull/8547#issuecomment-72350
72 hours have passed so I've closed the lazy consensus vote at incubator:
https://lists.apache.org/thread.html/raa0c7dacd8022c4110774e1523a082afa374cb852c57a8d1ff5077b3%40%3
github-actions[bot] commented on pull request #8609:
URL: https://github.com/apache/arrow/pull/8609#issuecomment-723499160
https://issues.apache.org/jira/browse/ARROW-10513
This is an automated message from the Apache Git Ser
vertexclique opened a new pull request #8609:
URL: https://github.com/apache/arrow/pull/8609
todos:
- [x] gnu abi hf
- [ ] gnu abi
- [x] musl abi hf
- [ ] musl abi
- [ ] start ci for armv7
This is an au
jorgecarleitao commented on pull request #8543:
URL: https://github.com/apache/arrow/pull/8543#issuecomment-723480908
@alamb and @nevi-me , thanks a lot for taking the time to review this.
I have rebased this against master. I am fine with either order, rebasing
this one is tedious b
nevi-me closed pull request #8541:
URL: https://github.com/apache/arrow/pull/8541
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nevi-me commented on pull request #8541:
URL: https://github.com/apache/arrow/pull/8541#issuecomment-723471732
> @alamb , @nevi-me and @jhorstmann , thanks a lot for taking a close look
into this, also for the amazing work yesterday and today on reviewing and
merging stuff. Really impressi
vertexclique edited a comment on pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#issuecomment-723470048
I don't think that's needed at all. Optimizations were extremely premature.
We should have thought about the future beforehand. I think we are prolonging
the discussio
jorgecarleitao commented on pull request #8541:
URL: https://github.com/apache/arrow/pull/8541#issuecomment-723470287
@alamb , @nevi-me and @jhorstmann , thanks a lot for taking a close look
into this, also for the amazing work yesterday and today on reviewing and
merging stuff. Really imp
vertexclique edited a comment on pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#issuecomment-723470048
I don't think that's needed at all. Optimizations were extremely premature.
We should have thought about the future beforehand. I think we are prolonging
the discussio
vertexclique commented on pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#issuecomment-723470048
I don't think that's needed at all. Optimizations were extremely premature.
We should have thought about the future beforehand. I think we are prolonging
the discussion witho
nevi-me closed pull request #8606:
URL: https://github.com/apache/arrow/pull/8606
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
jhorstmann commented on a change in pull request #8541:
URL: https://github.com/apache/arrow/pull/8541#discussion_r519187056
##
File path: rust/arrow/src/array/data.rs
##
@@ -121,7 +120,7 @@ impl ArrayData {
/// Returns whether the element at index `i` is null
pub fn
kiszk commented on pull request #8057:
URL: https://github.com/apache/arrow/pull/8057#issuecomment-723455119
I added tests to verify it works well on any architecture.
This is an automated message from the Apache Git Service.
nevi-me closed pull request #8562:
URL: https://github.com/apache/arrow/pull/8562
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nevi-me closed pull request #8560:
URL: https://github.com/apache/arrow/pull/8560
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nevi-me commented on pull request #8545:
URL: https://github.com/apache/arrow/pull/8545#issuecomment-723442063
@Marwes may you please rebase this, I think the conflicts are from your
other PR, which might share some commits with this one
---
nevi-me closed pull request #8561:
URL: https://github.com/apache/arrow/pull/8561
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nevi-me closed pull request #8608:
URL: https://github.com/apache/arrow/pull/8608
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
alamb commented on pull request #8571:
URL: https://github.com/apache/arrow/pull/8571#issuecomment-723439185
FYI @jorgecarleitao / @nevi-me I think we should merge this PR.
This is an automated message from the Apache Git S
alamb commented on a change in pull request #8541:
URL: https://github.com/apache/arrow/pull/8541#discussion_r519169437
##
File path: rust/arrow/src/array/builder.rs
##
@@ -3535,14 +3531,15 @@ mod tests {
None,
Some(6),
Some(7),
+
nevi-me commented on pull request #8608:
URL: https://github.com/apache/arrow/pull/8608#issuecomment-723437224
> I have a question related to why do we use a `Box<>` instead of just
putting it into the stack, but other parts of the code have that, and thus
makes sense to keep it as is.
jorgecarleitao commented on pull request #8608:
URL: https://github.com/apache/arrow/pull/8608#issuecomment-723436980
Ready to merge if the tests pass. I went through all the changes and they
seem reasonable. Most issues I had were the same that @alamb suggested, and the
rest seems straigh
nevi-me closed pull request #8575:
URL: https://github.com/apache/arrow/pull/8575
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nevi-me closed pull request #8576:
URL: https://github.com/apache/arrow/pull/8576
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nevi-me commented on a change in pull request #8608:
URL: https://github.com/apache/arrow/pull/8608#discussion_r519169297
##
File path: rust/arrow/src/ipc/convert.rs
##
@@ -537,59 +529,62 @@ pub(crate) fn get_fb_field_type<'a: 'b, 'b>(
}
}
List(re
nevi-me commented on a change in pull request #8608:
URL: https://github.com/apache/arrow/pull/8608#discussion_r519169243
##
File path: rust/arrow/src/datatypes.rs
##
@@ -1182,6 +1183,18 @@ impl Field {
self.nullable
}
+/// IReturns the dictionary ID
Review
nevi-me commented on pull request #8608:
URL: https://github.com/apache/arrow/pull/8608#issuecomment-723436040
> We can always add such a convenience function later, however. It is
definitely not required in this PR
Yes @alamb, we can address it as a follow-up. There's more work that
alamb commented on pull request #8543:
URL: https://github.com/apache/arrow/pull/8543#issuecomment-723435331
I also agree this PR is likely to cause a bunch of conflicts, so the less
time it is left outstanding the better.
T
jorgecarleitao commented on a change in pull request #8608:
URL: https://github.com/apache/arrow/pull/8608#discussion_r519166944
##
File path: rust/arrow/src/datatypes.rs
##
@@ -1182,6 +1183,18 @@ impl Field {
self.nullable
}
+/// IReturns the dictionary ID
nevi-me closed pull request #8556:
URL: https://github.com/apache/arrow/pull/8556
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nevi-me commented on a change in pull request #8556:
URL: https://github.com/apache/arrow/pull/8556#discussion_r519166695
##
File path: rust/arrow/src/compute/util.rs
##
@@ -100,41 +99,55 @@ pub(super) fn compare_option_bitmap(
/// Where a list array has indices `[0,2,5,10]`,
alamb commented on a change in pull request #8608:
URL: https://github.com/apache/arrow/pull/8608#discussion_r519166183
##
File path: rust/arrow/src/ipc/convert.rs
##
@@ -537,59 +529,62 @@ pub(crate) fn get_fb_field_type<'a: 'b, 'b>(
}
}
List(ref
github-actions[bot] commented on pull request #8608:
URL: https://github.com/apache/arrow/pull/8608#issuecomment-723431612
https://issues.apache.org/jira/browse/ARROW-10261
This is an automated message from the Apache Git Ser
nevi-me opened a new pull request #8608:
URL: https://github.com/apache/arrow/pull/8608
This changes a list datatype to use `Box` instead of `Box`.
This change is needed in order to make both Parquet and IPC roundtrips pass.
The C++ implementation uses `Field`, as it allows for pre
nevi-me commented on pull request #8590:
URL: https://github.com/apache/arrow/pull/8590#issuecomment-723429467
> One idea:
>
> 1. Make the array comparison on the parquet tests be done using the
`PartialEq`, like this PR is doing
> 2. Make `PartialEq` use the function `equal` bein
kiszk commented on a change in pull request #8057:
URL: https://github.com/apache/arrow/pull/8057#discussion_r519156391
##
File path:
java/memory/memory-netty/src/main/java/io/netty/buffer/UnsafeDirectLittleEndian.java
##
@@ -60,9 +59,6 @@
private UnsafeDirectLittleEndian
kiszk commented on a change in pull request #8057:
URL: https://github.com/apache/arrow/pull/8057#discussion_r519152228
##
File path:
java/memory/memory-netty/src/main/java/io/netty/buffer/UnsafeDirectLittleEndian.java
##
@@ -60,9 +59,6 @@
private UnsafeDirectLittleEndian
kiszk commented on a change in pull request #8057:
URL: https://github.com/apache/arrow/pull/8057#discussion_r519152228
##
File path:
java/memory/memory-netty/src/main/java/io/netty/buffer/UnsafeDirectLittleEndian.java
##
@@ -60,9 +59,6 @@
private UnsafeDirectLittleEndian
kiszk commented on a change in pull request #8057:
URL: https://github.com/apache/arrow/pull/8057#discussion_r519152228
##
File path:
java/memory/memory-netty/src/main/java/io/netty/buffer/UnsafeDirectLittleEndian.java
##
@@ -60,9 +59,6 @@
private UnsafeDirectLittleEndian
stefan-lange-dataeng opened a new issue #8607:
URL: https://github.com/apache/arrow/issues/8607
https://github.com/apache/arrow/blob/47f2e0cb03ed8ad265e0688ada8162bf46066483/python/pyarrow/parquet.py#L1737
When write_table encounters a problem, the exception handler removes the
atte
43 matches
Mail list logo
