[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [arrow] sunchao commented on a change in pull request #9770: ARROW-12019: [Rust] [Parquet] Update README for 2.6.0 support

2021-03-22 Thread GitBox
sunchao commented on a change in pull request #9770: URL: https://github.com/apache/arrow/pull/9770#discussion_r599282803 ## File path: rust/parquet/README.md ## @@ -50,14 +50,18 @@ See [crate documentation](https://docs.rs/crate/parquet/4.0.0-SNAPSHOT) on avail If you are

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609356 Benchmark runs are scheduled for baseline = ee24399c52c4fb704cbb2a69d489792505bece53 and contender = efcd862d87912e4efd93da3dc124d3b31d5d3e6b. Results will be available as

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609304 Benchmark runs are scheduled for baseline = ee24399c52c4fb704cbb2a69d489792505bece53 and contender = efcd862d87912e4efd93da3dc124d3b31d5d3e6b. Results will be available as

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [arrow] github-actions[bot] commented on pull request #9768: ARROW-12010: [C++][Compute] DRAFT Improve performance of the hash table used in GroupIdentifier

2021-03-22 Thread GitBox
github-actions[bot] commented on pull request #9768: URL: https://github.com/apache/arrow/pull/9768#issuecomment-804622859 https://issues.apache.org/jira/browse/ARROW-12010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] codecov-io commented on pull request #9775: ARROW-12047: [Rust] [Parquet] Cleanup clippy

2021-03-22 Thread GitBox
codecov-io commented on pull request #9775: URL: https://github.com/apache/arrow/pull/9775#issuecomment-804622488 # [Codecov](https://codecov.io/gh/apache/arrow/pull/9775?src=pr=h1) Report > Merging [#9775](https://codecov.io/gh/apache/arrow/pull/9775?src=pr=desc) (cd369c9) into

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609356 Benchmark runs are scheduled for baseline = ee24399c52c4fb704cbb2a69d489792505bece53 and contender = efcd862d87912e4efd93da3dc124d3b31d5d3e6b. Results will be available as

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609304 Benchmark runs are scheduled for baseline = ee24399c52c4fb704cbb2a69d489792505bece53 and contender = efcd862d87912e4efd93da3dc124d3b31d5d3e6b. Results will be available as

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [arrow] github-actions[bot] removed a comment on pull request #9775: ARROW-12047: [Rust] [Parquet] Cleanup clippy

2021-03-22 Thread GitBox
github-actions[bot] removed a comment on pull request #9775: URL: https://github.com/apache/arrow/pull/9775#issuecomment-804407438 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

[GitHub] [arrow] github-actions[bot] commented on pull request #9777: ARROW-12051: [GLib] Keep input stream reference of GArrowCSVReader

2021-03-22 Thread GitBox
github-actions[bot] commented on pull request #9777: URL: https://github.com/apache/arrow/pull/9777#issuecomment-804613334 https://issues.apache.org/jira/browse/ARROW-12051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] kou opened a new pull request #9777: ARROW-12051: [GLib] Keep input stream reference of GArrowCSVReader

2021-03-22 Thread GitBox
kou opened a new pull request #9777: URL: https://github.com/apache/arrow/pull/9777 The given input stream should be alive while a new GArrowCSVReader is alive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [arrow] ursabot removed a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804604641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804607422 @github-actions rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] ElenaHenderson removed a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ElenaHenderson removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-776435517 @ursabot please benchmark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804604688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804604641 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each

[GitHub] [arrow] ElenaHenderson removed a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ElenaHenderson removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503786 @ursabot please benchmark name=file-write lang=C++ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] ElenaHenderson removed a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ElenaHenderson removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] ursabot removed a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804602010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804602010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [arrow] ursabot removed a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804598791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804598791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [arrow] ursabot removed a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [arrow] ursabot removed a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804526484 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504976 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503963 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504421 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504976 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804526484 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each

[GitHub] [arrow] liyafan82 commented on pull request #8949: ARROW-10880: [Java] Support compressing RecordBatch IPC buffers by LZ4

2021-03-22 Thread GitBox
liyafan82 commented on pull request #8949: URL: https://github.com/apache/arrow/pull/8949#issuecomment-804525790 > @liyafan82 @emkornfield Can you one of you update https://github.com/apache/arrow/blob/master/docs/source/status.rst#ipc-format once this is all finished? @pitrou I

[GitHub] [arrow] liyafan82 commented on pull request #9744: ARROW-12012: [Java][JDBC] Fix BinaryConsumer reallocation

2021-03-22 Thread GitBox
liyafan82 commented on pull request #9744: URL: https://github.com/apache/arrow/pull/9744#issuecomment-804525245 Mostly look good. Thank you @zxf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] liyafan82 commented on pull request #9744: ARROW-12012: [Java][JDBC] Fix BinaryConsumer reallocation

2021-03-22 Thread GitBox
liyafan82 commented on pull request #9744: URL: https://github.com/apache/arrow/pull/9744#issuecomment-804525164 Rerunning integration tests. The failure seems unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504268 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504421 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504268 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504976 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each

[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504958 @ursabot please benchmark command=cpp-micro --suite-filter=arrow-compute-vector-selection-benchmark --benchmark-filter=TakeStringRandomIndicesWithNulls/262144/2

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504857 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each

[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504836 @ursabot please benchmarkname=file-write lang=Python -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504752 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each

[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504729 @ursabot please benchmark name=file-.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504421 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each

[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504384 @ursabot please benchmark lang=C++ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504268 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each

[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504207 @ursabot please benchmark lang=R -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503963 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each

[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503941 @ursabot please benchmark lang=Python -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503786 @ursabot please benchmark name=file-write lang=C++ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503791 Supported benchmark command examples: `@ursabot benchmark help` To run all benchmarks: `@ursabot please benchmark` To filter benchmarks by language:

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503706 Supported benchmark command examples: `@ursabot benchmark help` To run all benchmarks: `@ursabot please benchmark` To filter benchmarks by language:

[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503698 @ursabot please benchmark lang=Python lang=C++ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503646 Supported benchmark command examples: `@ursabot benchmark help` To run all benchmarks: `@ursabot please benchmark` To filter benchmarks by language:

[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503643 @ursabot please benchmark something=something -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503464 Supported benchmark command examples: `@ursabot benchmark help` To run all benchmarks: `@ursabot please benchmark` To filter benchmarks by language:

[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503460 @ursabot please benchmark lang=Java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503371 @ursabot hello -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503375 Supported benchmark command examples: `@ursabot benchmark help` To run all benchmarks: `@ursabot please benchmark` To filter benchmarks by language:

[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503301 @ursabot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503305 Supported benchmark command examples: `@ursabot benchmark help` To run all benchmarks: `@ursabot please benchmark` To filter benchmarks by language:

[GitHub] [arrow] ursabot removed a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-797872526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [arrow] ElenaHenderson removed a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ElenaHenderson removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-797872509 @ursabot please benchmark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804498390 Supported benchmark command examples: `@ursabot benchmark help` To run all benchmarks: `@ursabot please benchmark` To filter benchmarks by language:

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804484031 Supported benchmark command examples: @ursabot benchmark help @ursabot please benchmark To filter benchmarks by language: @ursabot please benchmark

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804483606 Supported benchmark command examples: @ursabot benchmark help @ursabot please benchmark To filter benchmarks by language: @ursabot please benchmark

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804464584 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as

[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804464584 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-03-22 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804464283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [arrow] nevi-me commented on a change in pull request #9705: ARROW-11365: [Rust] [Parquet] Logical type printer and parser

2021-03-22 Thread GitBox
nevi-me commented on a change in pull request #9705: URL: https://github.com/apache/arrow/pull/9705#discussion_r599118931 ## File path: rust/parquet/src/arrow/schema.rs ## @@ -959,11 +962,14 @@ mod tests { Field::new("boolean", DataType::Boolean, false),

[GitHub] [arrow] kou commented on pull request #9045: ARROW-11180: [Developer] cmake-format pre-commit hook doesn't run

2021-03-22 Thread GitBox
kou commented on pull request #9045: URL: https://github.com/apache/arrow/pull/9045#issuecomment-804431484 @MarcoGorelli I found some problems: * `python run-cmake-format.py` (no `paths` arguments) doesn't work because `PATTERNS` data aren't suitable for `glob()`. * We also

[GitHub] [arrow] github-actions[bot] commented on pull request #9776: ARROW-12048: [Rust][DataFusion] Support Common Table Expressions

2021-03-22 Thread GitBox
github-actions[bot] commented on pull request #9776: URL: https://github.com/apache/arrow/pull/9776#issuecomment-804416180 https://issues.apache.org/jira/browse/ARROW-12048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] kou closed pull request #9746: ARROW-12013: [C++][FlightRPC] Fix bundled gRPC version probing

2021-03-22 Thread GitBox
kou closed pull request #9746: URL: https://github.com/apache/arrow/pull/9746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] kou commented on a change in pull request #9746: ARROW-12013: [C++][FlightRPC] Fix bundled gRPC version probing

2021-03-22 Thread GitBox
kou commented on a change in pull request #9746: URL: https://github.com/apache/arrow/pull/9746#discussion_r599091271 ## File path: cpp/cmake_modules/ThirdpartyToolchain.cmake ## @@ -2371,30 +2371,30 @@ macro(build_grpc) set(ABSL_LIBRARIES) # Abseil libraries gRPC

[GitHub] [arrow] github-actions[bot] commented on pull request #9775: ARROW-12047: [Rust] [Parquet] Cleanup clippy

2021-03-22 Thread GitBox
github-actions[bot] commented on pull request #9775: URL: https://github.com/apache/arrow/pull/9775#issuecomment-804411748 https://issues.apache.org/jira/browse/ARROW-12047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] alamb commented on a change in pull request #9770: ARROW-12019: [Rust] [Parquet] Update README for 2.6.0 support

2021-03-22 Thread GitBox
alamb commented on a change in pull request #9770: URL: https://github.com/apache/arrow/pull/9770#discussion_r599087360 ## File path: rust/parquet/README.md ## @@ -50,14 +50,18 @@ See [crate documentation](https://docs.rs/crate/parquet/4.0.0-SNAPSHOT) on avail If you are

[GitHub] [arrow] github-actions[bot] commented on pull request #9775: ARROW-12047: [Rust] [Parquet] Cleanup clippy

2021-03-22 Thread GitBox
github-actions[bot] commented on pull request #9775: URL: https://github.com/apache/arrow/pull/9775#issuecomment-804407438 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then

[GitHub] [arrow] alamb commented on a change in pull request #9762: ARROW-12037: [Rust] [DataFusion] Support catalogs and schemas for table namespacing

2021-03-22 Thread GitBox
alamb commented on a change in pull request #9762: URL: https://github.com/apache/arrow/pull/9762#discussion_r599086894 ## File path: rust/datafusion/src/catalog/catalog.rs ## @@ -0,0 +1,78 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] alamb commented on pull request #9329: ARROW-11511: [Rust] Replace `Arc` by `ArrayData` in all arrays

2021-03-22 Thread GitBox
alamb commented on pull request #9329: URL: https://github.com/apache/arrow/pull/9329#issuecomment-804405923 Thanks @nevi-me for pushing the over the line.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] alamb commented on a change in pull request #9771: ARROW-12043: [Rust] [Parquet] Write FSB arrays

2021-03-22 Thread GitBox
alamb commented on a change in pull request #9771: URL: https://github.com/apache/arrow/pull/9771#discussion_r599084717 ## File path: rust/parquet/src/arrow/arrow_writer.rs ## @@ -189,11 +199,12 @@ fn write_leaves( ArrowDataType::Float16 =>

[GitHub] [arrow] Dandandan edited a comment on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels

2021-03-22 Thread GitBox
Dandandan edited a comment on pull request #9772: URL: https://github.com/apache/arrow/pull/9772#issuecomment-804390782 Haha @ch-sc @javierluraschi I tried it on this website which I used before for some simple checks https://rextester.com/l/postgresql_online_compiler but it shows

[GitHub] [arrow] Dandandan commented on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels

2021-03-22 Thread GitBox
Dandandan commented on pull request #9772: URL: https://github.com/apache/arrow/pull/9772#issuecomment-804390782 Haha @ch-sc @javierluraschi I tried it on this website which I used before https://rextester.com/l/postgresql_online_compiler but it shows `null` on every input now 藍

[GitHub] [arrow] jpedroantunes commented on pull request #9726: ARROW-11987: [C++][Gandiva] Implement trigonometric functions

2021-03-22 Thread GitBox
jpedroantunes commented on pull request #9726: URL: https://github.com/apache/arrow/pull/9726#issuecomment-804389337 @emkornfield any idea about this AMD64 Conda build problem (do not seems related to my pull request)?

[GitHub] [arrow] returnString commented on a change in pull request #9762: ARROW-12037: [Rust] [DataFusion] Support catalogs and schemas for table namespacing

2021-03-22 Thread GitBox
returnString commented on a change in pull request #9762: URL: https://github.com/apache/arrow/pull/9762#discussion_r599063974 ## File path: rust/datafusion/src/execution/context.rs ## @@ -512,6 +573,12 @@ pub struct ExecutionConfig { optimizers: Vec>, ///

[GitHub] [arrow] Dandandan opened a new pull request #9776: ARROW-12048: [Rust][DataFusion] Support Common Table Expressions

2021-03-22 Thread GitBox
Dandandan opened a new pull request #9776: URL: https://github.com/apache/arrow/pull/9776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow] github-actions[bot] commented on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels

2021-03-22 Thread GitBox
github-actions[bot] commented on pull request #9772: URL: https://github.com/apache/arrow/pull/9772#issuecomment-804378434 https://issues.apache.org/jira/browse/ARROW-11973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] github-actions[bot] commented on pull request #9671: ARROW-12045: [Go][Parquet] Initial Chunk of Parquet port to Go

2021-03-22 Thread GitBox
github-actions[bot] commented on pull request #9671: URL: https://github.com/apache/arrow/pull/9671#issuecomment-804378353 https://issues.apache.org/jira/browse/ARROW-12045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] nevi-me commented on a change in pull request #9771: ARROW-12043: [Rust] [Parquet] Write FSB arrays

2021-03-22 Thread GitBox
nevi-me commented on a change in pull request #9771: URL: https://github.com/apache/arrow/pull/9771#discussion_r599053605 ## File path: rust/parquet/src/arrow/arrow_writer.rs ## @@ -156,6 +156,16 @@ fn write_leaves( row_group_writer.close_column(col_writer)?;

[GitHub] [arrow] jorgecarleitao commented on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels

2021-03-22 Thread GitBox
jorgecarleitao commented on pull request #9772: URL: https://github.com/apache/arrow/pull/9772#issuecomment-804370136 I tried on mysql, postgres and big query and was happy with the table you provided on JIRA. I am also curious how I got a different result than @Dandandan xD -- This

[GitHub] [arrow] returnString commented on a change in pull request #9762: ARROW-12037: [Rust] [DataFusion] Support catalogs and schemas for table namespacing

2021-03-22 Thread GitBox
returnString commented on a change in pull request #9762: URL: https://github.com/apache/arrow/pull/9762#discussion_r599049329 ## File path: rust/datafusion/src/catalog/schema.rs ## @@ -0,0 +1,104 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] ch-sc commented on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels

2021-03-22 Thread GitBox
ch-sc commented on pull request #9772: URL: https://github.com/apache/arrow/pull/9772#issuecomment-804367750 Hi @Dandandan, I actaully checked on Postgres (11) beforehand and it did return exactly the values I provided in the table. ``` SELECT TRUE AND NULL; --> NULL SELECT

[GitHub] [arrow] returnString commented on a change in pull request #9762: ARROW-12037: [Rust] [DataFusion] Support catalogs and schemas for table namespacing

2021-03-22 Thread GitBox
returnString commented on a change in pull request #9762: URL: https://github.com/apache/arrow/pull/9762#discussion_r599044375 ## File path: rust/datafusion/src/catalog/catalog.rs ## @@ -0,0 +1,78 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] github-actions[bot] commented on pull request #9771: ARROW-12043: [Rust] [Parquet] Write FSB arrays

2021-03-22 Thread GitBox
github-actions[bot] commented on pull request #9771: URL: https://github.com/apache/arrow/pull/9771#issuecomment-804363911 https://issues.apache.org/jira/browse/ARROW-12043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] alamb commented on a change in pull request #9762: ARROW-12037: [Rust] [DataFusion] Support catalogs and schemas for table namespacing

2021-03-22 Thread GitBox
alamb commented on a change in pull request #9762: URL: https://github.com/apache/arrow/pull/9762#discussion_r599027565 ## File path: rust/datafusion/src/catalog/catalog.rs ## @@ -0,0 +1,78 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9771: ARROW-12043: [Rust] [Parquet] Write FSB arrays

2021-03-22 Thread GitBox
jorgecarleitao commented on a change in pull request #9771: URL: https://github.com/apache/arrow/pull/9771#discussion_r599033492 ## File path: rust/parquet/src/arrow/arrow_writer.rs ## @@ -156,6 +156,16 @@ fn write_leaves(

  1   2   3   >