[GitHub] [arrow] seddonm1 closed pull request #9944: ARROW-12290: [Rust][DataFusion] Add input_file_name function

seddonm1 closed pull request #9944: URL: https://github.com/apache/arrow/pull/9944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] seddonm1 commented on pull request #9944: ARROW-12290: [Rust][DataFusion] Add input_file_name function

seddonm1 commented on pull request #9944: URL: https://github.com/apache/arrow/pull/9944#issuecomment-816452198 Thanks both of you. I will have a look at the visitor pattern that @jorgecarleitao suggested as I agree this is quite dirty. Let met see what is possible and have another go. -

[GitHub] [arrow] trxcllnt commented on a change in pull request #9961: ARROW-12309: [JS] Make es2015 bundles the default

trxcllnt commented on a change in pull request #9961: URL: https://github.com/apache/arrow/pull/9961#discussion_r610382954 ## File path: js/bin/integration.js ## @@ -30,7 +30,7 @@ const { Table, RecordBatchReader, util: { createElementComparator } -} = require('.

[GitHub] [arrow] trxcllnt commented on a change in pull request #9961: ARROW-12309: [JS] Make es2015 bundles the default

trxcllnt commented on a change in pull request #9961: URL: https://github.com/apache/arrow/pull/9961#discussion_r610381787 ## File path: js/README.md ## @@ -224,7 +224,7 @@ The base `apache-arrow` package includes all the compilation targets for conveni The targets are also p

[GitHub] [arrow] trxcllnt commented on a change in pull request #9961: ARROW-12309: [JS] Make es2015 bundles the default

trxcllnt commented on a change in pull request #9961: URL: https://github.com/apache/arrow/pull/9961#discussion_r610381787 ## File path: js/README.md ## @@ -224,7 +224,7 @@ The base `apache-arrow` package includes all the compilation targets for conveni The targets are also p

[GitHub] [arrow] trxcllnt commented on a change in pull request #9961: ARROW-12309: [JS] Make es2015 bundles the default

trxcllnt commented on a change in pull request #9961: URL: https://github.com/apache/arrow/pull/9961#discussion_r610380913 ## File path: js/gulp/compile-task.js ## @@ -25,12 +25,12 @@ const typescriptTask = require('./typescript-task'); const { arrowTask, arrowTSTask } = requi

[GitHub] [arrow] trxcllnt commented on a change in pull request #9961: ARROW-12309: [JS] Make es2015 bundles the default

trxcllnt commented on a change in pull request #9961: URL: https://github.com/apache/arrow/pull/9961#discussion_r610380913 ## File path: js/gulp/compile-task.js ## @@ -25,12 +25,12 @@ const typescriptTask = require('./typescript-task'); const { arrowTask, arrowTSTask } = requi

[GitHub] [arrow] trxcllnt commented on a change in pull request #9961: ARROW-12309: [JS] Make es2015 bundles the default

trxcllnt commented on a change in pull request #9961: URL: https://github.com/apache/arrow/pull/9961#discussion_r610380913 ## File path: js/gulp/compile-task.js ## @@ -25,12 +25,12 @@ const typescriptTask = require('./typescript-task'); const { arrowTask, arrowTSTask } = requi

[GitHub] [arrow] westonpace commented on pull request #9892: ARROW-12208: [C++] Add the ability to run async tasks without using the CPU thread pool

westonpace commented on pull request #9892: URL: https://github.com/apache/arrow/pull/9892#issuecomment-816445528 I believe all new changes have been addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] westonpace commented on a change in pull request #9892: ARROW-12208: [C++] Add the ability to run async tasks without using the CPU thread pool

westonpace commented on a change in pull request #9892: URL: https://github.com/apache/arrow/pull/9892#discussion_r610361801 ## File path: cpp/src/arrow/dataset/file_base.cc ## @@ -418,14 +418,46 @@ Status WriteNextBatch(WriteState& state, const std::shared_ptr& scan_t retu

[GitHub] [arrow] jorgecarleitao closed pull request #9963: Modified bench

jorgecarleitao closed pull request #9963: URL: https://github.com/apache/arrow/pull/9963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [arrow] github-actions[bot] commented on pull request #9963: Modified bench

github-actions[bot] commented on pull request #9963: URL: https://github.com/apache/arrow/pull/9963#issuecomment-816417403 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/.github/CONTRIBUTING.md#Minor-Fixes). Could y

[GitHub] [arrow] jorgecarleitao opened a new pull request #9963: Modified bench

jorgecarleitao opened a new pull request #9963: URL: https://github.com/apache/arrow/pull/9963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [arrow] domoritz commented on pull request #9961: ARROW-12309: [JS] Make es2015 bundles the default

domoritz commented on pull request #9961: URL: https://github.com/apache/arrow/pull/9961#issuecomment-816415923 I think I need your help, @trxcllnt, with the closure compiler here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [arrow] westonpace commented on a change in pull request #9892: ARROW-12208: [C++] Add the ability to run async tasks without using the CPU thread pool

westonpace commented on a change in pull request #9892: URL: https://github.com/apache/arrow/pull/9892#discussion_r610352912 ## File path: cpp/src/arrow/util/thread_pool.h ## @@ -233,15 +233,7 @@ class ARROW_EXPORT SerialExecutor : public Executor { if (final_fut.is_finish

[GitHub] [arrow] westonpace commented on a change in pull request #9892: ARROW-12208: [C++] Add the ability to run async tasks without using the CPU thread pool

westonpace commented on a change in pull request #9892: URL: https://github.com/apache/arrow/pull/9892#discussion_r610351875 ## File path: cpp/src/arrow/util/thread_pool.h ## @@ -233,15 +233,7 @@ class ARROW_EXPORT SerialExecutor : public Executor { if (final_fut.is_finish

[GitHub] [arrow] westonpace commented on a change in pull request #9892: ARROW-12208: [C++] Add the ability to run async tasks without using the CPU thread pool

westonpace commented on a change in pull request #9892: URL: https://github.com/apache/arrow/pull/9892#discussion_r610349329 ## File path: cpp/src/arrow/dataset/file_base.cc ## @@ -418,14 +418,46 @@ Status WriteNextBatch(WriteState& state, const std::shared_ptr& scan_t retu

[GitHub] [arrow] domoritz commented on a change in pull request #9961: ARROW-12309: [JS] Make es2015 bundles the default

domoritz commented on a change in pull request #9961: URL: https://github.com/apache/arrow/pull/9961#discussion_r610347626 ## File path: js/gulp/compile-task.js ## @@ -25,12 +25,12 @@ const typescriptTask = require('./typescript-task'); const { arrowTask, arrowTSTask } = requi

[GitHub] [arrow] github-actions[bot] commented on pull request #9962: ARROW-12303: [JS] Use iterator instead of yield

github-actions[bot] commented on pull request #9962: URL: https://github.com/apache/arrow/pull/9962#issuecomment-816402720 https://issues.apache.org/jira/browse/ARROW-12303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] domoritz opened a new pull request #9962: ARROW-12303: [JS] Use iterator instead of yield

domoritz opened a new pull request #9962: URL: https://github.com/apache/arrow/pull/9962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [arrow] kou commented on pull request #9960: MINOR: [JS] Correct build commands

kou commented on pull request #9960: URL: https://github.com/apache/arrow/pull/9960#issuecomment-816393927 Thanks. Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [arrow] kou merged pull request #9960: MINOR: [JS] Correct build commands

kou merged pull request #9960: URL: https://github.com/apache/arrow/pull/9960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [arrow] github-actions[bot] commented on pull request #9961: ARROW-12309: [JS] Make es2015 bundles the default

github-actions[bot] commented on pull request #9961: URL: https://github.com/apache/arrow/pull/9961#issuecomment-816392424 https://issues.apache.org/jira/browse/ARROW-12309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] domoritz opened a new pull request #9961: ARROW-12309: [JS] Make es2015 bundles the default

domoritz opened a new pull request #9961: URL: https://github.com/apache/arrow/pull/9961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [arrow] drin commented on a change in pull request #9810: ARROW-11677: [C++][Docs] Add basic C++ datasets documentation

drin commented on a change in pull request #9810: URL: https://github.com/apache/arrow/pull/9810#discussion_r610336087 ## File path: docs/source/cpp/dataset.rst ## @@ -0,0 +1,381 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license a

[GitHub] [arrow] drin commented on a change in pull request #9810: ARROW-11677: [C++][Docs] Add basic C++ datasets documentation

drin commented on a change in pull request #9810: URL: https://github.com/apache/arrow/pull/9810#discussion_r610336087 ## File path: docs/source/cpp/dataset.rst ## @@ -0,0 +1,381 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license a

[GitHub] [arrow] drin commented on a change in pull request #9810: ARROW-11677: [C++][Docs] Add basic C++ datasets documentation

drin commented on a change in pull request #9810: URL: https://github.com/apache/arrow/pull/9810#discussion_r610330458 ## File path: docs/source/cpp/dataset.rst ## @@ -0,0 +1,381 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license a

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9936: ARROW-12278: [Rust][DataFusion] Use Timestamp(Nanosecond, None) for SQL TIMESTAMP Type

jorgecarleitao commented on a change in pull request #9936: URL: https://github.com/apache/arrow/pull/9936#discussion_r610328244 ## File path: rust/datafusion/src/execution/context.rs ## @@ -2878,6 +2878,54 @@ mod tests { Ok(()) } +#[tokio::test] +async

[GitHub] [arrow] drin commented on a change in pull request #9810: ARROW-11677: [C++][Docs] Add basic C++ datasets documentation

drin commented on a change in pull request #9810: URL: https://github.com/apache/arrow/pull/9810#discussion_r610327864 ## File path: docs/source/cpp/dataset.rst ## @@ -0,0 +1,381 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license a

[GitHub] [arrow] jacobBaumbach commented on a change in pull request #9806: ARROW-11991: [Rust][DataFusion] Maintain partition information in Union

jacobBaumbach commented on a change in pull request #9806: URL: https://github.com/apache/arrow/pull/9806#discussion_r610329683 ## File path: rust/datafusion/src/physical_plan/union.rs ## @@ -60,15 +60,31 @@ impl ExecutionPlan for UnionExec { /// Output of the union is t

[GitHub] [arrow] domoritz commented on pull request #9938: ARROW-12281: [JS] Remove shx, trash, and rimraf and update learna for yarn

domoritz commented on pull request #9938: URL: https://github.com/apache/arrow/pull/9938#issuecomment-816385207 I also noticed we don't use the `trash` dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] drin commented on a change in pull request #9810: ARROW-11677: [C++][Docs] Add basic C++ datasets documentation

drin commented on a change in pull request #9810: URL: https://github.com/apache/arrow/pull/9810#discussion_r610326551 ## File path: docs/source/cpp/dataset.rst ## @@ -0,0 +1,381 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license a

[GitHub] [arrow] domoritz commented on pull request #9960: MINOR: [JS] Correct build commands

domoritz commented on pull request #9960: URL: https://github.com/apache/arrow/pull/9960#issuecomment-816382027 Rebased onto master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] drin commented on a change in pull request #9810: ARROW-11677: [C++][Docs] Add basic C++ datasets documentation

drin commented on a change in pull request #9810: URL: https://github.com/apache/arrow/pull/9810#discussion_r610324994 ## File path: docs/source/cpp/dataset.rst ## @@ -0,0 +1,381 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license a

[GitHub] [arrow] domoritz commented on pull request #9938: ARROW-12281: [JS] Remove shx and rimraf and update learna for yarn

domoritz commented on pull request #9938: URL: https://github.com/apache/arrow/pull/9938#issuecomment-816381613 I merged master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [arrow] drin commented on a change in pull request #9810: ARROW-11677: [C++][Docs] Add basic C++ datasets documentation

drin commented on a change in pull request #9810: URL: https://github.com/apache/arrow/pull/9810#discussion_r610322157 ## File path: docs/source/cpp/dataset.rst ## @@ -0,0 +1,381 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license a

[GitHub] [arrow] westonpace commented on pull request #9941: ARROW-12220: [C++][CI] Thread sanitizer failure

westonpace commented on pull request #9941: URL: https://github.com/apache/arrow/pull/9941#issuecomment-816376215 Ok. I got lost trying to simplify things with an enum and, in the process, found a bug where a really fast consumer could try and restart the queue multiple times. @pit

[GitHub] [arrow] drin commented on a change in pull request #9810: ARROW-11677: [C++][Docs] Add basic C++ datasets documentation

drin commented on a change in pull request #9810: URL: https://github.com/apache/arrow/pull/9810#discussion_r610318957 ## File path: docs/source/cpp/dataset.rst ## @@ -0,0 +1,381 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license a

[GitHub] [arrow] drin commented on a change in pull request #9810: ARROW-11677: [C++][Docs] Add basic C++ datasets documentation

drin commented on a change in pull request #9810: URL: https://github.com/apache/arrow/pull/9810#discussion_r610318529 ## File path: docs/source/cpp/dataset.rst ## @@ -0,0 +1,381 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license a

[GitHub] [arrow] drin commented on a change in pull request #9810: ARROW-11677: [C++][Docs] Add basic C++ datasets documentation

drin commented on a change in pull request #9810: URL: https://github.com/apache/arrow/pull/9810#discussion_r610317754 ## File path: docs/source/cpp/dataset.rst ## @@ -0,0 +1,381 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license a

[GitHub] [arrow] drin commented on a change in pull request #9810: ARROW-11677: [C++][Docs] Add basic C++ datasets documentation

drin commented on a change in pull request #9810: URL: https://github.com/apache/arrow/pull/9810#discussion_r610317754 ## File path: docs/source/cpp/dataset.rst ## @@ -0,0 +1,381 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license a

[GitHub] [arrow] kou commented on pull request #9938: ARROW-12281: [JS] Remove shx and rimraf and update learna for yarn

kou commented on pull request #9938: URL: https://github.com/apache/arrow/pull/9938#issuecomment-816372686 Could you rebase on master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [arrow] kou merged pull request #9953: MINOR: [JS] remove superfluous space

kou merged pull request #9953: URL: https://github.com/apache/arrow/pull/9953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [arrow] kou closed pull request #9959: ARROW-12305: [JS] Update generate.py to python3 and new versions of pyarrow

kou closed pull request #9959: URL: https://github.com/apache/arrow/pull/9959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [arrow] kou commented on pull request #9960: MINOR: [JS] Correct build commands

kou commented on pull request #9960: URL: https://github.com/apache/arrow/pull/9960#issuecomment-816371819 Sorry, this is conflicted by merging #9918. Could you re-fix this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] kou closed pull request #9918: ARROW-12239: [JS] Switch to yarn

kou closed pull request #9918: URL: https://github.com/apache/arrow/pull/9918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [arrow] trxcllnt closed pull request #9957: ARROW-12305: [JS] Update generate.py to python3

trxcllnt closed pull request #9957: URL: https://github.com/apache/arrow/pull/9957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] drin commented on a change in pull request #9810: ARROW-11677: [C++][Docs] Add basic C++ datasets documentation

drin commented on a change in pull request #9810: URL: https://github.com/apache/arrow/pull/9810#discussion_r610307942 ## File path: docs/source/cpp/dataset.rst ## @@ -0,0 +1,381 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license a

[GitHub] [arrow] cyb70289 commented on a change in pull request #9948: ARROW-12150: [Python] Correctly infer type of mixed-precision Decimals

cyb70289 commented on a change in pull request #9948: URL: https://github.com/apache/arrow/pull/9948#discussion_r610285862 ## File path: cpp/src/arrow/python/decimal.cc ## @@ -214,12 +214,14 @@ DecimalMetadata::DecimalMetadata(int32_t precision, int32_t scale) : precision

[GitHub] [arrow] cyb70289 commented on a change in pull request #9948: ARROW-12150: [Python] Correctly infer type of mixed-precision Decimals

cyb70289 commented on a change in pull request #9948: URL: https://github.com/apache/arrow/pull/9948#discussion_r610285862 ## File path: cpp/src/arrow/python/decimal.cc ## @@ -214,12 +214,14 @@ DecimalMetadata::DecimalMetadata(int32_t precision, int32_t scale) : precision

[GitHub] [arrow] cyb70289 commented on pull request #9841: ARROW-11070: [C++] Implement power compute kernel

cyb70289 commented on pull request #9841: URL: https://github.com/apache/arrow/pull/9841#issuecomment-816341953 > Should we also add a benchmark? I see other kernels have them. Yes we should. It can be in another pr. Thanks for persistent in improving this pr. Will review soon. -

[GitHub] [arrow] domoritz edited a comment on pull request #9918: ARROW-12239: [JS] Switch to yarn

domoritz edited a comment on pull request #9918: URL: https://github.com/apache/arrow/pull/9918#issuecomment-816326899 Go for it. You can also merge since we probably should squash this pull request anyway. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [arrow] domoritz commented on pull request #9918: ARROW-12239: [JS] Switch to yarn

domoritz commented on pull request #9918: URL: https://github.com/apache/arrow/pull/9918#issuecomment-816326899 Go for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] kou commented on pull request #9957: ARROW-12305: [JS] Update generate.py to python3

kou commented on pull request #9957: URL: https://github.com/apache/arrow/pull/9957#issuecomment-816319282 Can we close this in favor of #9959? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow] kou merged pull request #9955: MINOR: [JS] correct comment in build file

kou merged pull request #9955: URL: https://github.com/apache/arrow/pull/9955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [arrow] kou commented on pull request #9918: ARROW-12239: [JS] Switch to yarn

kou commented on pull request #9918: URL: https://github.com/apache/arrow/pull/9918#issuecomment-816317653 It seems that the `-isystem` error isn't occurred on master. Can I rebase this branch on master? -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [arrow] kou closed pull request #9954: ARROW-12209: [JS] Copy all src files into the the TypeScript package

kou closed pull request #9954: URL: https://github.com/apache/arrow/pull/9954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [arrow] kou closed pull request #9951: ARROW-12300: [C++] Remove linking of cuda runtime library

kou closed pull request #9951: URL: https://github.com/apache/arrow/pull/9951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [arrow] kou commented on pull request #9951: ARROW-12300: [C++] Remove linking of cuda runtime library

kou commented on pull request #9951: URL: https://github.com/apache/arrow/pull/9951#issuecomment-816314731 Thanks. I'll merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [arrow] lidavidm commented on pull request #9810: ARROW-11677: [C++][Docs] Add basic C++ datasets documentation

lidavidm commented on pull request #9810: URL: https://github.com/apache/arrow/pull/9810#issuecomment-816312147 Thanks for the comments. I'll go through and make sure changes are consistent between Python/C++ (the C++ side of the docs was based on the Python one). FWIW, the double-c

[GitHub] [arrow] ianmcook commented on pull request #9952: ARROW-12197: [R] dplyr bindings for cast, dictionary_encode

ianmcook commented on pull request #9952: URL: https://github.com/apache/arrow/pull/9952#issuecomment-816311397 @nealrichardson this is ready for re-review. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] ianmcook commented on a change in pull request #9952: ARROW-12197: [R] dplyr bindings for cast, dictionary_encode

ianmcook commented on a change in pull request #9952: URL: https://github.com/apache/arrow/pull/9952#discussion_r610216317 ## File path: r/R/arrow-datum.R ## @@ -22,6 +22,7 @@ ArrowDatum <- R6Class("ArrowDatum", inherit = ArrowObject, public = list( cast = function(tar

[GitHub] [arrow] domoritz opened a new pull request #9960: MINOR: [JS] Correct build commands

domoritz opened a new pull request #9960: URL: https://github.com/apache/arrow/pull/9960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [arrow] domoritz commented on pull request #9918: ARROW-12239: [JS] Switch to yarn

domoritz commented on pull request #9918: URL: https://github.com/apache/arrow/pull/9918#issuecomment-816292196 @kou There is an error `CMake Error: Unknown argument -isystem` but I don't see how it's related. Any ideas? -- This is an automated message from the Apache Git Service. To res

[GitHub] [arrow] github-actions[bot] commented on pull request #9959: ARROW-12305: [JS] Update generate.py to python3 and update it to new versions

github-actions[bot] commented on pull request #9959: URL: https://github.com/apache/arrow/pull/9959#issuecomment-816282359 https://issues.apache.org/jira/browse/ARROW-12305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] domoritz opened a new pull request #9959: ARROW-12305: [JS] Update generate.py to python3 and update it to new versions

domoritz opened a new pull request #9959: URL: https://github.com/apache/arrow/pull/9959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [arrow] codecov-io edited a comment on pull request #9865: ARROW-12170: [Rust][DataFusion] Introduce repartition optimization

codecov-io edited a comment on pull request #9865: URL: https://github.com/apache/arrow/pull/9865#issuecomment-812913241 # [Codecov](https://codecov.io/gh/apache/arrow/pull/9865?src=pr&el=h1) Report > Merging [#9865](https://codecov.io/gh/apache/arrow/pull/9865?src=pr&el=desc) (4bb4dc5)

[GitHub] [arrow] github-actions[bot] commented on pull request #9958: ARROW-11328: [R] Collecting zero columns from a dataset returns entire dataset

github-actions[bot] commented on pull request #9958: URL: https://github.com/apache/arrow/pull/9958#issuecomment-816272914 https://issues.apache.org/jira/browse/ARROW-11328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] trxcllnt commented on pull request #9110: ARROW-11706: [JS] Better BigInt compatibility check

trxcllnt commented on pull request #9110: URL: https://github.com/apache/arrow/pull/9110#issuecomment-816272924 @kou Yeah, it looks good to me :+1: @marcprux we _strongly_ recommend against using the JSON format outside the Arrow CI integration tests, and may remove the JSON IPC clas

[GitHub] [arrow] alamb commented on pull request #9723: ARROW-11982: [Rust] Donate Ballista Distributed Compute Platform

alamb commented on pull request #9723: URL: https://github.com/apache/arrow/pull/9723#issuecomment-816272211 🎉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [arrow] andygrove closed pull request #9723: ARROW-11982: [Rust] Donate Ballista Distributed Compute Platform

andygrove closed pull request #9723: URL: https://github.com/apache/arrow/pull/9723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] domoritz removed a comment on pull request #9954: ARROW-12209: [JS] Copy all src files into the the TypeScript package

domoritz removed a comment on pull request #9954: URL: https://github.com/apache/arrow/pull/9954#issuecomment-816060173 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] domoritz removed a comment on pull request #9957: ARROW-12305: [JS] Update generate.py to python3

domoritz removed a comment on pull request #9957: URL: https://github.com/apache/arrow/pull/9957#issuecomment-816179702 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] github-actions[bot] commented on pull request #9957: ARROW-12305: [JS] Update generate.py to python3

github-actions[bot] commented on pull request #9957: URL: https://github.com/apache/arrow/pull/9957#issuecomment-816267762 https://issues.apache.org/jira/browse/ARROW-12305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] alamb commented on pull request #9944: ARROW-12290: [Rust][DataFusion] Add input_file_name function

alamb commented on pull request #9944: URL: https://github.com/apache/arrow/pull/9944#issuecomment-816264432 (BTW there is a small lint error on the PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] alamb commented on a change in pull request #9944: ARROW-12290: [Rust][DataFusion] Add input_file_name function

alamb commented on a change in pull request #9944: URL: https://github.com/apache/arrow/pull/9944#discussion_r610150874 ## File path: rust/datafusion/src/physical_plan/crypto_expressions.rs ## @@ -144,7 +144,7 @@ fn md5_array( } /// crypto function that accepts Utf8 or Larg

[GitHub] [arrow] github-actions[bot] commented on pull request #9956: ARROW-12211: [C++][Gandiva] Implement TO_NUMBER function in gandiva

github-actions[bot] commented on pull request #9956: URL: https://github.com/apache/arrow/pull/9956#issuecomment-816263386 https://issues.apache.org/jira/browse/ARROW-12211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] github-actions[bot] commented on pull request #9896: ARROW-12098: [R] Catch cpp build failures on linux

github-actions[bot] commented on pull request #9896: URL: https://github.com/apache/arrow/pull/9896#issuecomment-816263341 Revision: bb88a58989b3f093d625fc2e1adec60bad80b91c Submitted crossbow builds: [ursacomputing/crossbow @ actions-300](https://github.com/ursacomputing/crossbow/br

[GitHub] [arrow] domoritz commented on pull request #9918: ARROW-12239: [JS] Switch to yarn

domoritz commented on pull request #9918: URL: https://github.com/apache/arrow/pull/9918#issuecomment-816260639 @kou thanks! That came from a merge. I updated the lockfile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] alamb commented on pull request #9936: ARROW-12278: [Rust][DataFusion] Use Timestamp(Nanosecond, None) for SQL TIMESTAMP Type

alamb commented on pull request #9936: URL: https://github.com/apache/arrow/pull/9936#issuecomment-816259545 FYI @Dandandan / @seddonm1 / @ovr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] alamb closed pull request #9937: ARROW-12279: [Rust][DataFusion] Add test for null handling in hash join (ARROW-12266)

alamb closed pull request #9937: URL: https://github.com/apache/arrow/pull/9937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [arrow] alamb commented on pull request #9926: ARROW-12254: [Rust][DataFusion] Stop polling limit input once limit is reached

alamb commented on pull request #9926: URL: https://github.com/apache/arrow/pull/9926#issuecomment-816257938 > Looks good! (Small linting error) Thanks @Dandandan -- I fixed that up so hopefully this will be good to go tomorrow as well -- This is an automated message from the Apa

[GitHub] [arrow] kou commented on pull request #9918: ARROW-12239: [JS] Switch to yarn

kou commented on pull request #9918: URL: https://github.com/apache/arrow/pull/9918#issuecomment-816255857 It seems that the following error is related to this: https://github.com/apache/arrow/pull/9918/checks?check_run_id=2298651927#step:7:367 ```text error Your lockfile n

[GitHub] [arrow] alamb commented on pull request #9865: ARROW-12170: [Rust][DataFusion] Introduce repartition optimization

alamb commented on pull request #9865: URL: https://github.com/apache/arrow/pull/9865#issuecomment-816255241 I'll plan to merge this once CI is done (it looks like there is a bit of a backup now) -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [arrow] alamb commented on a change in pull request #9865: ARROW-12170: [Rust][DataFusion] Introduce repartition optimization

alamb commented on a change in pull request #9865: URL: https://github.com/apache/arrow/pull/9865#discussion_r610142533 ## File path: rust/datafusion/tests/user_defined_plan.rs ## @@ -471,12 +471,10 @@ impl Stream for TopKReader { return Poll::Ready(None);

[GitHub] [arrow] kou commented on pull request #9110: ARROW-11706: [JS] Better BigInt compatibility check

kou commented on pull request #9110: URL: https://github.com/apache/arrow/pull/9110#issuecomment-816253533 @trxcllnt Can we merge this? @marcprux Could you tell us your JIRA account? I want to assign you to https://issues.apache.org/jira/browse/ARROW-11706 . -- This is an automate

[GitHub] [arrow] pachamaltese opened a new pull request #9958: ARROW-11328: [R] Collecting zero columns from a dataset returns entire dataset

pachamaltese opened a new pull request #9958: URL: https://github.com/apache/arrow/pull/9958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [arrow] kou closed pull request #9917: ARROW-12238: [JS] Remove trailing spaces and consistently add space after //

kou closed pull request #9917: URL: https://github.com/apache/arrow/pull/9917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [arrow] github-actions[bot] commented on pull request #9954: ARROW-12209: [JS] Copy all src files into the the TypeScript package

github-actions[bot] commented on pull request #9954: URL: https://github.com/apache/arrow/pull/9954#issuecomment-816244012 https://issues.apache.org/jira/browse/ARROW-12209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] github-actions[bot] commented on pull request #9951: ARROW-12300: [C++] Remove linking of cuda runtime library

github-actions[bot] commented on pull request #9951: URL: https://github.com/apache/arrow/pull/9951#issuecomment-816240585 https://issues.apache.org/jira/browse/ARROW-12300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] github-actions[bot] commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build

github-actions[bot] commented on pull request #9933: URL: https://github.com/apache/arrow/pull/9933#issuecomment-816240350 Revision: 9ccb811082271fa532bb3b2556af3f021089d44b Submitted crossbow builds: [ursacomputing/crossbow @ actions-299](https://github.com/ursacomputing/crossbow/br

[GitHub] [arrow] github-actions[bot] commented on pull request #9952: ARROW-12197: [R] dplyr bindings for cast, dictionary_encode

github-actions[bot] commented on pull request #9952: URL: https://github.com/apache/arrow/pull/9952#issuecomment-816240346 https://issues.apache.org/jira/browse/ARROW-12197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] ianmcook commented on pull request #9896: ARROW-12098: [R] Catch cpp build failures on linux

ianmcook commented on pull request #9896: URL: https://github.com/apache/arrow/pull/9896#issuecomment-816238924 > I believe the last remaining issue here is that we are doing `R CMD check --as-cran --run-donttest` and the `\donttest` examples don't pass without arrow C++. I could either (1

[GitHub] [arrow] galipremsagar commented on pull request #9951: ARROW-12300: [C++] Remove linking of cuda runtime library

galipremsagar commented on pull request #9951: URL: https://github.com/apache/arrow/pull/9951#issuecomment-816230629 > @galipremsagar Could you tell us your JIRA account? I want to assign you to https://issues.apache.org/jira/browse/ARROW-12300 . `galipremsagar` is my username on JIR

[GitHub] [arrow] kou commented on pull request #9951: ARROW-12300: [C++] Remove linking of cuda runtime library

kou commented on pull request #9951: URL: https://github.com/apache/arrow/pull/9951#issuecomment-816228113 @galipremsagar Could you tell us your JIRA account? I want to assign you to https://issues.apache.org/jira/browse/ARROW-12300 . -- This is an automated message from the Apache Git S

[GitHub] [arrow] github-actions[bot] commented on pull request #9951: ARROW-12300: [C++] Remove linking of cuda runtime library

github-actions[bot] commented on pull request #9951: URL: https://github.com/apache/arrow/pull/9951#issuecomment-816219522 https://issues.apache.org/jira/browse/ARROW-11468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] ianmcook commented on a change in pull request #9952: ARROW-12197: [R] dplyr bindings for cast, dictionary_encode [WIP]

ianmcook commented on a change in pull request #9952: URL: https://github.com/apache/arrow/pull/9952#discussion_r610109004 ## File path: r/tests/testthat/test-dplyr.R ## @@ -421,12 +484,13 @@ test_that("explicit type conversions", { int2dbl = as.double(int), i

[GitHub] [arrow] github-actions[bot] commented on pull request #9950: ARROW-11468: [R] Allow user to pass schema to read_json_arrow()

github-actions[bot] commented on pull request #9950: URL: https://github.com/apache/arrow/pull/9950#issuecomment-816188615 https://issues.apache.org/jira/browse/ARROW-11468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] domoritz commented on pull request #9957: ARROW-12305: [JS] Update generate.py to python3

domoritz commented on pull request #9957: URL: https://github.com/apache/arrow/pull/9957#issuecomment-816179702 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For qu

[GitHub] [arrow] bkietz closed pull request #9939: ARROW-10421: [R] Use gc_memory_pool in more places

bkietz closed pull request #9939: URL: https://github.com/apache/arrow/pull/9939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please co

  1   2   3   >