[GitHub] [arrow-datafusion] jorgecarleitao commented on pull request #68: Experimenting with arrow2

2021-05-15 Thread GitBox
jorgecarleitao commented on pull request #68: URL: https://github.com/apache/arrow-datafusion/pull/68#issuecomment-841776668 An update on this: most functionality has now been migrated. So far this results in a +1k -1.8k change. There are some things missing: * the `ScalarValu

[GitHub] [arrow] zhztheplayer commented on pull request #10333: ARROW-12607: [Website] Doc section for Dataset Java bindings

2021-05-15 Thread GitBox
zhztheplayer commented on pull request #10333: URL: https://github.com/apache/arrow/pull/10333#issuecomment-841764639 Thanks @kiszk for helping checking this :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow-datafusion] jorgecarleitao commented on pull request #342: Left join could use bitmap for left join instead of Vec

2021-05-15 Thread GitBox
jorgecarleitao commented on pull request #342: URL: https://github.com/apache/arrow-datafusion/pull/342#issuecomment-841762453 Thanks a lot @boaz-codota ! Is there any performance difference? imo It would be good to measure before adding a dependency. Note that arrow also has

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #303: add random SQL function

2021-05-15 Thread GitBox
codecov-commenter commented on pull request #303: URL: https://github.com/apache/arrow-datafusion/pull/303#issuecomment-841758453 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/303?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #350: cleanup function return type fn

2021-05-15 Thread GitBox
codecov-commenter commented on pull request #350: URL: https://github.com/apache/arrow-datafusion/pull/350#issuecomment-841757846 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/350?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment

[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #328: fix 305 by using a null array as param for zero param functions

2021-05-15 Thread GitBox
Jimexist commented on a change in pull request #328: URL: https://github.com/apache/arrow-datafusion/pull/328#discussion_r633031732 ## File path: datafusion/src/physical_plan/functions.rs ## @@ -207,6 +215,14 @@ pub enum BuiltinScalarFunction { RegexpMatch, } +impl Buil

[GitHub] [arrow-datafusion] Jimexist opened a new pull request #350: cleanup function return type fn

2021-05-15 Thread GitBox
Jimexist opened a new pull request #350: URL: https://github.com/apache/arrow-datafusion/pull/350 # Which issue does this PR close? Closes #. # Rationale for this change # What changes are included in this PR? # Are there any user-facing changes?

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #328: fix 305 by using a null array as param for zero param functions

2021-05-15 Thread GitBox
codecov-commenter commented on pull request #328: URL: https://github.com/apache/arrow-datafusion/pull/328#issuecomment-841756124 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/328?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment

[GitHub] [arrow-datafusion] djKooks commented on issue #47: DataFrame.collect() should return async stream rather than a Vec

2021-05-15 Thread GitBox
djKooks commented on issue #47: URL: https://github.com/apache/arrow-datafusion/issues/47#issuecomment-841755336 @andygrove hope to touch on this if it's not on work yet 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] anthonylouisbsb commented on pull request #10300: ARROW-12699: [CI][Packaging][Java] Generate a jar compatible with Linux and MacOS for all Arrow components

2021-05-15 Thread GitBox
anthonylouisbsb commented on pull request #10300: URL: https://github.com/apache/arrow/pull/10300#issuecomment-841755233 @kou I opened a ticket https://issues.apache.org/jira/browse/ARROW-12801, and I will work on it. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [arrow] kou closed pull request #10278: ARROW-12704: [JS] Support and use optional chaining

2021-05-15 Thread GitBox
kou closed pull request #10278: URL: https://github.com/apache/arrow/pull/10278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [arrow] kou commented on pull request #10278: ARROW-12704: [JS] Support and use optional chaining

2021-05-15 Thread GitBox
kou commented on pull request #10278: URL: https://github.com/apache/arrow/pull/10278#issuecomment-841749996 Thanks. These failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] rok commented on a change in pull request #10176: ARROW-11759: [C++] Kernel to extract datetime components (year, month, day, etc) from timestamp type

2021-05-15 Thread GitBox
rok commented on a change in pull request #10176: URL: https://github.com/apache/arrow/pull/10176#discussion_r633016379 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal_test.cc ## @@ -0,0 +1,239 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] domoritz commented on pull request #10278: ARROW-12704: [JS] Support and use optional chaining

2021-05-15 Thread GitBox
domoritz commented on pull request #10278: URL: https://github.com/apache/arrow/pull/10278#issuecomment-841732801 I also merged this branch into the follow-up at https://github.com/apache/arrow/pull/10281. No idea why this one is failing. -- This is an automated message from the Apache

[GitHub] [arrow] domoritz commented on pull request #10278: ARROW-12704: [JS] Support and use optional chaining

2021-05-15 Thread GitBox
domoritz commented on pull request #10278: URL: https://github.com/apache/arrow/pull/10278#issuecomment-841732014 I merged master and updated the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [arrow] github-actions[bot] commented on pull request #10340: ARROW-12800: [JS] Drop IE Support and remove text encoder and decoder polyfills

2021-05-15 Thread GitBox
github-actions[bot] commented on pull request #10340: URL: https://github.com/apache/arrow/pull/10340#issuecomment-841730795 https://issues.apache.org/jira/browse/ARROW-12800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] domoritz opened a new pull request #10340: ARROW-12800: [JS] Drop IE Support and remove text encoder and decoder polyfills

2021-05-15 Thread GitBox
domoritz opened a new pull request #10340: URL: https://github.com/apache/arrow/pull/10340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow] kou commented on pull request #10278: ARROW-12704: [JS] Support and use optional chaining

2021-05-15 Thread GitBox
kou commented on pull request #10278: URL: https://github.com/apache/arrow/pull/10278#issuecomment-841730414 @domoritz Could you also rebase on master and update the pull request description? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [arrow] kou commented on pull request #10275: ARROW-12702: [JS] Update webpack and terser

2021-05-15 Thread GitBox
kou commented on pull request #10275: URL: https://github.com/apache/arrow/pull/10275#issuecomment-841730122 Thanks. I'll merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] kou closed pull request #10275: ARROW-12702: [JS] Update webpack and terser

2021-05-15 Thread GitBox
kou closed pull request #10275: URL: https://github.com/apache/arrow/pull/10275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [arrow] domoritz commented on pull request #10332: ARROW-12578: [JS] Remove Buffer in favor of TextEncoder API to support bundlers such as Rollup

2021-05-15 Thread GitBox
domoritz commented on pull request #10332: URL: https://github.com/apache/arrow/pull/10332#issuecomment-841729699 Great, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] kou closed pull request #10332: ARROW-12578: [JS] Remove Buffer in favor of TextEncoder API to support bundlers such as Rollup

2021-05-15 Thread GitBox
kou closed pull request #10332: URL: https://github.com/apache/arrow/pull/10332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [arrow] kou commented on pull request #10332: ARROW-12578: [JS] Remove Buffer in favor of TextEncoder API to support bundlers such as Rollup

2021-05-15 Thread GitBox
kou commented on pull request #10332: URL: https://github.com/apache/arrow/pull/10332#issuecomment-841729084 Thanks. I changed `@XXX` with `Co-authored-by: XXX`. I'll merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [arrow] kou merged pull request #10337: MINOR: [JS] Add VSCode settings

2021-05-15 Thread GitBox
kou merged pull request #10337: URL: https://github.com/apache/arrow/pull/10337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [arrow] kou closed pull request #10336: MINOR: [C++] Fix typo in memory.h

2021-05-15 Thread GitBox
kou closed pull request #10336: URL: https://github.com/apache/arrow/pull/10336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [arrow] kou commented on pull request #10147: MINOR: [JS] Update README to reflect new OmniSci JS Arrow use

2021-05-15 Thread GitBox
kou commented on pull request #10147: URL: https://github.com/apache/arrow/pull/10147#issuecomment-841727396 Closed in favor of #10335. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [arrow] kou closed pull request #10147: MINOR: [JS] Update README to reflect new OmniSci JS Arrow use

2021-05-15 Thread GitBox
kou closed pull request #10147: URL: https://github.com/apache/arrow/pull/10147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [arrow] domoritz commented on pull request #10275: ARROW-12702: [JS] Update webpack and terser

2021-05-15 Thread GitBox
domoritz commented on pull request #10275: URL: https://github.com/apache/arrow/pull/10275#issuecomment-841727405 I merged master so this should be good to squash and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] kou closed pull request #10335: ARROW-12797: [JS] Update readme with new links and remove outdated examples

2021-05-15 Thread GitBox
kou closed pull request #10335: URL: https://github.com/apache/arrow/pull/10335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [arrow] domoritz commented on pull request #10332: ARROW-12578: [JS] Remove Buffer in favor of TextEncoder API to support bundlers such as Rollup

2021-05-15 Thread GitBox
domoritz commented on pull request #10332: URL: https://github.com/apache/arrow/pull/10332#issuecomment-841726803 Excellent. I updated the title. Does it look good to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow] kou commented on pull request #10275: ARROW-12702: [JS] Update webpack and terser

2021-05-15 Thread GitBox
kou commented on pull request #10275: URL: https://github.com/apache/arrow/pull/10275#issuecomment-841724164 @domoritz Could you rebase on master to merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] kou closed pull request #10331: ARROW-12796: [JS] Support JSON output from benchmarks

2021-05-15 Thread GitBox
kou closed pull request #10331: URL: https://github.com/apache/arrow/pull/10331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [arrow] kou commented on pull request #10332: ARROW-12578: [JS] Remove Buffer in favor of TextEncoder API in NodeJS

2021-05-15 Thread GitBox
kou commented on pull request #10332: URL: https://github.com/apache/arrow/pull/10332#issuecomment-841722486 @domoritz Sure. Bug fixes without API breaking is suitable for a patch release in Semantic Versioning context. Could you update the pull request description before we merge th

[GitHub] [arrow-datafusion] andygrove opened a new issue #349: Ballista context should get file metadata from scheduler, not from local disk

2021-05-15 Thread GitBox
andygrove opened a new issue #349: URL: https://github.com/apache/arrow-datafusion/issues/349 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** I have a Ballista cluster running, and each scheduler and executor has access to TPC-H

[GitHub] [arrow] pprudhvi commented on pull request #10299: ARROW-12656: [C++][Gandiva] Implement castVARCHAR for date, intervalDay and intervalYear

2021-05-15 Thread GitBox
pprudhvi commented on pull request #10299: URL: https://github.com/apache/arrow/pull/10299#issuecomment-841710929 castVARCHAR_intervalyear is missing, could you please add the impl or edit the commit message above? -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [arrow-datafusion] Dandandan commented on pull request #320: Implement hash partitioned aggregation

2021-05-15 Thread GitBox
Dandandan commented on pull request #320: URL: https://github.com/apache/arrow-datafusion/pull/320#issuecomment-841709468 Somehow coverage test seems to fail... But doesn't show what is failing -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow-datafusion] Dandandan edited a comment on pull request #320: Implement hash partitioned aggregation

2021-05-15 Thread GitBox
Dandandan edited a comment on pull request #320: URL: https://github.com/apache/arrow-datafusion/pull/320#issuecomment-841709468 Somehow coverage run seems to fail... But doesn't show what is failing -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [arrow-rs] codecov-commenter commented on pull request #287: Fix FFI and add support for Struct type

2021-05-15 Thread GitBox
codecov-commenter commented on pull request #287: URL: https://github.com/apache/arrow-rs/pull/287#issuecomment-841704728 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/287?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [arrow-rs] jorgecarleitao commented on pull request #287: Fix FFI and add support for Struct type

2021-05-15 Thread GitBox
jorgecarleitao commented on pull request #287: URL: https://github.com/apache/arrow-rs/pull/287#issuecomment-841700074 @alamb , we are unable to distinguish if that is a false positive or a problem on our side. It is on my todo list to write to MIRI team to help us here. -- This is an a

[GitHub] [arrow-rs] roee88 commented on pull request #287: Fix FFI and add support for Struct type

2021-05-15 Thread GitBox
roee88 commented on pull request #287: URL: https://github.com/apache/arrow-rs/pull/287#issuecomment-841699212 > I also wondered if this would fix #227 (aka miri reported issues): > > ``` > RUST_BACKTRACE=1 MIRIFLAGS="-Zmiri-disable-isolation" cargo +nightly miri test -p arrow --

[GitHub] [arrow] domoritz commented on pull request #10281: ARROW-12393: [JS] Use closure for all UMD targets

2021-05-15 Thread GitBox
domoritz commented on pull request #10281: URL: https://github.com/apache/arrow/pull/10281#issuecomment-841698642 I updated the pull request to use closure for every target. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] github-actions[bot] commented on pull request #10339: ARROW-12799: [JS] Use Nullish Coalescing Operator (??) For Defaults

2021-05-15 Thread GitBox
github-actions[bot] commented on pull request #10339: URL: https://github.com/apache/arrow/pull/10339#issuecomment-841696000 https://issues.apache.org/jira/browse/ARROW-12799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] domoritz opened a new pull request #10339: ARROW-12799: [JS] Use Nullish Coalescing Operator (??) For Defaults

2021-05-15 Thread GitBox
domoritz opened a new pull request #10339: URL: https://github.com/apache/arrow/pull/10339 **The nullish coalescing operator (`??`) returns its right side when its left side is nullish** (`null` or `undefined`), and its left side otherwise. For example, `const x = a ?? b` would set `x` t

[GitHub] [arrow] github-actions[bot] commented on pull request #10338: ARROW-12798: [JS] Use == null Comparison

2021-05-15 Thread GitBox
github-actions[bot] commented on pull request #10338: URL: https://github.com/apache/arrow/pull/10338#issuecomment-841695238 https://issues.apache.org/jira/browse/ARROW-12798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] domoritz opened a new pull request #10338: ARROW-12798: [JS] Use == null Comparison

2021-05-15 Thread GitBox
domoritz opened a new pull request #10338: URL: https://github.com/apache/arrow/pull/10338 The `== null` check is a concise expression to identify nullish values (`null` and `undefined`). This refactoring replaces the following combinations of longer strict equality checks with the

[GitHub] [arrow-datafusion] jorgecarleitao opened a new issue #348: Reduce compile time of DataFusion?

2021-05-15 Thread GitBox
jorgecarleitao opened a new issue #348: URL: https://github.com/apache/arrow-datafusion/issues/348 During development of DataFusion I am getting a compile time that is hurting development. I am not sure if other feel the same, and I would like to gauge this here. I admit I do not ha

[GitHub] [arrow] domoritz commented on a change in pull request #10281: ARROW-12393: [JS] Use closure for every UMD target

2021-05-15 Thread GitBox
domoritz commented on a change in pull request #10281: URL: https://github.com/apache/arrow/pull/10281#discussion_r632983210 ## File path: js/tsconfig/tsconfig.es2015.cls.json ## @@ -2,10 +2,10 @@ { "extends": "./tsconfig.base.json", "compilerOptions": { -"target": "

[GitHub] [arrow-datafusion] Dandandan opened a new issue #347: Improve display of operators in Explain

2021-05-15 Thread GitBox
Dandandan opened a new issue #347: URL: https://github.com/apache/arrow-datafusion/issues/347 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Currently the plan shows the operators using the name instead of symbol. A readability

[GitHub] [arrow] domoritz commented on pull request #10281: ARROW-12393: [JS] Use closure for every UMD target

2021-05-15 Thread GitBox
domoritz commented on pull request #10281: URL: https://github.com/apache/arrow/pull/10281#issuecomment-841690343 https://github.com/apache/arrow/blob/068318fed5a2f3f77cf8cdd3ca2b0a86e0f8bace/js/tsconfig/tsconfig.es2015.cls.json#L1 is wrong then. We use the `.cls` config also for terser an

[GitHub] [arrow] domoritz edited a comment on pull request #10281: ARROW-12393: [JS] Use closure for every target but es5

2021-05-15 Thread GitBox
domoritz edited a comment on pull request #10281: URL: https://github.com/apache/arrow/pull/10281#issuecomment-841689886 Ahh, looks like the build system tricked me. ``` targets/es5/umd/: - -I bin 1.2M -I Arrow.es5.min.js.map 302k -I Arrow.js ``` We should us

[GitHub] [arrow] domoritz commented on pull request #10281: ARROW-12393: [JS] Use closure for every target but es5

2021-05-15 Thread GitBox
domoritz commented on pull request #10281: URL: https://github.com/apache/arrow/pull/10281#issuecomment-841689886 Ahh, looks like the build system tricked me. ``` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow-datafusion] andygrove commented on pull request #320: Implement hash partitioned aggregation

2021-05-15 Thread GitBox
andygrove commented on pull request #320: URL: https://github.com/apache/arrow-datafusion/pull/320#issuecomment-841689435 I filed https://github.com/apache/arrow-datafusion/issues/346 for implementing this optimization in Ballista -- This is an automated message from the Apache Git Servi

[GitHub] [arrow-datafusion] andygrove opened a new issue #346: Implement hash partitioned aggregation in Ballista

2021-05-15 Thread GitBox
andygrove opened a new issue #346: URL: https://github.com/apache/arrow-datafusion/issues/346 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** PR https://github.com/apache/arrow-datafusion/pull/320 implemented hash partitioned agg

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #344: Update Ballista to use new physical plan formatter utility

2021-05-15 Thread GitBox
codecov-commenter commented on pull request #344: URL: https://github.com/apache/arrow-datafusion/pull/344#issuecomment-841689013 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/344?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #342: Left join could use bitmap for left join instead of Vec

2021-05-15 Thread GitBox
codecov-commenter commented on pull request #342: URL: https://github.com/apache/arrow-datafusion/pull/342#issuecomment-841687494 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/342?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment

[GitHub] [arrow-datafusion] andygrove commented on issue #345: Indentation is incorrect for joins in formatted physical plans

2021-05-15 Thread GitBox
andygrove commented on issue #345: URL: https://github.com/apache/arrow-datafusion/issues/345#issuecomment-841687467 @alamb fyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [arrow-datafusion] andygrove opened a new issue #345: Indentation is incorrect for joins in formatted physical plans

2021-05-15 Thread GitBox
andygrove opened a new issue #345: URL: https://github.com/apache/arrow-datafusion/issues/345 **Describe the bug** The new physical plan formatting code does not handle joins correctly. Both children of a join should be shown at the same indent level. Here is an example of an inc

[GitHub] [arrow] domoritz opened a new pull request #10337: MINOR: [JS] Add VSCode settings

2021-05-15 Thread GitBox
domoritz opened a new pull request #10337: URL: https://github.com/apache/arrow/pull/10337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow-datafusion] andygrove opened a new pull request #344: Update Ballista to use new physical plan formatter utility

2021-05-15 Thread GitBox
andygrove opened a new pull request #344: URL: https://github.com/apache/arrow-datafusion/pull/344 # Which issue does this PR close? Closes #343. # Rationale for this change See Closes #343. # What changes are included in this PR? Remove Ba

[GitHub] [arrow-datafusion] andygrove opened a new issue #343: Update Ballista to use new physical plan formatter utility

2021-05-15 Thread GitBox
andygrove opened a new issue #343: URL: https://github.com/apache/arrow-datafusion/issues/343 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Ballista contains some hacky code for formatting physical query plans and we can now re

[GitHub] [arrow] domoritz opened a new pull request #10336: MINOR: Fix typo in memory.h

2021-05-15 Thread GitBox
domoritz opened a new pull request #10336: URL: https://github.com/apache/arrow/pull/10336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow-datafusion] Dandandan commented on pull request #342: Left join could use bitmap for left join instead of Vec

2021-05-15 Thread GitBox
Dandandan commented on pull request #342: URL: https://github.com/apache/arrow-datafusion/pull/342#issuecomment-841685880 > @Dandandan I hope I understood the requested change correctly. Was not familiar with bitvec before, but I used the docs and I think I implemented it correctly

[GitHub] [arrow] github-actions[bot] commented on pull request #10334: ARROW-12198: [R] bindings for strptime

2021-05-15 Thread GitBox
github-actions[bot] commented on pull request #10334: URL: https://github.com/apache/arrow/pull/10334#issuecomment-841683807 https://issues.apache.org/jira/browse/ARROW-12198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] kiszk commented on a change in pull request #10201: ARROW-11776: [Java][Dataset] Support writing to files within dataset scanner via JNI

2021-05-15 Thread GitBox
kiszk commented on a change in pull request #10201: URL: https://github.com/apache/arrow/pull/10201#discussion_r632975139 ## File path: java/dataset/src/main/java/org/apache/arrow/dataset/jni/JniWrapper.java ## @@ -52,7 +52,7 @@ private JniWrapper() { * Create Dataset from

[GitHub] [arrow] kiszk commented on a change in pull request #10333: ARROW-12607: [Website] Doc section for Dataset Java bindings

2021-05-15 Thread GitBox
kiszk commented on a change in pull request #10333: URL: https://github.com/apache/arrow/pull/10333#discussion_r632973438 ## File path: docs/source/java/dataset.rst ## @@ -0,0 +1,192 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor licen

[GitHub] [arrow] kiszk commented on a change in pull request #10333: ARROW-12607: [Website] Doc section for Dataset Java bindings

2021-05-15 Thread GitBox
kiszk commented on a change in pull request #10333: URL: https://github.com/apache/arrow/pull/10333#discussion_r632973406 ## File path: docs/source/java/dataset.rst ## @@ -0,0 +1,192 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor licen

[GitHub] [arrow] kiszk commented on a change in pull request #10333: ARROW-12607: [Website] Doc section for Dataset Java bindings

2021-05-15 Thread GitBox
kiszk commented on a change in pull request #10333: URL: https://github.com/apache/arrow/pull/10333#discussion_r632973338 ## File path: docs/source/java/dataset.rst ## @@ -0,0 +1,192 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor licen

[GitHub] [arrow] kiszk commented on a change in pull request #10333: ARROW-12607: [Website] Doc section for Dataset Java bindings

2021-05-15 Thread GitBox
kiszk commented on a change in pull request #10333: URL: https://github.com/apache/arrow/pull/10333#discussion_r632973238 ## File path: docs/source/java/dataset.rst ## @@ -0,0 +1,192 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor licen

[GitHub] [arrow] kiszk commented on a change in pull request #10333: ARROW-12607: [Website] Doc section for Dataset Java bindings

2021-05-15 Thread GitBox
kiszk commented on a change in pull request #10333: URL: https://github.com/apache/arrow/pull/10333#discussion_r632973238 ## File path: docs/source/java/dataset.rst ## @@ -0,0 +1,192 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor licen

[GitHub] [arrow-datafusion] boaz-codota commented on issue #240: Left join could use bitmap for left join instead of `Vec`

2021-05-15 Thread GitBox
boaz-codota commented on issue #240: URL: https://github.com/apache/arrow-datafusion/issues/240#issuecomment-841678377 I have a PR waiting for this issue: https://github.com/apache/arrow-datafusion/pull/342 -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [arrow] domoritz commented on a change in pull request #10281: ARROW-12393: [JS] Use closure for every target but es5

2021-05-15 Thread GitBox
domoritz commented on a change in pull request #10281: URL: https://github.com/apache/arrow/pull/10281#discussion_r632971808 ## File path: js/tsconfig/tsconfig.es2015.cls.json ## @@ -2,10 +2,10 @@ { "extends": "./tsconfig.base.json", "compilerOptions": { -"target": "

[GitHub] [arrow] domoritz commented on a change in pull request #10335: ARROW-12797: [JS] Update readme

2021-05-15 Thread GitBox
domoritz commented on a change in pull request #10335: URL: https://github.com/apache/arrow/pull/10335#discussion_r632970856 ## File path: js/README.md ## @@ -255,15 +214,11 @@ Full list of broader Apache Arrow [projects & organizations](https://arrow.apach ## Open Source Pro

[GitHub] [arrow] domoritz commented on a change in pull request #10147: MINOR: [JS] Update README to reflect new OmniSci JS Arrow use

2021-05-15 Thread GitBox
domoritz commented on a change in pull request #10147: URL: https://github.com/apache/arrow/pull/10147#discussion_r632970728 ## File path: js/README.md ## @@ -147,37 +147,33 @@ for (let i = -1, n = column.length; ++i < n;) { } ``` -### Usage with MapD Core +### Usage with O

[GitHub] [arrow] github-actions[bot] commented on pull request #10335: ARROW-12797: [JS] Update readme

2021-05-15 Thread GitBox
github-actions[bot] commented on pull request #10335: URL: https://github.com/apache/arrow/pull/10335#issuecomment-841676988 https://issues.apache.org/jira/browse/ARROW-12797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] domoritz opened a new pull request #10335: ARROW-12797: [JS] Update readme

2021-05-15 Thread GitBox
domoritz opened a new pull request #10335: URL: https://github.com/apache/arrow/pull/10335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow] github-actions[bot] commented on pull request #10334: Arrow 12198: [R] bindings for strptime

2021-05-15 Thread GitBox
github-actions[bot] commented on pull request #10334: URL: https://github.com/apache/arrow/pull/10334#issuecomment-841669771 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you ope

[GitHub] [arrow] AlenkaF opened a new pull request #10334: Arrow 12198: [R] bindings for strptime

2021-05-15 Thread GitBox
AlenkaF opened a new pull request #10334: URL: https://github.com/apache/arrow/pull/10334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow-datafusion] boaz-codota commented on pull request #342: Left join could use bitmap for left join instead of Vec

2021-05-15 Thread GitBox
boaz-codota commented on pull request #342: URL: https://github.com/apache/arrow-datafusion/pull/342#issuecomment-841669557 @Dandandan I hope I understood the requested change correctly. Was not familiar with bitvec before, but I used the docs and I think I implemented it correctly --

[GitHub] [arrow-datafusion] boaz-codota opened a new pull request #342: Left join could use bitmap for left join instead of Vec

2021-05-15 Thread GitBox
boaz-codota opened a new pull request #342: URL: https://github.com/apache/arrow-datafusion/pull/342 # Which issue does this PR close? Closes #240 . # Rationale for this change Described in the issue. # What changes are included in this PR? Described in the is

[GitHub] [arrow-rs] ritchie46 commented on pull request #21: WIP: Fix FFI UB with arrays with child data

2021-05-15 Thread GitBox
ritchie46 commented on pull request #21: URL: https://github.com/apache/arrow-rs/pull/21#issuecomment-841664755 Close, fixed in #287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow-rs] ritchie46 closed pull request #21: WIP: Fix FFI UB with arrays with child data

2021-05-15 Thread GitBox
ritchie46 closed pull request #21: URL: https://github.com/apache/arrow-rs/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow-rs] ritchie46 commented on pull request #287: Fix FFI and add support for Struct type

2021-05-15 Thread GitBox
ritchie46 commented on pull request #287: URL: https://github.com/apache/arrow-rs/pull/287#issuecomment-841664247 Nice work on this one! :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow-datafusion] andygrove commented on pull request #320: Implement hash partitioned aggregation

2021-05-15 Thread GitBox
andygrove commented on pull request #320: URL: https://github.com/apache/arrow-datafusion/pull/320#issuecomment-841661931 @Dandandan Looks like there is a conflict that needs fixing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [arrow] github-actions[bot] commented on pull request #10333: ARROW-12607: [Website] Doc section for Dataset Java bindings

2021-05-15 Thread GitBox
github-actions[bot] commented on pull request #10333: URL: https://github.com/apache/arrow/pull/10333#issuecomment-841660817 https://issues.apache.org/jira/browse/ARROW-12607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] zhztheplayer opened a new pull request #10333: ARROW-12607: [Website] Doc section for Dataset Java bindings

2021-05-15 Thread GitBox
zhztheplayer opened a new pull request #10333: URL: https://github.com/apache/arrow/pull/10333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [arrow-datafusion] Jimexist closed pull request #310: Simplify columnar array call and add From trait for columnar array values

2021-05-15 Thread GitBox
Jimexist closed pull request #310: URL: https://github.com/apache/arrow-datafusion/pull/310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [arrow] sahil1105 commented on a change in pull request #10088: ARROW-10675 [C++][Python] Support AWS S3 Web identity credentials

2021-05-15 Thread GitBox
sahil1105 commented on a change in pull request #10088: URL: https://github.com/apache/arrow/pull/10088#discussion_r632948223 ## File path: python/pyarrow/_s3fs.pyx ## @@ -74,6 +74,13 @@ cdef class S3FileSystem(FileSystem): Whether to connect anonymously if access_key

[GitHub] [arrow-rs] alamb commented on issue #292: Implement biweekly releases for arrow-rs, parquet-rs

2021-05-15 Thread GitBox
alamb commented on issue #292: URL: https://github.com/apache/arrow-rs/issues/292#issuecomment-841652592 Here is what I am thinking for the release workflow (based on the main apache release flow. The major difference is that there is no Release Candidate) Proposal: 1. Update vers

[GitHub] [arrow-rs] alamb commented on pull request #291: Add Send to the ArrayBuilder trait

2021-05-15 Thread GitBox
alamb commented on pull request #291: URL: https://github.com/apache/arrow-rs/pull/291#issuecomment-841647649 The integration test failure seemed related to some network problem. I have retriggered it -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #293: Remove old release scripts

2021-05-15 Thread GitBox
codecov-commenter edited a comment on pull request #293: URL: https://github.com/apache/arrow-rs/pull/293#issuecomment-841640206 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/293?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter

[GitHub] [arrow-rs] codecov-commenter commented on pull request #294: Remove old tasks

2021-05-15 Thread GitBox
codecov-commenter commented on pull request #294: URL: https://github.com/apache/arrow-rs/pull/294#issuecomment-841647011 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/294?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [arrow-rs] alamb opened a new pull request #294: Remove old tasks

2021-05-15 Thread GitBox
alamb opened a new pull request #294: URL: https://github.com/apache/arrow-rs/pull/294 # Which issue does this PR close? re https://github.com/apache/arrow-rs/issues/292 # Rationale for this change Remove cruft that is leftover from apache/arrow repo # What chan

[GitHub] [arrow-rs] codecov-commenter commented on pull request #293: Remove old release scripts

2021-05-15 Thread GitBox
codecov-commenter commented on pull request #293: URL: https://github.com/apache/arrow-rs/pull/293#issuecomment-841640206 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/293?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [arrow-rs] alamb opened a new pull request #293: Remove old release scripts

2021-05-15 Thread GitBox
alamb opened a new pull request #293: URL: https://github.com/apache/arrow-rs/pull/293 # Which issue does this PR close? re https://github.com/apache/arrow-rs/issues/292 # Rationale for this change Remove the release scripts (left over from apache/arrow) in preparation to add

[GitHub] [arrow-rs] alamb commented on issue #292: Implement biweekly releases for arrow-rs, parquet-rs

2021-05-15 Thread GitBox
alamb commented on issue #292: URL: https://github.com/apache/arrow-rs/issues/292#issuecomment-841634719 @jorgecarleitao is working on changelog creation in https://github.com/apache/arrow-rs/issues/274 There is a packaging issue here: https://github.com/apache/arrow-rs/issues/212

[GitHub] [arrow-rs] alamb opened a new issue #292: Implement biweekly releases for arrow-rs, parquet-rs

2021-05-15 Thread GitBox
alamb opened a new issue #292: URL: https://github.com/apache/arrow-rs/issues/292 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Implement the process that will allow us to release to crates.io every 2 weeks as described in the

[GitHub] [arrow] alippai edited a comment on pull request #10332: ARROW-12578: [JS] Remove Buffer in favor of TextEncoder API in NodeJS

2021-05-15 Thread GitBox
alippai edited a comment on pull request #10332: URL: https://github.com/apache/arrow/pull/10332#issuecomment-841630995 @domoritz ~~this drops the polyfill usage as well, is that intended? I didn't find a supported browsers list, if we support IE11, it's needed.~~ -- This is an automated

[GitHub] [arrow] alippai commented on pull request #10332: ARROW-12578: [JS] Remove Buffer in favor of TextEncoder API in NodeJS

2021-05-15 Thread GitBox
alippai commented on pull request #10332: URL: https://github.com/apache/arrow/pull/10332#issuecomment-841630995 @domoritz this drops the polyfill usage as well, is that intended? I didn't find a supported browsers list, if we support IE11, it's needed. -- This is an automated message fr

[GitHub] [arrow-rs] jorgecarleitao commented on issue #290: Add Send to ArrayBuilder

2021-05-15 Thread GitBox
jorgecarleitao commented on issue #290: URL: https://github.com/apache/arrow-rs/issues/290#issuecomment-841628601 makes sense, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [arrow-rs] codecov-commenter commented on pull request #291: Add Send to the ArrayBuilder trait

2021-05-15 Thread GitBox
codecov-commenter commented on pull request #291: URL: https://github.com/apache/arrow-rs/pull/291#issuecomment-841617411 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/291?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

  1   2   >