jorgecarleitao commented on pull request #68:
URL: https://github.com/apache/arrow-datafusion/pull/68#issuecomment-851234013
```bash
cd datafusion && cargo test --lib
echo $?
0
```
i.e. the unit tests of datafusion tests pass.
--
This is an automated message from the Ap
Jimexist commented on a change in pull request #429:
URL: https://github.com/apache/arrow-datafusion/pull/429#discussion_r642219305
##
File path: datafusion/src/physical_plan/windows.rs
##
@@ -421,18 +435,52 @@ async fn compute_window_aggregate(
let aggregated_mapped = fin
codecov-commenter commented on pull request #388:
URL: https://github.com/apache/arrow-rs/pull/388#issuecomment-851153388
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/388?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A
Jimexist opened a new pull request #388:
URL: https://github.com/apache/arrow-rs/pull/388
# Which issue does this PR close?
Closes #.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing changes?
codecov-commenter edited a comment on pull request #386:
URL: https://github.com/apache/arrow-rs/pull/386#issuecomment-851124315
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/386?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter
Jimexist commented on a change in pull request #429:
URL: https://github.com/apache/arrow-datafusion/pull/429#discussion_r642179178
##
File path: datafusion/src/physical_plan/windows.rs
##
@@ -421,18 +435,52 @@ async fn compute_window_aggregate(
let aggregated_mapped = fin
Jimexist opened a new issue #387:
URL: https://github.com/apache/arrow-rs/issues/387
**Describe the bug**
A clear and concise description of what the bug is.
`arrow/src/compute/kernels/window.rs` shall handle special cases of shifts:
- 0
- large off size offsets
**To R
codecov-commenter commented on pull request #386:
URL: https://github.com/apache/arrow-rs/pull/386#issuecomment-851124315
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/386?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A
Jimexist opened a new pull request #386:
URL: https://github.com/apache/arrow-rs/pull/386
# Which issue does this PR close?
Closes #.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing changes?
codecov-commenter commented on pull request #452:
URL: https://github.com/apache/arrow-datafusion/pull/452#issuecomment-851118576
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/452?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment
Jimexist opened a new pull request #452:
URL: https://github.com/apache/arrow-datafusion/pull/452
# Which issue does this PR close?
Closes #448 .
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing chang
hohav opened a new issue #385:
URL: https://github.com/apache/arrow-rs/issues/385
Possibly related: #282, #270.
Minimal reproducing code
[here](https://github.com/hohav/arrow-parquet-list-test).
Trying to write a Parquet file containing a variable-length array with
non-nullab
alippai opened a new issue #451:
URL: https://github.com/apache/arrow-datafusion/issues/451
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
Recently I came across LDBC benchmarks which is focused on graph-like
workloads. I'm wond
codecov-commenter commented on pull request #384:
URL: https://github.com/apache/arrow-rs/pull/384#issuecomment-851063613
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/384?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A
Dandandan commented on a change in pull request #384:
URL: https://github.com/apache/arrow-rs/pull/384#discussion_r642129881
##
File path: parquet/src/util/memory.rs
##
@@ -292,19 +292,28 @@ impl BufferPtr {
}
/// Returns slice of data in this buffer.
+#[inline]
yordan-pavlov opened a new pull request #384:
URL: https://github.com/apache/arrow-rs/pull/384
# Which issue does this PR close?
Closes #200.
# Rationale for this change
This PR attempts to implement a new, more efficient and also more generic
`ArrowArrayReader`, as a repla
codecov-commenter edited a comment on pull request #450:
URL: https://github.com/apache/arrow-datafusion/pull/450#issuecomment-851049870
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/450?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Dandandan edited a comment on pull request #383:
URL: https://github.com/apache/arrow-rs/pull/383#issuecomment-851059933
I added some details on the ASF Slack. I think the change is fine, but only
the tests should be fixed.
Maybe it makes sense to expose `get_bit` as well? This also
Dandandan commented on pull request #383:
URL: https://github.com/apache/arrow-rs/pull/383#issuecomment-851059933
I added some details on the ASF Slack. I think the change is fine, but only
the tests should be fixed.
Maybe it makes sense to expose `is_set` as well? This also could ma
codecov-commenter edited a comment on pull request #450:
URL: https://github.com/apache/arrow-datafusion/pull/450#issuecomment-851049870
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/450?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
codecov-commenter commented on pull request #450:
URL: https://github.com/apache/arrow-datafusion/pull/450#issuecomment-851049870
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/450?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment
boazberman commented on pull request #342:
URL: https://github.com/apache/arrow-datafusion/pull/342#issuecomment-851049746
I'm stuck on this, I've implemented the code which I think that should work,
but it is not working as expected. I opened the PR to get help.
https://github.com/apach
boazberman opened a new pull request #383:
URL: https://github.com/apache/arrow-rs/pull/383
# Which issue does this PR close?
Relates to https://github.com/apache/arrow-datafusion/issues/240 &
https://github.com/apache/arrow-datafusion/pull/342
# Rationale for this change
andygrove commented on pull request #450:
URL: https://github.com/apache/arrow-datafusion/pull/450#issuecomment-851046135
@edrevo fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
andygrove opened a new pull request #450:
URL: https://github.com/apache/arrow-datafusion/pull/450
# Which issue does this PR close?
Closes #449 .
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing chan
andygrove opened a new issue #449:
URL: https://github.com/apache/arrow-datafusion/issues/449
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
This issue is to track a small refactor to clean up some tech debt.
**Describe th
andygrove closed issue #446:
URL: https://github.com/apache/arrow-datafusion/issues/446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pl
andygrove merged pull request #447:
URL: https://github.com/apache/arrow-datafusion/pull/447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
kiszk commented on pull request #10423:
URL: https://github.com/apache/arrow/pull/10423#issuecomment-851040065
Good catch, the fix looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
codecov-commenter edited a comment on pull request #429:
URL: https://github.com/apache/arrow-datafusion/pull/429#issuecomment-849123108
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/429?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
codecov-commenter edited a comment on pull request #425:
URL: https://github.com/apache/arrow-datafusion/pull/425#issuecomment-847826098
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/425?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Jimexist commented on a change in pull request #403:
URL: https://github.com/apache/arrow-datafusion/pull/403#discussion_r642104113
##
File path: datafusion/src/physical_plan/expressions/nth_value.rs
##
@@ -0,0 +1,223 @@
+// Licensed to the Apache Software Foundation (ASF) unde
Jimexist commented on a change in pull request #403:
URL: https://github.com/apache/arrow-datafusion/pull/403#discussion_r642104014
##
File path: datafusion/src/physical_plan/expressions/nth_value.rs
##
@@ -0,0 +1,223 @@
+// Licensed to the Apache Software Foundation (ASF) unde
Jimexist opened a new issue #448:
URL: https://github.com/apache/arrow-datafusion/issues/448
I wonder if a more idomatic Rust way of doing this would be an enum like
```rust
enum NthValue {
First,
Last,
Nth(u32)
}
```
And then in `NthValueAccumulator
Jimexist commented on pull request #403:
URL: https://github.com/apache/arrow-datafusion/pull/403#issuecomment-851031913
> @Jimexist there is some change in `parquet-testing` can you revert that
change?
> Otherwise it's looking good (added some comments), I agree with @alamb we
can merg
jorgecarleitao commented on issue #374:
URL:
https://github.com/apache/arrow-datafusion/issues/374#issuecomment-851023806
Closed in #388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
jorgecarleitao closed issue #374:
URL: https://github.com/apache/arrow-datafusion/issues/374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
codecov-commenter commented on pull request #447:
URL: https://github.com/apache/arrow-datafusion/pull/447#issuecomment-851021809
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/447?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment
jorgecarleitao opened a new pull request #447:
URL: https://github.com/apache/arrow-datafusion/pull/447
Closes #446
Also simplifies many of the internal imports, removing unused imports and
place them all at the top of the module / file.
--
This is an automated message from th
jorgecarleitao opened a new issue #446:
URL: https://github.com/apache/arrow-datafusion/issues/446
And instead make it use `datafusion::arrow::*`. This allows the package to
follow what `datafusion` uses more closely, thereby reducing the need to bump
versions in ballista.
--
This i
ianmcook closed pull request #10327:
URL: https://github.com/apache/arrow/pull/10327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
ianmcook commented on a change in pull request #10327:
URL: https://github.com/apache/arrow/pull/10327#discussion_r642087084
##
File path: r/R/type.R
##
@@ -423,6 +423,24 @@ as_type <- function(type, name = "type") {
type
}
+canonical_type_str <- function(type_str) {
Rev
liyafan82 commented on pull request #10423:
URL: https://github.com/apache/arrow/pull/10423#issuecomment-850985161
> CC @liyafan82 or @lidavidm would you mind reviewing?
@emkornfield Thank you for working on this. I will take a look two or three
days later, when I come back from voca
codecov-commenter edited a comment on pull request #441:
URL: https://github.com/apache/arrow-datafusion/pull/441#issuecomment-850900230
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/441?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
jorgecarleitao edited a comment on issue #444:
URL:
https://github.com/apache/arrow-datafusion/issues/444#issuecomment-850976838
fyi, the goal of being `Vec` was to allow multi-argument aggregates. An
example is the pearson correlation between two columns (which can currently be
implement
Dandandan closed issue #444:
URL: https://github.com/apache/arrow-datafusion/issues/444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pl
Dandandan commented on issue #444:
URL:
https://github.com/apache/arrow-datafusion/issues/444#issuecomment-850977249
@jorgecarleitao Ah, yeah I think that makes sense. I'll just take care of it.
I think there is still some code (e.g. in Ballista protobuf I believe) that
assumes only
Dandandan closed pull request #445:
URL: https://github.com/apache/arrow-datafusion/pull/445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
jorgecarleitao commented on issue #444:
URL:
https://github.com/apache/arrow-datafusion/issues/444#issuecomment-850976838
fyi, the goal of being `Vec` was to allow multi-argument aggregates. An
example is the person correlation between two columns (which can currently be
implemented via a
Dandandan opened a new pull request #445:
URL: https://github.com/apache/arrow-datafusion/pull/445
# Which issue does this PR close?
Closes #444
# Rationale for this change
This makes the representation of aggregate functions more correct, makes
code dealing wi
Dandandan opened a new issue #444:
URL: https://github.com/apache/arrow-datafusion/issues/444
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
This makes the representation of aggregate functions more correct, makes
code dealing w
codecov-commenter edited a comment on pull request #441:
URL: https://github.com/apache/arrow-datafusion/pull/441#issuecomment-850900230
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/441?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
codecov-commenter edited a comment on pull request #441:
URL: https://github.com/apache/arrow-datafusion/pull/441#issuecomment-850900230
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/441?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
codecov-commenter edited a comment on pull request #382:
URL: https://github.com/apache/arrow-rs/pull/382#issuecomment-850953216
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/382?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter
ritchie46 commented on pull request #382:
URL: https://github.com/apache/arrow-rs/pull/382#issuecomment-850967804
@jorgecarleitao I implemented your proposal from #347. As we now need to
define an `enum` in the `with_capacities` constructor, I want to be extra
certain that I added all pos
jorgecarleitao commented on pull request #382:
URL: https://github.com/apache/arrow-rs/pull/382#issuecomment-850961132
Thanks @ritchie46 . My small concerns with this PR:
1. We are introducing yet another builder API for something relatively easy
to accomplish with an extra method
jorgecarleitao commented on issue #347:
URL: https://github.com/apache/arrow-rs/issues/347#issuecomment-850961026
I agree that it would be great to have a method to specify all capacities.
The required capacity is usually dependent on the problem over which
`MutableArrayData` is used
codecov-commenter commented on pull request #382:
URL: https://github.com/apache/arrow-rs/pull/382#issuecomment-850953216
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/382?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A
58 matches
Mail list logo
