arthursunbao commented on issue #10885:
URL: https://github.com/apache/arrow/issues/10885#issuecomment-895778664
OK. Thanks. That all I want to ask
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Dandandan closed issue #843:
URL: https://github.com/apache/arrow-datafusion/issues/843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-uns
Dandandan merged pull request #845:
URL: https://github.com/apache/arrow-datafusion/pull/845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: githu
aocsa commented on a change in pull request #10802:
URL: https://github.com/apache/arrow/pull/10802#discussion_r685732700
##
File path: cpp/src/arrow/compute/kernels/vector_selection.cc
##
@@ -2146,6 +2147,203 @@ class TakeMetaFunction : public MetaFunction {
}
};
+// ---
aocsa edited a comment on pull request #10802:
URL: https://github.com/apache/arrow/pull/10802#issuecomment-895768466
I updated this PR addressing feedback comments.
Main change, the following test cases were added.
- 0-lengthed inputs (to test the early termination code paths)
aocsa edited a comment on pull request #10802:
URL: https://github.com/apache/arrow/pull/10802#issuecomment-895768466
I updated the PR addressing feedback.
The following test cases were added.
- 0-lengthed inputs (to test the early termination code paths)
- non-zero but all nul
aocsa commented on pull request #10802:
URL: https://github.com/apache/arrow/pull/10802#issuecomment-895768466
I updated the PR addressing feedback.
The following test cases were added.
- 0-lengthed inputs (to test the early termination code paths)
- non-zero but all null value
houqp commented on pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688#issuecomment-895764931
converting PR back to draft mode since I noticed buildx just released a
native github action backend that we can leverage to keep layer cache size from
growing unbounded. i
sundy-li commented on issue #846:
URL:
https://github.com/apache/arrow-datafusion/issues/846#issuecomment-895763475
> With grouping the values in one value I am wondering whether it's good
enough for the hashtable? Or would you hash that again?
We don't care about the rehash in hash
aocsa commented on a change in pull request #10802:
URL: https://github.com/apache/arrow/pull/10802#discussion_r684369347
##
File path: cpp/src/arrow/compute/kernels/vector_selection.cc
##
@@ -2146,6 +2147,203 @@ class TakeMetaFunction : public MetaFunction {
}
};
+// ---
aocsa commented on a change in pull request #10802:
URL: https://github.com/apache/arrow/pull/10802#discussion_r685724753
##
File path: cpp/src/arrow/compute/kernels/vector_selection.cc
##
@@ -2146,6 +2147,203 @@ class TakeMetaFunction : public MetaFunction {
}
};
+// ---
aocsa commented on a change in pull request #10802:
URL: https://github.com/apache/arrow/pull/10802#discussion_r684373896
##
File path: cpp/src/arrow/compute/kernels/vector_selection.cc
##
@@ -2146,6 +2147,203 @@ class TakeMetaFunction : public MetaFunction {
}
};
+// ---
kou closed pull request #10900:
URL: https://github.com/apache/arrow/pull/10900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
kou commented on pull request #10900:
URL: https://github.com/apache/arrow/pull/10900#issuecomment-895749575
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
Dandandan commented on pull request #844:
URL: https://github.com/apache/arrow-datafusion/pull/844#issuecomment-895743451
I think it's pretty hard as @alamb mentions to vectorize this part, as it
also depends on the hashtable data structure (check collision on insert). I
think a fully vect
Dandandan commented on pull request #844:
URL: https://github.com/apache/arrow-datafusion/pull/844#issuecomment-895739487
I agree vectorizing that part can be hard I think it means somehow delaying
the collision handling and doing it for the full batch instead.
That might require impleme
Dandandan commented on issue #846:
URL:
https://github.com/apache/arrow-datafusion/issues/846#issuecomment-895733077
> If a column is nullable, we can use another byte to store the nullable
bits.
>
> If [u8, u8, u16] are all nullable, u64 key can be used.
How do you avoid tha
emkornfield commented on pull request #10603:
URL: https://github.com/apache/arrow/pull/10603#issuecomment-895723052
@shollyman any thoughts on were you want to take this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
emkornfield closed pull request #10600:
URL: https://github.com/apache/arrow/pull/10600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-uns
emkornfield commented on pull request #10600:
URL: https://github.com/apache/arrow/pull/10600#issuecomment-895720293
Sorry for the delay. Looks OK to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
emkornfield commented on a change in pull request #10789:
URL: https://github.com/apache/arrow/pull/10789#discussion_r685679951
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorTypeVisitor.java
##
@@ -114,6 +114,25 @@ private void validate
emkornfield commented on a change in pull request #10789:
URL: https://github.com/apache/arrow/pull/10789#discussion_r685679475
##
File path: java/tools/src/test/java/org/apache/arrow/tools/TestIpcFuzz.java
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation
emkornfield commented on a change in pull request #10789:
URL: https://github.com/apache/arrow/pull/10789#discussion_r685679286
##
File path: java/tools/src/test/java/org/apache/arrow/tools/TestIpcFuzz.java
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation
dongjoon-hyun commented on pull request #10838:
URL: https://github.com/apache/arrow/pull/10838#issuecomment-895716743
Thank you so much, @emkornfield ! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
emkornfield commented on pull request #10838:
URL: https://github.com/apache/arrow/pull/10838#issuecomment-895714092
Sorry for the delay, JIRA is now assigned to @dongjoon-hyun thanks for the
update!
--
This is an automated message from the Apache Git Service.
To respond to the message,
emkornfield commented on pull request #10864:
URL: https://github.com/apache/arrow/pull/10864#issuecomment-895707729
@liyafan82 thanks for doing this. i think we should split this work as
follows:
1. Changes to ArrowBuf
2. Changes to Vectors
3. Rollback removal of "deprecatd" m
andygrove closed issue #658:
URL: https://github.com/apache/arrow-datafusion/issues/658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-uns
andygrove commented on issue #658:
URL:
https://github.com/apache/arrow-datafusion/issues/658#issuecomment-895699718
@Dandandan This does seem to be resolved now. I ran it half a dozen times
just now and got consistent results:
```
++-+
lilixiang commented on a change in pull request #10893:
URL: https://github.com/apache/arrow/pull/10893#discussion_r685647708
##
File path: python/pyarrow/tests/test_flight.py
##
@@ -1545,6 +1573,33 @@ def test_roundtrip_errors():
with pytest.raises(flight.FlightIntern
jvictorhuguenin commented on pull request #10425:
URL: https://github.com/apache/arrow/pull/10425#issuecomment-895676708
@anthonylouisbsb, applied changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
westonpace merged pull request #14:
URL: https://github.com/apache/arrow-cookbook/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-u
westonpace opened a new pull request #26:
URL: https://github.com/apache/arrow-cookbook/pull/26
Right now the deploy operation checks out the current gh-pages branch, does
a `git add *` to update it, and then pushes it. However, this has some
downsides, most of which could be worked aroun
houqp edited a comment on issue #824:
URL:
https://github.com/apache/arrow-datafusion/issues/824#issuecomment-895662485
Based on the discussion so far, I recommend closing this issue since it was
originally created for global shared ExecutionContext and I think we have
already reached a c
houqp commented on issue #824:
URL:
https://github.com/apache/arrow-datafusion/issues/824#issuecomment-895662485
Based on the discussion so far, I recommend closing this issue since it was
originally created for global shared ExecutionContext and I think we have
already reached a consensu
lidavidm commented on a change in pull request #10890:
URL: https://github.com/apache/arrow/pull/10890#discussion_r685624528
##
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##
@@ -133,6 +134,116 @@ Result>
MeanInit(KernelContext* ctx,
return visitor.Create();
houqp commented on a change in pull request #651:
URL: https://github.com/apache/arrow-rs/pull/651#discussion_r685619334
##
File path: arrow/src/compute/kernels/temporal.rs
##
@@ -166,8 +168,62 @@ where
Ok(b.finish())
}
+/// Add the given `time_delta` to each time in th
kou commented on a change in pull request #10710:
URL: https://github.com/apache/arrow/pull/10710#discussion_r685617384
##
File path: r/configure
##
@@ -173,6 +186,11 @@ else
BUNDLED_LIBS=`echo "$BUNDLED_LIBS" | sed -e "s/\\.a lib/ -l/g" | sed
-e "s/\\.a$//" | sed -e
sunchao closed issue #660:
URL: https://github.com/apache/arrow-rs/issues/660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@a
sunchao merged pull request #662:
URL: https://github.com/apache/arrow-rs/pull/662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
jvictorhuguenin commented on a change in pull request #10425:
URL: https://github.com/apache/arrow/pull/10425#discussion_r685614811
##
File path: cpp/src/gandiva/precompiled/time_test.cc
##
@@ -315,6 +316,18 @@ TEST(TestTime, TimeStampAdd) {
EXPECT_EQ(add_date64_int64(String
jvictorhuguenin commented on a change in pull request #10425:
URL: https://github.com/apache/arrow/pull/10425#discussion_r685610874
##
File path: cpp/src/gandiva/precompiled/timestamp_arithmetic.cc
##
@@ -172,6 +172,57 @@ TIMESTAMP_DIFF(timestamp)
return millis + TO_MILLIS
kou commented on a change in pull request #10900:
URL: https://github.com/apache/arrow/pull/10900#discussion_r685603701
##
File path: c_glib/arrow-glib/basic-array.cpp
##
@@ -556,6 +558,81 @@ garrow_array_class_init(GArrowArrayClass *klass)
g_object_class_install_property(go
sundy-li commented on issue #846:
URL:
https://github.com/apache/arrow-datafusion/issues/846#issuecomment-895631463
If a column is nullable, we can use another byte to store the nullable bits.
If [u8, u8, u16] are all nullable, u64 key can be used.
--
This is an automated message
lidavidm commented on a change in pull request #22:
URL: https://github.com/apache/arrow-cookbook/pull/22#discussion_r685599066
##
File path: cpp/CONTRIBUTING.md
##
@@ -0,0 +1,184 @@
+Bulding the C++ Cookbook
+
+
+The C++ cookbook combines output from a
houqp commented on pull request #801:
URL: https://github.com/apache/arrow-datafusion/pull/801#issuecomment-895625177
I will wait for https://github.com/apache/arrow-datafusion/pull/845 before
merging this in to create a release tarball for voting.
--
This is an automated message from th
edponce commented on a change in pull request #10896:
URL: https://github.com/apache/arrow/pull/10896#discussion_r685586159
##
File path: cpp/src/arrow/compute/kernels/scalar_validity.cc
##
@@ -76,11 +79,32 @@ struct IsInfOperator {
struct IsNullOperator {
static Status C
hengaini2055 edited a comment on issue #10899:
URL: https://github.com/apache/arrow/issues/10899#issuecomment-895618846
[library
datasets](https://github.com/huggingface/datasets/blob/171f2bba9dd8b92006b13cf076a5bf31d67d3e69/src/datasets/table.py#L42),
use ```pa.memory_map(filename)``` to
edponce commented on a change in pull request #10896:
URL: https://github.com/apache/arrow/pull/10896#discussion_r685586159
##
File path: cpp/src/arrow/compute/kernels/scalar_validity.cc
##
@@ -76,11 +79,32 @@ struct IsInfOperator {
struct IsNullOperator {
static Status C
hengaini2055 commented on issue #10899:
URL: https://github.com/apache/arrow/issues/10899#issuecomment-895618846
[library datasets](url), use ```pa.memory_map(filename)``` to create a
memory mapped pa.table. The file may be a parquet file, a cvs file, or a
*.arrow (feather file)? As you sa
edponce commented on a change in pull request #10896:
URL: https://github.com/apache/arrow/pull/10896#discussion_r685586159
##
File path: cpp/src/arrow/compute/kernels/scalar_validity.cc
##
@@ -76,11 +79,32 @@ struct IsInfOperator {
struct IsNullOperator {
static Status C
hengaini2055 commented on issue #10899:
URL: https://github.com/apache/arrow/issues/10899#issuecomment-895609491
@lidavidm Thanks! How can I memory-map a Parquet file? I want to gain 'zero
copy' from a directory database(pyarrow). In Microsoft Power BI, We must read
all dataset to memory a
NGA-TRAN commented on a change in pull request #808:
URL: https://github.com/apache/arrow-datafusion/pull/808#discussion_r685543182
##
File path: datafusion/src/physical_plan/hash_aggregate.rs
##
@@ -779,8 +553,47 @@ impl GroupedHashAggregateStream {
}
type AccumulatorItem
westonpace opened a new issue #25:
URL: https://github.com/apache/arrow-cookbook/issues/25
PRs should have a clang-format check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
westonpace commented on a change in pull request #22:
URL: https://github.com/apache/arrow-cookbook/pull/22#discussion_r685544291
##
File path: cpp/code/CMakeLists.txt
##
@@ -0,0 +1,47 @@
+cmake_minimum_required(VERSION 3.19)
+project(arrow-cookbook)
+
+set(CMAKE_CXX_STANDARD 1
westonpace commented on a change in pull request #22:
URL: https://github.com/apache/arrow-cookbook/pull/22#discussion_r685543686
##
File path: cpp/CONTRIBUTING.md
##
@@ -0,0 +1,184 @@
+Bulding the C++ Cookbook
+
+
+The C++ cookbook combines output from
edponce commented on a change in pull request #10896:
URL: https://github.com/apache/arrow/pull/10896#discussion_r685534294
##
File path: cpp/src/arrow/compute/kernels/scalar_validity.cc
##
@@ -76,7 +79,26 @@ struct IsInfOperator {
struct IsNullOperator {
static Status Ca
cpcloud commented on a change in pull request #10856:
URL: https://github.com/apache/arrow/pull/10856#discussion_r685523322
##
File path: format/ComputeIR.fbs
##
@@ -0,0 +1,521 @@
+/// Licensed to the Apache Software Foundation (ASF) under one
+/// or more contributor license a
cpcloud commented on a change in pull request #10856:
URL: https://github.com/apache/arrow/pull/10856#discussion_r685522985
##
File path: format/ComputeIR.fbs
##
@@ -0,0 +1,510 @@
+/// Licensed to the Apache Software Foundation (ASF) under one
+/// or more contributor license a
lorenzwalthert commented on pull request #10879:
URL: https://github.com/apache/arrow/pull/10879#issuecomment-895542436
Thanks @nealrichardson. I referenced your comment in an open issue
(https://github.com/REditorSupport/languageserver/issues/462), I hope this gets
resolved. Regarding tha
westonpace closed pull request #10729:
URL: https://github.com/apache/arrow/pull/10729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsu
github-actions[bot] commented on pull request #10889:
URL: https://github.com/apache/arrow/pull/10889#issuecomment-895502332
Revision: c84b440e48a9f91513531bfab3ac2f1d8fcd6630
Submitted crossbow builds: [ursacomputing/crossbow @
actions-749](https://github.com/ursacomputing/crossbow/
nealrichardson commented on pull request #10889:
URL: https://github.com/apache/arrow/pull/10889#issuecomment-895501771
@github-actions crossbow submit test-r-rhub-debian-gcc-devel-lto-latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
alamb edited a comment on issue #790:
URL:
https://github.com/apache/arrow-datafusion/issues/790#issuecomment-895497999
https://github.com/apache/arrow-datafusion/pull/808 is now ready for review
by a wider group (no pun intended)
--
This is an automated message from the Apache Git Serv
alamb commented on issue #790:
URL:
https://github.com/apache/arrow-datafusion/issues/790#issuecomment-895497999
https://github.com/apache/arrow-datafusion/pull/808 is now ready for review
by a wider group
--
This is an automated message from the Apache Git Service.
To respond to the me
pitrou commented on pull request #10877:
URL: https://github.com/apache/arrow/pull/10877#issuecomment-895495304
Thank you for contributing @neil-b !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
emkornfield commented on pull request #10729:
URL: https://github.com/apache/arrow/pull/10729#issuecomment-895494683
forgot to to comment, these changes looks fine. thanks for tracing down the
paths. I don't know why stats for datapagev2 would have been disabled.
--
This is an automate
pitrou closed pull request #10877:
URL: https://github.com/apache/arrow/pull/10877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
westonpace commented on pull request #10729:
URL: https://github.com/apache/arrow/pull/10729#issuecomment-895487924
Forgot about this. Rebasing and then merging on green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
westonpace commented on issue #10885:
URL: https://github.com/apache/arrow/issues/10885#issuecomment-895485912
> Thanks, so you mean the IPC feather file format is the output of
ArvoStreamWriter, which is a binary file, but just with no data in it right?
I'm sorry but I don't know ho
github-actions[bot] commented on pull request #10889:
URL: https://github.com/apache/arrow/pull/10889#issuecomment-895485857
Revision: 039e68ce39788af3eab7683c729f0869cc2f388a
Submitted crossbow builds: [ursacomputing/crossbow @
actions-748](https://github.com/ursacomputing/crossbow/
nealrichardson commented on pull request #10889:
URL: https://github.com/apache/arrow/pull/10889#issuecomment-895485382
@github-actions crossbow submit test-r-rhub-debian-gcc-devel-lto-latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
jonkeane commented on pull request #10898:
URL: https://github.com/apache/arrow/pull/10898#issuecomment-895477736
That seems pretty uncommon to me. I could contrive a few examples that
aren't totally outlandish (say you're scaling/normalizing a value by groups,
you might save the log base
github-actions[bot] commented on pull request #10889:
URL: https://github.com/apache/arrow/pull/10889#issuecomment-895466709
Revision: 2f70cc4c82d9124118be151461b90fcf18f45ad2
Submitted crossbow builds: [ursacomputing/crossbow @
actions-747](https://github.com/ursacomputing/crossbow/
nealrichardson commented on pull request #10889:
URL: https://github.com/apache/arrow/pull/10889#issuecomment-895466005
@github-actions crossbow submit test-r-rhub-debian-gcc-devel-lto-latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
bkietz commented on a change in pull request #10802:
URL: https://github.com/apache/arrow/pull/10802#discussion_r685444859
##
File path: cpp/src/arrow/compute/kernels/vector_selection_test.cc
##
@@ -1734,5 +1734,372 @@ TEST(TestTake, RandomFixedSizeBinary) {
TakeRandomTest::
pitrou closed pull request #10871:
URL: https://github.com/apache/arrow/pull/10871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
westonpace edited a comment on pull request #10897:
URL: https://github.com/apache/arrow/pull/10897#issuecomment-895450555
Ah, if this is a behavior change then I can update that docstring as well.
I'll add, in support of my argument, that we parse quoted non-nulls as
integers. For examp
westonpace commented on pull request #10897:
URL: https://github.com/apache/arrow/pull/10897#issuecomment-895450555
Ah, if this is a behavior change then I can update that docstring as well.
I'll add, in support of my argument, that we parsed quoted non-nulls as
integers. For example:
github-actions[bot] commented on pull request #10889:
URL: https://github.com/apache/arrow/pull/10889#issuecomment-895445042
Revision: f5c007c2b6b6856e29c3f162d77e5173544cebb2
Submitted crossbow builds: [ursacomputing/crossbow @
actions-746](https://github.com/ursacomputing/crossbow/
nealrichardson commented on pull request #10889:
URL: https://github.com/apache/arrow/pull/10889#issuecomment-895444350
@github-actions crossbow submit test-r-rhub-debian-gcc-devel-lto-latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
Dandandan edited a comment on pull request #808:
URL: https://github.com/apache/arrow-datafusion/pull/808#issuecomment-895425959
On the db-benchmark aggregation queries:
PR:
```
q1 took 33 ms
q2 took 377 ms
q3 took 986 ms
q4 took 47 ms
q5 took 973 ms
q7 took 932 m
Dandandan commented on pull request #808:
URL: https://github.com/apache/arrow-datafusion/pull/808#issuecomment-895425959
On the db-benchmark aggregation queries:
PR:
```
q1 took 33 ms
q2 took 377 ms
q3 took 986 ms
q4 took 47 ms
q5 took 973 ms
q7 took 932 ms
q1
carlosmalt commented on a change in pull request #10431:
URL: https://github.com/apache/arrow/pull/10431#discussion_r685406286
##
File path: cpp/src/arrow/dataset/file_skyhook.h
##
@@ -0,0 +1,275 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more cont
Dandandan commented on issue #846:
URL:
https://github.com/apache/arrow-datafusion/issues/846#issuecomment-895422907
For the direct indexing idea, there is some more context here for the hash
join https://github.com/apache/arrow-datafusion/issues/816 where a similar
approach could be used
nealrichardson closed pull request #10894:
URL: https://github.com/apache/arrow/pull/10894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-
kkraus14 commented on pull request #10897:
URL: https://github.com/apache/arrow/pull/10897#issuecomment-895417384
Agreed that it's beneficial to change the behavior and docstring to allow
for treating empty quoted strings as null in the case of numeric columns.
Bigger picture, CSVs a
pitrou commented on pull request #10898:
URL: https://github.com/apache/arrow/pull/10898#issuecomment-895414211
cc @ianmcook @jonkeane for opinions about the log base question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
rommelDB commented on pull request #10898:
URL: https://github.com/apache/arrow/pull/10898#issuecomment-895413500
> Is it useful for the log base to be given as a `Datum` rather than a
function option? Are there use cases where one wants to lookup the log base in
a column?
@pitrou T
alamb commented on pull request #808:
URL: https://github.com/apache/arrow-datafusion/pull/808#issuecomment-895409906
I am basically done with this PR. All that remains in my mind is to run some
benchmarks and I'll mark it as ready for review
--
This is an automated message from the Apac
pitrou commented on a change in pull request #10871:
URL: https://github.com/apache/arrow/pull/10871#discussion_r685391213
##
File path: cpp/src/arrow/array/validate.cc
##
@@ -637,6 +638,23 @@ struct ValidateArrayFullImpl {
ARROW_EXPORT
Status ValidateArrayFull(const ArrayD
Dandandan commented on a change in pull request #840:
URL: https://github.com/apache/arrow-datafusion/pull/840#discussion_r685390622
##
File path: ballista/rust/core/proto/ballista.proto
##
@@ -144,18 +144,19 @@ enum ScalarFunction {
TOTIMESTAMP = 24;
ARRAY = 25;
NULLI
Dandandan commented on pull request #840:
URL: https://github.com/apache/arrow-datafusion/pull/840#issuecomment-895408746
Thanks @houqp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
alamb commented on issue #790:
URL:
https://github.com/apache/arrow-datafusion/issues/790#issuecomment-895408719
@sundy-li the idea of special casing fixed length types into fixed length
keys is a great idea, FWIW. I think we would probably get non trivial
performance speedup for those p
Dandandan merged pull request #840:
URL: https://github.com/apache/arrow-datafusion/pull/840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: githu
alamb opened a new issue #846:
URL: https://github.com/apache/arrow-datafusion/issues/846
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
The improved grouping algorithm on #790 improves grouping performance in
general for DataFu
Dandandan commented on issue #790:
URL:
https://github.com/apache/arrow-datafusion/issues/790#issuecomment-895407611
> FWIW I would expect `ScalarValue::iter_to_array` to show up in profiles
only for queries that had large numbers of groups where the time spent creating
the output was a s
Dandandan commented on issue #790:
URL:
https://github.com/apache/arrow-datafusion/issues/790#issuecomment-895407042
@sundy-li
Yes, I think for some types the hashing method might be further specialized
to speed up the hashing or to reduce the amount of memory needed for the hash
v
pitrou closed pull request #10886:
URL: https://github.com/apache/arrow/pull/10886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
lidavidm commented on a change in pull request #10890:
URL: https://github.com/apache/arrow/pull/10890#discussion_r685385813
##
File path: cpp/src/arrow/compute/kernels/aggregate_test.cc
##
@@ -189,6 +189,53 @@ TEST(TestBooleanAggregation, Sum) {
ResultWith(Datum
lidavidm commented on a change in pull request #10890:
URL: https://github.com/apache/arrow/pull/10890#discussion_r685385480
##
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##
@@ -133,6 +134,116 @@ Result>
MeanInit(KernelContext* ctx,
return visitor.Create();
1 - 100 of 209 matches
Mail list logo
