houqp commented on pull request #811:
URL: https://github.com/apache/arrow-datafusion/pull/811#issuecomment-906087245
I also think constructing `ParquetTable` async before passing to
`register_table` is a good idea. This is how delta-rs implements its
daatafusion integration as well.
liyafan82 closed pull request #10949:
URL: https://github.com/apache/arrow/pull/10949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
liyafan82 commented on pull request #10177:
URL: https://github.com/apache/arrow/pull/10177#issuecomment-906025236
The Java changes LGTM. Good job! @emkornfield
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cyb70289 closed pull request #11004:
URL: https://github.com/apache/arrow/pull/11004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubs
yjshen closed issue #731:
URL: https://github.com/apache/arrow-datafusion/issues/731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubs
github-actions[bot] commented on pull request #11004:
URL: https://github.com/apache/arrow/pull/11004#issuecomment-906004369
Revision: 755e0a5a0510c87fb7fb8f30edc95399e29c8e91
Submitted crossbow builds: [ursacomputing/crossbow @
actions-793](https://github.com/ursacomputing/crossbow/
cyb70289 commented on pull request #11004:
URL: https://github.com/apache/arrow/pull/11004#issuecomment-906004041
@github-actions crossbow submit test-ubuntu-20.04-cpp-14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
kimotorc closed issue #10965:
URL: https://github.com/apache/arrow/issues/10965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
kimotorc commented on issue #10965:
URL: https://github.com/apache/arrow/issues/10965#issuecomment-905967966
Thanks, I've filed a JIRA
([ARROW-13763](https://issues.apache.org/jira/browse/ARROW-13763)) with some
minimal code attached to demonstrate how the files are closed.
I've tri
emkornfield commented on pull request #9205:
URL: https://github.com/apache/arrow/pull/9205#issuecomment-905929679
Is there a technical blocker for keeping binary files in one of the
submodule testdata repos? I don't think other languages keep any data locally
in this repo.
--
This is
kkraus14 commented on a change in pull request #10979:
URL: https://github.com/apache/arrow/pull/10979#discussion_r696161541
##
File path: format/IRFunction.fbs
##
@@ -0,0 +1,68 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
kkraus14 commented on a change in pull request #10979:
URL: https://github.com/apache/arrow/pull/10979#discussion_r696161541
##
File path: format/IRFunction.fbs
##
@@ -0,0 +1,68 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
edponce commented on a change in pull request #10349:
URL: https://github.com/apache/arrow/pull/10349#discussion_r696160814
##
File path: python/pyarrow/tests/test_compute.py
##
@@ -1299,6 +1301,98 @@ def test_arithmetic_multiply():
assert result.equals(expected)
+@pyt
westonpace closed pull request #11003:
URL: https://github.com/apache/arrow/pull/11003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsu
github-actions[bot] commented on pull request #11004:
URL: https://github.com/apache/arrow/pull/11004#issuecomment-905913302
Revision: 755e0a5a0510c87fb7fb8f30edc95399e29c8e91
Submitted crossbow builds: [ursacomputing/crossbow @
actions-792](https://github.com/ursacomputing/crossbow/
westonpace commented on pull request #11004:
URL: https://github.com/apache/arrow/pull/11004#issuecomment-905912937
@github-actions crossbow submit test-ubuntu-20.04-cpp-17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
westonpace commented on issue #11007:
URL: https://github.com/apache/arrow/issues/11007#issuecomment-905911039
I think the short answer is that there is no way to handle this today but it
is valid future work.
The `isin` expression maps to the `is_in` kernel which only tests if an
e
seddonm1 commented on pull request #947:
URL: https://github.com/apache/arrow-datafusion/pull/947#issuecomment-905901026
looks good đź‘Ť
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
jacques-n commented on a change in pull request #10979:
URL: https://github.com/apache/arrow/pull/10979#discussion_r696135671
##
File path: format/IRFunction.fbs
##
@@ -0,0 +1,68 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
rok commented on a change in pull request #10997:
URL: https://github.com/apache/arrow/pull/10997#discussion_r696129093
##
File path: format/Schema.fbs
##
@@ -214,58 +214,123 @@ table Time {
bitWidth: int = 32;
}
-/// Time elapsed from the Unix epoch, 00:00:00.000 on 1 Ja
karldw commented on pull request #11001:
URL: https://github.com/apache/arrow/pull/11001#issuecomment-905889478
In the latest commit, I removed `LIBARROW_DOWNLOAD` and added
`TEST_OFFLINE_BUILD`. Does that seem right to you?
I wasn't positive I got the logic right in this section of
karldw commented on a change in pull request #11001:
URL: https://github.com/apache/arrow/pull/11001#discussion_r696125528
##
File path: r/tools/nixlibs.R
##
@@ -52,6 +43,21 @@ try_download <- function(from_url, to_file) {
!inherits(status, "try-error") && status == 0
}
+
babylone-star opened a new issue #11007:
URL: https://github.com/apache/arrow/issues/11007
Take the following table stored via pyarrow into Apache Parquet:
| | id | regions|
| - | -- | -- |
| 0 | A | ['us', 'uk'] |
| 1 | B | ['uk', 'mx'] |
karldw commented on a change in pull request #11001:
URL: https://github.com/apache/arrow/pull/11001#discussion_r696121898
##
File path: r/tools/nixlibs.R
##
@@ -52,6 +43,21 @@ try_download <- function(from_url, to_file) {
!inherits(status, "try-error") && status == 0
}
+
rok commented on pull request #10998:
URL: https://github.com/apache/arrow/pull/10998#issuecomment-905878409
@jorisvandenbossche I've pushed changes for second and third (printing
timezoneless timestamps and docs) point. I left the first as was (not timezone
data by default).
Please see
westonpace commented on a change in pull request #10794:
URL: https://github.com/apache/arrow/pull/10794#discussion_r696111634
##
File path: python/pyarrow/tests/test_csv.py
##
@@ -609,28 +489,184 @@ def test_skip_rows_after_names(self):
assert (values[opts.skip_ro
bkietz commented on a change in pull request #10915:
URL: https://github.com/apache/arrow/pull/10915#discussion_r696109693
##
File path: cpp/src/arrow/util/small_vector.h
##
@@ -0,0 +1,519 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
seddonm1 commented on pull request #947:
URL: https://github.com/apache/arrow-datafusion/pull/947#issuecomment-905869497
hi @adsharma . this looks good and I think it is correct.
I am not sure your tests are proving anything additional? This would benefit
from tests proving the `trim
alamb opened a new pull request #948:
URL: https://github.com/apache/arrow-datafusion/pull/948
# Which issue does this PR close?
Next part https://github.com/apache/arrow-datafusion/issues/866
Builds on https://github.com/apache/arrow-datafusion/pull/938 so review that
fir
seddonm1 commented on issue #935:
URL:
https://github.com/apache/arrow-datafusion/issues/935#issuecomment-905864071
I had a look at the postgres docs again and this implementation meets their
definition
(https://www.postgresql.org/docs/current/functions-string.html#id-1.5.8.10.7.2.2.2.1.1
bkietz closed pull request #10876:
URL: https://github.com/apache/arrow/pull/10876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
bkietz commented on pull request #10916:
URL: https://github.com/apache/arrow/pull/10916#issuecomment-905862899
@lidavidm rebased, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
kou commented on a change in pull request #11006:
URL: https://github.com/apache/arrow/pull/11006#discussion_r696094485
##
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##
@@ -1414,7 +1414,7 @@ endmacro()
if(ARROW_WITH_PROTOBUF)
if(ARROW_WITH_GRPC)
# gRPC 1.21
rok commented on pull request #10610:
URL: https://github.com/apache/arrow/pull/10610#issuecomment-905851379
What would be a good way to reach consensus here? A doodle poll to ML to see
what people find most intuitive?
--
This is an automated message from the Apache Git Service.
To respo
github-actions[bot] commented on pull request #11006:
URL: https://github.com/apache/arrow/pull/11006#issuecomment-905851029
https://issues.apache.org/jira/browse/ARROW-13760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
lidavidm commented on pull request #11006:
URL: https://github.com/apache/arrow/pull/11006#issuecomment-905850863
See https://github.com/apache/arrow/pull/10906#discussion_r695034020.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lidavidm opened a new pull request #11006:
URL: https://github.com/apache/arrow/pull/11006
This is to support the FlightSQL proposal in #10906.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
westonpace commented on a change in pull request #10997:
URL: https://github.com/apache/arrow/pull/10997#discussion_r696085932
##
File path: format/Schema.fbs
##
@@ -214,58 +214,123 @@ table Time {
bitWidth: int = 32;
}
-/// Time elapsed from the Unix epoch, 00:00:00.000
thisisnic edited a comment on pull request #10930:
URL: https://github.com/apache/arrow/pull/10930#issuecomment-905346586
When changing the R package C++, I've again run into the issue that
something needs editing to make sure that the lint script uses Python 3 (I
think, can't remember the
thisisnic commented on a change in pull request #10930:
URL: https://github.com/apache/arrow/pull/10930#discussion_r696079362
##
File path: r/vignettes/developing.Rmd
##
@@ -483,60 +434,156 @@ variables or other settings:
* All tests are skipped on Linux if the package builds
alamb merged pull request #939:
URL: https://github.com/apache/arrow-datafusion/pull/939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-un
alamb closed issue #933:
URL: https://github.com/apache/arrow-datafusion/issues/933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubsc
thisisnic commented on a change in pull request #10930:
URL: https://github.com/apache/arrow/pull/10930#discussion_r696074580
##
File path: r/vignettes/developing.Rmd
##
@@ -483,60 +434,156 @@ variables or other settings:
* All tests are skipped on Linux if the package builds
lidavidm commented on a change in pull request #10906:
URL: https://github.com/apache/arrow/pull/10906#discussion_r696073452
##
File path: format/FlightSql.proto
##
@@ -0,0 +1,454 @@
+/*
Review comment:
Thank you both for chiming in, I filed
https://issues.apache.org/j
alamb commented on pull request #909:
URL: https://github.com/apache/arrow-datafusion/pull/909#issuecomment-905834242
I'll give it until tomorrow in case anyone else wants to chime in or say
they are interested in reviewing it . Thanks @andygrove
--
This is an automated message from the
seddonm1 commented on issue #935:
URL:
https://github.com/apache/arrow-datafusion/issues/935#issuecomment-905833583
@alamb let me have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb commented on issue #935:
URL:
https://github.com/apache/arrow-datafusion/issues/935#issuecomment-905832359
> The problem boils down to the interpretation: is it a set of characters or
a string to be trimmed?
I think postgres `btrim` (what DataFusion is modeled on) is supposed
github-actions[bot] commented on pull request #11005:
URL: https://github.com/apache/arrow/pull/11005#issuecomment-905831964
https://issues.apache.org/jira/browse/ARROW-13691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
lidavidm commented on pull request #11005:
URL: https://github.com/apache/arrow/pull/11005#issuecomment-905831855
This builds on top of ARROW-13737 to avoid merge conflicts. Leaving in draft
until then.
--
This is an automated message from the Apache Git Service.
To respond to the messag
adsharma opened a new pull request #947:
URL: https://github.com/apache/arrow-datafusion/pull/947
# Which issue does this PR close?
Closes #935
# Rationale for this change
# What changes are included in this PR?
Implements the where clause for
alamb merged pull request #706:
URL: https://github.com/apache/arrow-datafusion/pull/706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-un
alamb commented on pull request #909:
URL: https://github.com/apache/arrow-datafusion/pull/909#issuecomment-905826892
cc @returnString
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
adsharma commented on issue #935:
URL:
https://github.com/apache/arrow-datafusion/issues/935#issuecomment-905826481
Thanks! That was one problem. Fixed now.
But there is a second significant problem:
```
> SELECT TRIM(BOTH 'leadtrail' FROM 'leadtrailtextleadtrail');
+--
westonpace commented on pull request #10993:
URL: https://github.com/apache/arrow/pull/10993#issuecomment-905822677
Yes, thanks for working on this. The SyncScanner should be deprecated (if
not removed outright) in 6.0.0 as part of ARROW-13338 so we probably don't want
to worry too much o
rafael-telles commented on a change in pull request #10906:
URL: https://github.com/apache/arrow/pull/10906#discussion_r696049366
##
File path:
java/flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/example/FlightSqlExample.java
##
@@ -0,0 +1,1733 @@
+/*
+ * Licensed
github-actions[bot] commented on pull request #11004:
URL: https://github.com/apache/arrow/pull/11004#issuecomment-905810384
Revision: c3bab5f0a2baa787e4defe715b681b71630dbd86
Submitted crossbow builds: [ursacomputing/crossbow @
actions-791](https://github.com/ursacomputing/crossbow/
westonpace commented on pull request #11004:
URL: https://github.com/apache/arrow/pull/11004#issuecomment-905809890
@github-actions crossbow submit test-ubuntu-20.04-cpp-17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on pull request #11004:
URL: https://github.com/apache/arrow/pull/11004#issuecomment-905809585
https://issues.apache.org/jira/browse/ARROW-13744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
nealrichardson commented on a change in pull request #11001:
URL: https://github.com/apache/arrow/pull/11001#discussion_r696042759
##
File path: r/tools/nixlibs.R
##
@@ -271,13 +281,18 @@ apache_download <- function(version, destfile, n_mirrors
= 3) {
}
find_local_source <
rafael-telles commented on a change in pull request #10906:
URL: https://github.com/apache/arrow/pull/10906#discussion_r696043212
##
File path:
java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlClient.java
##
@@ -0,0 +1,560 @@
+/*
+ * Licensed to the Ap
github-actions[bot] commented on pull request #11003:
URL: https://github.com/apache/arrow/pull/11003#issuecomment-905804312
Revision: d8aa00e698b24c3f7b619cab2eacf5a6f753643a
Submitted crossbow builds: [ursacomputing/crossbow @
actions-790](https://github.com/ursacomputing/crossbow/
westonpace commented on pull request #11003:
URL: https://github.com/apache/arrow/pull/11003#issuecomment-905803627
@github-actions crossbow submit test-conda-python-3.6-pandas-0.23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
laurentgo commented on a change in pull request #10906:
URL: https://github.com/apache/arrow/pull/10906#discussion_r696041466
##
File path:
java/flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/example/StatementContext.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to th
rafael-telles commented on a change in pull request #10906:
URL: https://github.com/apache/arrow/pull/10906#discussion_r696041133
##
File path:
java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlClient.java
##
@@ -0,0 +1,560 @@
+/*
+ * Licensed to the Ap
Igosuki commented on pull request #910:
URL: https://github.com/apache/arrow-datafusion/pull/910#issuecomment-905801351
@alamb will address everything soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
alamb commented on a change in pull request #909:
URL: https://github.com/apache/arrow-datafusion/pull/909#discussion_r695031745
##
File path: datafusion/src/physical_plan/coalesce_partitions.rs
##
@@ -43,12 +45,17 @@ use pin_project_lite::pin_project;
pub struct CoalesceParti
alamb commented on pull request #909:
URL: https://github.com/apache/arrow-datafusion/pull/909#issuecomment-905799662
I have a few PRs backed up on this one (e.g.
https://github.com/apache/arrow-datafusion/pull/938) so if someone has time to
review this PR in the near term I would be most
alamb commented on a change in pull request #909:
URL: https://github.com/apache/arrow-datafusion/pull/909#discussion_r696035860
##
File path: datafusion/src/physical_plan/metrics/baseline.rs
##
@@ -0,0 +1,183 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+/
rok commented on pull request #10998:
URL: https://github.com/apache/arrow/pull/10998#issuecomment-905796113
> > Default strftime string is now `%Y-%m-%dT%H:%M:%S`. Perhaps
`%Y-%m-%dT%H:%M:%S%z` would be better?
>
> Not fully sure about this one. In [#10647
(comment)](https://github
alamb commented on pull request #706:
URL: https://github.com/apache/arrow-datafusion/pull/706#issuecomment-905794116
I rebased this PR against master and if CI is all clean I plan to merge it
in 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, p
karldw commented on pull request #11001:
URL: https://github.com/apache/arrow/pull/11001#issuecomment-905793851
These builds are failing because they set `LIBARROW_DOWNLOAD` is `false` and
they need to download cmake, but my changes block downloading cmake when
`LIBARROW_DOWNLOAD` is `fals
kylepbit commented on a change in pull request #10906:
URL: https://github.com/apache/arrow/pull/10906#discussion_r696030806
##
File path:
java/flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/example/StatementContext.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the
mathiaspeters-sig opened a new pull request #716:
URL: https://github.com/apache/arrow-rs/pull/716
# Which issue does this PR close?
Closes #397
# Rationale for this change
See issue.
# What changes are included in this PR?
Two changes:
1. I added
alamb commented on a change in pull request #712:
URL: https://github.com/apache/arrow-rs/pull/712#discussion_r696022605
##
File path: parquet_derive/src/parquet_field.rs
##
@@ -534,13 +545,23 @@ impl Type {
})) }
}
"NaiveDate" => quot
westonpace commented on pull request #11003:
URL: https://github.com/apache/arrow/pull/11003#issuecomment-905787358
@kou @kszucs I'm not sure if it would be better to just wait for the problem
to resolve itself or be proactive and change things.
--
This is an automated message from the A
github-actions[bot] commented on pull request #11003:
URL: https://github.com/apache/arrow/pull/11003#issuecomment-905787005
https://issues.apache.org/jira/browse/ARROW-13747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
westonpace opened a new pull request #11003:
URL: https://github.com/apache/arrow/pull/11003
aiobotocore recently released 1.4.0 which is incompatible with s3fs < 2021.8
(which was also just released). Related:
https://stackoverflow.com/questions/68864939/s3fs-suddenly-stopped-working-in-
github-actions[bot] commented on pull request #11002:
URL: https://github.com/apache/arrow/pull/11002#issuecomment-905778835
https://issues.apache.org/jira/browse/ARROW-13759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
alamb commented on issue #935:
URL:
https://github.com/apache/arrow-datafusion/issues/935#issuecomment-905778857
@adsharma perhaps the arguments to ltrim are reversed? Maybe something like
`ltrim(Utf8("xxxbarxxx"), Utf8("x"))` would produce the expected answer?
--
This is an automated
alamb commented on a change in pull request #910:
URL: https://github.com/apache/arrow-datafusion/pull/910#discussion_r695977278
##
File path: .gitmodules
##
@@ -3,4 +3,5 @@
url = https://github.com/apache/parquet-testing.git
[submodule "testing"]
path = testin
pitrou commented on a change in pull request #10177:
URL: https://github.com/apache/arrow/pull/10177#discussion_r696015918
##
File path: cpp/src/arrow/array/array_test.cc
##
@@ -3060,4 +3098,14 @@ TEST(TestSwapEndianArrayData, ExtensionType) {
AssertArrayDataEqualsWithSwapEn
pitrou commented on a change in pull request #10177:
URL: https://github.com/apache/arrow/pull/10177#discussion_r696014979
##
File path: cpp/src/arrow/testing/random_test.cc
##
@@ -108,8 +108,9 @@ auto values = ::testing::Values(
field("time32ms", time32(TimeUnit::MILLI)),
github-actions[bot] commented on pull request #11001:
URL: https://github.com/apache/arrow/pull/11001#issuecomment-905770415
https://issues.apache.org/jira/browse/ARROW-12981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
karldw opened a new pull request #11001:
URL: https://github.com/apache/arrow/pull/11001
I took a stab at implementing the approach @nealrichardson laid out in
[ARROW-12981](https://issues.apache.org/jira/browse/ARROW-12981?focusedCommentId=17400415#comment-17400415).
Please let me know wh
emkornfield commented on a change in pull request #10177:
URL: https://github.com/apache/arrow/pull/10177#discussion_r696007626
##
File path: cpp/src/arrow/testing/random.cc
##
@@ -867,6 +869,7 @@ std::shared_ptr RandomArrayGenerator::ArrayOf(const
Field& field, int64_t
emkornfield commented on a change in pull request #10177:
URL: https://github.com/apache/arrow/pull/10177#discussion_r696006864
##
File path: cpp/src/arrow/testing/random_test.cc
##
@@ -108,8 +108,9 @@ auto values = ::testing::Values(
field("time32ms", time32(TimeUnit::MIL
emkornfield commented on a change in pull request #10177:
URL: https://github.com/apache/arrow/pull/10177#discussion_r696006144
##
File path: cpp/src/arrow/array/array_test.cc
##
@@ -3060,4 +3098,14 @@ TEST(TestSwapEndianArrayData, ExtensionType) {
AssertArrayDataEqualsWithS
emkornfield commented on a change in pull request #10177:
URL: https://github.com/apache/arrow/pull/10177#discussion_r696005707
##
File path: cpp/src/arrow/array/array_test.cc
##
@@ -3060,4 +3098,14 @@ TEST(TestSwapEndianArrayData, ExtensionType) {
AssertArrayDataEqualsWithS
pitrou commented on a change in pull request #10177:
URL: https://github.com/apache/arrow/pull/10177#discussion_r696002224
##
File path: cpp/src/arrow/testing/random.cc
##
@@ -867,6 +869,7 @@ std::shared_ptr RandomArrayGenerator::ArrayOf(const
Field& field, int64_t
// T
pitrou commented on a change in pull request #10177:
URL: https://github.com/apache/arrow/pull/10177#discussion_r696001673
##
File path: cpp/src/arrow/array/array_test.cc
##
@@ -3060,4 +3098,14 @@ TEST(TestSwapEndianArrayData, ExtensionType) {
AssertArrayDataEqualsWithSwapEn
lidavidm commented on a change in pull request #10994:
URL: https://github.com/apache/arrow/pull/10994#discussion_r695998614
##
File path: cpp/src/arrow/compute/kernels/hash_aggregate.cc
##
@@ -1833,30 +1853,45 @@ struct GroupedBooleanAggregator : public
GroupedAggregator {
pitrou commented on a change in pull request #10994:
URL: https://github.com/apache/arrow/pull/10994#discussion_r695992451
##
File path: cpp/src/arrow/compute/kernels/hash_aggregate.cc
##
@@ -824,6 +824,36 @@ Status AddHashAggKernels(
return Status::OK();
}
+template
+vo
pitrou commented on a change in pull request #10994:
URL: https://github.com/apache/arrow/pull/10994#discussion_r695992451
##
File path: cpp/src/arrow/compute/kernels/hash_aggregate.cc
##
@@ -824,6 +824,36 @@ Status AddHashAggKernels(
return Status::OK();
}
+template
+vo
felipeblazing commented on a change in pull request #10994:
URL: https://github.com/apache/arrow/pull/10994#discussion_r695975190
##
File path: cpp/src/arrow/compute/kernels/hash_aggregate.cc
##
@@ -933,31 +967,36 @@ struct GroupedReducingAggregator : public
GroupedAggregator
rafael-telles commented on a change in pull request #10906:
URL: https://github.com/apache/arrow/pull/10906#discussion_r695990036
##
File path:
java/flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/example/StatementContext.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed t
lidavidm commented on a change in pull request #10987:
URL: https://github.com/apache/arrow/pull/10987#discussion_r695973782
##
File path: cpp/src/arrow/compute/kernels/scalar_if_else.cc
##
@@ -1827,9 +1827,131 @@ Status ExecArrayCoalesce(KernelContext* ctx, const
ExecBatch& b
jonkeane commented on pull request #11000:
URL: https://github.com/apache/arrow/pull/11000#issuecomment-905733542
_nods_ in that case let’s keep the simplest thing (the PR as is) and either
bundle source and it’s moot or add something like the retry if nightly
doesn’t exist before we r
adsharma commented on issue #935:
URL:
https://github.com/apache/arrow-datafusion/issues/935#issuecomment-905730026
Does this look right?
https://github.com/adsharma/arrow-datafusion/commit/8c4bd15725d769f6e78f8218fe27c8e935316b93
After this code, I see a query plan that look
nealrichardson commented on a change in pull request #11000:
URL: https://github.com/apache/arrow/pull/11000#discussion_r695959406
##
File path: r/tools/nixlibs.R
##
@@ -215,10 +215,8 @@ download_source <- function() {
# Given VERSION as x.y.z.p
p <- package_version(VER
thisisnic commented on a change in pull request #10930:
URL: https://github.com/apache/arrow/pull/10930#discussion_r695947178
##
File path: r/vignettes/developing.Rmd
##
@@ -60,36 +71,38 @@ brew install apache-arrow
brew install apache-arrow --HEAD
```
+### Windows and Linu
1 - 100 of 196 matches
Mail list logo
