[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-10-29 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r739611163 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -537,6 +536,341 @@ struct FixedSizeBinaryTransformExecWithState } }; +template +

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-10-29 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r739611163 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -537,6 +536,341 @@ struct FixedSizeBinaryTransformExecWithState } }; +template +

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-10-29 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r739611163 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -537,6 +536,341 @@ struct FixedSizeBinaryTransformExecWithState } }; +template +

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-10-29 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r739607083 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -537,6 +536,341 @@ struct FixedSizeBinaryTransformExecWithState } }; +template +

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-10-29 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r739603493 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -537,6 +536,341 @@ struct FixedSizeBinaryTransformExecWithState } }; +template +

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-10-29 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r739603493 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -537,6 +536,341 @@ struct FixedSizeBinaryTransformExecWithState } }; +template +

[GitHub] [arrow] westonpace commented on a change in pull request #11535: ARROW-14429: [C++] Speed up IPC file reader on high-latency filesystems

2021-10-29 Thread GitBox
westonpace commented on a change in pull request #11535: URL: https://github.com/apache/arrow/pull/11535#discussion_r739600485 ## File path: cpp/src/arrow/ipc/read_write_test.cc ## @@ -1706,6 +1706,99 @@ TEST_F(TestFileFormat, ReadFieldSubset) { TestReadSubsetOfFields(); }

[GitHub] [arrow] jonkeane closed pull request #11578: [DON'T MERGE]: testing if ARROW-14514 is fixed in CI

2021-10-29 Thread GitBox
jonkeane closed pull request #11578: URL: https://github.com/apache/arrow/pull/11578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] jonkeane commented on pull request #11573: ARROW-14514: [R] UBSAN error on round kernel

2021-10-29 Thread GitBox
jonkeane commented on pull request #11573: URL: https://github.com/apache/arrow/pull/11573#issuecomment-955130885 🎉 the sanitizer passed: https://github.com/apache/arrow/pull/11578#issuecomment-955112753 -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [arrow-datafusion] Jimexist commented on pull request #1199: [WIP] add ScalarValue::Null and remove Option wrapping in other enum cases

2021-10-29 Thread GitBox
Jimexist commented on pull request #1199: URL: https://github.com/apache/arrow-datafusion/pull/1199#issuecomment-955121817 > THanks @Jimexist ! > > 1. I think this is a nice code cleanup PR > 2. I am not sure it helps directly with null constant support, however. > > There i

[GitHub] [arrow] github-actions[bot] commented on pull request #11579: ARROW-13643: [C++][Compute] Implement outer join with support for residual predicates

2021-10-29 Thread GitBox
github-actions[bot] commented on pull request #11579: URL: https://github.com/apache/arrow/pull/11579#issuecomment-955119722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] save-buffer opened a new pull request #11579: ARROW-13643: [C++][Compute] Implement outer join with support for residual predicates

2021-10-29 Thread GitBox
save-buffer opened a new pull request #11579: URL: https://github.com/apache/arrow/pull/11579 Implements residual predicates on hash join -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [arrow] lidavidm commented on a change in pull request #11535: ARROW-14429: [C++] Speed up IPC file reader on high-latency filesystems

2021-10-29 Thread GitBox
lidavidm commented on a change in pull request #11535: URL: https://github.com/apache/arrow/pull/11535#discussion_r739589727 ## File path: cpp/src/arrow/ipc/read_write_test.cc ## @@ -1706,6 +1706,99 @@ TEST_F(TestFileFormat, ReadFieldSubset) { TestReadSubsetOfFields(); } TE

[GitHub] [arrow] westonpace commented on a change in pull request #11535: ARROW-14429: [C++] Speed up IPC file reader on high-latency filesystems

2021-10-29 Thread GitBox
westonpace commented on a change in pull request #11535: URL: https://github.com/apache/arrow/pull/11535#discussion_r739588637 ## File path: cpp/src/arrow/ipc/reader.cc ## @@ -1216,15 +1216,23 @@ class RecordBatchFileReaderImpl : public RecordBatchFileReader { } Future

[GitHub] [arrow] github-actions[bot] commented on pull request #11578: [DON'T MERGE]: testing if ARROW-14514 is fixed in CI

2021-10-29 Thread GitBox
github-actions[bot] commented on pull request #11578: URL: https://github.com/apache/arrow/pull/11578#issuecomment-955112753 Revision: 7f0788eb7f6ff4c6200099c2eb89dcd20e9230cc Submitted crossbow builds: [ursacomputing/crossbow @ actions-1062](https://github.com/ursacomputing/crossbow

[GitHub] [arrow] jonkeane commented on pull request #11578: [DON'T MERGE]: testing if ARROW-14514 is fixed in CI

2021-10-29 Thread GitBox
jonkeane commented on pull request #11578: URL: https://github.com/apache/arrow/pull/11578#issuecomment-955112559 @github-actions crossbow submit test-fedora-r-clang-sanitizer Fix a typo in the CI script -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] westonpace commented on a change in pull request #11426: ARROW-14330: [C++] Create DataHolder

2021-10-29 Thread GitBox
westonpace commented on a change in pull request #11426: URL: https://github.com/apache/arrow/pull/11426#discussion_r739573619 ## File path: cpp/src/arrow/compute/memory_resources.cc ## @@ -0,0 +1,307 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow-rs] codecov-commenter commented on pull request #874: add ilike comparitor

2021-10-29 Thread GitBox
codecov-commenter commented on pull request #874: URL: https://github.com/apache/arrow-rs/pull/874#issuecomment-955078979 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/874?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [arrow] lidavidm commented on pull request #11573: ARROW-14514: [R] UBSAN error on round kernel

2021-10-29 Thread GitBox
lidavidm commented on pull request #11573: URL: https://github.com/apache/arrow/pull/11573#issuecomment-955074250 Thanks for working out the CI stuff! I tried to get a dynmically-linked ASan working but no dice there. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [arrow] aucahuasi commented on a change in pull request #11541: ARROW-13081: [C++] Disallow comparing zoned and naive timestamps

2021-10-29 Thread GitBox
aucahuasi commented on a change in pull request #11541: URL: https://github.com/apache/arrow/pull/11541#discussion_r739547812 ## File path: cpp/src/arrow/compute/kernels/scalar_compare_test.cc ## @@ -454,6 +454,54 @@ TEST(TestCompareTimestamps, Basics) { CheckArrayCase(secon

[GitHub] [arrow] jonkeane commented on pull request #11573: ARROW-14514: [R] UBSAN error on round kernel

2021-10-29 Thread GitBox
jonkeane commented on pull request #11573: URL: https://github.com/apache/arrow/pull/11573#issuecomment-955064369 Ok, I've got a CI that bumps into this. I'm still waiting for it to finish a (failing) build over at #11577, but I also created a combo of this branch + that branch and trigger

[GitHub] [arrow] github-actions[bot] commented on pull request #11578: [DON'T MERGE]: testing if ARROW-14514 is fixed in CI

2021-10-29 Thread GitBox
github-actions[bot] commented on pull request #11578: URL: https://github.com/apache/arrow/pull/11578#issuecomment-955063886 Revision: 5a0f8eef322394e7e7e44c4eaaecc32cfe51684a Submitted crossbow builds: [ursacomputing/crossbow @ actions-1061](https://github.com/ursacomputing/crossbow

[GitHub] [arrow] jonkeane commented on pull request #11578: [DON'T MERGE]: testing if ARROW-14514 is fixed in CI

2021-10-29 Thread GitBox
jonkeane commented on pull request #11578: URL: https://github.com/apache/arrow/pull/11578#issuecomment-955063559 @github-actions crossbow submit test-fedora-r-clang-sanitizer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] github-actions[bot] commented on pull request #11578: [DON'T MERGE]: testing if ARROW-14514 is fixed in CI

2021-10-29 Thread GitBox
github-actions[bot] commented on pull request #11578: URL: https://github.com/apache/arrow/pull/11578#issuecomment-955063271 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you ope

[GitHub] [arrow] jonkeane opened a new pull request #11578: [DON'T MERGE]: testing if ARROW-14514 is fixed in CI

2021-10-29 Thread GitBox
jonkeane opened a new pull request #11578: URL: https://github.com/apache/arrow/pull/11578 This should not be merged, it is a combination of #11573 and #11577 to test if the new CI and the fix works. Used for ease and visibility of crossbow triggering -- This is an automated message fro

[GitHub] [arrow] kou commented on a change in pull request #11567: ARROW-14505: [CI][Docs] Exercise documentation builds more frequently

2021-10-29 Thread GitBox
kou commented on a change in pull request #11567: URL: https://github.com/apache/arrow/pull/11567#discussion_r739542852 ## File path: ci/scripts/python_build.sh ## @@ -19,8 +19,10 @@ set -ex +arrow_dir=${1} source_dir=${1}/python Review comment: ```suggestion s

[GitHub] [arrow-datafusion] kszucs commented on pull request #873: Rework the python bindings using conversion traits from arrow-rs

2021-10-29 Thread GitBox
kszucs commented on pull request #873: URL: https://github.com/apache/arrow-datafusion/pull/873#issuecomment-955061956 Cc @cpcloud if you can have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [arrow-datafusion] kszucs commented on pull request #873: Rework the python bindings using conversion traits from arrow-rs

2021-10-29 Thread GitBox
kszucs commented on pull request #873: URL: https://github.com/apache/arrow-datafusion/pull/873#issuecomment-955061581 @houqp this should be ready now. Breaks the previous API at multiple places, but I think that's fine considering the early stage of the datafusion lib. We can also bump th

[GitHub] [arrow-datafusion] kszucs commented on a change in pull request #873: Rework the python bindings using conversion traits from arrow-rs

2021-10-29 Thread GitBox
kszucs commented on a change in pull request #873: URL: https://github.com/apache/arrow-datafusion/pull/873#discussion_r739539748 ## File path: python/Cargo.toml ## @@ -30,16 +30,16 @@ edition = "2018" libc = "0.2" tokio = { version = "1.0", features = ["macros", "rt", "rt-mu

[GitHub] [arrow] westonpace commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-10-29 Thread GitBox
westonpace commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r739539355 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -402,16 +401,16 @@ struct StringTransformExecBase { if (!input.is_valid) {

[GitHub] [arrow] westonpace commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-10-29 Thread GitBox
westonpace commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r739537974 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -537,6 +536,341 @@ struct FixedSizeBinaryTransformExecWithState } }; +template

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-10-29 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r739529736 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -537,6 +536,341 @@ struct FixedSizeBinaryTransformExecWithState } }; +template +

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-10-29 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r739524798 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -402,16 +401,16 @@ struct StringTransformExecBase { if (!input.is_valid) {

[GitHub] [arrow] lidavidm commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-10-29 Thread GitBox
lidavidm commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r739522959 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -402,16 +401,16 @@ struct StringTransformExecBase { if (!input.is_valid) {

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-10-29 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r739522336 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -402,16 +401,16 @@ struct StringTransformExecBase { if (!input.is_valid) {

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-10-29 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r739522336 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -402,16 +401,16 @@ struct StringTransformExecBase { if (!input.is_valid) {

[GitHub] [arrow] ursabot edited a comment on pull request #11572: ARROW-14517: [Python] Missing ampersand in CIpcReadOptions of CFeatherReader

2021-10-29 Thread GitBox
ursabot edited a comment on pull request #11572: URL: https://github.com/apache/arrow/pull/11572#issuecomment-954965740 Benchmark runs are scheduled for baseline = e8270d705da325158291f412235c9c155adceb39 and contender = fbaa405575bceda9e1e22295e8297689ada06cad. fbaa405575bceda9e1e22295e8

[GitHub] [arrow] ursabot edited a comment on pull request #11572: ARROW-14517: [Python] Missing ampersand in CIpcReadOptions of CFeatherReader

2021-10-29 Thread GitBox
ursabot edited a comment on pull request #11572: URL: https://github.com/apache/arrow/pull/11572#issuecomment-954965740 Benchmark runs are scheduled for baseline = e8270d705da325158291f412235c9c155adceb39 and contender = fbaa405575bceda9e1e22295e8297689ada06cad. fbaa405575bceda9e1e22295e8

[GitHub] [arrow] github-actions[bot] commented on pull request #11577: ARROW-14515: [R] Add clang sanitizer to crossbow

2021-10-29 Thread GitBox
github-actions[bot] commented on pull request #11577: URL: https://github.com/apache/arrow/pull/11577#issuecomment-955025756 Revision: 5da3fe85d4115c3b5aa7b7e9b39d5e5fcb934ae5 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1060](https://github.com/ursacomputing/crossbow

[GitHub] [arrow] jonkeane commented on pull request #11577: ARROW-14515: [R] Add clang sanitizer to crossbow

2021-10-29 Thread GitBox
jonkeane commented on pull request #11577: URL: https://github.com/apache/arrow/pull/11577#issuecomment-955025252 @github-actions crossbow submit test-fedora-r-clang-sanitizer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] lidavidm commented on pull request #11507: ARROW-14421: [C++] Implement Flight SQL

2021-10-29 Thread GitBox
lidavidm commented on pull request #11507: URL: https://github.com/apache/arrow/pull/11507#issuecomment-955023238 Regarding the Protobuf issue: I switched to vcpkg as that appears to be what you use, but I can't replicate still. What OS and compiler are you using? -- This is an automate

[GitHub] [arrow] jonkeane commented on pull request #11577: ARROW-14515: [R] Add clang sanitizer to crossbow

2021-10-29 Thread GitBox
jonkeane commented on pull request #11577: URL: https://github.com/apache/arrow/pull/11577#issuecomment-955021560 A locally triggered job: https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=14763&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb -- This is an automated me

[GitHub] [arrow] github-actions[bot] commented on pull request #11577: ARROW-14515: [R] Add clang sanitizer to crossbow

2021-10-29 Thread GitBox
github-actions[bot] commented on pull request #11577: URL: https://github.com/apache/arrow/pull/11577#issuecomment-955021622 https://issues.apache.org/jira/browse/ARROW-14515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] edponce commented on pull request #11573: ARROW-14514: [R] UBSAN error on round kernel

2021-10-29 Thread GitBox
edponce commented on pull request #11573: URL: https://github.com/apache/arrow/pull/11573#issuecomment-955007212 Final update: Made a trivial change for better readability of primary templates in specializations. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] lidavidm commented on a change in pull request #10260: ARROW-12671: [C++] Add OpenTelemetry to ThirdpartyToolchain

2021-10-29 Thread GitBox
lidavidm commented on a change in pull request #10260: URL: https://github.com/apache/arrow/pull/10260#discussion_r739465101 ## File path: cpp/src/arrow/util/tracing_internal.cc ## @@ -0,0 +1,252 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

[GitHub] [arrow] ursabot edited a comment on pull request #11572: ARROW-14517: [Python] Missing ampersand in CIpcReadOptions of CFeatherReader

2021-10-29 Thread GitBox
ursabot edited a comment on pull request #11572: URL: https://github.com/apache/arrow/pull/11572#issuecomment-954965740 Benchmark runs are scheduled for baseline = e8270d705da325158291f412235c9c155adceb39 and contender = fbaa405575bceda9e1e22295e8297689ada06cad. fbaa405575bceda9e1e22295e8

[GitHub] [arrow-rs] paddyhoran commented on issue #654: Add IPC support for Union Array

2021-10-29 Thread GitBox
paddyhoran commented on issue #654: URL: https://github.com/apache/arrow-rs/issues/654#issuecomment-954968101 Hi @sum12, I think it would make more sense to start with #85 and then #814. I believe they will be needed first. This issue is more high level and the success criteria wo

[GitHub] [arrow] ursabot commented on pull request #11572: ARROW-14517: [Python] Missing ampersand in CIpcReadOptions of CFeatherReader

2021-10-29 Thread GitBox
ursabot commented on pull request #11572: URL: https://github.com/apache/arrow/pull/11572#issuecomment-954965740 Benchmark runs are scheduled for baseline = e8270d705da325158291f412235c9c155adceb39 and contender = fbaa405575bceda9e1e22295e8297689ada06cad. fbaa405575bceda9e1e22295e8297689a

[GitHub] [arrow] lidavidm closed pull request #11572: ARROW-14517: [Python] Missing ampersand in CIpcReadOptions of CFeatherReader

2021-10-29 Thread GitBox
lidavidm closed pull request #11572: URL: https://github.com/apache/arrow/pull/11572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] lidavidm commented on pull request #11573: ARROW-14514: [R] UBSAN error on round kernel

2021-10-29 Thread GitBox
lidavidm commented on pull request #11573: URL: https://github.com/apache/arrow/pull/11573#issuecomment-954947428 This is the issue: ```diff diff --git a/cpp/src/arrow/compute/kernels/scalar_arithmetic.cc b/cpp/src/arrow/compute/kernels/scalar_arithmetic.cc index be6f35164..303

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1199: [WIP] add ScalarValue::Null and remove Option wrapping in other enum cases

2021-10-29 Thread GitBox
alamb commented on a change in pull request #1199: URL: https://github.com/apache/arrow-datafusion/pull/1199#discussion_r739438511 ## File path: datafusion/src/scalar.rs ## @@ -37,58 +37,60 @@ use std::{convert::TryFrom, fmt, iter::repeat, sync::Arc}; /// This is the single-va

[GitHub] [arrow] lidavidm commented on pull request #11573: ARROW-14514: [R] UBSAN error on round kernel

2021-10-29 Thread GitBox
lidavidm commented on pull request #11573: URL: https://github.com/apache/arrow/pull/11573#issuecomment-954943321 FYI, setting a breakpoint in R, you can indeed observe that we have the wrong OptionsWrapper type at some point. I'm also trying to track this down now. -- This is an automat

[GitHub] [arrow] edponce commented on pull request #11573: ARROW-14514: [R] UBSAN error on round kernel

2021-10-29 Thread GitBox
edponce commented on pull request #11573: URL: https://github.com/apache/arrow/pull/11573#issuecomment-954941979 Thanks @lidavidm! I am taking a careful look at the use of `OptionsWrapper` and `RoundOptionsWrapper`. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow-datafusion] alamb closed issue #1005: Support nested list and map (dictionary) access

2021-10-29 Thread GitBox
alamb closed issue #1005: URL: https://github.com/apache/arrow-datafusion/issues/1005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow-datafusion] alamb merged pull request #1006: Indexed field access for List

2021-10-29 Thread GitBox
alamb merged pull request #1006: URL: https://github.com/apache/arrow-datafusion/pull/1006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb commented on pull request #1006: Indexed field access for List

2021-10-29 Thread GitBox
alamb commented on pull request #1006: URL: https://github.com/apache/arrow-datafusion/pull/1006#issuecomment-954939791 Thanks for sticking with it @Igosuki ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1006: Indexed field access for List

2021-10-29 Thread GitBox
alamb commented on a change in pull request #1006: URL: https://github.com/apache/arrow-datafusion/pull/1006#discussion_r739434013 ## File path: datafusion/src/physical_plan/expressions/get_indexed_field.rs ## @@ -0,0 +1,103 @@ +// Licensed to the Apache Software Foundation (AS

[GitHub] [arrow-datafusion] alamb commented on pull request #1183: Fix logical plan optimization will execute twice in SQL mode

2021-10-29 Thread GitBox
alamb commented on pull request #1183: URL: https://github.com/apache/arrow-datafusion/pull/1183#issuecomment-954936349 > A summary of what the PR will do. I think it might be ok to optimize the plan twice (in other words, perhaps we can close the ticket as "working as expected"?). D

[GitHub] [arrow-datafusion] alamb commented on issue #1194: window functions with NULL literals in `partition by` and `order by` do not work: Internal("Sort operation is not applicable to scalar value

2021-10-29 Thread GitBox
alamb commented on issue #1194: URL: https://github.com/apache/arrow-datafusion/issues/1194#issuecomment-954933140 As @xudong963 mentions, closed in https://github.com/apache/arrow-datafusion/pull/1197 -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [arrow-datafusion] alamb closed issue #1194: window functions with NULL literals in `partition by` and `order by` do not work: Internal("Sort operation is not applicable to scalar value NULL"

2021-10-29 Thread GitBox
alamb closed issue #1194: URL: https://github.com/apache/arrow-datafusion/issues/1194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow] lidavidm commented on pull request #11573: ARROW-14514: [R] UBSAN error on round kernel

2021-10-29 Thread GitBox
lidavidm commented on pull request #11573: URL: https://github.com/apache/arrow/pull/11573#issuecomment-954932442 That said, the specific error in the logs makes me suspicious that this isn't a fix: it appears the sanitizer complains that `OptionsWrapper` cannot be downcast to `RoundOptio

[GitHub] [arrow-datafusion] xudong963 commented on issue #1194: window functions with NULL literals in `partition by` and `order by` do not work: Internal("Sort operation is not applicable to scalar v

2021-10-29 Thread GitBox
xudong963 commented on issue #1194: URL: https://github.com/apache/arrow-datafusion/issues/1194#issuecomment-954931586 Maybe the issue can close too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] lidavidm commented on pull request #11573: ARROW-14514: [R] UBSAN error on round kernel

2021-10-29 Thread GitBox
lidavidm commented on pull request #11573: URL: https://github.com/apache/arrow/pull/11573#issuecomment-954927775 Ok, well, I tried to get a build of Arrow with UBSan enabled, but can't quite get it working without having to re-compile R it seems. So I can't replicate or confirm this so fa

[GitHub] [arrow-datafusion] alamb commented on pull request #1197: Adjust the error message about ORDER BY does not work with literals

2021-10-29 Thread GitBox
alamb commented on pull request #1197: URL: https://github.com/apache/arrow-datafusion/pull/1197#issuecomment-954922375 Thanks @xudong963 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow-datafusion] alamb closed issue #1195: ORDER BY does not work with literals: Sort operation is not applicable to scalar value 'foo'

2021-10-29 Thread GitBox
alamb closed issue #1195: URL: https://github.com/apache/arrow-datafusion/issues/1195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow-datafusion] alamb merged pull request #1197: Adjust the error message about ORDER BY does not work with literals

2021-10-29 Thread GitBox
alamb merged pull request #1197: URL: https://github.com/apache/arrow-datafusion/pull/1197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] kszucs commented on pull request #873: Rework the python bindings using conversion traits from arrow-rs

2021-10-29 Thread GitBox
kszucs commented on pull request #873: URL: https://github.com/apache/arrow-datafusion/pull/873#issuecomment-954912793 One thing have left, I'm going to remove the `PyVolatility` wrapper in favor of plain strings. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow-datafusion] Igosuki removed a comment on pull request #1006: Indexed field access for List

2021-10-29 Thread GitBox
Igosuki removed a comment on pull request #1006: URL: https://github.com/apache/arrow-datafusion/pull/1006#issuecomment-954884073 Compilation fails on a match clause on expr but the match clause is there in the code, I don't get it. -- This is an automated message from the Apache Git Ser

[GitHub] [arrow] github-actions[bot] commented on pull request #11576: ARROW-14365: [R] Update README example to reflect new capabilities

2021-10-29 Thread GitBox
github-actions[bot] commented on pull request #11576: URL: https://github.com/apache/arrow/pull/11576#issuecomment-954905550 https://issues.apache.org/jira/browse/ARROW-14365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] emkornfield commented on pull request #11570: ARROW-14513: [Release][Go] Add /v6 suffix to release-6.0.0

2021-10-29 Thread GitBox
emkornfield commented on pull request #11570: URL: https://github.com/apache/arrow/pull/11570#issuecomment-954885292 > @emkornfield I've sent a message to the dev@ mailing list, how long do you think we should let it sit before carrying on here? Let's merge on Monday if there are no

[GitHub] [arrow-datafusion] Igosuki commented on pull request #1006: Indexed field access for List

2021-10-29 Thread GitBox
Igosuki commented on pull request #1006: URL: https://github.com/apache/arrow-datafusion/pull/1006#issuecomment-954884073 Compilation fails on a match clause on expr but the match clause is there in the code, I don't get it. -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #11575: ARROW-14469: [R] Binding for lubridate::month() doesn't have `label` argument implemented

2021-10-29 Thread GitBox
github-actions[bot] commented on pull request #11575: URL: https://github.com/apache/arrow/pull/11575#issuecomment-954870020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] lidavidm commented on pull request #11535: ARROW-14429: [C++] Speed up IPC file reader on high-latency filesystems

2021-10-29 Thread GitBox
lidavidm commented on pull request #11535: URL: https://github.com/apache/arrow/pull/11535#issuecomment-954863081 I've added a unit test that counts the number of read operations, instead of a benchmark, since that's a more reliable metric to track for this instance. -- This is an automa

[GitHub] [arrow] ursabot edited a comment on pull request #11439: ARROW-14351: [IR] Add projection list to Source node

2021-10-29 Thread GitBox
ursabot edited a comment on pull request #11439: URL: https://github.com/apache/arrow/pull/11439#issuecomment-954765375 Benchmark runs are scheduled for baseline = 2ae84e8e90a7c0d8cd37df07d69e982dcfd16eaf and contender = e8270d705da325158291f412235c9c155adceb39. e8270d705da325158291f41223

[GitHub] [arrow] ursabot edited a comment on pull request #11439: ARROW-14351: [IR] Add projection list to Source node

2021-10-29 Thread GitBox
ursabot edited a comment on pull request #11439: URL: https://github.com/apache/arrow/pull/11439#issuecomment-954765375 Benchmark runs are scheduled for baseline = 2ae84e8e90a7c0d8cd37df07d69e982dcfd16eaf and contender = e8270d705da325158291f412235c9c155adceb39. e8270d705da325158291f41223

[GitHub] [arrow] zeroshade commented on pull request #11570: ARROW-14513: [Release][Go] Add /v6 suffix to release-6.0.0

2021-10-29 Thread GitBox
zeroshade commented on pull request #11570: URL: https://github.com/apache/arrow/pull/11570#issuecomment-954827749 @emkornfield I've sent a message to the dev@ mailing list, how long do you think we should let it sit before carrying on here? -- This is an automated message from the Apach

[GitHub] [arrow-datafusion] Igosuki opened a new issue #1203: Support pseudo columns

2021-10-29 Thread GitBox
Igosuki opened a new issue #1203: URL: https://github.com/apache/arrow-datafusion/issues/1203 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Haven't see that anywhere in the code, so please let me know if I overlooekd it. Spa

[GitHub] [arrow-datafusion] Jimexist commented on pull request #1202: Fix `between` in select query

2021-10-29 Thread GitBox
Jimexist commented on pull request #1202: URL: https://github.com/apache/arrow-datafusion/pull/1202#issuecomment-954810414 thanks! could you also add an integration test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow-datafusion] capkurmagati opened a new pull request #1202: Fix `between` in select query

2021-10-29 Thread GitBox
capkurmagati opened a new pull request #1202: URL: https://github.com/apache/arrow-datafusion/pull/1202 1. Added match arms for `Expr::Between`, `Expr::Sort`, and `Expr::Wildcard` and removed default match in `expr.rs`. 2. Added match arm for `Expr::Between` in `planner.rs`. ```

[GitHub] [arrow] kszucs commented on a change in pull request #11571: ARROW-14476: [CI] Crossbow should comment cause of failure

2021-10-29 Thread GitBox
kszucs commented on a change in pull request #11571: URL: https://github.com/apache/arrow/pull/11571#discussion_r739293143 ## File path: dev/archery/archery/bot.py ## @@ -147,8 +147,8 @@ def handle_issue_comment(self, command, payload): if payload['comment']['autho

[GitHub] [arrow-datafusion] Jimexist commented on issue #1184: Null constants can not be used in most expressions

2021-10-29 Thread GitBox
Jimexist commented on issue #1184: URL: https://github.com/apache/arrow-datafusion/issues/1184#issuecomment-954788593 I have a draft up at https://github.com/apache/arrow-datafusion/pull/1199 please take an initial look @alamb -- This is an automated message from the Apache Git Service

[GitHub] [arrow-datafusion] xudong963 commented on pull request #1183: Fix logical plan optimization will execute twice in SQL mode

2021-10-29 Thread GitBox
xudong963 commented on pull request #1183: URL: https://github.com/apache/arrow-datafusion/pull/1183#issuecomment-954787474 A summary of what the PR will do. 1. Add a member variable such as `is_optimized` to LogicalPlan to avoid optimizing the logical plan twice. 2. Avoid optimiz

[GitHub] [arrow-rs] jhorstmann commented on pull request #878: Fix instances of UB that cause tests to not pass under miri

2021-10-29 Thread GitBox
jhorstmann commented on pull request #878: URL: https://github.com/apache/arrow-rs/pull/878#issuecomment-954785918 Changes here look good to me :rocket: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [arrow] zeroshade commented on pull request #11570: ARROW-14513: [Release][Go] Add /v6 suffix to release-6.0.0

2021-10-29 Thread GitBox
zeroshade commented on pull request #11570: URL: https://github.com/apache/arrow/pull/11570#issuecomment-954775055 @emkornfield If we want to keep the major version number the same for the Go lib as it is for the rest of them, then yes we'd need to make this broad change on every major rel

[GitHub] [arrow] ursabot edited a comment on pull request #11439: ARROW-14351: [IR] Add projection list to Source node

2021-10-29 Thread GitBox
ursabot edited a comment on pull request #11439: URL: https://github.com/apache/arrow/pull/11439#issuecomment-954765375 Benchmark runs are scheduled for baseline = 2ae84e8e90a7c0d8cd37df07d69e982dcfd16eaf and contender = e8270d705da325158291f412235c9c155adceb39. e8270d705da325158291f41223

[GitHub] [arrow-rs] alamb merged pull request #882: Remove unpassable cargo publish check from verify-release-candidate.sh

2021-10-29 Thread GitBox
alamb merged pull request #882: URL: https://github.com/apache/arrow-rs/pull/882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr..

[GitHub] [arrow-rs] alamb closed issue #881: verify-release-candidate.sh includes unpassable `cargo publish checks`

2021-10-29 Thread GitBox
alamb closed issue #881: URL: https://github.com/apache/arrow-rs/issues/881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arr

[GitHub] [arrow-rs] alamb opened a new pull request #882: Remove unpassable cargo publish check from verify-release-candidate.sh

2021-10-29 Thread GitBox
alamb opened a new pull request #882: URL: https://github.com/apache/arrow-rs/pull/882 Resolves https://github.com/apache/arrow-rs/issues/881 The newly added 'cargo publish` checks I added in #856 (see https://github.com/apache/arrow-rs/pull/856/files#diff-82f32771b6ac9daaadbfb77bd7

[GitHub] [arrow-rs] alamb opened a new issue #881: verify-release-candidate.sh includes unpassable `cargo publish checks`

2021-10-29 Thread GitBox
alamb opened a new issue #881: URL: https://github.com/apache/arrow-rs/issues/881 **Describe the bug** The newly added 'cargo publish` checks I added in #856 (see https://github.com/apache/arrow-rs/pull/856/files#diff-82f32771b6ac9daaadbfb77bd77062d63e131ad18ecd9014ff90eff17865964fR137-

[GitHub] [arrow] ursabot commented on pull request #11439: ARROW-14351: [IR] Add projection list to Source node

2021-10-29 Thread GitBox
ursabot commented on pull request #11439: URL: https://github.com/apache/arrow/pull/11439#issuecomment-954765375 Benchmark runs are scheduled for baseline = 2ae84e8e90a7c0d8cd37df07d69e982dcfd16eaf and contender = e8270d705da325158291f412235c9c155adceb39. e8270d705da325158291f412235c9c155

[GitHub] [arrow] bkietz closed pull request #11439: ARROW-14351: [IR] Add projection list to Source node

2021-10-29 Thread GitBox
bkietz closed pull request #11439: URL: https://github.com/apache/arrow/pull/11439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] jeszyb commented on pull request #11571: ARROW-14476: [CI] Crossbow should comment cause of failure

2021-10-29 Thread GitBox
jeszyb commented on pull request #11571: URL: https://github.com/apache/arrow/pull/11571#issuecomment-954759807 @kszucs instead, added a test for unathorized user trying to use the bot - now there's coverage for every change in this commit. -- This is an automated message from the Apache

[GitHub] [arrow] ursabot edited a comment on pull request #11536: ARROW-14174: [C++] Deduplicate some Decimal/FixedSizeBinary kernels

2021-10-29 Thread GitBox
ursabot edited a comment on pull request #11536: URL: https://github.com/apache/arrow/pull/11536#issuecomment-954152078 Benchmark runs are scheduled for baseline = faafc51840143635eb06957ccbb8d3669aa30c1d and contender = 2ae84e8e90a7c0d8cd37df07d69e982dcfd16eaf. 2ae84e8e90a7c0d8cd37df07d6

[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1183: Fix logical plan optimization will execute twice in SQL mode

2021-10-29 Thread GitBox
xudong963 commented on a change in pull request #1183: URL: https://github.com/apache/arrow-datafusion/pull/1183#discussion_r739242123 ## File path: datafusion/src/execution/context.rs ## @@ -176,6 +176,7 @@ impl ExecutionContext { config, exec

[GitHub] [arrow] lidavidm commented on a change in pull request #11507: ARROW-14421: [C++] Implement Flight SQL

2021-10-29 Thread GitBox
lidavidm commented on a change in pull request #11507: URL: https://github.com/apache/arrow/pull/11507#discussion_r739235905 ## File path: cpp/src/arrow/flight/flight-sql/client.h ## @@ -0,0 +1,233 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

[GitHub] [arrow] lidavidm commented on pull request #11507: ARROW-14421: [C++] Implement Flight SQL

2021-10-29 Thread GitBox
lidavidm commented on pull request #11507: URL: https://github.com/apache/arrow/pull/11507#issuecomment-954746311 It looks like we'll have to merge the Java PR first when time comes since the current Java Protobuf setup can't handle the `optional` fields. -- This is an automated message

[GitHub] [arrow-rs] alamb merged pull request #880: Release 6.1.0

2021-10-29 Thread GitBox
alamb merged pull request #880: URL: https://github.com/apache/arrow-rs/pull/880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr..

[GitHub] [arrow-rs] alamb opened a new pull request #880: Release 6.1.0

2021-10-29 Thread GitBox
alamb opened a new pull request #880: URL: https://github.com/apache/arrow-rs/pull/880 Prepare for the 6.1.0 release: * Changelog * Update versions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [arrow-datafusion] rdettai commented on pull request #1201: [fix] tests failing on nightly

2021-10-29 Thread GitBox
rdettai commented on pull request #1201: URL: https://github.com/apache/arrow-datafusion/pull/1201#issuecomment-954741031 Didn't have to double check this, but the jist of it is there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow-datafusion] rdettai opened a new pull request #1201: [fix] tests failing on nightly

2021-10-29 Thread GitBox
rdettai opened a new pull request #1201: URL: https://github.com/apache/arrow-datafusion/pull/1201 # Which issue does this PR close? Closes #614. # Rationale for this change Tests were failing on nightly # What changes are included in this PR? Avoid comparision to

  1   2   >